Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 24 2020 16:37

    greenkeeper[bot] on chance-1.1.6

    chore(package): update chance t… (compare)

  • May 23 2020 12:02
    greenkeeper[bot] commented #399
  • May 23 2020 12:02

    greenkeeper[bot] on mocha-7.2.0

    chore(package): update mocha to… (compare)

  • May 11 2020 18:38

    greenkeeper[bot] on chance-1.1.5

    chore(package): update chance t… (compare)

  • Apr 26 2020 06:50
    greenkeeper[bot] commented #399
  • Apr 26 2020 06:50

    greenkeeper[bot] on mocha-7.1.2

    chore(package): update mocha to… (compare)

  • Apr 08 2020 20:24
    greenkeeper[bot] commented #398
  • Apr 08 2020 20:24

    greenkeeper[bot] on sinon-9.0.2

    chore(package): update sinon to… (compare)

  • Mar 18 2020 10:20
    greenkeeper[bot] commented #399
  • Mar 18 2020 10:20

    greenkeeper[bot] on mocha-7.1.1

    chore(package): update mocha to… (compare)

  • Mar 17 2020 03:03

    greenkeeper[bot] on grunt-1.1.0

    chore(package): update grunt to… (compare)

  • Mar 17 2020 03:03
    greenkeeper[bot] labeled #403
  • Mar 17 2020 03:03
    greenkeeper[bot] opened #403
  • Mar 10 2020 09:23
    greenkeeper[bot] commented #398
  • Mar 10 2020 09:23

    greenkeeper[bot] on sinon-9.0.1

    chore(package): update sinon to… (compare)

  • Feb 28 2020 03:34
    greenkeeper[bot] commented #399
  • Feb 28 2020 03:34

    greenkeeper[bot] on mocha-7.1.0

    chore(package): update mocha to… (compare)

  • Feb 19 2020 11:48
    greenkeeper[bot] commented #398
  • Feb 19 2020 11:48

    greenkeeper[bot] on sinon-9.0.0

    chore(package): update sinon to… (compare)

  • Jan 26 2020 08:22
    greenkeeper[bot] commented #399
Miguel Castillo
@MiguelCastillo
I gotta write it up in the readmee :)
the connecting point between bit-loader and amd-loader is the Fetch contract
Mark Simulacrum
@Mark-Simulacrum
Do you want me to put up a pr renaming MLoader to BitLoader in bit-loader.js?
Miguel Castillo
@MiguelCastillo
yeah if there are any left for sure!
oh yeah, I missed a few spots in the rebranding there
Mark Simulacrum
@Mark-Simulacrum
Why do you have mloader-release in the dist dir? Should I remove it? The tests link to it...
Also, should I run the prepublish task to compile bit-loader into the dist dir before submitting my PR?
Miguel Castillo
@MiguelCastillo
i have mloader-release there as a reference for now... We can remove it since it is already in https://github.com/MiguelCastillo/bit-loader-goundzero
remove it in your PR
you dont run prepublish... That's automatically executed when you run npm install
so all you need to do is npm install to get dependencies and build
then npm test to make sure tests pass :)
Mark Simulacrum
@Mark-Simulacrum
Right, so I should do that, and submit the changes to dist/bit-loader.js in my PR?
Miguel Castillo
@MiguelCastillo
yup
i would like to automate the build with travis soon and have travis check in bit-loader.js for us when the build passes
Mark Simulacrum
@Mark-Simulacrum
Makes sense. I might see what I can do about that if you want
Miguel Castillo
@MiguelCastillo
sure!
i already have a workflow for that... I can get it started and we can go from there
Mark Simulacrum
@Mark-Simulacrum
#2 is open with the rename changes. All tests pass.
Miguel Castillo
@MiguelCastillo
yup, saw it
Mark Simulacrum
@Mark-Simulacrum
Should I change spromise to also do this instead of depending on grunt-cli in package.json? (MiguelCastillo/bit-loader@bba8c80)
Miguel Castillo
@MiguelCastillo
Sure
i cant remember what happened when I tried to do it before
Mark Simulacrum
@Mark-Simulacrum
I'll try it - if it doesn't work, no accepting the PR :)
Miguel Castillo
@MiguelCastillo
:) sounds good
i think you need to merge master into your pr
Mark Simulacrum
@Mark-Simulacrum
Okay, it looks like travis is not happy with it :)
#2 seems to be good with Travis after the merge.
Miguel Castillo
@MiguelCastillo
cool
Mark Simulacrum
@Mark-Simulacrum
It seems that travis can run commands after the build succeeds, but I'm not sure how to get Travis to commit the code and push it into the project. Travis can create a release, but that isn't quite what we want.
Miguel Castillo
@MiguelCastillo
yeah so you need to basically write some scritping to do that
let me look up a link
scroll to the bottom
Mark Simulacrum
@Mark-Simulacrum
I see it. Will set something up for Travis then :)
Miguel Castillo
@MiguelCastillo
cool
I havent done it myself... but it is possible
i will setup hooks to github release the way I have in spromise https://github.com/MiguelCastillo/spromise/releases
Miguel Castillo
@MiguelCastillo
amd-loader and bit-loader have travis integration
I gotta run a few errands but I will be back later to finish up some work on AMD
Mark Simulacrum
@Mark-Simulacrum
I don't think that what the link you posted suggests is secure, as it will expose the token publicly, allowing (anyone?) to commit to bit-loader. The way they would do this is by submitting a pull request with a change to travis ci, adding something like the following to the .travis.yml file, outputting the "secret" token.
before_script:
   - echo $GH_TOKEN
I'll look into how to do it more, though. See you later!
Miguel Castillo
@MiguelCastillo
right so what you do is encrypt the key with travis tools
Mark Simulacrum
@Mark-Simulacrum
It would be encrypted, but since Travis would decrypt the key at the start of the test, anyone could access it as I showed.. right?
Miguel Castillo
@MiguelCastillo
no. the decryption step isn't visible
take a quick peek at how emberjs does it for example https://github.com/emberjs/ember.js/blob/master/.travis.yml
dont let this particular thing hold you back from getting into the code though... particularly amd-loader
Mark Simulacrum
@Mark-Simulacrum
Ah, I see now. Okay. I'll start looking into amd-loader now; might return to auto deploying the builds later.
Miguel Castillo
@MiguelCastillo
I need to migrate the tests that are commented out here https://github.com/MiguelCastillo/bit-loader/blob/master/tests/specs/bit-loader.js