These are chat archives for Milk-Enterprises/Gambot

12th
Oct 2014
Rob Kellett
@RobKellett
Oct 12 2014 03:01
agreed
Emil Huseynaliev
@emilh91
Oct 12 2014 04:37
agreed
Rob Kellett
@RobKellett
Oct 12 2014 05:01
you can't agree with yourself
you little shit
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:03
:hibiscus:
alright
Rob Kellett
@RobKellett
Oct 12 2014 05:03
so lay it on me
I want to hit the hay soon
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:03
hows this pipeline going to work
new message comes in
it passes through pipelines
the pipeline*
Rob Kellett
@RobKellett
Oct 12 2014 05:04
so each Handler.Digest is going to return a string
which is fed to the next Handler
and jesus christ gitter is appening my messages in the wrong place
holy fuck
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:04
nice
but consider the following
Rob Kellett
@RobKellett
Oct 12 2014 05:05
return null to cancel propagation
or, hm
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:05
when will we need to cancel propagation though
:confused:
Rob Kellett
@RobKellett
Oct 12 2014 05:05
the rate limiter handler, for instance
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:05
:open_mouth:
good call
ok
next thing
we'll need priorities
on our handlers
IF we still awnt to do auto-detection of handlers
can be simple stuff: last, low, medium, high, immediate
Rob Kellett
@RobKellett
Oct 12 2014 05:06
I'm in favor of a simple priority system
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:06
or if we want to go full potato, numbers
Rob Kellett
@RobKellett
Oct 12 2014 05:06
no potatos here
jesus christ gitter
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:06
sh itter
actually
do we even need low/high
seems like all we need is
last, normal, first
Simon Gellis
@SupernaviX
Oct 12 2014 05:08
why can't I scroll
Rob Kellett
@RobKellett
Oct 12 2014 05:09
because dicks
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:09
well?
other than that it looks pretty solid
Rob Kellett
@RobKellett
Oct 12 2014 05:11
so basically
what's the handler.digest signature going to look like now
string Digest(string response, IMessage message, bool mentioned)?
first handler gets an empty string in response
if any handler returns null, stop the whole thing
if the last handler returns an empty string, don't do anything
?
Simon Gellis
@SupernaviX
Oct 12 2014 05:13
does it matter that not every handler makes sense as part of an pipeline?
Rob Kellett
@RobKellett
Oct 12 2014 05:14
as it is right now
there are no cases when two handlers would want to process the same message
so pipelining that won't affect functionality
but it would allow for your british handler
and the rate limiter
Simon Gellis
@SupernaviX
Oct 12 2014 05:16
/shrug
Rob Kellett
@RobKellett
Oct 12 2014 05:17
@mohammedh123 are we in agree
Simon Gellis
@SupernaviX
Oct 12 2014 05:18
think it'll ever matter what order handlers are in within their last/normal/first groups?
I can't think of any specific cases
Rob Kellett
@RobKellett
Oct 12 2014 05:19
me neither
therefore there are no cases
:shipit:
Simon Gellis
@SupernaviX
Oct 12 2014 05:19
agreed
:shipit:
Mohammed Hossain
@mohammedh123
Oct 12 2014 05:26
i was taking a dump
:shipit:
Rob Kellett
@RobKellett
Oct 12 2014 05:35
alright
I'm going to bed
but first
an issue
Simon Gellis
@SupernaviX
Oct 12 2014 05:35
:cold_sweat:
Rob Kellett
@RobKellett
Oct 12 2014 05:36
#29
@mohammedh123 this way you could also implement logging via pipelining
have one first-priority handler to log input, have one last-priority handler to log output
:idk:
Simon Gellis
@SupernaviX
Oct 12 2014 05:38
so the order does matter
that'd have to be very last to be accurate
Rob Kellett
@RobKellett
Oct 12 2014 05:38
augh yeah
maybe logging should be more of a core feature than a module
:confused:
Simon Gellis
@SupernaviX
Oct 12 2014 05:39
sounds reasonable
Rob Kellett
@RobKellett
Oct 12 2014 05:40
@mohammedh123 I'm delegating this decision to you
do whatever makes the most sense
well maybe mo's a bad judge for sense
:smirk:
Simon Gellis
@SupernaviX
Oct 12 2014 05:40
do whatever seems to make the least sense
Rob Kellett
@RobKellett
Oct 12 2014 05:40
:shipit:
Simon Gellis
@SupernaviX
Oct 12 2014 05:40
it'll be more fun to read that way
Rob Kellett
@RobKellett
Oct 12 2014 05:41
alright fuck I'm tired
:wave:
Simon Gellis
@SupernaviX
Oct 12 2014 05:41
Don't forget to update your stories and tasks!
Rob Kellett
@RobKellett
Oct 12 2014 05:41
:envy:
if you're bored you can take an open issue
:blush:
Simon Gellis
@SupernaviX
Oct 12 2014 05:41
:nope:
I'm learning Ada
Rob Kellett
@RobKellett
Oct 12 2014 05:42
oh dear
godspeed
Simon Gellis
@SupernaviX
Oct 12 2014 05:42
:salute:
Emil Huseynaliev
@emilh91
Oct 12 2014 16:53
ADA?
:spuke:
Mohammed Hossain
@mohammedh123
Oct 12 2014 17:31
:hibiscus:
Emil Huseynaliev
@emilh91
Oct 12 2014 17:35
ok I plan on pushing sqlite impl today
Mohammed Hossain
@mohammedh123
Oct 12 2014 20:15
:wonderhi:
Simon Gellis
@SupernaviX
Oct 12 2014 20:24
does that mean golive time is :soon: ?
Emil Huseynaliev
@emilh91
Oct 12 2014 21:29
@mohammedh123 @RobKellett do we not use an App.config anymore?
or do i have to re-create it? :smirk:
from the goof diff
Mohammed Hossain
@mohammedh123
Oct 12 2014 21:35
we do
i just write my own one
Mohammed Hossain
@mohammedh123
Oct 12 2014 22:53
:wonderhi:
Mohammed Hossain
@mohammedh123
Oct 12 2014 23:10
well
im not gonna lie
whats the return avlue of digest
is that just going to be response
i.e.
response = handler.Digest(response, blah, blah)
Emil Huseynaliev
@emilh91
Oct 12 2014 23:12
is the handler the pipeline itself?
or is it just the handler of its input message?
Mohammed Hossain
@mohammedh123
Oct 12 2014 23:14
Emil Huseynaliev
@emilh91
Oct 12 2014 23:18
is that in Pipeline? :|
Mohammed Hossain
@mohammedh123
Oct 12 2014 23:18
wut
thats in dispatcher you fcuk
ill probably renam emessage disatpcher to messagepipeline
or something
Emil Huseynaliev
@emilh91
Oct 12 2014 23:22
:sangry:
Mohammed Hossain
@mohammedh123
Oct 12 2014 23:22
:wonderhi:
¯\_(ツ)_/¯
that last message is not very intuitive... It should be "Okay, $who. Removed... "