These are chat archives for MinigameCore/MinigameCore

7th
Jul 2016
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 18:27
@Flibio MinigameCore/MinigameCore#9 ready for merge
also make travis required
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 19:22
also i was wondering... should we have bungee/proxy support in mind or is this plugin intended to be a single server setup?
Flibio
@Flibio
Jul 07 2016 20:27
That would be completely up to the individual implementations... currently, arenas can be either dedicated (one arena per server) or not (multiple arenas)
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 21:02
gonna add the main plugin class next
Flibio
@Flibio
Jul 07 2016 21:02
to what?
MinigameCore is becoming a plugin again?
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 21:02
MinigameCore...
yea..
Flibio
@Flibio
Jul 07 2016 21:03
Didn't know we were changing that
so sorry so sorry
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 21:03
:P
Flibio
@Flibio
Jul 07 2016 21:03
I'm going to cleanup the build system and stuff
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 21:03
i need to expand my issue on minigame concepts with details aswell
Flibio
@Flibio
Jul 07 2016 21:04
do you want builds to be number incrementally, and include details like MinigameCore API version?
ex: MinigameCore-1.0.0-451.jar title-api-build
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 21:05
gonna check the semver one sec
cuz i want follow that through properly
Flibio
@Flibio
Jul 07 2016 21:06
it would make it similar to sponge so users can follow it easily
actually i like the title-api-build except change the last - to a +
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 21:18
and if you want add the commit too
    [{
        "modid": "minigamecore",
        "name": "MinigameCore",
        "version": "1.0.0-SNAPSHOT",
        "description": "The MinigameCore framework.",
        "url": "http://minigamecore.github.io/docs/",
        "authorList": [
            "Flibio"
        ]
    }
]
\o/
Flibio
@Flibio
Jul 07 2016 21:52
where would I add that
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 22:13
title-api+build.commitSHA?
Flibio
@Flibio
Jul 07 2016 22:38
is the commitSHA really necessary? since a build would be built each commit, and released on GitHub, users could locate the commit from the releases by using the build number
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 22:39
hmm good point
Flibio
@Flibio
Jul 07 2016 23:26
so I will go with title-api+build
Also, I think we should just add the API as a Gradle dependency, rather than foolin' around with submodules
Much easier
another benefit is I can draw the API version to label the JAR with
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 23:33
sure
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 23:43
will the api dependency be done via your build system or via build.gradle...?
actually derp nvm
Hunar Roop Kahlon
@kinggoesgaming
Jul 07 2016 23:54
dont merge MinegameCore/MinigameCore#11 yet... i want to see how it works with the gradle shadow plugin cuz it was messing with it last time i checked
@Flibio ^