Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 11 09:55
    unwitting closed #24
  • Dec 11 2018 20:56

    Munter on master

    Add jsdoc (compare)

  • Dec 11 2018 03:17

    Munter on master

    Update readme (compare)

  • Dec 11 2018 03:05
    Munter closed #184
  • Dec 11 2018 03:03
    Munter closed #203
  • Dec 11 2018 03:02

    Munter on greenkeeper-postcss-6.0.1

    (compare)

  • Dec 11 2018 03:02
    Munter closed #201
  • Dec 11 2018 03:02

    Munter on greenkeeper-postcss-6.0.0

    (compare)

  • Dec 11 2018 03:02
    Munter closed #191
  • Dec 11 2018 03:02
    Munter closed #210
  • Dec 11 2018 03:02

    Munter on greenkeeper-postcss-5.2.10

    (compare)

  • Dec 11 2018 03:02

    Munter on greenkeeper-node-sass-4.5.3

    (compare)

  • Dec 11 2018 03:02
    Munter closed #197
  • Dec 11 2018 03:02

    Munter on greenkeeper-node-sass-4.5.2

    (compare)

  • Dec 11 2018 03:02
    Munter closed #196
  • Dec 11 2018 03:02
    Munter closed #194
  • Dec 11 2018 03:02

    Munter on greenkeeper-node-sass-4.5.1

    (compare)

  • Dec 11 2018 03:02

    Munter on greenkeeper-node-sass-4.5.0

    (compare)

  • Dec 11 2018 03:02
    Munter closed #193
  • Dec 11 2018 03:02

    Munter on greenkeeper-node-sass-4.4.0

    (compare)

Peter Müller
@Munter
Dave Jeffery
@davej
Yeah, your using the content property that's basically what I was doing
I used a fixed position overlay at the top of the page
(Not in PITM but in the middleware I was working on before)
Peter Müller
@Munter
fusile has wrappers that do the same for js and html
Those should probably be extracted
Dave Jeffery
@davej
Oh right, how does that work for js?
Peter Müller
@Munter
a script injects the same css overlay, but also puts the stack trace, or whatever error is available, in the console
Dave Jeffery
@davej
ok, cool. Doesn't sound too controversial to me.
Obviously not good for production but perfect for dev
Dave Jeffery
@davej
When you say that it outputs the error in console do you mean the node console or the browser console?
Peter Müller
@Munter
Browser console. But it seems I forgot to add that part in. I was sure I did that :)
Dave Jeffery
@davej
Yeah, browser console is what I did too :-)
Peter Müller
@Munter
For fusile it would make sense to also duplicate these in the node console.
Dave Jeffery
@davej
yup for sure
Cool, when I work on the source file syntax error stuff, I'll try and keep it modular and keep fusile in mind
Perhaps we can share the modules then
Peter Müller
@Munter
I'll pull out the js error and html error module snow
Dave Jeffery
@davej
Cool
What do you think about the idea of splitting tolk into separate modules?
Peter Müller
@Munter
That should certainly happen. The only question is which ones. I'm not sure I'm far enough in the process to know what the best abstractions are yet
Dave Jeffery
@davej
Just the wrapper around accord that forwards 'my-file.scss' to the correct compiler, could be a great module by itself.
Gustav Nikolaj
@gustavnikolaj
@Munter thanks for making me aware of the channel :-) I'll read up on it tomorrow. Good night!
Peter Müller
@Munter
That wrapper will likely change when a concept of configuration enters the stage
Dave Jeffery
@davej
I guess that's more stuff in the options object... but the abstraction is the same right?
Peter Müller
@Munter
Possibly, yes
Peter Müller
@Munter
@davej https://www.npmjs.com/package/jserror is out. Had to do a bunch of cleanup on csserror as well to make it work. Going to bed now and will look at htmlerror tomorrow
Dave Jeffery
@davej
Thanks a million!
Thanks for introducing me to unexpected assertion lib too. It's really nice and has a handy plugin for testing middlewares. Been working on adding tests this evening.
G'night
Gustav Nikolaj
@gustavnikolaj
@davej I have a few questions about davej/piggy-in-the-middle - I was thinking about doing something similar - I guess that's why @Munter pinged me here :-) Why did you not just use tolk directly - what is the use case for baby-tolk?
@davej The second question is why you chose to make it ES6 only? Unfortunately, I'm in a position where most of the work I do is still on node 0.10. As far as I can tell, you only really use arrow functions and classes - you even have a promise library already :-)
Dave Jeffery
@davej
@gustavnikolaj: 1. See here: Munter/tolk#17, hopefully PITM and tolk can share the same module to do compilation. I think that might look something like baby-tolk which does less stuff than tolk. Feature-wise the differences are no css auto-prefixing and source maps are passed up the promise chain rather than being inlined.
@gustavnikolaj: 2. I just wanted to play with some of the new ES6 stuff, I might convert it back to ES5 later. The promise library is only used to promisify built-in node functions. Native promises are used by the lib. There's also a couple of other things used like ES6 array methods.
Dave Jeffery
@davej
You can require it with babel and it should work with node 0.10.x. Let me know if it doesn't and I'll fix it.
Dave Jeffery
@davej
@gustavnikolaj: PITM is now in es5 and works with node 0.10+
Björn Söderqvist
@cybear
Pretty great project!
I'm a little disappointed to learn that Fuse does not exist on Windows. Or that I use Windows at work. Actually, a little of both. But I might try it out in a Docker instance.
Peter Müller
@Munter
I'd love ot some feedback on if the dokany compile of fuse actually works on windows. The readme on fuse-bindings says it might
Dave Jeffery
@davej
@Munter: Hey, added (js/css)error to PITM, works great. I have a few ideas for PRs but I'll let it sit a bit longer until I have a clearer idea.
Peter Müller
@Munter
I am sure there are improvements to be made. The css thing is pretty much just lifted out of the livestyle package for reuse and the js wrapper is just to get something working quickly
Dave Jeffery
@davej
Also did Baconize which basically compiles all files in a source directory and copies them to a target: https://github.com/davej/baconize
@Munter: Yup I had the same before and mine was lifted out of harp.js
Peter Müller
@Munter
hah. We've done lots of work that's the same as Harp in our own little bubble
I'd like to see if tolk or a version thereof can go back into Harp and replace terraform
Dave Jeffery
@davej
Yup, that would be great.
Peter Müller
@Munter
I've also done an assetgraph-builder plugin that replaces Harps static file output with an optimized, bundled, md5 hashed build