These are chat archives for MylesIsCool/ViaVersion

3rd
Mar 2016
Myles
@MylesIsCool
Mar 03 2016 10:27
Howdy
Mats
@Matsv
Mar 03 2016 10:29
Hi!
Myles
@MylesIsCool
Mar 03 2016 10:31
Hey Stam how's it going?
Mats
@Matsv
Mar 03 2016 10:38
I'm fine, you?
Myles
@MylesIsCool
Mar 03 2016 10:40
Going through SpigotMC PMs and replying (got like 20+), a lot of people use boss bars cries on inside
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:44
Hi :D
StamBoom I saw you are from the Netherlands as well?
Myles
@MylesIsCool
Mar 03 2016 10:44
Hey Hugo!
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:45
That $100 donation from HiveMC is awesome! Do they actually use it?
Mats
@Matsv
Mar 03 2016 10:45
Yeah, i'm from the Netherlands
Myles
@MylesIsCool
Mar 03 2016 10:46
They plan to
I've also been contacted by Wynncraft
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:46
Wow, nice
But you still can't use a lot of items, so before it's useful for Wynncraft there is still a LOT to do
Myles
@MylesIsCool
Mar 03 2016 10:47
So many people PM'ing me who are using AAC argh
What items are broken? Excluding exiting boats, riding etc.
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:47
Yeah, It's a shame we can't answer those SpigotMC PMs
Ender pearls
Myles
@MylesIsCool
Mar 03 2016 10:47
oh?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:47
I'll create an issue, 2 seconds
Mats
@Matsv
Mar 03 2016 10:48
That's the reason I don't publish plugins. Don't want people to ask the same question over and over again
Myles
@MylesIsCool
Mar 03 2016 10:49
I spend more of my time replying to bug reports than coding >.>
Paul Heidenreich
@Paulomart
Mar 03 2016 10:49
Hey everyone
Mats
@Matsv
Mar 03 2016 10:49
Hey
Myles
@MylesIsCool
Mar 03 2016 10:49
Howdy Paul :)
Gotta jump be back soon (lectures)
Paul Heidenreich
@Paulomart
Mar 03 2016 10:49
I was trying to tidy up some issues but there are to many :D
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:50
Yeah, it is so much, and people don't look at previous issues
so atleast 50% are duplicates
And BTW, the double placing sound for glass still occurs
How old are you guys? Just curious :P
These emojis....
Paul Heidenreich
@Paulomart
Mar 03 2016 10:52
Sound I would say are low priority. Did someone talk to see acc author?
No-one can fix that if it's closed source..
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:53
Yeah, but maybe Myles can ask it for free, since compatibility is also an advantage for the AAC author
AAC is AdvancedAntiCheat right?
Paul Heidenreich
@Paulomart
Mar 03 2016 10:57
Yeah, I doubt he would give out that. It's just because he is sending invalid metadata so some checks, we get a null pointer
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 10:59
Check out the bug with breeding, guess there's still something wrong with the metadata... MylesIsCool/ViaVersion#82
Mats
@Matsv
Mar 03 2016 11:04
I think I found out what causes the 'Can't exit vehicle' bug. In 1.8 Attach Entity sent vehicle = -1 & passenger = something to the client. But in 1.9 it (Set Passenger Packet) has to be vehicle = something & passengers = emptyarray
So I need to get somehow the vehicle id to fix this
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:05
Intercept the ATTACH_ENTITY packet and keep a local list?
Nice work
Paul Heidenreich
@Paulomart
Mar 03 2016 11:07
@HugoDaBosss this is because the value of the status metadata is mixed into something.. not sure but I saw a comment in code. I'm currently not home but I have some time in one - two hours from now.
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:07
In 1.8 the age from an entity was a byte, but in 1.9 it's just a single boolean: isBaby
I think the 1.8 servers has a custom age for animals that are currently on breeding cooldown, and in 1.9 this was removed.
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:13
In 1.8 the age for the parents is 1, and for the baby -1
Paul Heidenreich
@Paulomart
Mar 03 2016 11:13
So this is a easy fix then :D
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:14
Yeah, I'm working on it
Yep, it's fixed
Mats
@Matsv
Mar 03 2016 11:26
Does particles work properly?
Haven't seen any issues about them
fillefilip8
@fillefilip8
Mar 03 2016 11:28
hey haha :D
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:31
Hey filip(?) :D
Mats
@Matsv
Mar 03 2016 11:31
Hey
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:31
Yeah particles work fine
fillefilip8
@fillefilip8
Mar 03 2016 11:31
Yeah im Filip :)
I did that fancy message pull request if you remmber :D
I saw that u guys added a chat :D
So why not join it XD
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:33
Yeah, where are you from?
Mats
@Matsv
Mar 03 2016 11:33
I use most of the time IRC, never really use this. But it works pretty good
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:33
Yeah it's nice and clean, and gitub integration is nice
fillefilip8
@fillefilip8
Mar 03 2016 11:33
I'm from Sweden :)
brb gonna eat some lunch :)
Mats
@Matsv
Mar 03 2016 11:35
Enjoy
Paul Heidenreich
@Paulomart
Mar 03 2016 11:41
Is someone working on a item rewrite? I started on that yesterday
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:43
Which item rewrite?
Paul Heidenreich
@Paulomart
Mar 03 2016 11:43
Spawn eggs and potions
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:44
Oh I just started working on the spawn eggs, I'll let you make it then ;)
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:53
Maybe we should add plugin metrics? So we can see how much the plugin is actually used :D
Paul Heidenreich
@Paulomart
Mar 03 2016 11:54
I personaly really hate Metrics.. sorry^^
fillefilip8
@fillefilip8
Mar 03 2016 11:54
Why u hate Metrics?
Paul Heidenreich
@Paulomart
Mar 03 2016 11:54
It just costs performance
And disk space
fillefilip8
@fillefilip8
Mar 03 2016 11:55
disk space?
how?
Paul Heidenreich
@Paulomart
Mar 03 2016 11:56
There are classes in the plugin that I would not need without it.
But still its usefull, so we might go for it..
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:56
Isn't plugin metrics integrated in Spigot? Without any plugins there is still a pluginmetrics folder
fillefilip8
@fillefilip8
Mar 03 2016 11:57
U still need to implement it tho i think?
Lorenzo
@HAlexTM
Mar 03 2016 11:57
Nope, you need to implement metrics for any plugin
This is just a general setting
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 11:58
Ah okay
But it is up to myles to implement it I guess, because it's his plugin
fillefilip8
@fillefilip8
Mar 03 2016 11:58
^^
Lorenzo
@HAlexTM
Mar 03 2016 11:58
Yep, just copy and paste XD
Lorenzo
@HAlexTM
Mar 03 2016 11:59
Hey guys, you're working really better then other devs, and we're Hiring someone as our dev feel alone
fillefilip8
@fillefilip8
Mar 03 2016 12:00
I'm still trying to understand minecraft's packets logic XD
Lorenzo
@HAlexTM
Mar 03 2016 12:01
No one?
Ok XD
fillefilip8
@fillefilip8
Mar 03 2016 12:01
Lol
Lorenzo
@HAlexTM
Mar 03 2016 12:02
If anyone is a bit interested, just send an email to info@
LOL. ..
Paul Heidenreich
@Paulomart
Mar 03 2016 12:02
.ml says all
fillefilip8
@fillefilip8
Mar 03 2016 12:02
lols
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:03
I'm always interested in developing plugins, what kind of plugins are you looking at?
But we should keep this chat just for ViaVersion ;)
fillefilip8
@fillefilip8
Mar 03 2016 12:04
^
Beacuse ViaVersion is love
:D
melerpe
@melerpe
Mar 03 2016 12:05
Hi
fillefilip8
@fillefilip8
Mar 03 2016 12:05
Hey!
melerpe
@melerpe
Mar 03 2016 12:06
I have an idea (Not a javaguy here), use shields when a 1.9 player rightclicks with a sword (Just like hypixel) So 1.9clients can kinda block
fillefilip8
@fillefilip8
Mar 03 2016 12:08
I will see if i can do that haha. Well i can always try
haha
Lorenzo
@HAlexTM
Mar 03 2016 12:08
Hey
Lol
Paul Heidenreich
@Paulomart
Mar 03 2016 12:08
It's a great idea but we haven't stabilized the hack it self once this is done I'm sure someone will look at it
Lorenzo
@HAlexTM
Mar 03 2016 12:09
We choose .ml as M (ine) L (ight) and my name is Lorenzo, Co leader is Mario
Paul Heidenreich
@Paulomart
Mar 03 2016 12:09
Ml is 4 free
melerpe
@melerpe
Mar 03 2016 12:09
And 1.9 players can get pushed by mobs and players, while 1.8 cant
fillefilip8
@fillefilip8
Mar 03 2016 12:09
Time to fetch the lastest source of ViaVersion... XD
Lorenzo
@HAlexTM
Mar 03 2016 12:09
And thiz s better
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:11
I think the pushing by mobs happens clientside, so that's pretty hard to fix
melerpe
@melerpe
Mar 03 2016 12:11
It has something to do with teams
fillefilip8
@fillefilip8
Mar 03 2016 12:11
Why did they add pushing mobs/players again?
Wasnt that removed in like 1.7 or so?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:12
I have no idea, pushing players is also back
Yeah it was removed in 1.7, and maybe also 1.6
melerpe
@melerpe
Mar 03 2016 12:12
(Not A javaguy) Cant you make everyone join the same team and disable pushing(Atleast the players)
fillefilip8
@fillefilip8
Mar 03 2016 12:13
Lets blame Microsoft :)
melerpe
@melerpe
Mar 03 2016 12:13
They are listening
fillefilip8
@fillefilip8
Mar 03 2016 12:13
XD
melerpe
@melerpe
Mar 03 2016 12:13
NSA uses Microsoft computers
fillefilip8
@fillefilip8
Mar 03 2016 12:13
Well making everyone in same team
That would break some minigames plugins?
melerpe
@melerpe
Mar 03 2016 12:14
Not that i know of
They use array lists (Still no java here) to store players in teams (Most of them)
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:14
You could send those packets to only the 1.9 clients
So the server has the original teams, if any
fillefilip8
@fillefilip8
Mar 03 2016 12:15
Well yes @melerpe but some plugins can use the "Scoreboard" teams
melerpe
@melerpe
Mar 03 2016 12:15
Can
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:16
Maybe an option in the config?
melerpe
@melerpe
Mar 03 2016 12:16
Meaby add option in config
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:16
But it's low priority
melerpe
@melerpe
Mar 03 2016 12:16
Wanted to say the same
Always write never, would not cover all cases but most of them
Mats
@Matsv
Mar 03 2016 12:16
Yeah, that should be 'never'
fillefilip8
@fillefilip8
Mar 03 2016 12:17
I just hate github sometimes :)
Mats
@Matsv
Mar 03 2016 12:17
Why?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:18
Yeah me too, all those branches and commits x.x It's confusing sometimes
And the eclipse git plugin fucks up my formatting sometimes
fillefilip8
@fillefilip8
Mar 03 2016 12:18
I want to fetch the lastest source
and still keep my class i have
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:19
Yeah you need to create a new branch, then fetch the source
And then apply your changes
and then make a commit
I guess :P
fillefilip8
@fillefilip8
Mar 03 2016 12:21
Now i got the lastest source i think :D
Time to start coding XD
oh no
Mats
@Matsv
Mar 03 2016 12:22
This branch is 27 commits behind MylesIsCool:master says github
fillefilip8
@fillefilip8
Mar 03 2016 12:22
intellij hates me again XD
shift + 8 = *
wut
Mats
@Matsv
Mar 03 2016 12:23
I use 'Rebase GitHub fork' in IntellIJ
It seems to work
Don't know if thats the best way though
melerpe
@melerpe
Mar 03 2016 12:23
Which ide do you guys recomend to me, now using Netbeans, and eclipse hates me
fillefilip8
@fillefilip8
Mar 03 2016 12:23
I use eclipse and intellij
Mats
@Matsv
Mar 03 2016 12:24
I use intellij
gigosaurus
@gigosaurus
Mar 03 2016 12:24
IntelliJ master race
fillefilip8
@fillefilip8
Mar 03 2016 12:24
I do prefer eclipse for some stuff XD
When i need to have multiple projects open
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:26
I prefer eclipse most times, but git in eclipse is driving me crazy x.x
Mats
@Matsv
Mar 03 2016 12:27
Yeah Intellij has better Git integration
fillefilip8
@fillefilip8
Mar 03 2016 12:27
lols
melerpe
@melerpe
Mar 03 2016 12:27
Eclipse hates me, Used it to compile a plugin (From source) Failed. Then used netbeans worked
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:28
Yeah, but you need to compile ViaVersion using maven btw
melerpe
@melerpe
Mar 03 2016 12:28
I know
gigosaurus
@gigosaurus
Mar 03 2016 12:28
IntelliJ just has so many nice inspections and features that make it extremely easy to be really lazy and still produce good code. Was forced to use eclipse a few months back and hated how much I had to do manually
melerpe
@melerpe
Mar 03 2016 12:28
But even that failed
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:29
I'm downloading intellij ;)
fillefilip8
@fillefilip8
Mar 03 2016 12:29
Anyone know how the left hand works? XD
Mats
@Matsv
Mar 03 2016 12:30
just slot 45 right?
fillefilip8
@fillefilip8
Mar 03 2016 12:30
is it?
Mats
@Matsv
Mar 03 2016 12:30
Let me check
fillefilip8
@fillefilip8
Mar 03 2016 12:30
let me see XD
gigosaurus
@gigosaurus
Mar 03 2016 12:30
we've attempted to just make 1.9 clients drop any items attempted to be placed in the left hand but I think it currently just causes exceptions
I believe it is 45
melerpe
@melerpe
Mar 03 2016 12:31
But you can store the item while on the server
Cant you just set a unremovable barrier in the left hand
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:32
An item in the offhand slot should be prevented at all times
gigosaurus
@gigosaurus
Mar 03 2016 12:32
if that's the case then the dropping part isn't working correctly
melerpe
@melerpe
Mar 03 2016 12:32
(Atleast when they are in there inventory
gigosaurus
@gigosaurus
Mar 03 2016 12:32
any item that is placed in the left hand should be instantly dropped. if that isn't working then there's a bug - last I checked it wasn't working but was too tired to attempt to fix it
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:33
It's better to deny the use of the offhand slot, otherwise in 1.9 you will always see a barrier next to your hotbar
Yeah I thought it was fixed, but also this guy opened an issue about it: MylesIsCool/ViaVersion#67
melerpe
@melerpe
Mar 03 2016 12:34
Also fizz sounds like a fired arrow
gigosaurus
@gigosaurus
Mar 03 2016 12:34
Anyone have any idea on how to fix issue #38 as that's now probably the biggest and possibly only thing stopping me from using this
fillefilip8
@fillefilip8
Mar 03 2016 12:34
About that "giving a player a shield" if they block with a sword
melerpe
@melerpe
Mar 03 2016 12:34
yes
fillefilip8
@fillefilip8
Mar 03 2016 12:35
Is it just possible to send packet to the client saying he has a shield?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:35
I have no idea @gigosaurus
fillefilip8
@fillefilip8
Mar 03 2016 12:35
or will the 1.8 server
say an error
gigosaurus
@gigosaurus
Mar 03 2016 12:36
I have a feeling the org/spacehq/mc stuff isn't quite correct
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:36
Isn't the right click packet still send while holding right click in 1.9? If so, the server would still see it as blocking?
melerpe
@melerpe
Mar 03 2016 12:36
Yeah but for the 1.9 client it is not able to see
So how are you going to inform them that they are blocking
fillefilip8
@fillefilip8
Mar 03 2016 12:37
I just tried a bullshit method. By saying the player has a shield on slot 45
melerpe
@melerpe
Mar 03 2016 12:37
(And slow down is handeld by the client)
fillefilip8
@fillefilip8
Mar 03 2016 12:37
well
it gives me an error
Caused by: java.lang.ArrayIndexOutOfBoundsException: 9
XD
gigosaurus
@gigosaurus
Mar 03 2016 12:37
yeah I feel like we will have to implement hypixel style blocking
Mats
@Matsv
Mar 03 2016 12:37
Yeah you probably can't do it with the api
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:37
It will be difficult though :P
fillefilip8
@fillefilip8
Mar 03 2016 12:38
well
if we just tell the client that he has a shield for some sec?
or
reduce damage
on hit?
when they have "right clicked"
melerpe
@melerpe
Mar 03 2016 12:39
When you rigthclick in 1.9 i dont see a damage resistance / compared to 1.8
gigosaurus
@gigosaurus
Mar 03 2016 12:39
is there a packet sent from client->server when right click is no longer held?
fillefilip8
@fillefilip8
Mar 03 2016 12:39
Not sure
melerpe
@melerpe
Mar 03 2016 12:39
(I think they removed the block send packet
Mats
@Matsv
Mar 03 2016 12:40
I think http://wiki.vg/Pre-release_protocol#Use_Item sends it every tick while right clicked
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:40
Yeah that's a nice improvement, much beter than using place block packets in 1.8
fillefilip8
@fillefilip8
Mar 03 2016 12:41
the use item packet
melerpe
@melerpe
Mar 03 2016 12:41
Installing intellij
fillefilip8
@fillefilip8
Mar 03 2016 12:41
is already there in the "packettype"
so i guess we can use it?
fillefilip8
@fillefilip8
Mar 03 2016 12:42
Yea
im looking at that
Now just to telling the client to use a shield
or something
melerpe
@melerpe
Mar 03 2016 12:44
Or set there speed to smoething like 0.4
fillefilip8
@fillefilip8
Mar 03 2016 12:44
speed?
melerpe
@melerpe
Mar 03 2016 12:45
Walk speed
Because having a shield like hypixel is slower than blocking
(because of that i died 2 times)
fillefilip8
@fillefilip8
Mar 03 2016 12:47
I dont even know how to send packets on this
XD
@melerpe you mean slowness?
melerpe
@melerpe
Mar 03 2016 12:47
You could do that, but you can change speed like essentials /speed command
fillefilip8
@fillefilip8
Mar 03 2016 12:49
@StamBoom What is the "null" parameter?
melerpe
@melerpe
Mar 03 2016 12:49
Googled walking speed
fillefilip8
@fillefilip8
Mar 03 2016 12:49
is it a itemstack or something?
melerpe
@melerpe
Mar 03 2016 12:49
setWalkingSpeed(1);
fillefilip8
@fillefilip8
Mar 03 2016 12:50
oh
nbt shit -.-
Mats
@Matsv
Mar 03 2016 12:50
@fillefilip8 yeah i think itemstack
fillefilip8
@fillefilip8
Mar 03 2016 12:50
It says Slot Data Array of Slot
melerpe
@melerpe
Mar 03 2016 12:50
ans with spawn eggs why dont you read the nbt when a 1.9 player is in creative
fillefilip8
@fillefilip8
Mar 03 2016 12:51
melerpe
@melerpe
Mar 03 2016 12:51
As an update for 15w33a: spawn eggs no longer use the "Damage" value to determine the type of mob to summon. It now uses the "id" tag within "EntityTag" (meaning "EntityTag" is required):
/give @p spawn_egg 1 0 {EntityTag:{id:"Creeper",CustomName:"TEST",CustomNameVisible:1}}
Cant you read the id of the entity tag
Mats
@Matsv
Mar 03 2016 12:52
@melerpe I think @Paulomart is working on that
Paul Heidenreich
@Paulomart
Mar 03 2016 12:52
Im working on the spawn eggs right now
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:52
Yeah, but paul was going to fix those items
fillefilip8
@fillefilip8
Mar 03 2016 12:52
@StamBoom giving it a itemstack crashed my client :D
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:52
Yeah ^^
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:53
I'm getting this error with the bossbarapi: http://pastebin.com/YxwCs7Bf
fillefilip8
@fillefilip8
Mar 03 2016 12:53
No i didnt
@StamBoom How does that method work tho? XD
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:54
I think it uses the minecraft internals
Mats
@Matsv
Mar 03 2016 12:54
writeItem(net.minecraft.Itemstack(orSomethingLikeThat,output)
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:55
And btw, the readItem method, the ByteBuf is actually the input, not the output right?
Mats
@Matsv
Mar 03 2016 12:55
Yeah I guess so
Paul Heidenreich
@Paulomart
Mar 03 2016 12:56
Fingers crossed
fillefilip8
@fillefilip8
Mar 03 2016 12:56
@StamBoom to access that i would need to use craftbukkit?
Or is there a nms util or some kind
Mats
@Matsv
Mar 03 2016 12:56
Yeah reflection
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:56
ReflectionUtil.nms("Classname");
melerpe
@melerpe
Mar 03 2016 12:57
java 7 or java 8, what should i use
Myles
@MylesIsCool
Mar 03 2016 12:57
Howdy, I'm back
Mats
@Matsv
Mar 03 2016 12:57
Hi
fillefilip8
@fillefilip8
Mar 03 2016 12:57
My god i hate nms
Myles
@MylesIsCool
Mar 03 2016 12:57
I use Java 7 :P
fillefilip8
@fillefilip8
Mar 03 2016 12:57
fille cant handle the nms
Myles
@MylesIsCool
Mar 03 2016 12:57
Java 8 isn't widely used enough
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:58
I'm using 7, and it's working fine as well
Wb myles ;D
Myles
@MylesIsCool
Mar 03 2016 12:58
Nice work on the PRs @HugoDaBosss @StamBoom <3
fillefilip8
@fillefilip8
Mar 03 2016 12:58
Wb @MylesIsCool
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:58
Thanks :D
I'm looking in to the bossbar right now
Lorenzo
@HAlexTM
Mar 03 2016 12:59
Nowadays java 8 is required for most of plugins...
Myles
@MylesIsCool
Mar 03 2016 12:59
The idea would be you tap into entity metadata have some sort of BossBarTracker class maybe and track when WITHER or ENDERDRAGON spawned
Some hosts still use Java 7, I mean in essence if you're committing you're fine using w/e version as long as you don't use fancy things in Java 8
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 12:59
Yeah, and the names in 1.9 are in JSON right?
Mats
@Matsv
Mar 03 2016 13:00
@HugoDaBosss yeah
melerpe
@melerpe
Mar 03 2016 13:00
But there are now 6 or 8 types of bossbars
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:00
And there is an error while writing ENDER_DRAGON entitymeta: http://pastebin.com/YxwCs7Bf
Myles
@MylesIsCool
Mar 03 2016 13:00
well for packets it's typeID right?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:01
@melerpe Yeah but the packets are all the same
Myles could you push a new 0.4.6 update? A lot of people are opening issues which are actually fixed already :P
melerpe
@melerpe
Mar 03 2016 13:02
Or get a build server
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:02
@MylesIsCool
fillefilip8
@fillefilip8
Mar 03 2016 13:02
I could provide with a build server if you guys want
XD
Myles
@MylesIsCool
Mar 03 2016 13:03
I'll consider throwing up a build server sometime, I'll push 0.4.6 in 5 min (just gotta read through PMs / emails)
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:03
Yeah I have dedicated hosting available as well
fillefilip8
@fillefilip8
Mar 03 2016 13:04
:P
melerpe
@melerpe
Mar 03 2016 13:05
(Still no java guy) How do you add depencies in intellij, Is it kinda like netbeans
Myles
@MylesIsCool
Mar 03 2016 13:05
It's nice to see from the start the project was averaging like 3 stars now to like 5.5 haha
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:06
You should use maven @melerpe
4.5 xd But yeah the ratings have gone up quite a bit
melerpe
@melerpe
Mar 03 2016 13:06
Maven, so can i convert an existing project to maven
Mats
@Matsv
Mar 03 2016 13:06
Yes
fillefilip8
@fillefilip8
Mar 03 2016 13:06
Yes @melerpe
Mats
@Matsv
Mar 03 2016 13:06
Intellij wil detect maven
will
fillefilip8
@fillefilip8
Mar 03 2016 13:07
This happens when fille uses packets: Caused by: java.io.IOException: Packet 0/8 (PacketPlayInBlockPlace) was larger than I expected, found 2 bytes extra whilst reading packet 8
Dont ask me what im doing
Myles
@MylesIsCool
Mar 03 2016 13:08
Are you using your own plugin to send packets?
fillefilip8
@fillefilip8
Mar 03 2016 13:08
I was playing around with your plugin
Myles
@MylesIsCool
Mar 03 2016 13:08
is this editing it or what haha
fillefilip8
@fillefilip8
Mar 03 2016 13:08
Well i was trying to do something
but i fail
More stuff changed on boats in 1.9
Myles
@MylesIsCool
Mar 03 2016 13:09
My advice would be to look at wiki.vg on how it works
they document most things, but not everything though haha
fillefilip8
@fillefilip8
Mar 03 2016 13:09
Yeah ik
But im new to packets :)
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:09
Does anyone know if you can enable push notification on the Gitter mobile client?
fillefilip8
@fillefilip8
Mar 03 2016 13:09
Im better at the other stuff in java
Mats
@Matsv
Mar 03 2016 13:10
@HugoDaBosss It asked me when I started it for the first time
fillefilip8
@fillefilip8
Mar 03 2016 13:10
:)
melerpe
@melerpe
Mar 03 2016 13:10
My idea was https://github.com/Turkey2349/Call_Of_Minecraft-Zombies with MCjukebox API sounds (And it did kinda work, but there where erros in the original project)
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:11
Using the android app @StamBoom ?
Mats
@Matsv
Mar 03 2016 13:11
Nope IOS, But I never got any notifications from it though
Maybe because I'm online
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:11
Guess they didn't add support for push notification then
fillefilip8
@fillefilip8
Mar 03 2016 13:11
Umm
i cant connect to my test server with 1.9 anymore
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:12
Because in iOS an app needs to ask for push notifications, while in android it's always allowed
fillefilip8
@fillefilip8
Mar 03 2016 13:12
i just re fetched the lastest source :O
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:12
Let me check @fillefilip8
fillefilip8
@fillefilip8
Mar 03 2016 13:13
It was my code i think
:P
melerpe
@melerpe
Mar 03 2016 13:13
updated
God job myles
fillefilip8
@fillefilip8
Mar 03 2016 13:13
Minecarts are still broken tho?
i just got kicked for flying :D
melerpe
@melerpe
Mar 03 2016 13:13
Are they
NOOOOOOOO
That ruins the themepark part
fillefilip8
@fillefilip8
Mar 03 2016 13:14
nvm
intellij just hates me when i compile the lastest code
XD
Myles
@MylesIsCool
Mar 03 2016 13:14
I've pushed version 0.4.6 https://www.spigotmc.org/resources/viaversion.19254/ (Thanks to @StamBoom @HugoDaBosss for fixing quite a few bugs in this release ^.^)
Paul Heidenreich
@Paulomart
Mar 03 2016 13:16
Man these Items are tricky
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:16
Oh man I love fixing versions @MylesIsCool ;)
Myles
@MylesIsCool
Mar 03 2016 13:16
I'd assume you need to make some sort of NBTTransformer, then make an enum with potion types or what, or use bukkits inbuilt one :(
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:16
Yeah I looked into reading items from a NBT datastream
melerpe
@melerpe
Mar 03 2016 13:16
How to add libaries and depencies to a project in intellij, trying to make some edits (Second plugin edit) to some systems for using mcjukebox API (or how do i convert to maven)
Paul Heidenreich
@Paulomart
Mar 03 2016 13:16
Yes I was assuming ids but its enum
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:17
But it's quite difficult actually
Paul Heidenreich
@Paulomart
Mar 03 2016 13:17
:D
Had it done with ids ^^
Then minecraft wiki is wrong..
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:17
Couldn't you use a public NBT library, read the bytebuf, and then read from the nbt object?
That way you don't depend on minecraft code
Mats
@Matsv
Mar 03 2016 13:17
https://github.com/Steveice10/OpenNBT spacehq's opennbt could be an option?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:17
Or did you write the NBT reading yourself @Paulomart ?
Paul Heidenreich
@Paulomart
Mar 03 2016 13:18
Using nms currently
Myles
@MylesIsCool
Mar 03 2016 13:18
You could just reflect the MC one, I like including other libraries but it just becomes a big overhead but does make the project lead towards independance
We could probably abstract it later :)
Paul Heidenreich
@Paulomart
Mar 03 2016 13:18
Yeah. get it working first ^^
Myles
@MylesIsCool
Mar 03 2016 13:19
This message was deleted
This message was deleted
This message was deleted
fillefilip8
@fillefilip8
Mar 03 2016 13:22
I wonder why my compile on intellij
is biggger then the jar on spigot
hmmm
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:22
Maybe you included the dependencies in your jar?
fillefilip8
@fillefilip8
Mar 03 2016 13:24
No?
Wierd :D
Paul Heidenreich
@Paulomart
Mar 03 2016 13:27
YES
TitanicFreak
@TitanicFreak
Mar 03 2016 13:28
oh dear
does this work
Paul Heidenreich
@Paulomart
Mar 03 2016 13:28
Yes, still need to add a few things..
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:29
It works for almost everything, but there are still some small bugs
TitanicFreak
@TitanicFreak
Mar 03 2016 13:29
talking about
this chat
but alright
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:29
Hahahah okay nvm then :P
TitanicFreak
@TitanicFreak
Mar 03 2016 13:30
I already have my own protocol hack.
I'm just here because I like public projects
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:30
Make one yourself?
Or did you buy the other one for about 1000$ from that other guy xd
TitanicFreak
@TitanicFreak
Mar 03 2016 13:30
bought it from katie
it works for my uses, so I'm not complaining.
impressed how far this has come though
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:31
But I gotta go guys, gotta go to work
I'll catch up with you later this evening
Mats
@Matsv
Mar 03 2016 13:31
cya
TitanicFreak
@TitanicFreak
Mar 03 2016 13:31
rip
Paul Heidenreich
@Paulomart
Mar 03 2016 13:31
See you
fillefilip8
@fillefilip8
Mar 03 2016 13:32
cya
Fille did a pull request :)
TitanicFreak
@TitanicFreak
Mar 03 2016 13:35
I should probably test
if viaversion works with lilypad
actually, brb.
Myles
@MylesIsCool
Mar 03 2016 13:38
It doesn't work fully I need to get compatibility, some guy PM'd me about it but I don't have a full setup
fillefilip8
@fillefilip8
Mar 03 2016 13:38
@StamBoom How would that work?
Mats
@Matsv
Mar 03 2016 13:38
@fillefilip8 yeah nvm i doesn't compile :P
fillefilip8
@fillefilip8
Mar 03 2016 13:38
@StamBoom I thought that too. I like wut XD
Im gonna add some commands to ViaVersion :)
TitanicFreak
@TitanicFreak
Mar 03 2016 13:40
@MylesIsCool what do you need?
Paul Heidenreich
@Paulomart
Mar 03 2016 13:43
so I got the first part of the itemstacks done, will look at it more later see you
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 13:52
Nice job!
Did you push it to your own repo?
fillefilip8
@fillefilip8
Mar 03 2016 13:53
When i compile it the plugin doesnt always work
wierd
It just says "Disconnected"
fillefilip8
@fillefilip8
Mar 03 2016 13:58
MylesIsCool/ViaVersion#87
TitanicFreak
@TitanicFreak
Mar 03 2016 14:06
rip
was hoping myles would tell me what he needs help with
I'll just wing it
Myles
@MylesIsCool
Mar 03 2016 14:06
Oh sorry TitanicFreak didn't see that just got back
I wanted to know if the plugin works if you just make it load before Lilypad-Connect or what
@TitanicFreak ^^
fillefilip8
@fillefilip8
Mar 03 2016 14:07
@MylesIsCool Look at my pull request :)
TitanicFreak
@TitanicFreak
Mar 03 2016 14:08
@MylesIsCool ah, thanks.
I'll run some tests now, give me like 30 minutes or so. also kinda eating breakfast.
Myles
@MylesIsCool
Mar 03 2016 14:10
@fillefilip8 Could you add more to the YML like command description, usage, and permission? as well as removing by _MylesC (i feel it's better without that)
@fillefilip8 Otherwise looks good
melerpe
@melerpe
Mar 03 2016 14:21
Meaby for some 1.9 handeling look at carbon 2
They also implemented an api for offhand slot
TitanicFreak
@TitanicFreak
Mar 03 2016 14:33
lol
yeah, viaversion
works perfectly
with lilypad
wasn't expecting that
@MylesIsCool
Myles
@MylesIsCool
Mar 03 2016 14:34
Did you need any modification?
TitanicFreak
@TitanicFreak
Mar 03 2016 14:34
nah
downloaded it off of spigot
just loaded it normally
it was broken 3-4 versions ago
oh what fun
Myles
@MylesIsCool
Mar 03 2016 14:34
When we fixed protocol lib it probs fixed it cheers
TitanicFreak
@TitanicFreak
Mar 03 2016 14:35
usually lilypad
doesn't like ANYTHING touching netty
protocolsupport for example is entirely broken with lilypad
This message was deleted
:+1:
Myles
@MylesIsCool
Mar 03 2016 14:36
Cheers man
melerpe
@melerpe
Mar 03 2016 14:37
This message was deleted
melerpe
@melerpe
Mar 03 2016 14:52
So what viaversion is doing is the opposite of protocolsupport
Via version 1.8-->1.9
Protocolsupport 1.9-->1.8
TitanicFreak
@TitanicFreak
Mar 03 2016 14:59
yes
Lorenzo
@HAlexTM
Mar 03 2016 15:22
Is carbon 2 compatible with ViaVersion? ? Did you tried?
Myles
@MylesIsCool
Mar 03 2016 15:24
Why would use use carbon 2 and viaversion?
Lorenzo
@HAlexTM
Mar 03 2016 15:33
because Spigot 1.9 is really a * bugged thing, sorry
Myles
@MylesIsCool
Mar 03 2016 15:34
Would you not just use carbon 2?
haha
Lorenzo
@HAlexTM
Mar 03 2016 15:36
mmm is carbon "Protocolling hacking"?? XD
Myles
@MylesIsCool
Mar 03 2016 15:37
Essentially carbon is this plugin but with the advantage of having 1.9 features.
and the point that this was mainly done by the time they started carbon 2
Lorenzo
@HAlexTM
Mar 03 2016 15:42
Oh ok.. but no problem, i'm not going to remove 1.8 support
TitanicFreak
@TitanicFreak
Mar 03 2016 16:03
then carbon 2
isn't for you
carbon 2 is all about simulating a 1.9 server
Myles
@MylesIsCool
Mar 03 2016 16:05
In other news
i'm working on removing herobrine, he's annoying me too much
TitanicFreak
@TitanicFreak
Mar 03 2016 16:06
didn't mojang already remove that?
like 16 or so times?
Lorenzo
@HAlexTM
Mar 03 2016 16:06
XD
Myles
@MylesIsCool
Mar 03 2016 16:07
:(
yeah but he got in our code
TitanicFreak
@TitanicFreak
Mar 03 2016 16:07
dammit dinnerbone
you had one job
Lorenzo
@HAlexTM
Mar 03 2016 16:11
your job, nothing he like 180 ° rotation...
TitanicFreak
@TitanicFreak
Mar 03 2016 16:11
you know its
possible to do mirrors
in minecraft
fillefilip8
@fillefilip8
Mar 03 2016 16:13
@MylesIsCool The command already has a permission but sure :)
@MylesIsCool I will add that :)
TitanicFreak
@TitanicFreak
Mar 03 2016 16:13
hmm
does gitter have an ios
app
Mats
@Matsv
Mar 03 2016 16:13
@TitanicFreak yes
TitanicFreak
@TitanicFreak
Mar 03 2016 16:13
sweet
now I don't have to keep my laptop screen open and drain the battery
fillefilip8
@fillefilip8
Mar 03 2016 16:24
Have u guys seen this error before? http://prnt.sc/aaq6aw
Myles
@MylesIsCool
Mar 03 2016 16:29
about 10 billion times
the error kick message itself, does not help
fillefilip8
@fillefilip8
Mar 03 2016 16:29
has it been fixed?
Myles
@MylesIsCool
Mar 03 2016 16:29
It's a vague error
several things that cause it, have been
fillefilip8
@fillefilip8
Mar 03 2016 16:29
What causes it?
Myles
@MylesIsCool
Mar 03 2016 16:29
I just said
It's a vague error
fillefilip8
@fillefilip8
Mar 03 2016 16:29
:P
Myles
@MylesIsCool
Mar 03 2016 16:29
There is no 1 specific cause
but multiple
fillefilip8
@fillefilip8
Mar 03 2016 16:30
examples?
Myles
@MylesIsCool
Mar 03 2016 16:30
Invalid Kick Json, Invalid Chat Json, Invalid Header / Footer Json, Invalid Title Json
Mats
@Matsv
Mar 03 2016 16:30
http://wiki.vg/Protocol Almost everything where Field type 'Chat' is
fillefilip8
@fillefilip8
Mar 03 2016 16:31
Ah okay
I will fix that yml description stuff to the command :)
@MylesIsCool
Mats
@Matsv
Mar 03 2016 16:31
Probably also the reason why books doesn't work
Myles
@MylesIsCool
Mar 03 2016 16:31
I'm in belief books packet has changed which is why that doesnt
Might be worth checking PlayerListItem
as it uses Chat
Mats
@Matsv
Mar 03 2016 16:32
Yeah maybe, but the nbt is different from books
Myles
@MylesIsCool
Mar 03 2016 16:33
oh
If you don't want to
I will write a parser to look through NBT data
fix any strings starting with "
:)
fillefilip8
@fillefilip8
Mar 03 2016 16:37
This is how i fail with github fillefilip8/ViaVersion@dc73fcb
So good XD
Paul Heidenreich
@Paulomart
Mar 03 2016 16:41
Hmm, I got the rewrite from 1.8 to 1.9 done. But if a 1.9 clients creates a spawn egg in create it is invalid for other 1.8 clients
fillefilip8
@fillefilip8
Mar 03 2016 16:44
@MylesIsCool MylesIsCool/ViaVersion#87
@Paulomart "You should squash the commits" What do you mean?
Paul Heidenreich
@Paulomart
Mar 03 2016 16:46
Make them into one commit.
fillefilip8
@fillefilip8
Mar 03 2016 16:46
How tho?
XD
Paul Heidenreich
@Paulomart
Mar 03 2016 16:46
You currently have a lot
fillefilip8
@fillefilip8
Mar 03 2016 16:47
But how to do that?
YES GOT THE F*CKIN SPAWN EGGS
On to the potions!
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 16:48
Wow nice work @Paulomart :D
Mats
@Matsv
Mar 03 2016 16:48
Nice
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 16:48
Back btw
Paul Heidenreich
@Paulomart
Mar 03 2016 16:50
hmm
You do you get the potion name by the id? I hava a nms mobeffect thou..
fillefilip8
@fillefilip8
Mar 03 2016 16:53
@Paulomart i dont understand anything :D
Paul Heidenreich
@Paulomart
Mar 03 2016 16:53
LOL German Minecraft Wiki is updated but not the english one xD
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 16:54
Hahahah wtf, logics
Paul Heidenreich
@Paulomart
Mar 03 2016 16:55
Im from germany so its good :D
fillefilip8
@fillefilip8
Mar 03 2016 16:57
@Paulomart this text editor is wierd as fuck
i dont understand its logic
Paul Heidenreich
@Paulomart
Mar 03 2016 16:58
I will do it when im ready with the positons,
fillefilip8
@fillefilip8
Mar 03 2016 16:58
i literally just broke git -.-
Paul Heidenreich
@Paulomart
Mar 03 2016 17:12
Man this is even without reflection so hacky..
fillefilip8
@fillefilip8
Mar 03 2016 17:18
i cant handle this github logic
Paul Heidenreich
@Paulomart
Mar 03 2016 17:20
NUUUU MOJANG WHY DO YOU DO THIS
2016-03-03_18.19.56.png
fillefilip8
@fillefilip8
Mar 03 2016 17:21
rip
@Paulomart is that git "squash" needed?
beacuse i cant understand it
im just making it worse
Paul Heidenreich
@Paulomart
Mar 03 2016 17:22
Not really it would just clean up all your commits into one
fillefilip8
@fillefilip8
Mar 03 2016 17:23
can you help me understand it :D
Paul Heidenreich
@Paulomart
Mar 03 2016 17:30
sorry Im currently busy getting these potions working
fillefilip8
@fillefilip8
Mar 03 2016 17:31
this is rip
nothign happend :(
MylesIsCool/ViaVersion#87
Thats how u break github
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 17:36
Yeah github can be confusing
If you just keep one master branch, which you keep up to date with the fork, and for each commit you want to do you create a new branch for that specific commit
fillefilip8
@fillefilip8
Mar 03 2016 17:36
somehow
myles
commited to my repo
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 17:36
That's how I keep it organized
fillefilip8
@fillefilip8
Mar 03 2016 17:36
according to the pull request
brb
Paul Heidenreich
@Paulomart
Mar 03 2016 17:39
hmpf.. #96
Paul Heidenreich
@Paulomart
Mar 03 2016 17:49
Mystalion/ViaVersion@10f6a9e
@fillefilip8 there you go
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 17:50
I'm currently at a LAN party so I won't do much coding, but I'm here to answer
Paul Heidenreich
@Paulomart
Mar 03 2016 17:52
Okay^^
@fillefilip8 I edit the commit message to fit the changes: Mystalion/ViaVersion@15f0756
Myles
@MylesIsCool
Mar 03 2016 18:10
@Paulomart not going to pull until reflection, i'm going to push a change that allows any version of 1.8 essentially and this would break it.
Paul Heidenreich
@Paulomart
Mar 03 2016 18:10
Yeah I know its [WIP] Currently I have no idea how to fix potions..
Should I remove them and add them in a later pr?
Myles
@MylesIsCool
Mar 03 2016 18:10
my advice would be doing what @StamBoom does by using NBT viewer
and compare
Paul Heidenreich
@Paulomart
Mar 03 2016 18:11
This message was deleted
PunKeel
@PunKeel
Mar 03 2016 18:11
Hello there, has anyone tested #83 with more than 2 players ? I suspect it to be non working
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:11
Just write a class similar to the PacketTypes and SoundEffects, wit the new and old type potions
Paul Heidenreich
@Paulomart
Mar 03 2016 18:12
It would not work even then.
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:13
So the kind of potion it is is stored in the NBT now, and not longer in the damage value right?
Paul Heidenreich
@Paulomart
Mar 03 2016 18:13
Yes, its the potion id
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:14
So what you are doing is intercepting packets sent to the server from 1.9 clients, and removing the NBT and adding the damage value
Paul Heidenreich
@Paulomart
Mar 03 2016 18:14
But even when I send always minecraft:water the client dosent render the texture
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:14
Yeah but doesn't the water also have NBT?
PunKeel
@PunKeel
Mar 03 2016 18:14
^- looks funny with witches
Paul Heidenreich
@Paulomart
Mar 03 2016 18:14
Yes
ist minecraft:water
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:15
And packets sent from the 1.9 client to the server just replace the NBT with damage values
Paul Heidenreich
@Paulomart
Mar 03 2016 18:15
in {Potion:minecraft:water}
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:15
Well not 'just', but this is how you are doing it right?
Paul Heidenreich
@Paulomart
Mar 03 2016 18:15
Trying to do first 1.8 -> 1.9 Client
This message was deleted
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:16
So does the conversion from damage value to NBT work?
Paul Heidenreich
@Paulomart
Mar 03 2016 18:16
Somehow yes
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:16
Did you submit a PR already?
Paul Heidenreich
@Paulomart
Mar 03 2016 18:17
#96, wip
Myles
@MylesIsCool
Mar 03 2016 18:17
I tried looking for the ghast bug, it is a very weird bug :(
I'm blaming herobrine
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:17
Yeah It is herobrine....
It appeared even before my sound fix
Isn't it the world_effect packet? Because that one supports ghast sounds
^ where I convert to nbt, but this not accepted by the client, at least the texture is not rendered. The type end effects of the potions are shown
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:19
Is there no NBT tag for the texture?
Maybe an undocumented one?
Paul Heidenreich
@Paulomart
Mar 03 2016 18:19
No, I took a look at the data the client is sending to server when spawning in one
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:20
Yeah but maybe they are not sending the texture tag? As it's not needed for the server?
Dunno, just speculating xd
Paul Heidenreich
@Paulomart
Mar 03 2016 18:20
Yeah that was my thought now too
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:21
Are there any 1.9 nbt viewers?
Mats
@Matsv
Mar 03 2016 18:21
NBTExplorer worked for me
This one?
Paul Heidenreich
@Paulomart
Mar 03 2016 18:21
Looking with nms now^^
Mats
@Matsv
Mar 03 2016 18:22
@HugoDaBosss Yeah
Lorenzo
@HAlexTM
Mar 03 2016 18:24
?Hey Guys, i'm making a commit for config & metrics, do you need any message string
Myles
@MylesIsCool
Mar 03 2016 18:26
I don't really want metrics
I'm sorry
There's too many issues with connection and i'd rather not overcomplicate that
Paul Heidenreich
@Paulomart
Mar 03 2016 18:28
Okey it seems that I need to set CustomPotionEffects
I dont know why
Paul Heidenreich
@Paulomart
Mar 03 2016 18:37
Ok now its not
Myles
@MylesIsCool
Mar 03 2016 18:37
Does anyone here have the bug with seeing closedconnection exception or what
Paul Heidenreich
@Paulomart
Mar 03 2016 18:44
@MylesIsCool no idea how to fix potions, I will remove it if you are ok with that?
Myles
@MylesIsCool
Mar 03 2016 18:46
For now if you want that's fine
as long as you add reflection or what
Paul Heidenreich
@Paulomart
Mar 03 2016 18:46
Yes
Myles
@MylesIsCool
Mar 03 2016 18:46
it's worth noting storing the methods and what will be an advantage
because constantly getting the methods takes time
Paul Heidenreich
@Paulomart
Mar 03 2016 18:47
So not preinitialion of the methods?
Would do that
Is there any easy replacement nbt api?
Mats
@Matsv
Mar 03 2016 18:49
Maybe OpenNBT from spacehq?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:49
Yeah it was mentioned before here
It looks nice
Paul Heidenreich
@Paulomart
Mar 03 2016 18:50
So should I reflect the nms nbt methods?
Someone worked with that before?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:50
I wouldn't recommend using reflection
Paul Heidenreich
@Paulomart
Mar 03 2016 18:50
I know
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 18:50
But a NBT api shouldn't be too hard
And this one by md_5? https://github.com/md-5/NIO-NBT
Myles
@MylesIsCool
Mar 03 2016 18:52
"Experimental" hmmhmh
It's worth noting
I'm going to change all uses of GSON
to JsonSimple
due to incompatibility with older 1.8 versions
fillefilip8
@fillefilip8
Mar 03 2016 18:54
@MylesIsCool Can you check my pull request now? :D
Paul Heidenreich
@Paulomart
Mar 03 2016 18:55
Glowstone has a nice api for that too :D
Lorenzo
@HAlexTM
Mar 03 2016 18:55
@MylesIsCool i'm sorry i was out these 10 minutes, but there is any problem: just add 2 lines for Metrics, so i've removed this
Paul Heidenreich
@Paulomart
Mar 03 2016 18:57
OpenNBT has no support for reading and writing to bytebuffers or im wrong?
Myles
@MylesIsCool
Mar 03 2016 18:58
he has his own implementation in MCProtocolLib
Lorenzo
@HAlexTM
Mar 03 2016 19:00
my config update is ready soon
fillefilip8
@fillefilip8
Mar 03 2016 19:00
@HAlexTM what config update XD
Lorenzo
@HAlexTM
Mar 03 2016 19:01
I'm introducing a config.ylm for messages and other (now just messages)
yml. * sorry
fillefilip8
@fillefilip8
Mar 03 2016 19:02
Cool @HAlexTM
I'm still waiting for @MylesIsCool to accept my pull request XD
Myles
@MylesIsCool
Mar 03 2016 19:02
maybe one year
;)
when i add debug mode ya?
;)
fillefilip8
@fillefilip8
Mar 03 2016 19:02
-.-
@MylesIsCool Please XD
@MylesIsCool Btw read private message XD
Myles
@MylesIsCool
Mar 03 2016 19:03
I will when I get round to it, I'm currently trying to fix some other issues.
Lorenzo
@HAlexTM
Mar 03 2016 19:03
XD
fillefilip8
@fillefilip8
Mar 03 2016 19:04
@MylesIsCool Anything i can do? "to help this project"
Myles
@MylesIsCool
Mar 03 2016 19:05
flip a coin? ;)
fillefilip8
@fillefilip8
Mar 03 2016 19:05
hahahhahaha
XD
@MylesIsCool hates me :(
fillefilip8
@fillefilip8
Mar 03 2016 19:12
:o hivemc uses this? :O
Myles
@MylesIsCool
Mar 03 2016 19:14
I don't think they use it yet, but yeah
fillefilip8
@fillefilip8
Mar 03 2016 19:14
They donated tho? XD
Myles
@MylesIsCool
Mar 03 2016 19:14
Yeah
fillefilip8
@fillefilip8
Mar 03 2016 19:15
:)
Should i close my old pull request?
(the one with the message when trying to enter minecarts)
Beacuse that was fixed :D
aka MylesIsCool/ViaVersion#33
Paul Heidenreich
@Paulomart
Mar 03 2016 19:18
Whats the name of the root tag?
In NBT?
Lorenzo
@HAlexTM
Mar 03 2016 19:26
@MylesIsCool i've pull requested, if you want, so.. do it! XD
asp
so, want me to add "Utils" class in the main package?
i can do it, say me
Myles
@MylesIsCool
Mar 03 2016 19:27
I don't really think Utils is needed
it just seems lazy
logger.warn("msg") works fine
fillefilip8
@fillefilip8
Mar 03 2016 19:28
^^
Lorenzo
@HAlexTM
Mar 03 2016 19:28
i had some errors, but i'll try ty
fillefilip8
@fillefilip8
Mar 03 2016 19:28
@MylesIsCool HAI
:D
Lorenzo
@HAlexTM
Mar 03 2016 19:31
System.out.println("msg"); should work
Myles
@MylesIsCool
Mar 03 2016 19:31
no
use getLogger().warn("message")
fillefilip8
@fillefilip8
Mar 03 2016 19:31
@HAlexTM that doesnt show what plugin makes it
Myles
@MylesIsCool
Mar 03 2016 19:31
in the main plugin class
fillefilip8
@fillefilip8
Mar 03 2016 19:31
@MylesIsCool wasnt the "off hand" slot disabled?
Doesnt it make u drop the item?
if you put a item in the off hand
Lorenzo
@HAlexTM
Mar 03 2016 19:31
getLogger().info what's the different between warn and info??
fillefilip8
@fillefilip8
Mar 03 2016 19:32
@HAlexTM insteed of INFO message here
Myles
@MylesIsCool
Mar 03 2016 19:32
the way they display in the console
fillefilip8
@fillefilip8
Mar 03 2016 19:32
it shows WARN message here
Lorenzo
@HAlexTM
Mar 03 2016 19:32
uhh yep ok, sorry i need to sleep
fillefilip8
@fillefilip8
Mar 03 2016 19:34
brb gonna be playing some star trek online :D
Lorenzo
@HAlexTM
Mar 03 2016 19:34
cya
Paul Heidenreich
@Paulomart
Mar 03 2016 20:15
@MylesIsCool updated pr
noo just found a bug wait
Myles
@MylesIsCool
Mar 03 2016 20:18
do potions work
Paul Heidenreich
@Paulomart
Mar 03 2016 20:18
No, currently only spawn eggs
Myles
@MylesIsCool
Mar 03 2016 20:20
can you also sync it <3?
Paul Heidenreich
@Paulomart
Mar 03 2016 20:20
Yeah, will fix the bug first, give me a few
Paul Heidenreich
@Paulomart
Mar 03 2016 20:29
no git!
gigosaurus
@gigosaurus
Mar 03 2016 20:35
could all these malformed JSON exceptions be because 1.9 is expecting strict JSON, whereas the 1.8 server will happily send off non-strict JSON (including in packets that haven't had any changes between 1.8 and 1.9)?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:35
Yeah that's the case
gigosaurus
@gigosaurus
Mar 03 2016 20:35
so every single packet which uses JSON needs to be checked
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:36
Yeah there is a fixJson packet in OutgoingTransformer
Myles
@MylesIsCool
Mar 03 2016 20:36
Yeah it is that reason
gigosaurus
@gigosaurus
Mar 03 2016 20:36
cos right now we don't check things like the player list item or chat message
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:37
Oh seriously? I though those were being checked already
gigosaurus
@gigosaurus
Mar 03 2016 20:37
nope, their packets didn't change at all so we didn't think they needed to be checked for anything
I'll go through adding all the ones which were missed because of this
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:37
Okay nice!
gigosaurus
@gigosaurus
Mar 03 2016 20:38
definitely didn't just spend the past 2 hours being like "wtf is giving off json" - checking all the stuff we modify and they appear correct, only just now realised that all packets would be affected
Z609
@Z609
Mar 03 2016 20:39
This message was deleted
MylesIsCool/ViaVersion#41 <- this
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:40
Yeah they still don't work, but do you get kicked?
Mats
@Matsv
Mar 03 2016 20:40
@Z609 Yeah, it's not fixed (yet)
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:41
Version 0.4.7?
Z609
@Z609
Mar 03 2016 20:41
Just using the latest Github
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:41
Oh whoops, nevermind, 0.4.6, sorry
Mats
@Matsv
Mar 03 2016 20:42
Wait, are entity names also json?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:42
If they have color, yes
atleast in 1.9 I think
Myles
@MylesIsCool
Mar 03 2016 20:42
boss bars are still broken
that is the error
Z609
@Z609
Mar 03 2016 20:42
I'll send you the classes that I have for boss bars.
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:42
Yeah the client gives a JSON error, but the server itself has problems writing the metadata
Maybe we can look at Spigot 1.9 and see how it sends boss bars and just use that method after getting the wither's name?
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:44
Yeah that would be possible
Does protocollib work in 1.9?
Z609
@Z609
Mar 03 2016 20:45
They do have a build for it.
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 20:45
Or can we trust the wiki.vg documentation
Mats
@Matsv
Mar 03 2016 20:45
@Z609 doesn't work on 1.9
@StamBoom What, bossbars?
Z609
@Z609
Mar 03 2016 20:47
Let me re-compile Spigot 1.9 and see if I can find anything
Myles
@MylesIsCool
Mar 03 2016 20:47
We can add a bossbar api
if we wanted
Z609
@Z609
Mar 03 2016 20:48
Or I can just use your API and just check if (isPorted())
But both would require NMS, so I don't really see the difference
Paul Heidenreich
@Paulomart
Mar 03 2016 20:48
cannot use api on 1.8?!
Z609
@Z609
Mar 03 2016 20:48
Or not NMS, but packets
@Paulomart ?
Paul Heidenreich
@Paulomart
Mar 03 2016 20:49
@Z609 BossBarAPI
Z609
@Z609
Mar 03 2016 20:49
Oh. You can, but it's not working with ViaVersion on 1.8 Spigot with 1.9 clients
Paul Heidenreich
@Paulomart
Mar 03 2016 20:50
With custom packets i guess then?
Z609
@Z609
Mar 03 2016 20:50
Yup
Myles
@MylesIsCool
Mar 03 2016 20:51
SoonTM
Paul Heidenreich
@Paulomart
Mar 03 2016 20:51
Yeah I know. I was first thinking you talked about using the api :D
Paul Heidenreich
@Paulomart
Mar 03 2016 20:57
@MylesIsCool pr is ready for merge
Myles
@MylesIsCool
Mar 03 2016 20:57
Yeah looking at it now
:)
Myles
@MylesIsCool
Mar 03 2016 21:05
i'm gonna modify it
a tiny bit
lol
Paul Heidenreich
@Paulomart
Mar 03 2016 21:05
What part?
Myles
@MylesIsCool
Mar 03 2016 21:05
the package it's in
annoys me
Paul Heidenreich
@Paulomart
Mar 03 2016 21:05
lets see
OMG wtf?!
I think i was tired yesterday..
fillefilip8
@fillefilip8
Mar 03 2016 21:17
I just saw reevemc donated...
I work for reevemc as dev xD
Myles
@MylesIsCool
Mar 03 2016 21:18
yeah he said haha
fillefilip8
@fillefilip8
Mar 03 2016 21:18
XDDD
Thanks for accepting my pull request too :)
@MylesIsCool
Myles
@MylesIsCool
Mar 03 2016 21:21
It's no problem
The reason i'm not active at the minute on git it cause i'm working with several server owners
to find some of these painful errors we can't find cause for
fillefilip8
@fillefilip8
Mar 03 2016 21:22
I understand :)
Not that easy to be famous xD haha
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 21:24
Are there any projects like this? Or are we the only one?
Well the only public one
Paul Heidenreich
@Paulomart
Mar 03 2016 21:24
I think so..
fillefilip8
@fillefilip8
Mar 03 2016 21:24
Well there is carbon, protocolsupport
but they are not close to done
this project is much better xD
gigosaurus
@gigosaurus
Mar 03 2016 21:32
I wasn't getting any more MalformedJsonExceptions after using my PR woooo
Hugo Kerstens
@HugoDaBosss
Mar 03 2016 21:32
Nice job :D
fillefilip8
@fillefilip8
Mar 03 2016 21:33
Going to sleep. Its late for me haha
Bye guys :D
Myles
@MylesIsCool
Mar 03 2016 21:33
Not sure if you saw me post about that earlier, but good job on implementing @gigosaurus
gigosaurus
@gigosaurus
Mar 03 2016 21:34
what'd you post about it earlier?
Myles
@MylesIsCool
Mar 03 2016 21:36
i said that, that was the only packet not done :P
gj on doing it much love <3
gigosaurus
@gigosaurus
Mar 03 2016 21:37
oh right :P I only found out it wasn't done by listening for packets and waiting for the one which would kick my client for MalformedJsonException
Paul Heidenreich
@Paulomart
Mar 03 2016 21:37
@MylesIsCool I send you a private message
Myles
@MylesIsCool
Mar 03 2016 21:38
I'm most likely gonna add a command like, /viaversion allowblaming
then when someone disconnects
it prints out the possible blame for the disconnect packet wise
last like 4 packets
Paul Heidenreich
@Paulomart
Mar 03 2016 21:41
Yeah do that
gigosaurus
@gigosaurus
Mar 03 2016 21:42
I don't think that's worth doing - when I was trying to find out the cause of the MalformedJsonException, the tab packet causing it wasn't in the last 4 packets sent
There were another 700 packets sent to my client before I got disconnected
Most of them were chunk data
Unless the server is localhost there's going to be that latency delay
Paul Heidenreich
@Paulomart
Mar 03 2016 21:44
Maybe filter out chunk data?
Im heading out. see you guys
gigosaurus
@gigosaurus
Mar 03 2016 21:48
131 of those 700 packets aren't the chunk data packet
46 of them are Update Block Entity
57 of them are Set Slot
the rest are other misc packets such as Title, Update Sign, and all the packets sent on a world load/change
Although I suppose if a 1.9 player isn't logging in or respawning or changing worlds at the same time then it could pick up something useful
Myles
@MylesIsCool
Mar 03 2016 22:06
Gonna release 0.4.7
Myles
@MylesIsCool
Mar 03 2016 22:23
Great work @gigosaurus @Paulomart @fillefilip8 @StamBoom <3
Zaino60
@Zaino60
Mar 03 2016 22:37
Hi guys, awesome plugin, thank you very much for creating it!
However, I have found some bugs during my tests with 1.9
  • Alll Written Books are not working (You can't open them if you are in 1.9)
  • I asked many ppl to test this and I can confirm it isn't my problem specifically: I detected that the chunk loading of 1.9 clients in a 1.8 server using viaversion is really fuzzy and most of the chunks don't load unless you interact with them (Break/Place a block), which can turn really annoying most of the times.
  • Potions are seen as "Missing Texture" because the items IDs changed, similarly to what happened with the spawn eggs that you fixed :D
Hope that helps, thanks again for the awesome plugin :D
Mats
@Matsv
Mar 03 2016 22:41
All issues are known
But thanks for reporting :)
I'll take a look at books tomorrow
Zaino60
@Zaino60
Mar 03 2016 22:41
oh, good to hear :)
thanks
Myles
@MylesIsCool
Mar 03 2016 22:45
who implemented sounds again
need to stab
:)
(well the block break "fix")
use throw new CancelException(); to cancel packet sending <3 <3 finally solved a bug after spending 4 hrs looking for it
gigosaurus
@gigosaurus
Mar 03 2016 22:48
So anyone have any idea on issue #38 yet?
it's weird because the client is fully aware of the blocks that it isn't rendering - you can climb up invisible ladders and everything
Myles
@MylesIsCool
Mar 03 2016 22:50
magic
Mats
@Matsv
Mar 03 2016 22:50
Not sure, but maybe packet Map Chunk Bulk? It's gone in 1.9 but 1.8 still sends it
Wiki.vg: "Map Chunk Bulk
Replaced
Myles
@MylesIsCool
Mar 03 2016 22:51
We do fix that
it's a main packet
it's handled by
ViaEncodeHandler
Mats
@Matsv
Mar 03 2016 22:51
Ohh
Myles
@MylesIsCool
Mar 03 2016 22:51
if you want to read how it works
gigosaurus
@gigosaurus
Mar 03 2016 22:52
what is that int which we just set to 65535?
Myles
@MylesIsCool
Mar 03 2016 22:52
well
i'm not sure
nobody has docs on it
but in vanilla code
i saw it as that
it might be that
if anyone finds what it is, gold medal ahah
might be worth looking in MCP for it
it might be the bitmask for the chunk to use
an extract:
ChunkMap chunkmap = PacketPlayOutMapChunk.a(chunk, true, '\uffff');
Myles
@MylesIsCool
Mar 03 2016 22:58
Which is same as 65535 so i'd assume that's fine