These are chat archives for MylesIsCool/ViaVersion

4th
Mar 2016
Z609
@Z609
Mar 04 2016 00:26
I'm going to try and see what's wrong with AAC and the PLAYER errors. Don't know really. It's probably something with this https://github.com/aadnk/PacketWrapper/blob/master/PacketWrapper/src/main/java/com/comphenix/packetwrapper/WrapperPlayServerNamedEntitySpawn.java
It might have to do with armor as AAC uses armor. I'll get back to you on this.
Z609
@Z609
Mar 04 2016 00:36
Yup! :) Fixed with this config in forcefield: http://pastebin.com/8PSYn7ZU
I still get this error though yet I'm not crashing, I'll try getting to the bottom of this: http://pastebin.com/8wfyFYuG
Myles
@MylesIsCool
Mar 04 2016 01:01
So tired :(, finished potions not gonna commit incase i did any stupid bugs cause tired
(well not gonna push to next version)
Z609
@Z609
Mar 04 2016 01:04
get some rest
Jumla
@Jumla
Mar 04 2016 01:40
Is books not working a known issue?
Myles
@MylesIsCool
Mar 04 2016 07:45
@Jumla Yeah, it's todo with how PluginMessage has changed, hopefully will be fixed soon
fillefilip8
@fillefilip8
Mar 04 2016 08:31
Hey @MylesIsCool :)
Myles
@MylesIsCool
Mar 04 2016 08:41
Howdy @fillefilip8 :)
fillefilip8
@fillefilip8
Mar 04 2016 08:41
Just woke up :D
Myles
@MylesIsCool
Mar 04 2016 08:41
PS: Version got bumped to 0.4.9 and released (Adding potions / fixing some json issues)
Myles
@MylesIsCool
Mar 04 2016 10:05
Fixed books, (on github)
Myles
@MylesIsCool
Mar 04 2016 12:03
@gigosaurus Does the chunk issue still happen with latest git?
Hugo Kerstens
@hugokerstens
Mar 04 2016 12:04
Hi guys! I'm back
Myles
@MylesIsCool
Mar 04 2016 12:04
Hey Hugo :)
Mats
@Matsv
Mar 04 2016 12:04
Hey
Hugo Kerstens
@hugokerstens
Mar 04 2016 12:05
So what are we working on right now?
gigosaurus
@gigosaurus
Mar 04 2016 12:08
@MylesIsCool I'm unable to test right now but I don't think that would change anything - I don't think the server would ever send off a chunk data packet with no chunk data (bitmask == 0) unless it was intending to unload the chunk, in which case it would make groundUp = true
Myles
@MylesIsCool
Mar 04 2016 12:09
@gigosaurus So there's no case that bitmask would be 0 and cause the issues we're seeing?
Maybe the issue is to do with BulkChunks on the edge of void causing it to detect as unload :S
gigosaurus
@gigosaurus
Mar 04 2016 12:11
Don't think so, although I can't say for certain as I can't remember if I explicitly tested for that
Ooohhhh that could be it
I don't think it is but it could be
Myles
@MylesIsCool
Mar 04 2016 12:12
The good news is we're getting less bug reports so we're becoming stable woo +1
gigosaurus
@gigosaurus
Mar 04 2016 12:14
I'm going to sleep because it's 12:14pm and I haven't gone to bed yet :p
Myles
@MylesIsCool
Mar 04 2016 12:15
Have a good night thanks for all your effort <3 it's appreciated @gigosaurus
fillefilip8
@fillefilip8
Mar 04 2016 12:16
Hey! XD
Fille is back :D
Mats
@Matsv
Mar 04 2016 12:16
Hi
fillefilip8
@fillefilip8
Mar 04 2016 12:16
hi @StamBoom XD
Mats
@Matsv
Mar 04 2016 12:18
@MylesIsCool BKCommonLib works for me
Myles
@MylesIsCool
Mar 04 2016 12:18
Someone told me it didn't work? :(
Mats
@Matsv
Mar 04 2016 12:18
0 errors
Myles
@MylesIsCool
Mar 04 2016 12:18
Are you using any plugins that use it haha
Mats
@Matsv
Mar 04 2016 12:18
With and without protocollib
Yeah traincarts
And signlink
Sounds are different but it's working
Myles
@MylesIsCool
Mar 04 2016 12:20
Oh the other thing which would be cool to find the source is the ghast sound as we know it's caused by bat spawning
as it happens with their spawn eggs
@StamBoom I'll put that issue off then :)
Mats
@Matsv
Mar 04 2016 12:20
Yeah someone said it was the bat spawnegg
But idk I tried it
Myles
@MylesIsCool
Mar 04 2016 12:21
There's like no packets related to it, which is what's weird
maybe the sound is in like metadata or something
Mats
@Matsv
Mar 04 2016 12:21
Yeah maybe
Could possibly be client-sided
Myles
@MylesIsCool
Mar 04 2016 12:23
Well how does it get caused? o.0 cause i'm pretty sure it's not a 1.9 bug
fillefilip8
@fillefilip8
Mar 04 2016 12:24
mojang magic...
Mats
@Matsv
Mar 04 2016 13:13
I don't understand why commandblocks won't open. I added new NBT tags, tried to add op permission level (http://wiki.vg/Pre-release_protocol#Entity_Status) but it does still not work. Does anyone have some idea what it could possible be?
Myles
@MylesIsCool
Mar 04 2016 13:20
it's done via pluginmessages like books
Mats
@Matsv
Mar 04 2016 13:24
Yeah I tried that. But it's not sending any plugin message packet
Myles
@MylesIsCool
Mar 04 2016 13:48
is it not the server that sends it?
Mats
@Matsv
Mar 04 2016 13:49
@MylesIsCool Nope opening command blocks is client-sided
Hugo Kerstens
@hugokerstens
Mar 04 2016 13:57
Didn't the block NBT data change? So it's invalid when you try to open it in 1.9?
Mats
@Matsv
Mar 04 2016 13:58
Yes It did, I changed it in packet update block entity
looked exactly the same
As 1.9
But 1.9 did work but 1.8 not
Hugo Kerstens
@hugokerstens
Mar 04 2016 13:58
Hmm that's strange
Mats
@Matsv
Mar 04 2016 13:58
I mean in 1.9 server
I'll take another look at it when I'm back home
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:03
I'm figuring out why ender pearls arent working right now
Mats
@Matsv
Mar 04 2016 14:04
Enderpearls never worked in creative 1.8
however it works in 1.9
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:04
Oh are you serious? x.x Didn't know that
Mats
@Matsv
Mar 04 2016 14:04
but it's probably at spigots end
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:04
Yeah in spigot 1.9 they are working again
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:31
Okay I found the issue with the armor points, in 1.9 there is a new Attribute called armor, which need to be sent by the server.
I'm going to fix this
Mats
@Matsv
Mar 04 2016 14:34
:+1:
Does the NBT tag order matter?
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:46
Guess not, not sure though
Mats
@Matsv
Mar 04 2016 14:47
I'm still thinking that it has something to do with OP permission levels. You can't open commandblocks in singleplayer if allow_cheats is off
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:49
Yeah there is a new thing in the world state packet, with the op permission level
But you already did that right?
I did that one
Is there another one?
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:49
Oh yes sorry I ment that one
Let me check for another one
Mats
@Matsv
Mar 04 2016 14:49
Could'nt find any
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:50
Hmm me neither
The incoming and outgoing transformers are per client right?
Mats
@Matsv
Mar 04 2016 14:51
Yes
Hugo Kerstens
@hugokerstens
Mar 04 2016 14:56
What's the correct way of sending an extra packet from the outgoingtransformer?
ByteBuf buf = info.getChannel().alloc().buffer();
//Do stuff
info.getChannel().writeAndFlush(buf);
Like that?
Mats
@Matsv
Mar 04 2016 15:03
Not sure if that's the best way but I use it like that
Hugo Kerstens
@hugokerstens
Mar 04 2016 15:09
And how do I get the entity id of the player? What packet is sent to identify the spawn location?
Nevermind xd
Hugo Kerstens
@hugokerstens
Mar 04 2016 15:34
Does anyone have any idea why this doesn't work? HugoDaBosss/ViaVersion@7b3b77c
The armor points and the entity id are correct, but the ENTITY_PROPERTIES packet isn't sent, or is wrong
Oh and @StamBoom , it may be obvious, but did you enable command blocks for your test server in server.properties?
Mats
@Matsv
Mar 04 2016 15:38
@HugoDaBosss Yeah I did haha
Didn't know generic.armor was a thing
fillefilip8
@fillefilip8
Mar 04 2016 15:41
@MylesIsCool
Mats
@Matsv
Mar 04 2016 15:57
@HugoDaBosss Aren't 100/103 armor slots?
Hugo Kerstens
@hugokerstens
Mar 04 2016 15:59
No the detection works fine
Even the calculation of the amor points
Mats
@Matsv
Mar 04 2016 15:59
Does the packet send?
Hugo Kerstens
@hugokerstens
Mar 04 2016 15:59
Don't know, how would I check?
But I think the packet was wrong, because I think you need to use a basevalue of 0, and then modifiers like ADD_NUMBER <armorpoints>
I fixed that, but somehow I broke something else that now the PLAY_SET_SLOT packets aren't recognized anymore by ViaVersion x.x
So I can't test it
Mats
@Matsv
Mar 04 2016 16:01
Can you push it to GitHub?
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:03
HugoDaBosss/ViaVersion@e3adb12
Here you go @StamBoom
fillefilip8
@fillefilip8
Mar 04 2016 16:04
Did someone add a nms itemstack (nbt data) util?
Mats
@Matsv
Mar 04 2016 16:04
Yes
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:04
Not yet, Stamboom suggested using SpaceHQ's one
Oh you added it already
Nice :D
fillefilip8
@fillefilip8
Mar 04 2016 16:04
Good
now i can see if my code works
Mats
@Matsv
Mar 04 2016 16:05
PacketUtil.readNBT if you only want NBT or ItemSlotRewriter.readItemStack
@fillefilip8
fillefilip8
@fillefilip8
Mar 04 2016 16:06
@StamBoom I want to write NBT
:D
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:06
PacketUtil.writeNBT?
Mats
@Matsv
Mar 04 2016 16:06
writeNBT, writeItemStack
@HugoDaBosss But how did you break it haha
@HugoDaBosss nothing changed
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:06
Yeah I don't know
But first when I complied it it showed up as ViaVersion-1.0-SNAPSHOT.jar
But after those changes it was ViaVersion-0.4.9.jar
Mats
@Matsv
Mar 04 2016 16:07
Yeah probably because you updated your branch
fillefilip8
@fillefilip8
Mar 04 2016 16:08
@HugoDaBosss Beacuse i fixed that
@HugoDaBosss i added so i renames the jar XD
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:08
Yeah that's a nice addon :D
fillefilip8
@fillefilip8
Mar 04 2016 16:08
Yeah ik :D
Beacuse i saw Myles changing like 4 files to update the version number XD
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:09
Yeah I know that it is because of pom.xml, but somehow it didn't update first
But can you try to compile my version @StamBoom or @fillefilip8 ?
Mats
@Matsv
Mar 04 2016 16:09
sure one sec
fillefilip8
@fillefilip8
Mar 04 2016 16:10
I think i need to refetch the source
beacuse i can see any nbt stuff XD
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:10
Yeah you should always rebase with the original one before adding anything new xd
fillefilip8
@fillefilip8
Mar 04 2016 16:11
git really hates me sometimes
Mats
@Matsv
Mar 04 2016 16:13
Invalid session please restart your game
1 sec
haha
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:13
Fucking mojang xd
Mats
@Matsv
Mar 04 2016 16:15
Still invalid session. Maybe session servers offline? ;L let me check
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:16
nope
You also need to restart your launcher, and make sure to first close any other open launchers xd
Mats
@Matsv
Mar 04 2016 16:16
Yeah I had 1.8 open
Works now
Same problem it's not detecting it
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:17
Isn't system.out broken for some reason?
fillefilip8
@fillefilip8
Mar 04 2016 16:17
What?
Mats
@Matsv
Mar 04 2016 16:18
Nope I use it every test
Works for me
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:18
Yeah for me as well
Mats
@Matsv
Mar 04 2016 16:18
What packet are you intercepting?
Oh set_slot
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:19
By the way, how come we can use the Bukkit API while working async in netty? Because normally when you try to acces the Bukkit API in an async runnable it will throw a NPE
Yeah let me double check the Id's for set_slot
Myles
@MylesIsCool
Mar 04 2016 16:19
we don't Hugo
where are we using it async to bukkit?
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:20
Is all this netty network stuff on the same thread as bukkit? Wow
Myles
@MylesIsCool
Mar 04 2016 16:20
no
we never use any main bukkit functions that interrupt with main thread?
all calls are done via blocking
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:21
Ahh okay, thanks for the explanation ;)
Mats
@Matsv
Mar 04 2016 16:21
@HugoDaBosss There is already another SET_SLOT above your if
It's probably not getting to yours
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:21
Wow seriously 0.0
Myles
@MylesIsCool
Mar 04 2016 16:22
We only use main thread functions a few times the function to do it is in the main ViaVersion
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:22
Yeah the above one probably has return;
Myles
@MylesIsCool
Mar 04 2016 16:22
I end up developing in offline mode cause the mojang servers are so dodgy
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:22
Yeah but then the packets won't be encrypted? Or am I wrong
So that would be a big change in the networking
Although the netty stuff already works fine now ;)
Thanks btw @StamBoom , wouldn't have found it myself xd
Probably mistyped set_slot when searching
Myles
@MylesIsCool
Mar 04 2016 16:25
I'm confused, what's up?
Mats
@Matsv
Mar 04 2016 16:25
@HugoDaBosss Thanks Intellij i guess? :smile: https://gyazo.com/877e84672d086e50cfc1022228627e8f
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:26
Oh I accidentally added the packet == PacketType.xxx twice for the same packet, hence it was not working
@MylesIsCool is this the correct way of sending another packet from the OutgoingTransformer?
ByteBuf buf = info.getChannel().alloc().buffer();
//Do stuff
info.getChannel().writeAndFlush(buf);
Myles
@MylesIsCool
Mar 04 2016 16:30
it's one way of doing it
should work perfectly fine
hugo
i see your error
you ready for me to correct you
@HugoDaBosss
writeVarInt(PacketType.PLAY_ENTITY_PROPERTIES.getPacketID(), buf);
use getNewPacketID I think it is
you're sending old packet meaning it gets lost :(
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:34
Oh wow :D
Thank you soo much :D @MylesIsCool
Let me test it
Still doesn't work D:
Myles
@MylesIsCool
Mar 04 2016 16:38
does the client get kicked
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:39
Nope, just nothing
Let me double check everything again
Myles
@MylesIsCool
Mar 04 2016 16:39
it definitely sends the packet yes?
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:40
I don't know, how do I check that?
This is the corresponding code in minecraft 1.9: http://pastebin.com/FusCkHdq
Myles
@MylesIsCool
Mar 04 2016 16:42
why are you using some writeString
???
oh
did you static import packetutil?
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:42
No just to clarify
Myles
@MylesIsCool
Mar 04 2016 16:42
:?
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:42
Yeah, well I didn't
But it is imported :P
Myles
@MylesIsCool
Mar 04 2016 16:42
what is writeString(xyz)
when your done remember to remove
"import static us.myles.ViaVersion.util.PacketUtil.*;"
cause I prefer not having static imports ;)
oh
ik why your code is broke
you need to move it
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:44
yeah? :D
Myles
@MylesIsCool
Mar 04 2016 16:44
above the PLAY_SET_SLOT?
did you fix that
it needs to be above line 514
*415
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:44
Yeah, I'll push the new version to github
HugoDaBosss/ViaVersion@28dd2b6
This is the only reference I have for the bytes used for different operations: http://minecraft.gamepedia.com/Attribute#Operations
Don't know if it's correct
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:49
All the changes I made, fixed the typo for the operation btw: https://github.com/MylesIsCool/ViaVersion/compare/master...HugoDaBosss:master_patch
Myles
@MylesIsCool
Mar 04 2016 16:51
so what happens in the version you say you got sorta working
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:51
It calculates the desired armor points
That's all xd
Myles
@MylesIsCool
Mar 04 2016 16:52
I think you're doing it wrong
I think what you need to do
is attach NBT data to items in the item rewriter
if it's armour
I don't think the modifier works as an entity modifier
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:53
Oh wow, let me check the protocollib for 1.9 again
Myles
@MylesIsCool
Mar 04 2016 16:54
Well my theory is
it does work
it just doesn't display maybe?
ItemArmor.java might help you
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:56
http://pastebin.com/GkvVYQD1 This is what the 1.9 server sends
Myles
@MylesIsCool
Mar 04 2016 16:56
might be the op you're trying to use then is wrong
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:57
But the packet is for an entity, because it includes an entityid
Myles
@MylesIsCool
Mar 04 2016 16:57
wait
your sending packets wrong
I think
try using info.getChannel().pipeline().writeAndFlush instead
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:58
Checking now :D
Myles
@MylesIsCool
Mar 04 2016 16:58
It's what I use in Incoming
" info.getChannel().pipeline().writeAndFlush(setSlotPacket); // slot is empty"
because doing writeAndFlush pretty sure avoids all the encoders maybe
I gotta brb, be back soon getting food
Hugo Kerstens
@hugokerstens
Mar 04 2016 16:59
Still not working
What I'm going to try now is a different modifier for each armor piece
Not just one for all the armor
Myles
@MylesIsCool
Mar 04 2016 16:59
The best idea would be just to use the packet constructor and reflection
hah
if you're still having issues when I come back i'll look into it
Hugo Kerstens
@hugokerstens
Mar 04 2016 17:00
Oh nvm, that idea wouldn't work as well, because you have the same situation now with 1 armor piece
Yeah, bon apetit :D
I'm going to get some food as well
Need to work tonight, don't know if I'll be back before work
fillefilip8
@fillefilip8
Mar 04 2016 17:04
Gonna go and buy some stuff from the store brb
:D
Myles
@MylesIsCool
Mar 04 2016 17:33
I have returned
let's look at this thing Hugo's working on
Hugo Kerstens
@hugokerstens
Mar 04 2016 17:57
I think you are unable to use reflection here
because the generic.armor attribute is not present in 1.8
Myles
@MylesIsCool
Mar 04 2016 18:00
I fixed your code
There was an issue with UUID and packet sending
Hugo Kerstens
@hugokerstens
Mar 04 2016 18:04
Wow seriously?
Is it working now?
Myles
@MylesIsCool
Mar 04 2016 18:04
well
I need to fix it a bit
because it doesn't work with shift clicking
Hugo Kerstens
@hugokerstens
Mar 04 2016 18:04
Yeah I noticed that
Myles
@MylesIsCool
Mar 04 2016 18:04
and i'd rather not have 10 billion issue reports of that haha
Hugo Kerstens
@hugokerstens
Mar 04 2016 18:04
You could just use bukkit events?
Or the transaction packet?
Dont know what it is called exactly
But I'm off to work, will be back in around 3 hours
Myles
@MylesIsCool
Mar 04 2016 18:05
Okay cool :) thanks for work towards this :D
Myles
@MylesIsCool
Mar 04 2016 18:12
brb fire alarm
fillefilip8
@fillefilip8
Mar 04 2016 18:58
rip
Mats
@Matsv
Mar 04 2016 19:07
StamBoom/ViaVersion@811b7a1 anyone know why commandblocks does still not work even after changing op permission level & by adding NBT?
Myles
@MylesIsCool
Mar 04 2016 19:07
cause of plugin messages as said before
Mats
@Matsv
Mar 04 2016 19:07
It's client-sided
Opening commandblocks
Doesn't send plugin messages
Myles
@MylesIsCool
Mar 04 2016 19:08
there are plugin messages
for it
look in playerconnection
Mats
@Matsv
Mar 04 2016 19:09
Yeah to change commands
But not to open an command block
Mats
@Matsv
Mar 04 2016 19:14
The problem has probably something to do with op permission levels. In 1.9 you can no longer open an commandblock (in singleplayer) when allow_cheats is off
Myles
@MylesIsCool
Mar 04 2016 19:18
How are you tell the client they are op or what?
the packet sending your using doesnt work
Myles
@MylesIsCool
Mar 04 2016 19:19
info.getChannel().pipeline().writeAndFlush(buf); doesnt work sadly
Mats
@Matsv
Mar 04 2016 19:19
Oh
Myles
@MylesIsCool
Mar 04 2016 19:24
If you git sync or what i've added an api for it
info.sendRawPacket(packet)
Mats
@Matsv
Mar 04 2016 19:26
Oh nice thanks
Mats
@Matsv
Mar 04 2016 19:36
Unfortunately, it didn't fix the commandblock problem
Mats
@Matsv
Mar 04 2016 19:59
it's opening now :smile:
Myles
@MylesIsCool
Mar 04 2016 20:04
Committed armor, based on @HugoDaBosss code but modified to work with shift :)
Mats
@Matsv
Mar 04 2016 20:05
Nice :D
Myles
@MylesIsCool
Mar 04 2016 20:07
When you finish command blocks we'll push version 0.5 maybe
Mats
@Matsv
Mar 04 2016 20:14
Not sure if I'll finish this today. I'm pretty tired. Probably make a lot of bugs
Myles
@MylesIsCool
Mar 04 2016 20:15
It's cool whenever man, I just like pushing feature full updates :)
Myles
@MylesIsCool
Mar 04 2016 21:08
Might have a fix for chunk issues :O
Mats
@Matsv
Mar 04 2016 21:08
Nice what was the problem?
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:08
Nice job!
Im back btw
Myles
@MylesIsCool
Mar 04 2016 21:08
Well it's a might have a fix, I'm getting my friend to verify if it works
He owns a skyblock server
Mats
@Matsv
Mar 04 2016 21:08
Hey @HugoDaBosss
Myles
@MylesIsCool
Mar 04 2016 21:08
Hugo I committed armour stuff if you saw
Okay
So I've got confirmation this fixes it from my friend
lol
I just removed 1.9 unloading
Mats
@Matsv
Mar 04 2016 21:12
Will that cause any issues? Lag for the client?
Myles
@MylesIsCool
Mar 04 2016 21:12
Well 1.8 chunk loading unloading just sets chunks to nothing
which is what this would be
I guess just a tiny bit more memory really
256 bytes per chunk
Mats
@Matsv
Mar 04 2016 21:13
Well, that's acceptable if it fixes it
Myles
@MylesIsCool
Mar 04 2016 21:13
Well it might even be less than that to be honest, i'm not sure on the direct implementation in 1.9
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:15
What was the problem with my code? The way the packet was sent?
Myles
@MylesIsCool
Mar 04 2016 21:16
Yeah, I mean it's todo with pipline
*pipeline
Gonna commit current version
I feel like chunks is quite important
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:21
I never experienced it myself, but there were indeed a lot of people complaining
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:26
Hahaha nice work on the armor @MylesIsCool ,
I see my calculateAmorPoints method with the ItemStack[] actually came to use ;)
I was planning first to use bukkit, but thought it could also be done just with packets
But unfortunately the shift click wasn't working
Myles
@MylesIsCool
Mar 04 2016 21:29
It could be done but it'd require inventory tracking I think to get the item
which really isn't worth it
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:30
Yeah then using bukkit events just works fine.
It's so annoying that they changed between 1.8 and 1.9 which sounds are clientside and which ones are serverside x.x
Myles
@MylesIsCool
Mar 04 2016 21:36
0.5.0 is now avaliable - https://www.spigotmc.org/resources/viaversion.19254/ - Thanks @HugoDaBosss for armour work :)
fillefilip8
@fillefilip8
Mar 04 2016 21:38
XDD
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:41
Nice!
I still hate git btw :D Or git hates me actually
Myles
@MylesIsCool
Mar 04 2016 21:44
I use sourcegit as a client
it sucks cause it doesn't handle pull requests very well
I used to use another client, can't remember the name
I used SmartGit then moved to SourceTree
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:46
Yeah as soon as i use the git bash everything is fine, but somehow eclipse git doesn't stash correctly
Myles
@MylesIsCool
Mar 04 2016 21:46
Oh don't use in-built IDE git lol
it's much more satisfying with a proper client
in source git you just hit like Menu -> Stash
enter a name etc
i mean source tree
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:47
Ehh myles? MylesIsCool/ViaVersion#120 @MylesIsCool
Lukas
@LukvonStrom
Mar 04 2016 21:51
Noticed that Problem too. Console is totally spammed.
Myles
@MylesIsCool
Mar 04 2016 21:52
Yeah I deployed a debug version by accident
slipped :P
Hugo Kerstens
@hugokerstens
Mar 04 2016 21:54
Hahaha happens to the best of us ;)
Lukas
@LukvonStrom
Mar 04 2016 21:59
Thanks for the fast fix :)
Myles
@MylesIsCool
Mar 04 2016 22:01
Well i'm fast fixer if i realise i'm an idiot haha
fillefilip8
@fillefilip8
Mar 04 2016 22:01
Loool
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:03
Does anyone have any ideas on how to fix MylesIsCool/ViaVersion#114 (Glass pane hitbox)
Wow the donations are going crazy :D
fillefilip8
@fillefilip8
Mar 04 2016 22:09
Myles. Yeah ik the reeve people are good xD
lols
Myles
@MylesIsCool
Mar 04 2016 22:15
Hugo: Not fixable tbh
Well we could fix
use reflection
change hitbox of pane
to nothing
would work
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:15
Yeah but that would break a lot of things
Myles
@MylesIsCool
Mar 04 2016 22:15
like what?
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:15
You would be able to shoot arrows through glass panes xd
And other projectiles
Myles
@MylesIsCool
Mar 04 2016 22:16
Make it so hitbox is nothing when no adjacent blocks ya ;)?
fillefilip8
@fillefilip8
Mar 04 2016 22:16
Wallhack xD
Myles
@MylesIsCool
Mar 04 2016 22:16
There's no real fix otherwise
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:16
It is fixable, but I think not worth the hassle
Myles
@MylesIsCool
Mar 04 2016 22:17
there are more important issues
like the ghast herobrine bug
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:17
Yeah im looking at that now
fillefilip8
@fillefilip8
Mar 04 2016 22:17
herobrine?
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:17
It seems the EFFECT packet causes that
Yeah we blamed herobrine for that bug ;)
fillefilip8
@fillefilip8
Mar 04 2016 22:17
:worried:
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:17
I'm working on it
Beating herobrine :D
Myles
@MylesIsCool
Mar 04 2016 22:17
when we fix it
i'm gonna put as the changelog
haha
removed herobrine
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:18
Removed herorbine?
Yeahhhh
Same thought xd
fillefilip8
@fillefilip8
Mar 04 2016 22:18
lol
Mojang doesnt know how to remove herobrine
but myles do....
and @HugoDaBosss
Myles
@MylesIsCool
Mar 04 2016 22:18
I don't hugo possibly does haha
fillefilip8
@fillefilip8
Mar 04 2016 22:19
Im going to sleep now
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:19
Actually AlexNova1555 found the issue
fillefilip8
@fillefilip8
Mar 04 2016 22:19
its 23.15
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:19
And PunKeel connected it to the EFFECT packet
fillefilip8
@fillefilip8
Mar 04 2016 22:19
See you guys laterrr
Mats
@Matsv
Mar 04 2016 22:19
Cya
fillefilip8
@fillefilip8
Mar 04 2016 22:19
Bye
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:20
Bye
Myles
@MylesIsCool
Mar 04 2016 22:31
Cheers for flint steel fix @HugoDaBosss <3
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:34
It was an easy fix ;) We just need to find other sounds which are also clientsided now, and add the shouldIgnore = true
Wow random error: http://prntscr.com/abaj8m
No errors in console at all
And again... It appears when I'm spawning a lot of bats xd
Phineas
@Phineas
Mar 04 2016 22:38
o;
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:38
Appears when spawning a lot of other mobs as well
(With the exact same numbers)
HEROBRINE HAS BEEN REMOVED FROM THE GAME! :D #10 is fixed
Myles
@MylesIsCool
Mar 04 2016 22:44
Quick question
I want to add debug mode
do I add it per player
to for whole server
so you do like /viaver debug
and it turns on
do you need to sync
"This branch has conflicts that must be resolved
Use the command line to resolve conflicts before continuing."
ugh
Mats
@Matsv
Mar 04 2016 22:45
Yay git <3
Chat is a sync right?
dont think you'll need it
Myles
@MylesIsCool
Mar 04 2016 22:46
I want to add debug mode
so in console
it can print packets
Mats
@Matsv
Mar 04 2016 22:46
oh
not sure about that
Myles
@MylesIsCool
Mar 04 2016 22:47
just makes it easier so you guy
hey jim
type /viaver debug
create error
paste log
or what
Hugo Kerstens
@hugokerstens
Mar 04 2016 22:49
You should probably add it for the whole server
And that you need to enable it, and on restart it automatically disables
I'll just create a new branch and add it again xd 2 sec
Myles
@MylesIsCool
Mar 04 2016 23:02
hugo hurry up or you'll be out of date when i add debug mode xD
i'll wait until you pull until i add it
just to be nice
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:02
Took some time, but here it is: MylesIsCool/ViaVersion#126
Thanks ;)
By the way, don't we have resource leaks when we throw a new CancelException while there is still data to read in the input ByteBuf?
Or does netty take care of that
Myles
@MylesIsCool
Mar 04 2016 23:06
if you look in code
} catch (CancelException e) {
bytebuf.readBytes(bytebuf.readableBytes());
throw e;
} finally {
oldPacket.release();
}
we handle it
netty does resource handle some things
we just have to release unused copies
:)
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:08
Ahh nice! :D
It's so annoying people name errors: Login Error, Error in console, console spam
Like we can quickly identify what the error is about then x.x
Myles
@MylesIsCool
Mar 04 2016 23:10
I rename them most of time
to be more relevant
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:10
Can't you give us permission to rename issues and such?
Myles
@MylesIsCool
Mar 04 2016 23:11
I'll give it to you as long as you promise to be ya know responsible, (which i'm sure you will be) and don't like misclose issues haha
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:12
Yeah accidentally close issues would be quite difficult actually :P
And ofcourse, I promise to be responsible
Myles
@MylesIsCool
Mar 04 2016 23:15
Oh and don't merge any PRs without getting them checked cause otherwise we'll run into stupid issues
:)
(cause let's face it all of us have our bad moments)
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:17
Yeah i'll let you merge the PR's
That will keep things more organized ;)
Yeah for example pushing a debug version... uhum
Myles
@MylesIsCool
Mar 04 2016 23:18
I mean
I just comment in and comment out the debug stuff
haha
there's no like debug arg
but now we have /viaver debug
I might make it so you could also maybe use
like
java -jar spigot.jar -debug
and it'd also work
perhaps
Mats
@Matsv
Mar 04 2016 23:24
I'm going to sleep, see you guys later
Myles
@MylesIsCool
Mar 04 2016 23:24
See you StamBoom have a lovely night :)
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:25
Good night @StamBoom !
Yeah you can check if the minecraft server is in debug mode, I saw it begin used by another plugin.
So you should enable the log if /viaver debug of the minecraft server is in debug mode
http://wiki.vg/Protocol#Update_Block_Entity "1: set spawn potentials of a mob spawner"
Nice documentation x.x
Myles
@MylesIsCool
Mar 04 2016 23:28
I use debug mode
it's quite useful for some things
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:30
Mob spawner NBT: EntityId (deprecated in 1.9), I'll look int oit
Myles
@MylesIsCool
Mar 04 2016 23:32
It's worth noting I won't be around tomorrow until late (this time ish) as i'm out. So you're in charge @HugoDaBosss haha
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:34
Yeah I won't be available as well until around 4/5pm GMT +1, so yeah...
But in the evening I'll keep an eye out :D
By the way, did we have a general NBT library implemented? Or do we still need one
Myles
@MylesIsCool
Mar 04 2016 23:36
OpenNBT works
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:38
Oh wow, overlooked it while looking through the dependencies xd
Myles
@MylesIsCool
Mar 04 2016 23:38
It's a small library but it makes NBT look amazing
Going to work with one of these guys with bungee issues
see if I can grab it
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:46
Yeah nice
How do I convert a bytebuf to a datainputstream?
Nvm, I got it
Myles
@MylesIsCool
Mar 04 2016 23:48
so been talking
and like
people using bungeepackets
bungeepackets is so ugh
it doesn't work
Hugo Kerstens
@hugokerstens
Mar 04 2016 23:50
Yeah packets from bungee -> client won't work at all, because the server with ViaVersion won't ever interact with them.