These are chat archives for MylesIsCool/ViaVersion

8th
Mar 2016
Myles
@MylesIsCool
Mar 08 2016 00:00
Version 0.5.8 is now out https://www.spigotmc.org/resources/viaversion.19254/ thanks to everyone involved, @rj0495 @Matsv
Ryan James
@rj0495
Mar 08 2016 00:00
Np
Mats
@Matsv
Mar 08 2016 00:01
Woah 100 reviews @MylesIsCool
Z609
@Z609
Mar 08 2016 00:02
It was working fine with my 1.8 though.
Same code, just using a different message.
Mats
@Matsv
Mar 08 2016 00:03
Can you send me your code?
Z609
@Z609
Mar 08 2016 00:03
I can send you at most the class as it is part of my custom server, one sec.
Myles
@MylesIsCool
Mar 08 2016 00:04
Off to bed, see you soon pals :)
Z609
@Z609
Mar 08 2016 00:04
One moment, let me just make sure I'm not crazy and try and see if the listener is even being executed sigh
Mats
@Matsv
Mar 08 2016 00:04
Cya
Myles
@MylesIsCool
Mar 08 2016 00:04
should just put system.out.println everywhere its what i do
Z609
@Z609
Mar 08 2016 00:05
I'm sending messages to players specifically
Could this be the issue? http://prntscr.com/acikco
Ryan James
@rj0495
Mar 08 2016 00:06
Cya @MylesIsCool
Z609
@Z609
Mar 08 2016 00:07
Bi @MylesIsCool
Z609
@Z609
Mar 08 2016 00:17
I'm done...Checked the usage of my class and found out I only initialized it but never used it to register a listener -_-
hopefully this'll work.
Mats
@Matsv
Mar 08 2016 00:19
Yeah that's pretty annoying I always put 100 debug messages in it to prevent mistakes like that
Z609
@Z609
Mar 08 2016 00:20
By the way, Minecade uses ViaVersion (albeit an older version :)) http://prntscr.com/acipb7
pvmac2194
@pvmac2194
Mar 08 2016 00:37
Hey, not sure if this has been said, but is there a way to remove the bossbar upon disconnect so when a player switches servers they do not have it? I already do .removePlayer
Mats
@Matsv
Mar 08 2016 00:39
You mean with bungeecord?
pvmac2194
@pvmac2194
Mar 08 2016 00:39
Yes
Mats
@Matsv
Mar 08 2016 00:40
Are you using the latest version? They implemented it SpigotMC/BungeeCord@a7664a5
pvmac2194
@pvmac2194
Mar 08 2016 00:42
Nope, thank you very much for that
Mats
@Matsv
Mar 08 2016 00:43
No problem :)
Mats
@Matsv
Mar 08 2016 12:01
731 emails from github.. Forgot to disable it :worried:
fillefilip8
@fillefilip8
Mar 08 2016 12:01
Lol @Matsv
Im trying to even make a application with netty. And i cant even bind it to a port
:D
Mats
@Matsv
Mar 08 2016 12:02
Why can't you? Is the port already in use or don't you know how to bind it?
fillefilip8
@fillefilip8
Mar 08 2016 12:02
idk how to bind
:D
i feel so stupid
You might want to follow that :)
That'll teach you some basic stuff
fillefilip8
@fillefilip8
Mar 08 2016 12:04
Im not using netty 5 :D
should i use that insteed?
Select the version you use :)
fillefilip8
@fillefilip8
Mar 08 2016 12:06
"'bind(io.netty.channel.ChannelFuture)' in 'io.netty.bootstrap.ServerBootstrap' cannot be applied to '(int)'"
i criiiiiiiiiiiiiiiiiiiiiiiiiiiiiii
Myles
@MylesIsCool
Mar 08 2016 12:06
Netty is pretty cool if you want an easy project to look at
It's based a lot about having "handlers" in order and passing down a pipeline
fillefilip8
@fillefilip8
Mar 08 2016 12:08
'bind(io.netty.channel.ChannelFuture)' in 'io.netty.bootstrap.ServerBootstrap' cannot be applied to '(java.net.InetSocketAddress)'
-.-
Myles
@MylesIsCool
Mar 08 2016 12:09
What's your code to bind
fillefilip8
@fillefilip8
Mar 08 2016 12:09
"bootstrap.bind(new InetSocketAddress(1337)).sync().channel()
.closeFuture().sync();"
copied from your page
Myles
@MylesIsCool
Mar 08 2016 12:10
What netty version you using
fillefilip8
@fillefilip8
Mar 08 2016 12:11
4.0.0
alpha 5
Myles
@MylesIsCool
Mar 08 2016 12:12
I use <version>4.0.12.Final</version> in the project
fillefilip8
@fillefilip8
Mar 08 2016 12:12
kk
there we go :D
"There is insufficient memory for the Java Runtime Environment to continue." thanks school laptop
u are very nice with java today
fillefilip8
@fillefilip8
Mar 08 2016 12:20
whats the thing called
that u use to read info from etc packet
XD
like reading shorts, bytes,string
Myles
@MylesIsCool
Mar 08 2016 12:21
ByteBuf
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 12:29
Ughh don't you guys have school or so?
Myles
@MylesIsCool
Mar 08 2016 12:30
I'm at University I have lectures at random times ;)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 12:31
Yeah at my age that isn't the case...
fillefilip8
@fillefilip8
Mar 08 2016 12:31
fille got school
but hey
java is funnier then school
Kappa
Myles
@MylesIsCool
Mar 08 2016 12:32
MylesIsCool/ViaVersion@1262847 will someone readd the methods removed from bossbar >.> <3 (I gtg)
fillefilip8
@fillefilip8
Mar 08 2016 12:32
and there intellij crashed :D
:)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 12:32
Although 1 day a week I have free from school so I can follow computer science at a university like today ;)
Let me check @MylesIsCool
Myles
@MylesIsCool
Mar 08 2016 12:33
just copy old interface source
then paste
;)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 12:34
Oh sorry I can't do any coding right now...
I'm at my phone xd
Mats
@Matsv
Mar 08 2016 12:34
Oh did he remove things?
Myles
@MylesIsCool
Mar 08 2016 12:34
Yeah >.>
Mats
@Matsv
Mar 08 2016 12:35
i'll just copy / paste from the pull request. Did someone change after that?
SOmething important?
Myles
@MylesIsCool
Mar 08 2016 12:36
don't think so?
fillefilip8
@fillefilip8
Mar 08 2016 12:38
any way to kill the process that listens to a port. Beacuse the server still using my port beacuse it crashed....
i cri killing the task
tried*
Mats
@Matsv
Mar 08 2016 12:38
Are you on windows?
fillefilip8
@fillefilip8
Mar 08 2016 12:38
nothing happend
ye
im on windows :D
Mats
@Matsv
Mar 08 2016 12:38
Sorry don't know how to do that on windows :P
you can kill processes with the task manager I think
Myles
@MylesIsCool
Mar 08 2016 12:39
unless you can task manager then sure, otherwise no
could reboot / logout ;)
fillefilip8
@fillefilip8
Mar 08 2016 12:39
too lazy
Mats
@Matsv
Mar 08 2016 12:39
Change your port
fillefilip8
@fillefilip8
Mar 08 2016 12:39
or i just kill
all the "low ram usage" java processes :D
Myles
@MylesIsCool
Mar 08 2016 12:39
I've found something quite interesting to do with portals
Mats
@Matsv
Mar 08 2016 12:39
Yeah if you can kill it
Myles
@MylesIsCool
Mar 08 2016 12:40
which might be the edge of the portal bug
Mats
@Matsv
Mar 08 2016 12:40
@MylesIsCool Nice! Is it some kind of packet?
Myles
@MylesIsCool
Mar 08 2016 12:40
no
in 1.8 it uses entityBaseTick to work out cooldown
in 1.9 it uses a different method
just gotta work out how this method is called
oh it works same just in a method now my bad
lol
fillefilip8
@fillefilip8
Mar 08 2016 12:42
what should i call to send something to the server?
i tried ctx.channel().writeAndFlush("HAI");
Myles
@MylesIsCool
Mar 08 2016 12:42
basic byte servers don't support strings
you'd need a StringEncoder and decoder
for that
fillefilip8
@fillefilip8
Mar 08 2016 12:42
nvm :D
hehe
i forgot that
lels
Myles
@MylesIsCool
Mar 08 2016 12:43
you can google for simple echo server in netty
bbl
fillefilip8
@fillefilip8
Mar 08 2016 12:43
but i can send a byte[] ?
aka string to byte[]
...
Mats
@Matsv
Mar 08 2016 12:49
@MylesIsCool done
Yeah @fillefilip8
fillefilip8
@fillefilip8
Mar 08 2016 12:51
Would you recommend ByteBuf if i want to read bytes and strings?
Mats
@Matsv
Mar 08 2016 12:58
I'd use a StringDecoder / encoder
Myles
@MylesIsCool
Mar 08 2016 14:08
Thanks @Matsv <3
Mats
@Matsv
Mar 08 2016 14:30
@MylesIsCool No problem :)
fillefilip8
@fillefilip8
Mar 08 2016 16:12
Hi
Mats
@Matsv
Mar 08 2016 16:12
Hey
fillefilip8
@fillefilip8
Mar 08 2016 16:13
Cleaning my room and listening to monstercat
XD
fillefilip8
@fillefilip8
Mar 08 2016 16:19
@Matsv i wanted to send byte,short and strings
fillefilip8
@fillefilip8
Mar 08 2016 16:29
Any ideas? :)
Mats
@Matsv
Mar 08 2016 16:39
@fillefilip8 I'm not really good at teaching people. You might want to check out tutorials like this: http://seeallhearall.blogspot.nl/2012/06/netty-tutorial-part-15-on-channel.html
fillefilip8
@fillefilip8
Mar 08 2016 16:39
Its very hard to find youtube tutorials on netty tho :D
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 16:40
Youtube tutorials are not very useful imo
If you have time you can watch them, but reading is a lot faster
fillefilip8
@fillefilip8
Mar 08 2016 16:40
XD
Mats
@Matsv
Mar 08 2016 16:41
Nope I agree. They also explain it better on books/written tutorials
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 16:42
Yeah I started with java with a Java for dummies book :D
But that was a loong time ago
fillefilip8
@fillefilip8
Mar 08 2016 16:42
Lol
fille didnt learn from books :D
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 16:43
Does anyone have any idea for #172?
fillefilip8
@fillefilip8
Mar 08 2016 16:43
@MylesIsCool Any comment on my pull request maybe? MylesIsCool/ViaVersion#134
Mats
@Matsv
Mar 08 2016 16:44
MylesIsCool/ViaVersion#163 does anyone have problems with knockback? I don't
@HugoDaBosss i'll take a look at it
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 16:44
He says it's about 10-20% of the time
So probably something else which causes it
Mats
@Matsv
Mar 08 2016 16:45
I didn't have a problem. Did it like 50 times :s
Uch that emoji
:confused:
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 16:45
Yeah also :P is horrible...
Is there a way to force sync my repo from the fork? So just overwrite it using github?
fillefilip8
@fillefilip8
Mar 08 2016 16:47
-F?
idk
:D
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 16:53
Any ideas yet @Matsv on #172?
It's okay with wiki.vg
@rj0495 How are you so sure #172 is caused by protocollib?
Ryan James
@rj0495
Mar 08 2016 16:55
I can tell you for a Fact
LibsDisguises send straight through Prot lib
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 16:57
Yeah but it has to do something with the score for a player, everything is right according to wiki.vg
But somehow the value is still a byte....
Ryan James
@rj0495
Mar 08 2016 16:57
Hmm
LD doesn't use that.
I'll check now
[01:11:19 WARN]: at com.comphenix.protocol.reflect.accessors.DefaultMetho
That's a Protlib issue
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:01
Can't we fix all these kind of issues by just cancelling the packet as soon as we encounter any exception, and log it and ask for a report?
So that people won't get disconnected and such
Ryan James
@rj0495
Mar 08 2016 17:01
We could listen for the packet but
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:02
Yeah ofcourse it is easier to say it than to implement it
Ryan James
@rj0495
Mar 08 2016 17:02
Prot lib overrides ViaVersion?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:02
ProtocolLib adds another handler to the pipeline I think
And we intercept packets before they reach ProtocolLib
Its Server - ProtocolLib - ViaVersion - Client
Ryan James
@rj0495
Mar 08 2016 17:03
hmm
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:04
So we could just cancel any outgoing packets which cause errors
Ryan James
@rj0495
Mar 08 2016 17:04
I thought it was Server - Vv - Prot - Client
1 Second
I think I know the Cycle
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:05
Well protocollib uses the internal minecraft packet object format, not the bytebuf one we are using
We just replace the minecraft encoder and decoder
Ryan James
@rj0495
Mar 08 2016 17:05
loadbefore: [ProtocolLib, ProxyPipe]
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:05
And minecraft first decodes packets before they read them
Ryan James
@rj0495
Mar 08 2016 17:07
Also, I have been testing with Arrows
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:07
And btw, shouldn't we add sort of a packet cache for outgoing packets? Since a lot of packets are sent to multiple clients, and we transform them each seperately
Ryan James
@rj0495
Mar 08 2016 17:07
Seems that the p.launchprojectile works fine
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:07
Even when fired 2 times without moving?
Ryan James
@rj0495
Mar 08 2016 17:14
Yeah I'm gonna try again now to be 100% Sure
Ryan James
@rj0495
Mar 08 2016 17:33
@HugoDaBosss Yeah it works fine with LaunchProjectile
i know what I'll do
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 17:37
Just onplaylaunchprojectile, cancel it and use p.launchprojectile?
Ryan James
@rj0495
Mar 08 2016 17:38
Yeah but I think you should listen to the Event in spigot
i am writing something now
Yeah we listen for the Packet @HugoDaBosss
Ryan James
@rj0495
Mar 08 2016 17:43
Since Event doesn't call
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:09
The arrow will shoot, it will just have the wrong velocity clientside
So the event WILL call
Ryan James
@rj0495
Mar 08 2016 18:10
Nah it doesn't just tried
And the arrows don't shoot
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:11
Then the bug changed, for me it would shoot, and then take some time to place it properly
Ryan James
@rj0495
Mar 08 2016 18:11
I don't see that
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:11
But let me test it with the latest version
Ryan James
@rj0495
Mar 08 2016 18:11
Yeah please do
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:11
Last time I tested was one of the earliest versions
Mats
@Matsv
Mar 08 2016 18:11
Is this not a 1.9 bug? I have the same problem in singleplayer
Ryan James
@rj0495
Mar 08 2016 18:11
Also, How are you dumping the packets?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:11
Yeah that's what I said @Matsv
But nobody believed me....
Yeah got support now :D
Ryan James
@rj0495
Mar 08 2016 18:12
It's now I don't see anything with the Vanilla Build
i see no Clientside bugs
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:13
Yeah me neither now
But I'm almost sure there were before
Ryan James
@rj0495
Mar 08 2016 18:13
Hmm
How do you dump packets to the console?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:13
With editing viaversion code or just with protocollib?
Ryan James
@rj0495
Mar 08 2016 18:14
Prot
Myles
@MylesIsCool
Mar 08 2016 18:14
./packet add client
etc
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:14
use /packet names <client | server>
and there you will find the legacy id
Ryan James
@rj0495
Mar 08 2016 18:14
Ok :)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:14
and use the legacy id to to /packet add client <id> true
If you are on windows you can right click, then find, will make searching for the ID a lot easier xd
Ryan James
@rj0495
Mar 08 2016 18:15
:smile:
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:17
Wow indeed, it won't shoot anymore
Ryan James
@rj0495
Mar 08 2016 18:17
Yeah
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:17
Even serverside
Ryan James
@rj0495
Mar 08 2016 18:58
Hello
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:58
Hi :D
Ryan James
@rj0495
Mar 08 2016 18:58
[18:26:00 INFO]: [ProtocolLib] Received PacketPlayInBlockPlace[8, legacy: 15] from rj0495:
{ a = { name = "MAIN_HAND", ordinal = 0 }, timestamp = 1457461560740 }
[18:26:02 INFO]: [ProtocolLib] Received PacketPlayInBlockDig[7, legacy: 14] from rj0495:
{ a = { a = 0, c = 0, d = 0 }, b = { g = 0, h = 1, i = -1, j = "down", k = { e = "y", f = "VERTICAL", name = "Y", ordinal = 1 }, l = { c = -1, d = "Towards negative", name = "NEGATIVE", ordinal = 1 }, m = { a = 0, c = -1, d = 0 }, name = "DOWN", ordinal = 0 }, c = { name = "RELEASE_USE_ITEM", ordinal = 5 } }
[18:26:02 INFO]: [ProtocolLib] Sent PacketPlayOutSpawnEntity[14, legacy: 23] to rj0495:
{ a = 56, b = { mostSigBits = -3608493333542254160, leastSigBits = -7007445500614571244 }, c = -180.96075951498796, d = 70.52000000327826, e = 118.6429079189659, f = 24072, g = -1248, h = -2729, i = -3, j = 68, k = 60, l = 54 }
Packet dump for 1.9 Spigot
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:58
Yeah we know that
Did you also do it for spigot 1.8?
Ryan James
@rj0495
Mar 08 2016 18:59
I was just showing how it is all Called,
I'll do 1.8 now. Do you want with VV or no?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 18:59
Without
And please use pastebin, so this chat willl be more clear and organized ;)
I'll do a packet dump for the latest viaversion build, with 1.8 client and 1.9 client
Ryan James
@rj0495
Mar 08 2016 19:02
Ok. You do that.
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:02
Could you just say the legacy ids? So I won't have to search :)
Ryan James
@rj0495
Mar 08 2016 19:04
Sure for 1.9
14, 23
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:04
Yeah but they are cross version ;)
Thanks :D
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:10
You should also listen for 15, PlayInBlockPlace
Ryan James
@rj0495
Mar 08 2016 19:10
I will.
But say I make a 15 wait then if people were to do a 'weak' throw the arrow would still shoot far
Dw I didn't read that properly
facepalm
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:13
Here is the packet dump for 1.8 server with 1.9 client
http://pastebin.com/805WtHWn
First shot is initial shot, 2nd shot withouth moving, 3rd shot after moving
Here is the packet dump for 1.8 server with 1.8 client
Same order
Ryan James
@rj0495
Mar 08 2016 19:16
Do a raw 1.8
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:16
You were going to do that right?
Ryan James
@rj0495
Mar 08 2016 19:17
I did :smile: I just didn't do in the same order
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:17
Wait I see a change, let me test something :D
Ryan James
@rj0495
Mar 08 2016 19:18
ok I'll make 1 in same order
They all look exactly the same in 1.8 except pos changes
Myles
@MylesIsCool
Mar 08 2016 19:25
it could be something like they changed how they work
I've just found quite an interesting bug
a 1.9 client cannot see a 1.9 client drawing a bow :)
Mats
@Matsv
Mar 08 2016 19:26
It's really strange. You can not drown when you stand stil, same problem with bows, and taking damage (under water) and maybe more?
Myles
@MylesIsCool
Mar 08 2016 19:26
but a 1.8 can see 1.9
so 1.9 bow drawing is broke
Ryan James
@rj0495
Mar 08 2016 19:26
Food is broken too?
PacketPlayOutSpawnEntity isn't called at all for the Bow
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:28
The only change for the 1.9 client is the e,f and g values have a value
While the 1.8 playinblockplace packets don't
And that's for the start of the bow drawing
So the start isn't registered
I feel i'm really close to fixing it
Ryan James
@rj0495
Mar 08 2016 19:31
Couldn't you just edit the packet when it comes into have none of those values?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:36
Okay the packets for 1.9 and 1.8 for BlockDig and BlockPlace are exactly the same now
But still no luck D:
Ryan James
@rj0495
Mar 08 2016 19:36
Hmm
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:37
1.8 players see the 1.9 players aiming their bow by the way
Myles
@MylesIsCool
Mar 08 2016 19:37
of course
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:37
Nevermind...
Oh not nevermind
Myles
@MylesIsCool
Mar 08 2016 19:38
I'm on a fun investigation
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:38
But on 1.9 you can't see anyone spanning their bow
Myles
@MylesIsCool
Mar 08 2016 19:38
it's called the enumanimation investigation
:)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:38
Even not 1.8 players
That's a nice name for such a horrible investigation ;)
Myles
@MylesIsCool
Mar 08 2016 19:38
it's the name in the code for the animation ;)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:39
PacketPlayInArmAnimation is never send while drawing a bow btw, neither on 1.9 nor 1.8

It's strange because you execute this check @MylesIsCool

inHand.getType().name().endsWith("SWORD")

But still players get a shield when drawing a bow...

Myles
@MylesIsCool
Mar 08 2016 19:41
what
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:41
See my latest issue
Players get a shield while drawing a bow
Myles
@MylesIsCool
Mar 08 2016 19:41
that's cause it's a 2 way blade
incoming and outgoing
I patched the outgoing just now
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:46
Ughhh this is so strange....
Mats
@Matsv
Mar 08 2016 19:55
Does anyone have this problem?
MylesIsCool/ViaVersion#177
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 19:58
Yeah for me it's working as well
Someone reported the same issues earlier
Myles
@MylesIsCool
Mar 08 2016 19:59
tested with bungee?
Mats
@Matsv
Mar 08 2016 19:59
Yeah I did
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:03
Anyone having any luck with the arrows yet?
Myles
@MylesIsCool
Mar 08 2016 20:04
trying something
nope :D
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:05
When drawing a bow an EntityMetaData packet is sent with byte 16 at index 0
[21:04:59 INFO]: [ProtocolLib] Sent PacketPlayOutEntityMetadata[28, legacy: 40] to HugoDaBosss:
{ a = 312, b = ([0: 16 (Byte)]) }
[21:05:02 INFO]: [ProtocolLib] Sent PacketPlayOutEntityMetadata[28, legacy: 40] to HugoDaBosss:
{ a = 312, b = ([0: 0 (Byte)]) }
Upper when is when starting to draw a bow, lower one when stop aiming
Yeah that's 0x10
eating/blocking/
drinking
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:07
Yeah but it is not recognized by the 1.9 client for some reason
Myles
@MylesIsCool
Mar 08 2016 20:07
maybe it's herobrine :O
Mats
@Matsv
Mar 08 2016 20:07
Probably
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:08
Herobrine wasn't the ghasts, because we were able to fix that
He is probably an evil arrow god or something
Myles
@MylesIsCool
Mar 08 2016 20:08
he's angry at us for not using the new arrows
:(
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:09
Yeah we are quite ungrateful indeed...
Myles
@MylesIsCool
Mar 08 2016 20:11
[20:10:14 INFO]: [ProtocolLib] Sent PacketPlayOutEntityMetadata[28, legacy: 40] to _MylesC:
{ a = 11, b = (DataWatcherItem[object=DataWatcherObject[index=5, serializer=Serializer[type=class java.lang.Byte, handle=net.minecraft.server.v1_9_R1.DataWatcherRegistry$1@3d893295, optional=false]], value=1, dirty=false]) }
that's 1.9 when I draw a bow
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:11
Index 5?
That's really strange
Myles
@MylesIsCool
Mar 08 2016 20:11
I've never seen index 5
and that i assume
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:12
Yeah me neither
Myles
@MylesIsCool
Mar 08 2016 20:12
is the bug
could it be
PLAYER_HUMAN_BYTE(HumanEntity.class, 16, Type.Byte, NewType.Discontinued),
perhaps?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:12
Yeah it's a byte
But it is not used in 1.8
Is there a list with datawatchableobject types in the source code?
Myles
@MylesIsCool
Mar 08 2016 20:13
well
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:13
So all the different types
Myles
@MylesIsCool
Mar 08 2016 20:13
that's why it's hard
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:13
I wasn't able to find it
Myles
@MylesIsCool
Mar 08 2016 20:13
There is a list
just in every type lol
like EntityItem
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:13
Ohh they are spread over each different class, let me take a looko
Myles
@MylesIsCool
Mar 08 2016 20:13
I haven't looked for 5
:D
5 is also sent when you eat food
could this be the magic bug
who knows
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:15
It would be really strange if this is what caused the bug
Myles
@MylesIsCool
Mar 08 2016 20:15
Well it might be
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:15
Because launching the arrow is server side
Myles
@MylesIsCool
Mar 08 2016 20:15
the client only sends the packet or what
when it has the metadata
to prevent lag
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:16
Yeah but the packet that they release the bow is actually sent
Or there are other packets involved then PlayInBlockDig PlayInBlockPlace and PlayInUseItem
Myles
@MylesIsCool
Mar 08 2016 20:16
I'd assume 5 might be a new animation packet
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:17
But it is a bytevalue, with atleast 5 meaning eating/drinking/aiming
That's all we know for now
Myles
@MylesIsCool
Mar 08 2016 20:19
wiki.vg has it just has no clue
If you're interested it's this in the code
protected static final DataWatcherObject<Byte> as = DataWatcher.a(EntityLiving.class, DataWatcherRegistry.a);
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:19
Yeah there isn't anything about this on wiki.vg
Myles
@MylesIsCool
Mar 08 2016 20:20
It declares what hand to use
I believe
this.datawatcher.set(as, Byte.valueOf((byte)i));
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:20
How do I check from a byte again that it contains the 0x10 bitmask?
Myles
@MylesIsCool
Mar 08 2016 20:20
int i = 1;
    if (enumhand == EnumHand.OFF_HAND) {
      i |= 2;
    }
like this
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:20
Wow that's interesting
Myles
@MylesIsCool
Mar 08 2016 20:20
if (x & 0x10 == 0x10) {}
so when an entity does a dig or a place
the server updates meta data of current hand?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:22
Guess that's it, but this shouldn't make any difference for a 1.8 server
output.markWriterIndex();
output.resetWriterIndex();
This will reset it to the marker right?
Myles
@MylesIsCool
Mar 08 2016 20:23
well you have to use the marker before that
so you mark it
read said thing
then reset
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:23
Same for writing? I can just overwrite after that I use reset?
Yeah I know I have to place the marker before that xd
Myles
@MylesIsCool
Mar 08 2016 20:23
I'd assume so
OH
I get it
I know why entity animations don't work
it's cause the metadata declares what hand to animate
oh
Mats
@Matsv
Mar 08 2016 20:25
:clap:
Myles
@MylesIsCool
Mar 08 2016 20:25
and that's the end of myles discovers things, thx all for watching
Mats
@Matsv
Mar 08 2016 20:25
Hahaha
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:27
YOU ARE RIGHT MYLES
ITS WORKING :D :D :D
Only issue now it doesnt stop animating :P Will fix
Myles
@MylesIsCool
Mar 08 2016 20:27
what works
??
plz
plz
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:28
The bow animations
in 1.9
with viaversion
Myles
@MylesIsCool
Mar 08 2016 20:28
does eating work
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:28
Let me check
Just fixing a small thing
Starting....
Myles
@MylesIsCool
Mar 08 2016 20:30
I got bows working 100%
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:30
Just need to get some hunger :P
Myles
@MylesIsCool
Mar 08 2016 20:30
of time on my client
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:30
Yeah me as well
Wait, shooting them doesnt work D:
But the animations do ;)
Whoops broke minecraft
Myles
@MylesIsCool
Mar 08 2016 20:32
were potions fixed
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:32
Don't know, just crashed both my minecrafts :P
It crashed when throwing items
Myles
@MylesIsCool
Mar 08 2016 20:33
btw the weird stone bug is in vanilla minecraft with item drops
so we're fine
well i think it might be prot lib
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:33
What stone bug? Dropped items appearing as stone?
Myles
@MylesIsCool
Mar 08 2016 20:34
dropped blocks i think
my solution is probs easier than yours
though I did cheat
:)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:36
I just checked when writing the entity status packet if it was a player, and then write an index 5, byte type id, and then 1 or 0, depending on if 0x10 is present
Myles
@MylesIsCool
Mar 08 2016 20:36
I do it in MetaDataRewriter do you?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:36
Yeah me as well
Myles
@MylesIsCool
Mar 08 2016 20:36
it should be a constant 1
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:36
Did you add it to MetaIndex?
Myles
@MylesIsCool
Mar 08 2016 20:36
cause we only use 1 hand
nope
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:37
Yeah but when I just write 1, it won't stop aiming
Myles
@MylesIsCool
Mar 08 2016 20:37
oh good point
lel
1 bug down, only 5 million to go!
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:38
Yeah D:
Can you actually shoot bows normally?
Myles
@MylesIsCool
Mar 08 2016 20:38
Nah it does still break
:'(
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:38
Yeah...
But are you pushing the commit?
Because it is an improvement
Myles
@MylesIsCool
Mar 08 2016 20:39
Your commit is better ;)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:39
Sure?
Myles
@MylesIsCool
Mar 08 2016 20:39
Yep <3
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:40
I'm some commits late :P Let me check
Myles
@MylesIsCool
Mar 08 2016 20:43
You know what i'm stuck on
I was gonna write a patch for boss bars right
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:43
Yeah?
Myles
@MylesIsCool
Mar 08 2016 20:43
so I go and decompile BarAPI to see how it works
and they use metadata 10 for boss name
and I can't find any ref to metadata 10 for boss name in 1.8
:(
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:43
Wait I'll check in a sec, just tidying up my code
File14
@File14
Mar 08 2016 20:44
Hello
Guys thanks for making Viaversion!
Myles
@MylesIsCool
Mar 08 2016 20:45
np
File14
@File14
Mar 08 2016 20:45
When is the new update coming out? And will you fix the Holographic Displays bug?
Myles
@MylesIsCool
Mar 08 2016 20:46
well, the holographic one isn't really game breaking
and it's not really a design flaw of viaversion itself
File14
@File14
Mar 08 2016 20:46
Okay, will the boat bug be fixed in next version?
Myles
@MylesIsCool
Mar 08 2016 20:47
and that bug is?
File14
@File14
Mar 08 2016 20:47
You know if you go into a boat, then you can sail away, on ground. Then if you jump out off it you get teleported where you started sailing.
Myles
@MylesIsCool
Mar 08 2016 20:48
I'd suggest opening a bug report on github about that. https://github.com/MylesIsCool/ViaVersion/issues
File14
@File14
Mar 08 2016 20:48
But I've just told you?
Myles
@MylesIsCool
Mar 08 2016 20:48
and?
File14
@File14
Mar 08 2016 20:49
So why do I need to make it then?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:49
To organize things
Myles
@MylesIsCool
Mar 08 2016 20:49
Because then we can see if other people have the bug and investigate into it better, and it gives a systematic approach.
File14
@File14
Mar 08 2016 20:50
Okay, I'll do that then. But do you know why it doesn't load some chunks for 1.9 users? https://i.gyazo.com/14a7a91bd28260286647bb4e17ef2c50.jpg
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:50
#178 :D
Myles
@MylesIsCool
Mar 08 2016 20:50
are you using AAC
File14
@File14
Mar 08 2016 20:50
Nope
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:51
It's not loading the main chunk around spawn right?
File14
@File14
Mar 08 2016 20:51
Correct
Just 1 of them
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:51
There was just an update for 1.9, and since that update we are getting these issues
File14
@File14
Mar 08 2016 20:51
You can see the spawn point at the picture, where the sign is.
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:51
Probably something in the update broke it
File14
@File14
Mar 08 2016 20:52
Update 1.9?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:52
Small bug fix update probably
File14
@File14
Mar 08 2016 20:52
So it's not in your plugin or what?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:52
It's not working, but this bug is there as well in spigot 1.9 probably
File14
@File14
Mar 08 2016 20:52
I'm using protocollib, that is ok right?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:53
Yeah protocollib is supported, although some plugins using protocollib can cause issues
File14
@File14
Mar 08 2016 20:53
Yeah, okay.
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:54
MylesIsCool/ViaVersion#173 Could you reply to this issue saying you are having this issue without AAC?
Myles
@MylesIsCool
Mar 08 2016 20:54
is the missing chunk 0,0?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:54
Yeah it is @MylesIsCool
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:55
Yep, 0,0
Could you reply to #173?
File14
@File14
Mar 08 2016 20:56
done
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:56
Ty
File14
@File14
Mar 08 2016 20:57
But this issuse is ONLY for 1.9 users not 1.8
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:57
Yeah but when it is in the 1.9 client it won't show up for 1.8 users ;)
File14
@File14
Mar 08 2016 20:57
What?!
Myles
@MylesIsCool
Mar 08 2016 20:57
ViaVersion only modifies info to 1.9 clients
doesn't touch 1.8
@File14 Are the 0,0 chunks always missing, how could I replicate this
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 20:58
The issue with the 0,0 chunks missing has been reported before in earlier versions
usually there is something corrupt in them
File14
@File14
Mar 08 2016 20:59
It's loading if I join the server, but then if I fly away like 70 blocks it just randomly unloads.
Myles
@MylesIsCool
Mar 08 2016 20:59
usually 0,0 bugs are off by 1 errors :P
File14
@File14
Mar 08 2016 21:00
Maybe the problem will get solved if you add so the 0,0 chunk is loaded always
Myles
@MylesIsCool
Mar 08 2016 21:00
Yeah we can't do that at a packet level
Yeah I can replicate the bug
Thanks for the help @File14 I'll look into it
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:02
How did you do that @MylesIsCool ?
Myles
@MylesIsCool
Mar 08 2016 21:02
goto 0, 0
turn my render to 32 chunks
fly away a bit
you see it get unloaded
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:02
Oh wow it doesn't even have to be corrupt
let me check
Myles
@MylesIsCool
Mar 08 2016 21:03
it seems herobrine has taken the chunks hostage after taking our arrows, we're going to have to run after him and catch him. Might take some time, sorry @File14
File14
@File14
Mar 08 2016 21:05
Alright, but thanks for taking care of it.
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:06
Can't get it to replicate @MylesIsCool
D:
Myles
@MylesIsCool
Mar 08 2016 21:08
maybe it's cause herobrine can only be one place at once
hmmhm
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:08
Yeah that should be it
Myles
@MylesIsCool
Mar 08 2016 21:08
are you using prot lib
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:09
Yep
Myles
@MylesIsCool
Mar 08 2016 21:10
Well
I fixed the bug
the down side is
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:10
Yay :D
Myles
@MylesIsCool
Mar 08 2016 21:10
I now have infinite render distance
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:10
Hahah lolz
Myles
@MylesIsCool
Mar 08 2016 21:10
which might be an issue
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:10
Hmmm, 'might' be ;)
Myles
@MylesIsCool
Mar 08 2016 21:12
nah
it's cause i had it on 32 chunks
haha
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:13
By the way, you probably should not print a whole error when the hand fetching item thing fails
Myles
@MylesIsCool
Mar 08 2016 21:13
probs ;)
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:13
Because when the server times out it is spammed xd
Set my randomTickSpeed to 99999999, RIP server
Myles
@MylesIsCool
Mar 08 2016 21:13
wanna make a PR ;)
Did @gigosaurus verify that I fixed MAP_BULK
I mean MAP_CHUNK or what
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:14
And shouldn't we try to catch all errors while transforming packets? And just print the trace, and throw a cancelexception so the malformed packet won't be sent
I have no idea...
Myles
@MylesIsCool
Mar 08 2016 21:15
maybe
:)
I'll add that Hugo
you fix the hand item yeah, and i'll fix that
;)
;)
deal?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:15
Yeah :D Deal
And isn't it better to return an Itemstack with air then null?
Myles
@MylesIsCool
Mar 08 2016 21:18
well all our entity code
uses null when writing
so null is better for us
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:18
Ah okay, then it's fine
And for the late-bind, can't we just set a task to run every 5 seconds trying to inject the packet handler, and on succes it stops?
Myles
@MylesIsCool
Mar 08 2016 21:19
I'll work on that sometime
It's stupid doing it that way
cause there is methodology to late-bind
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:20
Isn't there an all plugins loaded event?
Or something like that
Ryan James
@rj0495
Mar 08 2016 21:20
@HugoDaBosss Did you sort arrows?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:20
Nope, Herobrine still posseses them
We fixed bow animations though
Ryan James
@rj0495
Mar 08 2016 21:21
Ok Good
The chunk bug?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:26
Yeah @MylesIsCool fixed it
File14
@File14
Mar 08 2016 21:26
In that build?
Myles
@MylesIsCool
Mar 08 2016 21:27
I wouldn't use that one
i'd use latest
lol
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:27
Ehh @MylesIsCool you still print out the chunk coordinates...
Myles
@MylesIsCool
Mar 08 2016 21:27
it was fixed hugo
your behind
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:27
Ah okay ;)
File14
@File14
Mar 08 2016 21:27
The #26 then?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:27
No I just clicked the commit link from the Buildserver
Yeah that one should be alright, although it is not recommended using nonreleased version
File14
@File14
Mar 08 2016 21:28
:smile:
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:38
@MylesIsCool does the latest spigot version 0.5.8 include the bossbar updates?
Ryan James
@rj0495
Mar 08 2016 21:56
#47 #177 Applies to leads too
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:56
Are you able to replicate that issue?
For me it's working fine @rj0495
Ryan James
@rj0495
Mar 08 2016 21:56
yeah
I'll rep issue
Mats
@Matsv
Mar 08 2016 21:57
Leads are also working fine for me
Myles
@MylesIsCool
Mar 08 2016 21:58
uh i don't think so @HugoDaBosss
the ones where methods were removed hugo?
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:59
Yea
h
What I'm stating, is it time for another update? ;)
Myles
@MylesIsCool
Mar 08 2016 21:59
Well I'm hoping to finish late-bind support
:(
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 21:59
Ahh okay
Need help with anything
?
Myles
@MylesIsCool
Mar 08 2016 22:00
Nah
Thanks for the offer though <3
Hugo Kerstens
@HugoDaBosss
Mar 08 2016 22:00
Np :D
JoshK_
@JoshTheDev
Mar 08 2016 22:50
hey @MylesIsCool
MAP_CHUNK protocollib definitely doesn't work
It just kicks players and throws exceptions
Myles
@MylesIsCool
Mar 08 2016 22:53
It worked for me?
JoshK_
@JoshTheDev
Mar 08 2016 22:55
What code did you use?
Myles
@MylesIsCool
Mar 08 2016 22:56
I just listened for the packet
like the issue said
JoshK_
@JoshTheDev
Mar 08 2016 22:56
All good if I pm you the code I'm using?
Myles
@MylesIsCool
Mar 08 2016 22:57
Sure