These are chat archives for MylesIsCool/ViaVersion

11th
Mar 2016
ridalarry
@ridalarry
Mar 11 2016 10:30
I have 2 minor bugs with witherboss
if I have anti flicker on it wont show the given damage to the wither
and if I have a boss bar plugin (this only happened once) and I did /wild it will show 4 witherbosses 3 of them are not changing and only 1 is changing
Myles
@MylesIsCool
Mar 11 2016 10:46
The way bosses work changed so we can't really fix which one renders. And for ant flicker, just turn it off and don't use said boss bar plugin which causes it
anti-flicker prevents the health changing
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 10:50
Created PR @MylesIsCool :D
Myles
@MylesIsCool
Mar 11 2016 12:26
rubs beard
brb making lunch ;)
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 12:28
Imaginary beard* ;)
Myles
@MylesIsCool
Mar 11 2016 12:30
of course it's imaginary haha
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 13:00
But
Whoops
But is the PR okay?
Myles
@MylesIsCool
Mar 11 2016 13:01
Yeah looked fine so i pulled
Mats
@Matsv
Mar 11 2016 15:28
http://wiki.vg/Pre-release_protocol Rip pre-release protocol I guess?
lenis0012
@lenis0012
Mar 11 2016 15:36
they make a new protocol version but all they change is set the dimensiont to an int?
wot
that doesn't make ANY sense
Mats
@Matsv
Mar 11 2016 15:36
Nope.. But they make it easy for us
:D
lenis0012
@lenis0012
Mar 11 2016 15:38
also
they implemented some very nice paper
well
lets check out that chunk issue
from what i know there are 2 issues.
1> empty chunks are not set
2> sending empty chunks bugs out
Myles
@MylesIsCool
Mar 11 2016 16:03
we'll do a classic patch for this bad boy
ya know ;)
First protocol hack to support 1.9.1
woo!
which PRE added the change :(
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 16:17
It should be in the latest right?
Myles
@MylesIsCool
Mar 11 2016 16:18
dw i'm on it
good news, we're now patched for 1.9.1 PRE2 +
lenis0012
@lenis0012
Mar 11 2016 16:33
@MylesIsCool thanks for merge conflicts
much appreciated
Myles
@MylesIsCool
Mar 11 2016 16:40
np np
lenis0012
@lenis0012
Mar 11 2016 16:48
i think ill rewrite the chunk thing
this is what i got so far
@MylesIsCool
ridalarry
@ridalarry
Mar 11 2016 17:59
is there any update?
I am used to daily update now no updates looks wierd xD
Mats
@Matsv
Mar 11 2016 18:01
@ridalarry That's probably because most bugs are fixed now :)
ridalarry
@ridalarry
Mar 11 2016 18:02
true
only 4 issues left
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 18:47
well 5 now, but it's probably a duplicate
Mats
@Matsv
Mar 11 2016 18:48
Yeah true but since we don't know what causes it, it's pretty good to see someone else with the same problem :P
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 18:48
Yeah indeed
I added duplicate label, but didn't close it ;)
lenis0012
@lenis0012
Mar 11 2016 19:32
So
i finished new chunk system
ima test
pray for me
Mats
@Matsv
Mar 11 2016 19:32
Nice :)
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 19:33
Yay nice! :D
Mats
@Matsv
Mar 11 2016 19:34
@HugoDaBosss player_digging is getting handled right?
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 19:35
Oh yeah nevermind, but why is it called Player Digging....
Mats
@Matsv
Mar 11 2016 19:35
I have no idea
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 19:35
Thought it were different packets xd
lenis0012
@lenis0012
Mar 11 2016 19:35
[20:35:39 WARN]: 4054783 Bytes left after reading chunk!
[20:35:39 WARN]: 4042495 Bytes left after reading chunk!
[20:35:39 WARN]: 4067071 Bytes left after reading chunk!
[20:35:39 WARN]: 4054783 Bytes left after reading chunk!
[20:35:39 WARN]: 4071167 Bytes left after reading chunk!
[20:35:39 WARN]: 4071167 Bytes left after reading chunk!
[20:35:39 WARN]: 4054783 Bytes left after reading chunk!
[20:35:39 WARN]: 4038399 Bytes left after reading chunk!
[20:35:39 WARN]: 4050687 Bytes left after reading chunk!
[20:35:39 WARN]: 4038399 Bytes left after reading chunk!
[20:35:39 WARN]: 4038399 Bytes left after reading chunk!
[20:35:39 INFO]: Lennyooops left the game.
[20:35:39 WARN]: 4026111 Bytes left after reading chunk!
[20:35:39 WARN]: 4050687 Bytes left after reading chunk!
[20:35:39 WARN]: 4038399 Bytes left after reading chunk!
[20:35:39 WARN]: 4038399 Bytes left after reading chunk!
[20:35:39 WARN]: 4054783 Bytes left after reading chunk!
[20:35:39 WARN]: 4071167 Bytes left after reading chunk!
oh
Mats
@Matsv
Mar 11 2016 19:36
Rip
@HugoDaBosss Probably because it's Player digging @ wiki.vg
Myles
@MylesIsCool
Mar 11 2016 19:54
packet names are based off wiki.vg
;)
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 19:57
Ah yeah that explains it ;)
Apparently when your pc is out of memory it just hard resets x.x
Mats
@Matsv
Mar 11 2016 20:15
Lol why did github implement 'Your reaction'
lenis0012
@lenis0012
Mar 11 2016 20:20
uhh lol
chunk manager works
but its uh
only showing redstone
Mats
@Matsv
Mar 11 2016 20:21
That's strange. Maybe because redstone sent a block update later?
lenis0012
@lenis0012
Mar 11 2016 20:21
oh yeah probably
so it doesn't work at all
lol
</3
Mats
@Matsv
Mar 11 2016 20:22
Haha yeah probably :P
Myles
@MylesIsCool
Mar 11 2016 20:25
@lenis0012 originally i wrote my own chunk thing, then gave up due to stupid bugs and just used MCProtocolLib and ported between the two versions ;)
lenis0012
@lenis0012
Mar 11 2016 20:29
but thats why the chunk rendering is bugged @MylesIsCool
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 21:28
WTf
Myles
@MylesIsCool
Mar 11 2016 21:29
I should probably just search for ServerConnection :(
I think it's cause it's CraftBukkit and not spigot
lol
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 21:32
Github should really add strikethrough markup xd
lenis0012
@lenis0012
Mar 11 2016 21:32
why are chunks so retarded....
Hugo Kerstens
@HugoDaBosss
Mar 11 2016 21:32
Because mojang
ridalarry
@ridalarry
Mar 11 2016 21:41
I have noticed something wierd its not by the plugin its from mojang themselves
they removed 1.9 as a release
and made it as a snapshot
Myles
@MylesIsCool
Mar 11 2016 21:47
Got a question
How does this look
This message was deleted
lenis0012
@lenis0012
Mar 11 2016 21:48
what is it?
oh
that looks pretty neat
Myles
@MylesIsCool
Mar 11 2016 21:48
how do you even use code blocks
ugh
lenis0012
@lenis0012
Mar 11 2016 21:48
gist
lol
Thoughts?
Mats
@Matsv
Mar 11 2016 21:51
I like the idea but I don't you think it'll get a mess to register them all in one class?
Myles
@MylesIsCool
Mar 11 2016 21:52
well it is of course expandable to multiple classes :)
lenis0012
@lenis0012
Mar 11 2016 21:52
i like it
Myles
@MylesIsCool
Mar 11 2016 21:52
I just realised I never finished the map(Type.NOTHING) to UUID
lenis0012
@lenis0012
Mar 11 2016 21:52
you can split them up into categories
WorldPackets, EntityPackets, InventoryPackets, MovePackets, OtherPackets
Myles
@MylesIsCool
Mar 11 2016 21:54
I mean the end goal
is we could have a program analyse the protocol
and automatically generate the structure of these
Mats
@Matsv
Mar 11 2016 21:55
Yeah it's really easy to add versions this way
multiple versions
if you wanted to
Myles
@MylesIsCool
Mar 11 2016 21:55
So instead of like having dodgy if(protocol xyz for patching 1.9 PRE 2
the code would be like
class Protocol1.9PRE2 extends Protocol1.9 {
// override x packet etc
}
lenis0012
@lenis0012
Mar 11 2016 21:56
ProtocolRegistry.applyBaseProtocol(1_9_Protocol());
ProtocolRegisrty.applyProtocolPatch(1_9_1_Protocol());
Myles
@MylesIsCool
Mar 11 2016 21:56
also means any plugin can write a protocol
lenis0012
@lenis0012
Mar 11 2016 21:57
then every protocol takes an argument PacketWrapper
with the packet info provided by the previous protocol
whether that be vanilla or another protocol
i wouldn't extend another protocol
get the player's current protocol.
Get the one after that
set that as his base protocol
then add all the other protocols that came after

so if i join with 1.8 and MC 1.9.2 is out

ProtocolRegistry.applyBaseProtocol(1_9_Protocol);
ProtocolRegistry.applyProtocolPatch(1_9_1_Protocol);
ProtocolRegistry.applyProtocolPatch(1_9_2_Protocol);

then packetPlayOutHandshake goes

Vanilla
Creates packet

1_9_Protocol
sets protocol version from 106 to 107

1_9_1_Protocol
sets protocol version from 107 to 108

1_9_2_Protocol
sets protocol version from 108 to 109

Netty
Sends to client

Mats
@Matsv
Mar 11 2016 22:08
yeah some system like that would be pretty awesome but when for example 1.9.10 out is, it has to check 10 different things before it'll go to the client. Will that affect performance?
lenis0012
@lenis0012
Mar 11 2016 23:07
no
because the only modifications made are the ones changed in the current protocol
if you dont do this you need to add support for each previous protocl individually
which is infinitely more work
ridalarry
@ridalarry
Mar 11 2016 23:09
do anyone know why does 1.9 got replaced from a release to a snapshot?
lenis0012
@lenis0012
Mar 11 2016 23:13
guys i made the new chunk converter
its so much better!
well
almost
Myles
@MylesIsCool
Mar 11 2016 23:13
This is when you realise, what we had was pretty good