These are chat archives for MylesIsCool/ViaVersion

12th
Mar 2016
lenis0012
@lenis0012
Mar 12 2016 01:15
@MylesIsCool Im getting really close
it just only sends like half the sections
for some reason
Hugo Kerstens
@hugokerstens
Mar 12 2016 09:58
You are putting a lot of work in this @lenis0012 ;) I really appreciate you trying to solve this bug :D
It's probably something small which isn't working yet
lenis0012
@lenis0012
Mar 12 2016 12:34
I made a PR
got it working
@MylesIsCool
lenis0012
@lenis0012
Mar 12 2016 12:40
i already use it on my server play.choochoosmc.com
if you wanna see for yourself
because its in a void world the chunk used to be all glitchy
Hugo Kerstens
@hugokerstens
Mar 12 2016 12:44
Can you send a build? Then I can test it on my own server as well ;)
Really nice work :D
lenis0012
@lenis0012
Mar 12 2016 12:45
will in a sec
making a tiny patch
Hugo Kerstens
@hugokerstens
Mar 12 2016 12:51
Okay I build it already myself
But I gtg D:
Yeah it works :D
Only some debug printing, but that is an easy fix ;)
thats a better version
lenis0012
@lenis0012
Mar 12 2016 13:09
the empty chunk issue is back tho
rip
Myles
@MylesIsCool
Mar 12 2016 13:27
Not going to pull until it works better than custom system :)
Otherwise good job ;)
lenis0012
@lenis0012
Mar 12 2016 13:28
im working on it
lol
lenis0012
@lenis0012
Mar 12 2016 14:28
FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
i fixed it but accidentally did a hard reset
kill me
lenis0012
@lenis0012
Mar 12 2016 14:47
Okay
remade it
its working
@MylesIsCool
lenis0012
@lenis0012
Mar 12 2016 14:57
it should also be a bit faster
Myles
@MylesIsCool
Mar 12 2016 19:39
Not at PC but can anyone add a patch to NBT to make sure in.readableBytes isn't too high <3?
Just add to readNBT :)
lenis0012
@lenis0012
Mar 12 2016 20:11
heh?
Myles
@MylesIsCool
Mar 12 2016 20:11
it's fine @ pc now ;)
lenis0012
@lenis0012
Mar 12 2016 20:14
good
approve my PR then
Myles
@MylesIsCool
Mar 12 2016 20:14
well I have the test it first don't I
lenis0012
@lenis0012
Mar 12 2016 20:21
of course not
its not like it could break anything
its not like i touched something very fragile
Myles
@MylesIsCool
Mar 12 2016 20:25
Nice way to fix #201 ;)
I mean apart from the unused variables here and there, it's good :) good work
lenis0012
@lenis0012
Mar 12 2016 20:28
lol yup
the reason why that bug report is fixed
is because im no longer manually creating those chunk packets
instead directly converting the chunk bulk packet
that way it skips the double data generation
Myles
@MylesIsCool
Mar 12 2016 20:29
Well you are >.>
"Object chunkPacket = mapChunkRef.newInstance();"
lenis0012
@lenis0012
Mar 12 2016 20:30
ye but its empty\
Myles
@MylesIsCool
Mar 12 2016 20:30
Just not using constructor
lenis0012
@lenis0012
Mar 12 2016 20:30
im not using the chunk constructor
which calculates the data over again
Myles
@MylesIsCool
Mar 12 2016 20:30
It's a good way of avoiding it so kudos to you :)
lenis0012
@lenis0012
Mar 12 2016 20:30
running obfuscation twice
:)
Myles
@MylesIsCool
Mar 12 2016 21:02
0.6.4 is now out https://www.spigotmc.org/resources/viaversion.19254/ Thanks @lenis0012, @HugoDaBosss, @Matsv