These are chat archives for MylesIsCool/ViaVersion

18th
Mar 2016
Vislo
@Vislo
Mar 18 2016 05:52
is NoCheatPlus compatible with viaversion?
Like they block 1.9 clients?
Mats
@Matsv
Mar 18 2016 07:21
It works on my server, but some people reported issues, not sure
fillefilip8
@fillefilip8
Mar 18 2016 14:24
working on my custom image service :D
lel
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:03
It's working fine on my server @Vislo
Bodoo
@Bodoo
Mar 18 2016 16:07
Hey, is someone here who can help me with an error which comes since a few weeks?
It comes from Viaversion
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:07
I just replied to your issue ;)
It is a duplicate, it has been reported many times before
Bodoo
@Bodoo
Mar 18 2016 16:07
Do you know what causes this error?
Our hub server crash since a few weeks
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:08
It has something to do with the PlayInBlockDig packet, but we haven't been able to identify what is the cause of this
Bodoo
@Bodoo
Mar 18 2016 16:08
Do you have an idea on how to block this packet or maybe cancel events so that this error dont appear anymore?
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:08
MylesIsCool/ViaVersion@0d3ba67 This commit should fix that the actual error is shown, and not the invocationtargetexception
Bodoo
@Bodoo
Mar 18 2016 16:08
maybe cancel blockdamage event
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:09
Yeah if you cancel the digging as soon as it starts the client won't send the blockdig packet
But the blockdig packet is used for more things than just breaking blocks
Bodoo
@Bodoo
Mar 18 2016 16:10
yeah, we already canceled blockdamage event but this error still occures
hmm
doesnt have other servers this error too?
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:10
So are players still able to finish breaking a block?
Yeah, I tagged 3 duplicates in my comment on your issue
Bodoo
@Bodoo
Mar 18 2016 16:10
nono, there is't even the block diging animation
is it maybe related to flyingblocks?
we have balloons on our hub servers, they are fallingblocks on bats
and the bats follow the player
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:11
Could you download the latest development version from one of the build servers? In that version it should be fixed that the actual error is printed to the console
Bodoo
@Bodoo
Mar 18 2016 16:11
yes
Bodoo
@Bodoo
Mar 18 2016 16:12
oh sec
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:12
So use 0.6.6-SNAPSHOT
Bodoo
@Bodoo
Mar 18 2016 16:12
i download and put on servers
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:13
Yeah thank you :D As soon as the error is thrown again please add it to your issue ;)
We have been unable to replicate this issue ourselves, so you are a huge help! :D
Bodoo
@Bodoo
Mar 18 2016 16:13
okay, i'l report it as soon as i see this error, i think maybe 10 minutes :D
Bodoo
@Bodoo
Mar 18 2016 16:29
Nothing until now..
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:32
What's you IP?
Bodoo
@Bodoo
Mar 18 2016 16:32
TheVace.net
if you want to come teamspeak we can talk about this error, same ip
Myles
@MylesIsCool
Mar 18 2016 16:34
did someone say teaparty on thevace ts ;)?
Bodoo
@Bodoo
Mar 18 2016 16:34
hehehe
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:34
Wow busy server :D
there you can see the crashes
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 16:35
I'm on the TS ;)
Myles
@MylesIsCool
Mar 18 2016 18:22
Just switched to GSON for all json stuff due to some weird mem leaks, also fixed a bug with boss bars and 1.8 clients
Bodoo
@Bodoo
Mar 18 2016 18:24
Thanks so much ❤️
Myles
@MylesIsCool
Mar 18 2016 18:26
I'm just hoping it should sort it >.>
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:30
So did the lobby crash already @Bodoo ?
Zaino60
@Zaino60
Mar 18 2016 19:47
Hello Guys I just found two major ViaVersion bugs
Myles
@MylesIsCool
Mar 18 2016 19:47
there is a github issues page
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:48
Before reporting an issue here, please create an issue on the github page following the issue tempalte
Zaino60
@Zaino60
Mar 18 2016 19:48
when you are riding a mob (I just tested with a pig and a horse but I think it's with all entities), you randomly die when you are walking/jumping
oh ok, sorry
Myles
@MylesIsCool
Mar 18 2016 19:49
make sure to post plugins and other info
Zaino60
@Zaino60
Mar 18 2016 19:50
yeah, doing that
done, I included a video showing how it happens to. Hope it helps
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:54
Let me read, formatted it a bit ;)
Zaino60
@Zaino60
Mar 18 2016 19:55
Also, thank you very much for creating this plugin, if it weren't because of you, many servers would still be in 1.8 and would have lost a lot of players or would have been forced to pay $1000 of the Lilypad patch. Thank you, really, you are the best <3
Mats
@Matsv
Mar 18 2016 19:55
I think it's because we didn't implement the VEHICLE_MOVE_REQUEST packet
in 1.9 horse riding / boat riding is client-sided
We are not handeling that (yet)
The server thinks the horse is in the void
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:56
Yeah but the strange thing is he dies instantly
Not void damage
But it is probably what you said
Mats
@Matsv
Mar 18 2016 19:57
Does that minigame not handle that? :confused:
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:57
Let me check when he falls in the void first
Yeah that's because of the plugin
Mats
@Matsv
Mar 18 2016 19:57
at 8 min it's parcour
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:57
Yeah okay so it's because the vehicle move request packet as you said
Mats
@Matsv
Mar 18 2016 19:58
Yeah it's client-sided D:
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:58
Yeah but at 14:37 you can clearly see someone walking with the horse
Or that person is using 1.8
Mats
@Matsv
Mar 18 2016 19:59
Yeah but since it's client-sided the client thinks it's moving
even though the server doesn't register everything
It registers some movements with STEER_VEHICLE
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 19:59
Yeah but I mean someone else walking the horse ;)
Did you see the video in the issue @Zaino60 reported?
Mats
@Matsv
Mar 18 2016 20:00
Yes
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 20:02
This 'audrey' appears to have the same issue, but you can clearly see the audreys horse move
Mats
@Matsv
Mar 18 2016 20:02
Time?
at the video
Mats
@Matsv
Mar 18 2016 20:03
Yeah that's because STEER_VEHICLE does still sent most of the packets too. The only problem is when you use a and d I think
At least that's what i experienced with boats
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 20:03
This speculations are so fun to hear xd 'you can't stand still' 'cobwebs kill you' xd
Mats
@Matsv
Mar 18 2016 20:06
Yeah it'd be pretty annoying for them :P
https://fileserver.matsv.nl/media?id=5bbe56e95526022e65fc3a521e72edc7 If you move for a while, you'll get off a little (1.8.8 left, 1.9 right)
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 20:12
Mats
@Matsv
Mar 18 2016 20:13
Yeah I saw it
Pretty awesome :smile:
Myles
@MylesIsCool
Mar 18 2016 20:24
Yeah the dev follows me on twitter ;)
Zaino60
@Zaino60
Mar 18 2016 20:56
Yeah it was really funny because they didn't understand what was happening
but yeah I think it's because the packets thing because it really looks like the horse isn't synchronized with what you are really doing, since it falls to the void when you actually didn't fall, and vice-versa
Myles
@MylesIsCool
Mar 18 2016 21:08
refactoring like no tomorrow ;O
Mats
@Matsv
Mar 18 2016 21:09
Rip old way of transforming packets
Myles
@MylesIsCool
Mar 18 2016 21:09
laughs
I'm not going to merge tonight :(
I haven't reimplemented debug mode
:)
Mats
@Matsv
Mar 18 2016 21:09
Noooooooo we can't live without debug mode
Myles
@MylesIsCool
Mar 18 2016 21:10
Yeah which is why it'll get put off till like saturday night
:P
Myles
@MylesIsCool
Mar 18 2016 21:19
you know it's a good refactor when
Showing 98 changed files with 1,267 additions and 1,436 deletions.
Mats
@Matsv
Mar 18 2016 21:22
Yeah, when I renamed my package name, git liked to remove everything and add everything after that :P
Myles
@MylesIsCool
Mar 18 2016 21:23
well if you look
I did clean up a lot of code
there is a lot of changes
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:23
Let me look! Sounds good :D
Mats
@Matsv
Mar 18 2016 21:23
True
Myles
@MylesIsCool
Mar 18 2016 21:25
Just using the README as a todo list before i forget everything on my mind ;)
Is there a way to do a branch difference haha
Yeah ofcourse xd Just click compare when on your not master branch
I was already looking at it ;)
Myles
@MylesIsCool
Mar 18 2016 21:26
This is where you realise that it's an insane amount of change
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:27
Yeah 99 files, almost 100
Gotta reach that 100 xd
Myles
@MylesIsCool
Mar 18 2016 21:28
Also i'm all cool if anyone does any patches to the master cause it's easy to keep up to date now everything is ported :P
oh and if you see any stupid mistakes please say <3
though there is a lot of code to look at
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:29
I'm reading it right now :)
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:37
By the way, don't we need general interfaces for things like the metaindex and stuff?
Myles
@MylesIsCool
Mar 18 2016 21:37
nope
Metadata is implemented
;)
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:38
Yeah okay you don't get what I mean, but I realize it's not needed now ;)
Myles
@MylesIsCool
Mar 18 2016 21:41
also I'm up for suggestion for any changes if you think something has a silly name or what
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:42
Shouldn't all the PlayerPackets, InventoryPacket, etc extend a general PacketTransformer or something like that? Just like the Protocol1_9TO1_8 extends Protocol
Myles
@MylesIsCool
Mar 18 2016 21:42
uh, I thought about it then I just thought to keep it simple shrug
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:45
And the names of the protocol packages, it's called protocol1_9to1_8, isn't that a bit confusing?
Myles
@MylesIsCool
Mar 18 2016 21:45
I couldn't think of a better name that was readable :(
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 21:46
Yeah I don't have a better solution as well xd
And it's also confusing because a protocol goes two ways, so 'to' is confusing as well
But it doesn't matter that much
https://github.com/MylesIsCool/ViaVersion/blob/apiv2/src/main/java/us/myles/ViaVersion/ViaIdleThread.java#L30 Also since this task is used very often, can't you just keep a list of players for each protocol? Instead of just ported players
Myles
@MylesIsCool
Mar 18 2016 21:50
it's not expensive using the line of code i added
Maybe instead of Type and newType
Just versionType
Or something like that
Myles
@MylesIsCool
Mar 18 2016 22:00
Pushing version 0.6.6
what's PR 247 advantages
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:01
Well instead of iterating through all armortypes it gets it from an hashmap
Same as with the packet ids
Myles
@MylesIsCool
Mar 18 2016 22:03
im sorry wont be in 0.6.6
:(
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:03
It's a PR for apiv2 btw, or are you going to push apiv2 in 0.6.6 already?
Myles
@MylesIsCool
Mar 18 2016 22:03
nah
apiv2 is for tomorrow / sunday when we're happy
:)
I didn't see it was for APIv2
my bad
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:04
Hahahah np, that's why I mentioned it ;)
Myles
@MylesIsCool
Mar 18 2016 22:11
Today has been productive for me :), reached level 20 on wow, on the edge of finishing this :D
Mats
@Matsv
Mar 18 2016 22:12
Is level 20 high in wow? Never played it :open_mouth:
Myles
@MylesIsCool
Mar 18 2016 22:13
I don't play either, did it cause there's a promotion with another game, hearthstone ;) (took me like 8 hours total to get to 20 >.>)
Mats
@Matsv
Mar 18 2016 22:14
Lol, was it worth it? :p
Myles
@MylesIsCool
Mar 18 2016 22:15
uh, debatable ;)
Do we want JProfiler licenses?
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:19
Yeah :D But our project needed to be atleast 2 months old right?
Myles
@MylesIsCool
Mar 18 2016 22:19
nah thats for other things
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:19
Ahh okay, then ofcourse :D
I have 2 days left to evaluate ;)
Mats
@Matsv
Mar 18 2016 22:20
That was IntelliJ right?
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:20
Yeah sorry I'm mixing things up
Myles
@MylesIsCool
Mar 18 2016 22:20
if you goto a school you can get free education license
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:21
Yeah but I'm currently at a regular high school, don't know if JProfiler accepts that
Myles
@MylesIsCool
Mar 18 2016 22:23
well profilers won't
but intellij will
Where is the 2 months minimum?
Myles
@MylesIsCool
Mar 18 2016 22:24
nah it's intellij
which has 2 months min
I've applied for JProfiler
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:25
For our project? Or individual using your school
Myles
@MylesIsCool
Mar 18 2016 22:25
Our project haha
Mats
@Matsv
Mar 18 2016 22:26
IntelliJ is 3 months, how old is this project? 1 month? 3 weeks?
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:26
https://www.jetbrains.com/student/ This doesn't apply for me...
Wow, my school email is valid for application :D It doesn't even end with .edu or something, just .nl
Myles
@MylesIsCool
Mar 18 2016 22:27
like 1 month technically matsv
Mats
@Matsv
Mar 18 2016 22:28
First push 19 days ago
feels longer
Myles
@MylesIsCool
Mar 18 2016 22:28
I worked on it before git ofc
;)
Eventually we'll apply to jetbrains for a license for everyone :)
Hugo Kerstens
@HugoDaBosss
Mar 18 2016 22:30
Yeah! I got mine already ;)