These are chat archives for MylesIsCool/ViaVersion

19th
Mar 2016
Hugo Kerstens
@hugokerstens
Mar 19 2016 00:14
#250
Going to sleep now, bye!
Although I think everyone is asleep already
fillefilip8
@fillefilip8
Mar 19 2016 12:58
hi
Mats
@Matsv
Mar 19 2016 12:58
Hey @fillefilip8
fillefilip8
@fillefilip8
Mar 19 2016 12:58
I made my image service :P
Mats
@Matsv
Mar 19 2016 12:59
Nice! what do you use? :D
fillefilip8
@fillefilip8
Mar 19 2016 13:02
My own code :P
and sharex
XD
Mats
@Matsv
Mar 19 2016 13:03
Nice :D, my php code that i've made for sharex is pretty shit
:P
thats an example what it can do :D
Mats
@Matsv
Mar 19 2016 13:04
Yay gifs :D
fillefilip8
@fillefilip8
Mar 19 2016 13:05
yeah
it supports any image format
png,jpg,gif
:D
Mats
@Matsv
Mar 19 2016 13:06
Yeah I support png,jpg,gif,mp4
fillefilip8
@fillefilip8
Mar 19 2016 13:06
i can add mp4 too if i want
but i dont need it
Mats
@Matsv
Mar 19 2016 13:06
Don't do it if you have limited disk space
:P
fillefilip8
@fillefilip8
Mar 19 2016 13:06
:P
gif will work
Mats
@Matsv
Mar 19 2016 13:07
Yeah I should probably] use gifs instead of mp4
fillefilip8
@fillefilip8
Mar 19 2016 13:07
since i can use gif with high quality
Mats
@Matsv
Mar 19 2016 13:07
20 frames p/s is the highest right?
Or am I wrong
:P
fillefilip8
@fillefilip8
Mar 19 2016 13:08
let me check
i seem to able to put it at 30fps
but the text is red
doesnt sound that good :D
Mats
@Matsv
Mar 19 2016 13:09
Yeah don't think that'll work
But not sure
fillefilip8
@fillefilip8
Mar 19 2016 13:09
:P
Well my image service records views too :D
it has a views counter
per each image
so i can see if someone clicked it :P
Mats
@Matsv
Mar 19 2016 13:10
:D
fillefilip8
@fillefilip8
Mar 19 2016 13:11
i love sharex:D
so good
:D
Mats
@Matsv
Mar 19 2016 13:12
Do you use your own database for view-count or just something like google-analytics?
fillefilip8
@fillefilip8
Mar 19 2016 13:12
my own database
if i want to be really sneaky/evil i can record each ip of each image view...
XD
brb
Mats
@Matsv
Mar 19 2016 13:13
Wannabe NSA
:P
@fillefilip8 You might want to make your security a little bit better if you don't want everyone to be able to upload :P
Oh I spelled your name wrong
my bad
:P
fillefilip8
@fillefilip8
Mar 19 2016 13:45
:D
dam u :D
Bodoo
@Bodoo
Mar 19 2016 13:45
:D
Mats
@Matsv
Mar 19 2016 13:45
Sorry <3
fillefilip8
@fillefilip8
Mar 19 2016 13:48
now there is security i think :D
be my guest and try upload :D
Mats
@Matsv
Mar 19 2016 13:48
You probably added some $_GET or $_POST check right? :)
fillefilip8
@fillefilip8
Mar 19 2016 13:48
haha :D
yup
Mats
@Matsv
Mar 19 2016 13:49
Well if you don't check how much people try, you could just infinitly try it with a script
fillefilip8
@fillefilip8
Mar 19 2016 13:49
and if they fail
{
"error": "WTF DO U THINK YOU ARE DOING?"
}
Hugo Kerstens
@hugokerstens
Mar 19 2016 13:49
And any luck on crashes yet @Bodoo ? :D
fillefilip8
@fillefilip8
Mar 19 2016 13:49
best error message 11/10
:D
Mats
@Matsv
Mar 19 2016 13:49
I've just a empty screen
:(
fillefilip8
@fillefilip8
Mar 19 2016 13:50
what is your post parameters?
Mats
@Matsv
Mar 19 2016 13:50
Oh nothing wait
fillefilip8
@fillefilip8
Mar 19 2016 13:51
try find a exploit? :D
haha
Mats
@Matsv
Mar 19 2016 13:51
I'm currently working on boats, ill try it later
:)
fillefilip8
@fillefilip8
Mar 19 2016 13:51
damit you used some disk space
hahahah
Mats
@Matsv
Mar 19 2016 13:52
Yeah I thought let's be nice and not upload 100gb
fillefilip8
@fillefilip8
Mar 19 2016 13:52
lol
100gb wont work tho
and how would u make a 100gb image file
plz explain :D
Mats
@Matsv
Mar 19 2016 13:52
free cloudflare has a limit of100 mb upload every session
I think
Hugo Kerstens
@hugokerstens
Mar 19 2016 13:53
You can set the size of a file to whatever you want
Even if it's empty
Mats
@Matsv
Mar 19 2016 13:54
And just setup a script that uploads it over and over again
fillefilip8
@fillefilip8
Mar 19 2016 13:54
cloudflare is bae
dont u think mr cloudflare will kill u?
Mats
@Matsv
Mar 19 2016 13:54
Well probably
fillefilip8
@fillefilip8
Mar 19 2016 14:00
brb
@Matsv your image
has the most views...
my god
Mats
@Matsv
Mar 19 2016 14:01
YEAA
:DDDD
10/10 image
fillefilip8
@fillefilip8
Mar 19 2016 14:02
lel
brb XD
gonna go to the storeeeeeeeeeeeeee
NomNuggetNom
@NomNuggetNom
Mar 19 2016 18:44
Anyone else getting a pretty bad memory leak? Using 0.6.6
It's Netty, I got the log http://nom.codes/t/r/MYtxZ
Myles
@MylesIsCool
Mar 19 2016 18:52
Thanks for the log will look at when home if nobody else does @NomNuggetNom
NomNuggetNom
@NomNuggetNom
Mar 19 2016 18:53
Thanks :+1:
We are actually running a newer netty version than you probably, but I don't think that should be an issue
Myles
@MylesIsCool
Mar 19 2016 19:13
Did you have mem leak detector on Netty on then?
NomNuggetNom
@NomNuggetNom
Mar 19 2016 19:13
Yup
Myles
@MylesIsCool
Mar 19 2016 19:13
Ah :) will be home in an hour to look at it
Myles
@MylesIsCool
Mar 19 2016 20:24
i love when people have social chit chat in the viaversion discussion >.>
Hugo Kerstens
@hugokerstens
Mar 19 2016 20:25
Hahahah reading all messages back? xd
Myles
@MylesIsCool
Mar 19 2016 20:25
on the spigotmc page
of people being like "hey buddy yeah we should meet up on a server"
this is what pm is for :(
time to go memory leak hunting ;)
Hugo Kerstens
@hugokerstens
Mar 19 2016 20:26
Ohh you mean in spigot, but here in this chat it's some social stuff as well ;)
Myles
@MylesIsCool
Mar 19 2016 20:26
I don't mind too much in here
Hugo Kerstens
@hugokerstens
Mar 19 2016 20:26
Hahah good luck! :D
Myles
@MylesIsCool
Mar 19 2016 20:27
I watch the spigot thread so it's annoying getting like 20+ notifications
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:27
@HugoDaBosss About my PR, I don't want to get rid of all errors, but that thing has been spamming my chat and makes everything else impossible to see.
Myles
@MylesIsCool
Mar 19 2016 20:27
you're using a constant
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:27
It's not a fatal error or anything, I don't see what's wrong with adding an option
Myles
@MylesIsCool
Mar 19 2016 20:27
perhaps if it was some sort of debug related thing
then sure
Mats
@Matsv
Mar 19 2016 20:27
@NomNuggetNom Make sure you cancel all your packets when you despawn entities
Hugo Kerstens
@hugokerstens
Mar 19 2016 20:27
^^
It means you are wasting network resources, as the client would have had no idea as well for which entity the packet was ment
Myles
@MylesIsCool
Mar 19 2016 20:30
it's worth noting the alex guy from latest tickets I have on skype
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:30
Hmm, I think you're on to something. Can you elaborate? Which packets should I cancel?
Myles
@MylesIsCool
Mar 19 2016 20:30
entity metadata etc
Mats
@Matsv
Mar 19 2016 20:30
Entity velocity
oh no
nvm
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:31
Why are those ever sent if the entity has been despawned though?
Mats
@Matsv
Mar 19 2016 20:31
Well some plugins despawn it only for one player
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:31
Oh yeah, we do that.
Mats
@Matsv
Mar 19 2016 20:31
The server will send updates from that entity even when it's despawned for the client
That's why you should cancel other packets like metadata (with the despawned entity id)
That causes the error
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:32
Hmm, is it possible other plugins have that issue to? I'm wondering if there's a way to block all packets like that
Obviously I could figure out how to do it for my plugins
Myles
@MylesIsCool
Mar 19 2016 20:33
@NomNuggetNom What params do you launch minecraft with to enable netty debug? or is it spigot config?
I know that for normal launch it's -Dio.netty.leakDetectionLevel=advanced but I can't see any results :(
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:33
Yeah, that didn't work for me either, I had to add this: ResourceLeakDetector.setLevel(Level.ADVANCED);
Myles
@MylesIsCool
Mar 19 2016 20:34
evil grin soon to debug mode mwahaha
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:34
Warning: Apparently reduces performance by a lot
Myles
@MylesIsCool
Mar 19 2016 20:34
It does ;)
maybe i'll add a command might be useful
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:36
@Matsv Does that issue apply even if you spawned the entity with packets too?
If it's not a real entity then why would the server try sending packets?
Mats
@Matsv
Mar 19 2016 20:36
No
only if you despawned entities that still exists server-sided
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:37
Right
Trying to think of an easy way to detect that
I think I know how
Mats
@Matsv
Mar 19 2016 20:41
You could intercept the DESPAWN packet and cache the ids that still exists at bukkit
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:41
Yeah
Then intercept any other packets and just check
Mats
@Matsv
Mar 19 2016 20:41
Yup
NomNuggetNom
@NomNuggetNom
Mar 19 2016 20:41
Easy enough
Myles
@MylesIsCool
Mar 19 2016 20:42
ok
i got the mem leak
Mats
@Matsv
Mar 19 2016 20:42
What was it?
Myles
@MylesIsCool
Mar 19 2016 20:42
someone left the tap on
and the packet juices were flowing out
Mats
@Matsv
Mar 19 2016 20:43
Sounds good
Hugo Kerstens
@hugokerstens
Mar 19 2016 20:43
someone left the spigot open*
Myles
@MylesIsCool
Mar 19 2016 20:43
is bodoo around
Hugo Kerstens
@hugokerstens
Mar 19 2016 20:44
Not sure, he didn't report back with any crashes yet
Myles
@MylesIsCool
Mar 19 2016 20:45
well he told me
that he had a crash
and i said use latest release
cause he was on 0.6.6-SNAPSHOT
shrug
Hugo Kerstens
@hugokerstens
Mar 19 2016 20:47
He is online on his server in lobby 4 :) stalking
Bodoo
@Bodoo
Mar 19 2016 20:58
Hey, im here yes
Mats
@Matsv
Mar 19 2016 20:58
Hello :wave:
Bodoo
@Bodoo
Mar 19 2016 20:59
Hi :) If you want to talk i can go to my computer
Myles
@MylesIsCool
Mar 19 2016 20:59
oh i just wanted to say we just fixed a big mem leak
Bodoo
@Bodoo
Mar 19 2016 20:59
oh okay, i will download the newest version and put it on the server later :)
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:31
Oh you fixed it? Nice work @MylesIsCool
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:37
Lol
I've got issues
Myles
@MylesIsCool
Mar 19 2016 21:38
what profiler you usin
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:38
jvisualvm
Myles
@MylesIsCool
Mar 19 2016 21:39
you able to take a allocation list
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:39
Heap dump?
It's Netty, ViaVersion isn't running though, I think
Myles
@MylesIsCool
Mar 19 2016 21:39
Oh hahaha
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:41
That's why I think @Matsv is on to something
Mats
@Matsv
Mar 19 2016 21:45
Wait what
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:45
You said I might be sending packets of destroyed entities
Mats
@Matsv
Mar 19 2016 21:45
Well bukkit is sending them
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:45
Yeah
It's flooding my console atm
I wonder if it's Citizens
Mats
@Matsv
Mar 19 2016 21:46
Hm, citizens entities are client-sided right?
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:47
Nope, I believe they actually spawn them, because they make sounds.
Mats
@Matsv
Mar 19 2016 21:48
But citizens isn't despawning per-player entities right?
Citizens is open-source let me check
Looks like it's using craftbukkit to despawn npc's
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:51
Hmm
Oh boy.
I found something
NomNuggetNom
@NomNuggetNom
Mar 19 2016 21:57
It's Citizens.
Actually, wait, my methodology might be flawed.
Mats
@Matsv
Mar 19 2016 22:01
Citizens does never set velocity? Or are you using moving npc's? But still, can't find code in citizens that despawns npc for some player
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:01
Not sure why I printed that
Mats
@Matsv
Mar 19 2016 22:03
Is that in citizens?
Myles
@MylesIsCool
Mar 19 2016 22:04
good news
we fixed a bug breaking 1.8 clients
woo
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:08
@MylesIsCool Can you link me the latest jar? Spigotmc is down :(
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:09
Thanks :)
That has the memory leak fix, right?
Myles
@MylesIsCool
Mar 19 2016 22:09
ya
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:15
It's not Citizens
Myles
@MylesIsCool
Mar 19 2016 22:18
the moment when you accidentally deploy apiv2 to a production server
oops
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:23
Okay
I need to figure this thing out lol
When the "unable to get entity ID" thing really starts going the server grinds to a halt
So it's definitely related
@MylesIsCool Any chance you could whip up a quick fork where it prints some more info, or should I fork it and do it?
Myles
@MylesIsCool
Mar 19 2016 22:32
unless you use debug mode in command
I don't know any other info you would want
you're better forking
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:32
Lol read that as "you better fucking"
Just got that
0.6.7-snapshot
Myles
@MylesIsCool
Mar 19 2016 22:37
are you up to date
and what client version
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:37
API version 1.8.8-R0.1-SNAPSHOT)
Myles
@MylesIsCool
Mar 19 2016 22:37
"client"
not server
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:37
Oh o hoh
Why does it matter?
There are multiple people on, I'm not sure what everyone is using.
Myles
@MylesIsCool
Mar 19 2016 22:38
because the last patch fixes 1.8?
:|
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:39
Yeah, not sure
I assume some people were 1.9 some were 1.8
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:51
@MylesIsCool Any idea what entity ID 212 - 215 is?
Myles
@MylesIsCool
Mar 19 2016 22:51
they are relative to your server.
.>
...
NomNuggetNom
@NomNuggetNom
Mar 19 2016 22:51
Lol nice face
Myles
@MylesIsCool
Mar 19 2016 23:10
should be
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:20
Do you not use Java 8?..
Myles
@MylesIsCool
Mar 19 2016 23:21
Do you think every server uses Java 8?
Bodoo
@Bodoo
Mar 19 2016 23:21
We use Java8
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:21
Shame on anyone who doesn't imo
Bodoo
@Bodoo
Mar 19 2016 23:22
I think the most do it, all of my friends and other server admins use it
Myles
@MylesIsCool
Mar 19 2016 23:22
Hosting companies do not, hence the reason of java 7
and java 7 isn't too bad
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:22
    List<org.bukkit.entity.Entity> list = EvoPlugin.getInstance().getServer().getWorlds().stream().flatMap(w -> w.getEntities().stream()).filter(e -> e.getEntityId() == id).collect(Collect.toLinkedList());
VS
    List<org.bukkit.entity.Entity> list = new LinkedList<>();
    for (org.bukkit.World world : EvoPlugin.getInstance().getServer().getWorlds())
        for (org.bukkit.entity.Entity entity : world.getEntities())
            if (entity.getEntityId() == id)
                list.add(entity);
Myles
@MylesIsCool
Mar 19 2016 23:23
On the subject one of my hosts I have a server with emailed me today saying my server is now java 8 to prove the point
(I don't use this host I just have a server with them)
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:27
Sometimes "unable to get entity for ID" represents a CraftPlayer..?
:l
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:34
@MylesIsCool I am still seeing memory warnings, you want logs?
I'm 100% up to date
Myles
@MylesIsCool
Mar 19 2016 23:35
You could try solving them if you want ;)
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:36
I detest Netty
Myles
@MylesIsCool
Mar 19 2016 23:36
lol
It's amazing how could you detest it
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:36
Personally I feel like it's too complex
Myles
@MylesIsCool
Mar 19 2016 23:37
It's not too complex when you understand it
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:37
Except for certain situations
Myles
@MylesIsCool
Mar 19 2016 23:37
It's rather elegant and inspiring in some cases
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:37
Yeah, I just didn't like having to read a book on how to write a simple client/server :P
Myles
@MylesIsCool
Mar 19 2016 23:38
Yeah I suppose haha
I mean the only comparable simpler library i've seen
is NAGA for java
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:38
I just wrote my own simple one, it's not very hard
Myles
@MylesIsCool
Mar 19 2016 23:38
naga is a simple one ;)
NomNuggetNom
@NomNuggetNom
Mar 19 2016 23:40
There's another
Myles
@MylesIsCool
Mar 19 2016 23:47
try build 72
Myles
@MylesIsCool
Mar 19 2016 23:53
Off to bed :P