These are chat archives for MylesIsCool/ViaVersion

22nd
Mar 2016
Myles
@MylesIsCool
Mar 22 2016 10:05
I've just been reading replies to issues and what Alex said maybe the issue is because simulate pt sends packets when the player is dead or something like that
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 10:06
Yeah but the client still accepts packets then right?
Myles
@MylesIsCool
Mar 22 2016 10:17
Well it's the server that crashes and maybe it's something to do with ticking a dead player 0.0
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 10:20
Yeah but that would say custom clients can crash the server
But if it's everytime a player is dead than the issue would be far more common
Myles
@MylesIsCool
Mar 22 2016 10:29
I have a theory on the issue
That maybe it's todo with sending packets in non Netty thread
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 11:30
Hmmm that could be, but the code for sendrawpacket handles being in another thread
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 11:56
Why do we modify the y -movement of an armorstand on the entity look move packet with the hologramyoffset?
It is relative, so it shouldn't matter
And the same is for the enitity relative move, in the current version we don't even respect the hologramyoffset from the config
If anyone could remove the hologramoffset code in the apiv2 and master for those 2 packets that would be great, I currently don't have access to a computer with git
Myles
@MylesIsCool
Mar 22 2016 12:00
probably a good point i'll remove in a sec
Myles
@MylesIsCool
Mar 22 2016 13:55
Been looking at the creative "dupe" bug with cancelling items i'd presume throwing items in creative has maybe changed, the best fix I could produce would be that throwing items would make it disappear :(
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:00
Yeah but duping would be less annoying than no dropping at all
I mean, you can get any item in creative whatsoever
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:30
Created 2 PRs for apiv2 and master for the hologram movements ;)
Myles
@MylesIsCool
Mar 22 2016 14:32
Did i not fix them o.0
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:33
Ehh no?
Your last change was 16 hours ago
Myles
@MylesIsCool
Mar 22 2016 14:34
oh
i forgot to push
lol
Mats
@Matsv
Mar 22 2016 14:34
MylesIsCool/ViaVersion@3549a82
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:34
Oh wow in the apiv2 you fixed it, don't get why I didn't see it
Myles
@MylesIsCool
Mar 22 2016 14:34
oh wait
yeah
Did you modify more packets than I did
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:35
Wow somehow I synced but the changes weren't there?
Myles
@MylesIsCool
Mar 22 2016 14:35
I only modified 1 packet
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:35
Yeah the entity relative move, and entity relative move AND look
Github is acting strange, somehow in my commit it removes already removed code again?
Myles
@MylesIsCool
Mar 22 2016 14:37
so do I pull
or just manually do it
:(
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:37
Well the file looks okay when I click on view on current commit, so guess pull is fine
Myles
@MylesIsCool
Mar 22 2016 14:38
you're doomed if this breaks everything
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 14:38
:D
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:04
http://prntscr.com/aiiopi ;) Another invalid review removed :D
Myles
@MylesIsCool
Mar 22 2016 15:05
wow damn
what counts as an invalid review
o.o
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:05
Ehh old reviews which no longer are valid for the current version
Just for all those people: HELP DOESN'T WORK , and then leave a 1 star review
Mats
@Matsv
Mar 22 2016 15:06
Oh nice ;)
Myles
@MylesIsCool
Mar 22 2016 15:07
Is there a guideline?
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:07
Ehh guess there is, but I reported 3 in total, of which 2 have been removed
Myles
@MylesIsCool
Mar 22 2016 15:08
there's quite a few 3 star ones with features which have been fixed :(
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:08
Yeah, you can report them. Just make a short and brief description of what is wrong with them
Should we add a seperate option in the config to suppress Unable to get entity for ID: xxxx lines?
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:14
Just list on spigot that if you are getting those lines one of your plugins is not modifying packets properly, and if you want to stop these messages from showing enable xxx in config
Mats
@Matsv
Mar 22 2016 15:14
I'm think it's a good idea as long people get informed one of their plugin is sending bad packets
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:15
Yeah so the messages are there by default, just an option in the config which states explicitely there is a plugin error
Mats
@Matsv
Mar 22 2016 15:15
Yeah :smile:
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:22
Do we only throw these errors in transformMetadata in outgoingtransformer?
Mats
@Matsv
Mar 22 2016 15:22
Yeah
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:34
Created 2 PRs @Matsv @MylesIsCool
Myles
@MylesIsCool
Mar 22 2016 15:36
I would prefer a method in ViaVersionPlugin to reduce the line length
that handles the getBoolean(xyz)
and also giving it a default value just in case of some weird bug
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:37
Shouldn't we create some kind of access to the config in the apiv2?
Just read access though
Myles
@MylesIsCool
Mar 22 2016 15:38
Well it's more it looks cleaner just using plugin.isUnknownEntitiesSupressed()?
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:38
Yeah but right now you have to cast to ViaVersionAPI to ViaVersionPlugin everytime
Oh and btw, 'suppressed' is the correct spelling right?
Myles
@MylesIsCool
Mar 22 2016 15:39
I'd assume so
Yeah the casting is a bum
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:40
Just add a method in ViaVersionAPI?
Myles
@MylesIsCool
Mar 22 2016 15:40
What would it be called
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:41
The same, just like the isDebug boolean in ViaVersionAPI
isUnknownEntitiesSuppressed() is okay right?\
Myles
@MylesIsCool
Mar 22 2016 15:41
maybe
we should have
getPlugin()
in
ViaVersion
so you just use ViaVersion.getPlugin().xyz
instead of getInstance()
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:42
Yeah but then the ViaVersionAPI instance is useless xd
Maybe just getInstance for the ViaVersionAPI, and getPlugin for the ViaVersionPlugin
Myles
@MylesIsCool
Mar 22 2016 15:43
That's what i'm talking about?
you use getPlugin instead of getInstance in the code (not replacing it api wise)
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:43
Ohh I thought you ment to totally replace getInstance ;) My bad
Mats
@Matsv
Mar 22 2016 15:44
The api would be pretty useless if you add getPlugin though
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:45
Yeah, that's true...
Myles
@MylesIsCool
Mar 22 2016 15:45
Others plugins do it?
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:45
We could just add methods for the necesarry config settings in the ViaVersionAPI interface
Mats
@Matsv
Mar 22 2016 15:45
You could also add a new api class ViaVersionAPI.getConfig().isUnknownEntitiesSppressed()
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:47
Hmmm, what do we do? xd
Mats
@Matsv
Mar 22 2016 15:47
@MylesIsCool choice :P
Myles
@MylesIsCool
Mar 22 2016 15:47
It's more that you need to think
do we want to expose config to API
do devs really want to know config values
does worldedit have an api for reading their config from outside ;)
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:48
Ehh, probably not xd
Mats
@Matsv
Mar 22 2016 15:48
Well I mean more like read-only, I think with the new api, some developers might want access to it though
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:48
Design struggles....
Yeah even though if noone uses it, it is there, so no complaints ;)
Myles
@MylesIsCool
Mar 22 2016 15:49
If anyone would like to make a config class, it's cool :) and I'll port it to apiv2 if you want to do it for normal API
:)
Mats
@Matsv
Mar 22 2016 15:49
Uhm @HugoDaBosss Are you going to do it or should I do it?
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:49
We can just make it for the apiv2 right now only? The master branch is soon going to be deprecated
Mats
@Matsv
Mar 22 2016 15:49
That's true :P
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:49
I'll do it ;) Is it fine if I just let ViaVersionPlugin implement a new Config interface?
Myles
@MylesIsCool
Mar 22 2016 15:50
sly
literally the code becomes this

getConfig() {

return this;

}
works for me (y)
Should still add descriptions though
Myles
@MylesIsCool
Mar 22 2016 15:58
Unknown is spelled wrong
:)
Outwise A++
*otherwise
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 15:58
Ughh.... :D
What shortcut to refactor methods in intellij again?
Mats
@Matsv
Mar 22 2016 15:59
ctrl f6 or something like that
Myles
@MylesIsCool
Mar 22 2016 15:59
shift f6
Mats
@Matsv
Mar 22 2016 15:59
^
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 16:02
Fixed, just need to add descriptions ;)
Is boss bar two words?
Myles
@MylesIsCool
Mar 22 2016 16:07
yeah
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 16:07
And armor stand?
two words as well I guess
Myles
@MylesIsCool
Mar 22 2016 16:09
yh
Myles
@MylesIsCool
Mar 22 2016 16:21
replace word Obtain
with
Get
otherwise looks fine to me
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 16:22
Yeah I just copied the markup from the ViaVersionAPI, should I replace obtain with get there as well>?
Myles
@MylesIsCool
Mar 22 2016 16:22
Yeah I would
Obtain sounds over complex for the fact it's a getter
Mats
@Matsv
Mar 22 2016 16:23
Is this not just a overloaded server?
MylesIsCool/ViaVersion#262
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 16:25
Yeah but it is really strange people are reporting this issue since just a few versions
Mats
@Matsv
Mar 22 2016 16:25
Oh I only heard this issue from this guy
But 100+ online with bad-optimized plugins is even without viaversion pretty laggy
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 16:27
Yeah this alexmarkey reported #251 , and says the lag is caused by ViaVersion
Myles
@MylesIsCool
Mar 22 2016 16:27
Him and alex are reporting mem leaks
just nobody has debugged them yet.
did L4BORG ever say what server he was with
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 16:31
You mean what network?
Myles
@MylesIsCool
Mar 22 2016 16:34
Same thing
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 16:34
Hmm guess not, shows nothing on his spigotmc profile
Troctor
@Troctor
Mar 22 2016 16:34
@MylesIsCool no update from the profile for you, my computer did a random automatic restart over the night
hasn't crashed since
Myles
@MylesIsCool
Mar 22 2016 16:35
Cheers man @Troctor
Troctor
@Troctor
Mar 22 2016 16:35
I'll let you know once the profiler turns something up
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 17:49
When are we going to make the apiv2 the main branch? Because if you want to fix bugs right now you would have to do fix them twice
Myles
@MylesIsCool
Mar 22 2016 17:49
in 10 lemons
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 17:49
Thanks for the clarification ;)
Myles
@MylesIsCool
Mar 22 2016 17:51
ikr
my issue is, I don't want to push until I know it's stabled
have you tested it locally
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 17:51
Not yet to be honest, will do some testing on my own server
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 17:58
Lol it doesn't even work xd
The only problem is, we can't see where the error is coming from with the apiv2
Myles
@MylesIsCool
Mar 22 2016 18:05
It does to some extent tell you the error
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 18:05
Yeah but only what type failed to read/write
Myles
@MylesIsCool
Mar 22 2016 18:06
So what's your error?
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 18:06
Not the actual packet what failed, you'd have to enable debug mode for that
IndexOutOfBoundsException, the casual xd
Myles
@MylesIsCool
Mar 22 2016 18:07
that doesn't look related to viaver
oh
yeah
i see
it's a long stack
The reason it doesn't tell you is because it doesn't know
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 18:09
Yeah I know
The remappers are only defined in EntityPackets, it doesn't run through entitypackets each time
Myles
@MylesIsCool
Mar 22 2016 18:10
I'll look into how this could be better when I'm back for dinner
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 18:20
It is caused by a packet with id 17, but according to the debug a packet with ID 17 has never been sent?
Nevermind, I think I needed to convert to hex ;)
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 18:26
Found the error ;) It was with the spawn experience orb
Yeah it is fixed :D
Myles
@MylesIsCool
Mar 22 2016 18:31
Time to work on making errors better and useful
wooo
Did you PR the fix to the issue
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 18:32
Yeah :D
Myles
@MylesIsCool
Mar 22 2016 18:32
;)
under 60s
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 18:33
:D ultimate team work ;)
You merged so fast travis failed :(
Myles
@MylesIsCool
Mar 22 2016 18:34
cries
Myles
@MylesIsCool
Mar 22 2016 19:01
anything about that massive array @HugoDaBosss ?
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 19:05
Well I looked at the code, but couldn't find an issue with the code...
We only access the soundeffects at the soundeffect packet in outgoingtransformer right?
SoundEffect could be way more optimised though if we used a map, it searches all values now
Myles
@MylesIsCool
Mar 22 2016 19:12
yep it could be ;)
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 19:15
Created PR to remove some debug code
Myles
@MylesIsCool
Mar 22 2016 19:17
grumble grumble
I have it removed locally grumble syncing
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 19:19
Created another PR for SoundEffect :D
Myles
@MylesIsCool
Mar 22 2016 19:27
laughs mwahaha
oops
I just pushed debug code
my bad
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 19:28
Hahahah as long as it's not on spigot it's okay ;)
Myles
@MylesIsCool
Mar 22 2016 19:28
The new informative exceptions are here
they inform you about packet read / write issues yay
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 19:28
Yeah :D Let me test them ;)
Myles
@MylesIsCool
Mar 22 2016 19:29
Hence the reason I pushed broken code haha
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 19:30
Hahaha why did you change it back to int ;) Or did you not yet sync?
Myles
@MylesIsCool
Mar 22 2016 19:30
That was the test i was doing
lol
which i then fixed >>
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 19:32
But I gtg now, I actually needed to learn for a french test which I have tomorrow ;) Just 'wasted' 5 hours on this stupid stupid project xd
Myles
@MylesIsCool
Mar 22 2016 19:33
wooow savage :) gl
Myles
@MylesIsCool
Mar 22 2016 22:12
is hugo alive :O
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:13
Always ;)
French is just an illussiooonnn woosh
Myles
@MylesIsCool
Mar 22 2016 22:14
i'm wondering when apiv2 should be pushed rubs beard
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:14
in 8 lemons I guess now :D
Myles
@MylesIsCool
Mar 22 2016 22:15
wow, I just wanna be sure that it doesn't remove any functionality
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:15
Yeah we should do a full comparison next to each other, the master and apiv2
And probably state on spigot that this is a testing release, to expect bugs
But I tested it on my own server, my testing server and that RPG server, didn't found any bugs yet
And by the way, shouldn't we release versions on Github as well? Or is that maybe too much if we already have spigotmc
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:21
We can use the apiv2 as the 'initial' release 1.0.0, and maybe release b1.0.0 as an apiv2 test? And push 1.0.0 a few days after
But b1.0.0 would break version checking I guess xd
Myles
@MylesIsCool
Mar 22 2016 22:22
or just like 0.7 lel
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:22
Yeah that would work as well, but don't you think we should do a 1.0.0 release soon?
Or do we keep incrementing by 0.0.1 ;)
Myles
@MylesIsCool
Mar 22 2016 22:23
1.0.0 is when there is no bugs
hahahaahahhaha cries
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:24
Okay, sounds reasonable ;) Guess we need a lot of 0.9.9.x.x.x releases then xd
Myles
@MylesIsCool
Mar 22 2016 22:24
ofc
0.7.1.0.0.0.1
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:25
Btw, to implement the new config here, do I just remove the whole plugin field?
https://github.com/MylesIsCool/ViaVersion/blob/apiv2/src/main/java/us/myles/ViaVersion/update/UpdateListener.java Or do I just change it to plugin.getConfig().isCheckForUpdates()?
So plugin.isCheckForUpdates() or ViaVersion.getConfig().isCheckForUpdates()?
Myles
@MylesIsCool
Mar 22 2016 22:26
I'd do that yeah
:)
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:26
Ah nvm, we need plugin as an argument in the UpdateUtil, I will just change to plugin.isCheckForUpdates()
gives 2 options "I'd do that yeah" ;)
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 22:38
Created PR @MylesIsCool
Nevermind, there are 2 different set compression packets, ignore ;)
Myles
@MylesIsCool
Mar 22 2016 23:24
It changed with what state it's in
Also thanks for the PRs @HugoDaBosss
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 23:28
HugoDaBosss/ViaVersion@9c5c181 What do you think of this?
Did you forgot to write the item stack again?
Myles
@MylesIsCool
Mar 22 2016 23:29
not needed
;)
The stack is a reference in the PacketWrapper
therefore the rewriter just updates the reference
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 23:30
Ahhh, okay ;)
But you are sure the login set compression packet is handled right? Then it's fine
Myles
@MylesIsCool
Mar 22 2016 23:30
You can do that and I mean possibly looks better that way but it's fine otherwise :)
Of course, well I have not tested with bungee
rolls eyes
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 23:31
We should keep a todo list xd
Myles
@MylesIsCool
Mar 22 2016 23:32
I use //TODO comments most of the time
when it's in the code haha
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 23:40
Shouldn't we keep a list of window types by ID instead of only the current open window? I feel like it would be more failproof ;)
Myles
@MylesIsCool
Mar 22 2016 23:41
the IDs mean nothing?
They increment for a new window, nothing else :(
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 23:42
So everytime you open the same window again you'd have a new id?
Myles
@MylesIsCool
Mar 22 2016 23:42
essentially yeah
you can test it out if you want :P
Hugo Kerstens
@HugoDaBosss
Mar 22 2016 23:43
Yeah I just shut down my pc... Time to sleep ;)
Will test it tomorrow!
Myles
@MylesIsCool
Mar 22 2016 23:44
Haha :)