These are chat archives for MylesIsCool/ViaVersion

23rd
Mar 2016
Troctor
@Troctor
Mar 23 2016 10:01
@MylesIsCool
Got results.
CraftAsyncDebugger
initialized by us.myles.ViaVersion.ViaVersionPlugin
class us.myles.ViaVersion.VialdleThread
"Couldn't find player idle packet, help!"
There's a memory leak in the UTF-8 content in there
There's billions of instances
Myles
@MylesIsCool
Mar 23 2016 10:11
Does it echo to your console saying that?
Troctor
@Troctor
Mar 23 2016 10:11
not sure, the other guy i work with caught it
was sleeping :X
Myles
@MylesIsCool
Mar 23 2016 10:12
It seems very odd if that is the memory leak
Troctor
@Troctor
Mar 23 2016 10:12
well
considering there are 2000 idle threads
i'd assume it is
:X
"2000 craft scheduler threads"
Myles
@MylesIsCool
Mar 23 2016 10:15
They might not necessarily belong to ViaVersion
ViaIdle only gets registered once during enabling it
Troctor
@Troctor
Mar 23 2016 10:15
well they're all started by viaversion
CraftAsyncDebugger
initialized by us.myles.ViaVersion.ViaVersionPlugin
Myles
@MylesIsCool
Mar 23 2016 10:16
Essentially i need you to replicate that issue with debug mode on
Troctor
@Troctor
Mar 23 2016 10:16
it'll occur again, ill turn it on.
Myles
@MylesIsCool
Mar 23 2016 10:17
For some reason it fails to find the packet to send to simulate flying and due to it printing the error out bukkit handles that async or something :S
Troctor
@Troctor
Mar 23 2016 10:24
it might not be a memory leak
do you spawn async threads or use the async scheduler anywhere?
Myles
@MylesIsCool
Mar 23 2016 10:25
I believe ViaIdleThread is the only closest thing
I just noticed how we could hugely optimise ViaIdleThread ;
;)
Troctor
@Troctor
Mar 23 2016 10:26
ill join you in looking
Myles
@MylesIsCool
Mar 23 2016 10:27
Are you using anything funny server version wise?
Troctor
@Troctor
Mar 23 2016 10:27
standard spigot 1.8.7
1.8.8*
direct from buildtools
Myles
@MylesIsCool
Mar 23 2016 10:28
Ah sounds fine
Troctor
@Troctor
Mar 23 2016 10:28
We build it on our jenkins server, would you like the specific jar?
Myles
@MylesIsCool
Mar 23 2016 10:30
Nah it's fine haha :)
Troctor
@Troctor
Mar 23 2016 10:38
also myles
it only occurs when players are on
the crash
Myles
@MylesIsCool
Mar 23 2016 10:41
Well it would be like that cause the code only runs if there's players on ;)
Troctor
@Troctor
Mar 23 2016 10:41
I also have a heapdump
from it
lemme get it
Renual
@Renual1337
Mar 23 2016 11:09
Hello
Mats
@Matsv
Mar 23 2016 11:09
Hi
Renual
@Renual1337
Mar 23 2016 11:09
Hello
Is Myles here?
Troctor
@Troctor
Mar 23 2016 11:10
This message was deleted
Renual
@Renual1337
Mar 23 2016 11:10
@MylesIsCool
Myles
@MylesIsCool
Mar 23 2016 12:02
Yes, @Renual1337
Renual
@Renual1337
Mar 23 2016 12:15
Yo dude
Mats
@Matsv
Mar 23 2016 12:31
Almost 5000 total downloads :D
Renual
@Renual1337
Mar 23 2016 12:32
Cool cool.
lenis0012
@lenis0012
Mar 23 2016 18:44
nice guys
i finished my profile assignment :)
any bugs that need to be slain?
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 18:46
Well you can compare apiv2 with master, and check if any functionalities are missing in apiv2
And check if packets are transformed the same etc
Myles
@MylesIsCool
Mar 23 2016 18:48
Well if you wanna test apiv2 it's appreciated as well :) (on smaller servers ofc)
lenis0012
@lenis0012
Mar 23 2016 18:49
why don't you write a junit test?
Myles
@MylesIsCool
Mar 23 2016 18:49
well i'd have to write a test for every packet ;)?
lenis0012
@lenis0012
Mar 23 2016 18:49
no
you have to write a packet parser that creates packet via api1
and also on api2
then compared their fields
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 18:50
Yeah but how are we going to create those packest?
We need input, just using it on a server is way easier
lenis0012
@lenis0012
Mar 23 2016 18:50
json file with sample packets
create it by running it in bukkit
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 18:51
Well if you want to create something like that it is appreciated ;)
lenis0012
@lenis0012
Mar 23 2016 19:04
sure
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:23
Just an idea, but I think we need to finish apiv2 before 1.9.1 comes out. Then we can support 1.9.1 voor spigot 1.9 servers, and I guess there will be quite some demand for that
Myles
@MylesIsCool
Mar 23 2016 20:24
It's just testing rn
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:24
We don't have support for spigot1.9 right now do we?
Wow nice :D
Myles
@MylesIsCool
Mar 23 2016 20:24
we do
on apiv2
lenis0012
@lenis0012
Mar 23 2016 20:24
hugo
Mats
@Matsv
Mar 23 2016 20:24
'then we can support 1.9.1 voor spigot 1.9' blame the dutch language :P
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:24
Oh nice :D Never looked at the server injector there ;)
lenis0012
@lenis0012
Mar 23 2016 20:24
support 1.9.1 voor spigot 1.9?
lol
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:25
Hahahah sssttt @Matsv ;)
Yeah 1.9.1 will have a new protocol
lenis0012
@lenis0012
Mar 23 2016 20:25
well
Myles
@MylesIsCool
Mar 23 2016 20:25
new protocol
lenis0012
@lenis0012
Mar 23 2016 20:25
dutch guys are just really smart
;)
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:25
Just one small change, but you will be unable to join
Mats
@Matsv
Mar 23 2016 20:25
Yeah Myles why aren't you Dutch
lenis0012
@lenis0012
Mar 23 2016 20:25
born in the right country
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:26
You're from the US right @lenis0012 ? Or am I totally wrong xd
Myles
@MylesIsCool
Mar 23 2016 20:26
cause i'm british ;)
lenis0012
@lenis0012
Mar 23 2016 20:29
nah I'm from the netherlands
but my brain is english
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:29
Wooohh hype :D
lenis0012
@lenis0012
Mar 23 2016 20:29
I don't even think in my native language anymore
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 20:30
Well as long as those dutch genes are in your blood everything is fine ;)
Myles
@MylesIsCool
Mar 23 2016 21:51
Apologies for not much dev today, I found an exploit in Minecraft server code which can cause huge issues for servers and been in talks with Mojang Devs, Md_5, and some big servers.
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 22:26
Wow, that sounds important :innocent:
MylesIsCool/ViaVersion#271 Probably not so important ;)
Myles
@MylesIsCool
Mar 23 2016 22:29
do you own aac
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 22:29
Bought it for my own server ;) Just now
Myles
@MylesIsCool
Mar 23 2016 22:29
wow
savage
im sure you can patch it since you own it yourself
Hugo Kerstens
@HugoDaBosss
Mar 23 2016 22:31
Yeah they are probably sending wrong packets, but I'll check
Bought it mainly to replace NCP, as is sucks, but using it for testing with ViaVersion is a nice bonus ;)