These are chat archives for MylesIsCool/ViaVersion

7th
May 2016
Andrew Tran
@xXAndrew28Xx
May 07 2016 20:58
@MylesIsCool , the playerinteractevent firing twice is a deal breaker for me :P
Mats
@Matsv
May 07 2016 21:12
@xXAndrew28Xx im going to take a look at it tomorrow to see if there is a proper fix without breaking other stuff like chests.
Myles
@MylesIsCool
May 07 2016 22:02
I understand it can be an issue, I've spent hours on it before attempting to find a good patch for it and could not without breaking vanilla behaviour. I currently don't have the time to put into it, hence my openness with saying if anyone finds a fix it's cool. It's a very complicated issue.
Faizaan
@SirFaizdat
May 07 2016 22:07

@xXAndrew28Xx A quick and extremely dirty fix is, if it is firing twice every time, to just toggle a boolean and so the event handler will only respond when that boolean is true. Always toggle it.

I know this is dirty and is depends on unintended behavior, but at least it's something until a fix is found.

Myles
@MylesIsCool
May 07 2016 22:10
I have a friend who simply just patched the event not to fire if in the same tick, (50ms). Which I suppose you could use, but that is hacky. The issue with the problem is the changes and the new "use item" packet. :)
ridalarry
@ridalarry
May 07 2016 23:33
this plugin is not getting any updates since may 4 and it use to have daily updates if not public it will be snapshots did it discontinue? as I see there are 11 issues not fixed too
Mats
@Matsv
May 07 2016 23:34
Busy times ;)
ridalarry
@ridalarry
May 07 2016 23:35
oh
Faizaan
@SirFaizdat
May 07 2016 23:35
(i.e. it's not discontinued at all)
ridalarry
@ridalarry
May 07 2016 23:35
is there anything new with the boats or the click event being happening twice?
Faizaan
@SirFaizdat
May 07 2016 23:36
Click event: "I understand it can be an issue, I've spent hours on it before attempting to find a good patch for it and could not without breaking vanilla behaviour. I currently don't have the time to put into it, hence my openness with saying if anyone finds a fix it's cool. It's a very complicated issue." - MylesIsCool at 18:04
ridalarry
@ridalarry
May 07 2016 23:36
I know I saw that
but someone said he/she found a dirty fix
I think it was you
Faizaan
@SirFaizdat
May 07 2016 23:37
It's a dirty temporary fix for API users, not a fix for ViaVersion itself (while we wait for a proper fix to be made to ViaVersion)
ridalarry
@ridalarry
May 07 2016 23:37
oh
Mats
@Matsv
May 07 2016 23:38
About boats sync, I tried many different things, but so far I couldn't find anything without any of the version having disadvantages
ridalarry
@ridalarry
May 07 2016 23:39
there is a fix that myles mentioned that it would break chests, can it work to check if its a chest or not. If its a chest work normally if it isnt then use the fix
Mats
@Matsv
May 07 2016 23:40
Just broke every block that had some kind of right click action, buttons, furnaces etc
ridalarry
@ridalarry
May 07 2016 23:40
oh
for the boats is it speed related or anti hacks related? or both?
Mats
@Matsv
May 07 2016 23:40
I'm afraid some kind of fix like that would break more things than fix things
Well if I would implement the new vehicle move packet, we'd have to do the anticheat, because we are changing the position directly. And that'd give 1.9 players advantages because it's faster
ridalarry
@ridalarry
May 07 2016 23:42
is it possible to allow use the boat fix with a comment in config that it would be faster for 1.9 users?
that option can be disabled by default
as its better than 1.9 users cant use boats at all
Faizaan
@SirFaizdat
May 07 2016 23:42
That is true
Mats
@Matsv
May 07 2016 23:43
The anticheat plugins will probably freak out, but I'll give it a try
ridalarry
@ridalarry
May 07 2016 23:44
most anti cheat plugins have an option to disable or change the velocity
Faizaan
@SirFaizdat
May 07 2016 23:44
Users would have to use the correct velocity though, which would need to be listed somewhere
Perhaps that could be included in the aforementioned config comment
ridalarry
@ridalarry
May 07 2016 23:45
ya that would work
also I think myles said his friend was able to fix the bug with double click im not sure if he also meant api users
Mats
@Matsv
May 07 2016 23:46
Nah he meant the plugin developers
ridalarry
@ridalarry
May 07 2016 23:46
oh
Mats
@Matsv
May 07 2016 23:46
not a real fix for viaversion
ridalarry
@ridalarry
May 07 2016 23:47
do you think its possible to have a fix or not really?
like canceling 1.9 clients clicks withen 2 ticks
Faizaan
@SirFaizdat
May 07 2016 23:48
Do we know the actual root cause of the event firing twice?
ridalarry
@ridalarry
May 07 2016 23:49
Idk but I think its due to the second hand in 1.9
Mats
@Matsv
May 07 2016 23:49
The thing is, viaversion is a protocol translator, it changes things before bukkit/spigot even handles them in ticks.
@SirFaizdat in 1.9 is a new packet 'use item' that triggers when you use a item, in 1.8 it was all in one packet 'block digging' so viaversion has to translate use item to block digging
Faizaan
@SirFaizdat
May 07 2016 23:50
This one's sticky (surpassing tricky)
Mats
@Matsv
May 07 2016 23:52
I'll take a look tomorrow in the minecraft source to see how both versions handle it
ridalarry
@ridalarry
May 07 2016 23:54
is the double click considered noswing for the anti hacks?
Mats
@Matsv
May 07 2016 23:54
I have no idea tbh
But it's only right click, right?