These are chat archives for MylesIsCool/ViaVersion

23rd
Jun 2016
Mats
@Matsv
Jun 23 2016 00:00
You changed the version to the 1.9 chunk, but are reading the 1.8
Casting it
lenis0012
@lenis0012
Jun 23 2016 00:00
no
Mats
@Matsv
Jun 23 2016 00:00
i mean
lenis0012
@lenis0012
Jun 23 2016 00:00
i think its the index
im not reading the right int
also i think the packet ids are wrong
@Matsv I wanna read the dimension of the join game packet
Mats
@Matsv
Jun 23 2016 00:03
But the isReadable is also never true on a 1.9 server right? ;)
it never read it before
lenis0012
@lenis0012
Jun 23 2016 00:04
so how do i read it then
Mats
@Matsv
Jun 23 2016 00:04
Oh you meant the other packet
i looked at the chunk one
lenis0012
@lenis0012
Jun 23 2016 00:05
wait
i can just sue .read right?
Mats
@Matsv
Jun 23 2016 00:05
Yeah you can
lenis0012
@lenis0012
Jun 23 2016 00:05
alright trying again
fingers crossed
ffff
Mats
@Matsv
Jun 23 2016 00:06
Any console error?
lenis0012
@lenis0012
Jun 23 2016 00:07
only that the connection was aborted
which is because of that client error
Mats
@Matsv
Jun 23 2016 00:07
Oh and btw
the join game
and respawn
you are reading it with 'get'
but it's never mapped
use pass through
that will also give the object
i use that
Mats
@Matsv
Jun 23 2016 00:10
I think 'read' will not send the value with the final packet
You'd have to write it again, or use int value = wrapper.passThrough(Type.INT)
lenis0012
@lenis0012
Jun 23 2016 00:18
@Matsv I got it
works
Mats
@Matsv
Jun 23 2016 00:19
Nice :)
lenis0012
@lenis0012
Jun 23 2016 00:22
@Matsv i crash after walking around tho
after like 1 minute
Mats
@Matsv
Jun 23 2016 00:23
Same crash?
With the missing entitydata
things
lenis0012
@lenis0012
Jun 23 2016 00:23
its a blockentity crash

Description: Server forgot to send required information to construct BlockEntity

java.lang.RuntimeException: Missing BlockEntity
at bqy.b(SourceFile:162)
at bqu.a(SourceFile:100)
at bqu.run(SourceFile:43)
at java.lang.Thread.run(Thread.java:745)

Mats
@Matsv
Jun 23 2016 00:23
Yeah, what if you place a chest in front of you, log out
log in
lenis0012
@lenis0012
Jun 23 2016 00:24
I can join with a 1.9.2 server now tho
and use up to 1.10 i think
pretty sure thats what myles wanted
@Matsv just crashed but didnt even move
Mats
@Matsv
Jun 23 2016 00:24
Woah, the thunder exploded something really close to me
lenis0012
@lenis0012
Jun 23 2016 00:24
its raining over here too
Netherlands best weather
Mats
@Matsv
Jun 23 2016 00:25
So you crash directly when you login?
lenis0012
@lenis0012
Jun 23 2016 00:25
nope
but after a few seconds
BlockState: minecraft:chest[facing=south]
Block coordinates: World: (555,17,340), Chunk: (at 11,1,4 in 34,21; contains blocks 544,0,336 to 559,255,351), Region: (1,0; contains chunks 32,0 to 63,31, blocks 512,0,0 to 1023,255,511)
Mats
@Matsv
Jun 23 2016 00:25
Oh what block is causing it this time
lenis0012
@lenis0012
Jun 23 2016 00:27
a dungeon probably
lenis0012
@lenis0012
Jun 23 2016 00:36
@Matsv hey mats
what if i check the block type
and if it should have a tile entity
send it along?
Mats
@Matsv
Jun 23 2016 00:38
yeah it's currently doing that in protocol1.9.4to1.9.2 or something like that
lenis0012
@lenis0012
Jun 23 2016 00:39
then why am i getting an error?
Mats
@Matsv
Jun 23 2016 00:40
Try to add a debug message in FakeTileEntity.java, see if it even finds it
lenis0012
@lenis0012
Jun 23 2016 00:42
maybe y and z are not inverted ;)
Mats
@Matsv
Jun 23 2016 00:44
Maybe ;)
lenis0012
@lenis0012
Jun 23 2016 00:45
@Matsv right i fixed it
Mats
@Matsv
Jun 23 2016 00:46
Was it the wrong y and z?
lenis0012
@lenis0012
Jun 23 2016 00:46
nope
it was trying to read the 1_8_to_1_9 chunk
instead of the 1_9_1_2_Chunk
Mats
@Matsv
Jun 23 2016 00:47
Ah
lenis0012
@lenis0012
Jun 23 2016 00:50
gonna pr
Mats
@Matsv
Jun 23 2016 00:50
Alright, you might've broke 1.8
lenis0012
@lenis0012
Jun 23 2016 00:52
?
ill check
it did break 1.8
rip
[02:53:13 WARN]: Caused by: java.io.IOException: Unable to read type Byte, found Short
[02:53:13 WARN]: at us.myles.ViaVersion.api.PacketWrapper.read(PacketWrapper.java:157)
[02:53:13 WARN]: at us.myles.ViaVersion.api.PacketWrapper.passthrough(PacketWrapper.java:194)
[02:53:13 WARN]: at us.myles.ViaVersion.protocols.protocol1_9_3to1_9_1_2.Protocol1_9_3TO1_9_1_2$3$1.handle(Protocol1_9_3TO1_9_1_2.java:121)
wtf
@Matsv maaaattt
Mats
@Matsv
Jun 23 2016 00:58
Did that not change in 1.9.2
lenis0012
@lenis0012
Jun 23 2016 00:58
MAYBE
maybe*
Mats
@Matsv
Jun 23 2016 00:58
from byte to short or something like that
or the other eay
lenis0012
@lenis0012
Jun 23 2016 00:59
@Matsv nope
it was a byte in 1.9 as well
so shouldn't it already be transformed?
o.0
It is transformed I think
lenis0012
@lenis0012
Jun 23 2016 01:00
then shy does it throw an error
lenis0012
@lenis0012
Jun 23 2016 01:04
so
how do i fix it
Mats
@Matsv
Jun 23 2016 01:04
The second one is an unsigned byte
lenis0012
@lenis0012
Jun 23 2016 01:04
it gives an error when reading that byte ;s
oh
thats taken seperately
ooooooh
thats really cool :o
[03:06:01 WARN]: io.netty.handler.codec.EncoderException: java.lang.ClassCastException: us.myles.ViaVersion.protocols.protocol1_9to1_8.chunks.Chunk1_9to1_8 cannot be cast to us.myles.ViaVersion.protocols.protocol1_9_3to1_9_1_2.Chunk1_9_1_2
Mats
@Matsv
Jun 23 2016 01:08
Rip
how does your code look like now
lenis0012
@lenis0012
Jun 23 2016 01:08
whaaat
Mats
@Matsv
Jun 23 2016 01:08
It's probably checking the object instead of the class types somewhere
Mats
@Matsv
Jun 23 2016 01:10
Make sure both classes override the getBaseClass method to the same location
oh and the if () else statement can also go
it was a temp fix to not explode 1.9 - 1.9.2 servers
lenis0012
@lenis0012
Jun 23 2016 01:10
so the entire else statement
can go?
Mats
@Matsv
Jun 23 2016 01:11
Yes
lenis0012
@lenis0012
Jun 23 2016 01:13
hmm
i think
we already have a chunk object
right
so it needs seperate handling
Mats
@Matsv
Jun 23 2016 01:14
it's both implementing Chunk right?
lenis0012
@lenis0012
Jun 23 2016 01:17
yea
Mats
@Matsv
Jun 23 2016 01:18
You should probably make some methods that you need for the chunk rewriter
and cast the read to chunk instead of one of the versions
I'm sorry, I'm going to sleep now
if you can't get it working, you can create a wip PR :)
lenis0012
@lenis0012
Jun 23 2016 01:22
im also going in a bit
so idk
Mats
@Matsv
Jun 23 2016 01:22
Alright! Have a good night
lenis0012
@lenis0012
Jun 23 2016 02:01
MylesIsCool/ViaVersion#447
I tested it
works on 1.8 and 1.9.2
oh shit
my last change broke it on 1.9.2
Ill fix it tomorrow
just call it a WIP
TitanicFreak
@TitanicFreak
Jun 23 2016 02:10
now I'm glad
that I'm updating my 1.9 servers to 1.9.4
less broken... things.
ridalarry
@ridalarry
Jun 23 2016 04:09
I crash for piston extension
Mats
@Matsv
Jun 23 2016 11:05
Node uses a lot of ram https://fs.matsv.nl/media?id=2gsmpkt
Florian
@sinnlosername
Jun 23 2016 11:17
Hi
Mats
@Matsv
Jun 23 2016 11:20
Hey
lenis0012
@lenis0012
Jun 23 2016 15:17
how do i forcible read the 1.9 chunk
im so confused
Mats
@Matsv
Jun 23 2016 15:18
The 1.9 one reads when the 1.8 is non existent
lenis0012
@lenis0012
Jun 23 2016 15:18
except it doesn't
the isReadable returns false
on 1.9.2
Mats
@Matsv
Jun 23 2016 15:19
so you are basically reading the 1.8 chunks if you are on a 1.8 server
Yeah you shouldn't include that if
lenis0012
@lenis0012
Jun 23 2016 15:19
if i dont include the if
will it read using 1.9?
Mats
@Matsv
Jun 23 2016 15:19
yes
Z609
@Z609
Jun 23 2016 15:20
Hey @Matsv, can you look at #450 ? It's probably something stupid on my part.
Bungeecord is definitely not the problem because I can't even connect before it crashes
Mats
@Matsv
Jun 23 2016 15:22
@Z609 does it crash without protocollib?
Z609
@Z609
Jun 23 2016 15:22
I can try it, let me check
Trying it without ProtocolSupport just to make sure that is actually the problem
lenis0012
@lenis0012
Jun 23 2016 15:23
lol fuck
mc is using the global palette
Z609
@Z609
Jun 23 2016 15:23
Okay, it works without ProtocolSupport. Trying it without ProtocolLib
Mats
@Matsv
Jun 23 2016 15:24
Sup lenis?
lenis0012
@lenis0012
Jun 23 2016 15:24
Apparently
Z609
@Z609
Jun 23 2016 15:24
Works, but lots of buggies
lenis0012
@lenis0012
Jun 23 2016 15:24
vanilla uses the global block palette to send chunks
which is a pain in the ass to read
Z609
@Z609
Jun 23 2016 15:24
Meaning, tablist not working (might be my Bungee version, but I have no idea)
And all my plugins depend on ProtocolLib, so hopefully something can be fixed
Actually, that wasn't the problem
It just closed again, although I was able to connect for a short while.
Mats
@Matsv
Jun 23 2016 15:26
@ridalarry Did you enable the config option for the patch?
That's the full server log without ProtocolLib, it still crashes after a bit. I was able to connect this time, though. Using HexagonMC running MC 1.7 client on 1.8.8 server.
Mats
@Matsv
Jun 23 2016 15:28
You renamed ViaVersion? :(
Z609
@Z609
Jun 23 2016 15:28
Let me try the vanilla version, maybe it's some bs with my version
Maybe it'd help if I was on 0.9.4 too sigh
Mats
@Matsv
Jun 23 2016 15:35
@Z609 you shared the api key from your website in that log, make sure to change it
Z609
@Z609
Jun 23 2016 15:36
Thank you for letting me know
Mats
@Matsv
Jun 23 2016 15:36
I'm unavailable for ~1/2 hours now. Will try to reproduce it after that
Z609
@Z609
Jun 23 2016 15:37
Alright, that's fine :smile:
Z609
@Z609
Jun 23 2016 15:47

This is where the error is happening. Must be something wrong with that Iterator.

http://pastebin.com/aBUVReEn (look for my comment saying "Line 136")

Florian
@sinnlosername
Jun 23 2016 16:13
Everything in java which contains "net" is shitty. ^^
troyfrew
@troyfrew
Jun 23 2016 16:31
@Z609
//if ( org.spigotmc.SpigotConfig.playerShuffle > 0 && MinecraftServer.currentTick % org.spigotmc.SpigotConfig.playerShuffle == 0 )
//{
// Collections.shuffle( this.h );
//}
you can just set player shuffle to 0 in your spigot.yml
Z609
@Z609
Jun 23 2016 16:53
That can't be the problem. playerShuffle is 0 in my spigot.yml.
troyfrew
@troyfrew
Jun 23 2016 16:54
ah. well then the try catch "fixes" it.
Z609
@Z609
Jun 23 2016 16:55
I haven't gotten a custom copy of Spigot yet unfortunately, and I have no idea how to do that. I have cloned it but I don't know where to start, all I have are the patches.
Florian
@sinnlosername
Jun 23 2016 17:53
Hate my life. I've got a nullPointerException without stacktrace since days. D:
Mats
@Matsv
Jun 23 2016 17:53
Enable debug in server.properties
Florian
@sinnlosername
Jun 23 2016 17:54
? O.o
I know in which code "part" the error happens, but not in which line.
Z609
@Z609
Jun 23 2016 18:55
Think I figured out what's disconnecting me now. It might be LibsDisguises, but I have no idea what the issue could be.
Z609
@Z609
Jun 23 2016 19:23
LibsDisguises is the problem, no idea what they're doing when someone joins
Mats
@Matsv
Jun 23 2016 19:23
Do you use the LibsDisguises that's compatible with 1.8?
Z609
@Z609
Jun 23 2016 19:24
Yup.
version 8.6.8
Confirmed not working. Thought it was ProtocolLib and/or my plugins but I don't do that many packets in my plugins onJoin, and it disconnects the player before they can fully load the world.
Doesn't disconnect players higher than 1.7 I believe. Seems to be a 1.7 issue.
Faizaan
@faizaand
Jun 23 2016 20:35
So many problems would vanish if people would update their servers
Mats
@Matsv
Jun 23 2016 20:37
Like what? ;)
Faizaan
@faizaand
Jun 23 2016 20:38
Like plugins having to support multiple versions at a time while accommodating the new features
Which complicates testing and support
Mats
@Matsv
Jun 23 2016 20:39
true true
But some people will stay on 1.8 forever without giving 1.9> a chance sadly.
'PVP SUCKS!!!!!!' 'MOJANG RUINED MINECRAFT!!!!', and if they gave it a chance, it's most of the time not more than 10 minutes
Faizaan
@faizaand
Jun 23 2016 20:43
Mojang should just block 1.8 clients from the auth servers at some point
Gabriele C.
@sgdc3
Jun 23 2016 23:33
@SirFaizdat :+1: :fire:
:clap:
lenis0012
@lenis0012
Jun 23 2016 23:36
that would be the ultimate dick move
I dont think even Microsoft would go that far
they should get people to udpate by making the updates worth it
polar bears and elytra just aren't it