These are chat archives for MylesIsCool/ViaVersion

21st
Aug 2016
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:16
I found a dupe exploit on my server and I have no idea how to fix it .-.
Mats
@Matsv
Aug 21 2016 21:18
@MrPowerGamerBR: So what is the exploit?
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:18
@Matsv but I can't reproduce atm and maybe it is a plugin that I'm using
If you add a item and lapis lazuli to the enchantment table and close the menu, the Item amount becomes the same amount as the lapis lazuli
Example:
If I add 1 diamond and 64 lapis lazulis and then close the menu
It becomes 64 diamonds and 64 lapis
Mats
@Matsv
Aug 21 2016 21:19
Oh that's fun
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:19
And a error is shown in the console
But the error doesn't show WHAT is causing this
Mats
@Matsv
Aug 21 2016 21:19
Rip :(
Tried to remove your plugins one-by-one?
You had like 60 right
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:20
@Matsv 107, but that s isn't the issue, the problem is that I don' t know HOW it starts happening
I restarted my server and I can't do the issue again
[05:34:11] [Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
    at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_101]
    at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_101]
    at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:45) [patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:774) [patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:378) [patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:713) [patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:616) [patched.jar:git-TacoSpigot-"65fd35f"]
    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_101]
Caused by: java.lang.NullPointerException
    at net.minecraft.server.v1_8_R3.ContainerEnchantTable.a(ContainerEnchantTable.java:111) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.ContainerEnchantTable$1.update(ContainerEnchantTable.java:27) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.Slot.f(Slot.java:60) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.Container.clickItem(Container.java:351) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1667) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.PacketPlayInWindowClick.a(SourceFile:31) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.PacketPlayInWindowClick.a(SourceFile:9) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_101]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_101]
    at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) ~[patched.jar:git-TacoSpigot-"65fd35f"]
    ... 5 more
Unless this is a TacoSpigot issue
Mats
@Matsv
Aug 21 2016 21:21
Might be
But are those items ghost items?
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:21
Nope
Mats
@Matsv
Aug 21 2016 21:21
Or is it really registered
Oh that's bad
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:22
And the problem is that it only starts happening after something that I don't know happens
Because I can't duplicate after I restarted my server, but I could 5 minutes before it rebooted
Mats
@Matsv
Aug 21 2016 21:23
Strange :|
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:25
uh...
I think I know what is causing the issue
But I don't know WHY it happens
I think I will just edit TacoSpigot's source to simply do nothing when that error happens
Ok, it seems it is happening when it sends my plugin information to the database
BUT WHY THAT HAPPENS? IT ISN'T EVEN RELATED TO ENCHANTMENTS
Myles
@MylesIsCool
Aug 21 2016 21:29
@MrPowerGamerBR you don't still use protocol support do you
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:29
@MylesIsCool I'm using, but that error still happened even without PS
Mats
@Matsv
Aug 21 2016 21:29
Let's just blame Myles
Myles
@MylesIsCool
Aug 21 2016 21:30
WOW
:'(
try removing half plugins test?
good ol 50 50 magic
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:30
@MylesIsCool if I could simply do that, it would be cool, however I don't know what triggers the issue
Myles
@MylesIsCool
Aug 21 2016 21:31
i'd do that, just copy everything localhost or what
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:31
If only start happens if something that I don't know what it is happens
That's the problem
*It
I think I will just edit TacoSpigot's source, maybe it is easier than trying to pinpoint what is the issue (because I just can't find it)
There is a bug about that in Spigot tho: https://hub.spigotmc.org/jira/browse/SPIGOT-2434
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:44
YEAH I FOUND WHAT CAUSES THE ISSUE
Myles
@MylesIsCool
Aug 21 2016 21:44
is it me
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:45
e.getWhoClicked().openEnchanting(e.getWhoClicked().getLocation(), true);
I think it is this
I couldn't dupe it like 100%
But it dupes 1 item
Example:
If I add a diamond and lapis lazuli to a enchantment table
If I close the menu it returns 2 diamonds
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 21:55
I will try with PaperSpigot
(Also happens with PaperSpigot)
Mats
@Matsv
Aug 21 2016 22:03
And normal spigot?
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 22:04
@Matsv I think it also happens
Because the bug report I shared is about passing a null value
And I'm passing a location, but in that location there isn't a Enchantment Table
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 22:23
Yep, found how to reproduce:
If you stand above the Enchantment Table, no error happens
If you stand anywhere except above, the error happens and the item is duplicated
This happens with Spigot, PaperSpigot and TacoSpigot. CraftBukkit is unaffected.
Myles
@MylesIsCool
Aug 21 2016 22:27
so where is the error caused
:)
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 22:34
e.getWhoClicked().openEnchanting(e.getWhoClicked().getLocation(), true);
But I will fix straight from the server source because I could also dupe with any Enchantment Table
MrPowerGamerBR
@MrPowerGamerBR
Aug 21 2016 23:22
tbh, while the update to 1.8 may have given me some headaches due to bugs those bugs really can't beat the awesomeness of Armor Stands
Now I spend my time adding armor stands to things
https://i.sli.mg/0z3yd4.png https://i.sli.mg/ZbnKWR.png https://i.sli.mg/R1bQXU.png I really can't stop using Armor Stands, they are awesome. I don't know how I lived in 1.7.10 without Armor Stands.