Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 08 11:07
    putgeminmouth closed #120
  • Jul 05 2018 08:59
    juliendangers edited #107
  • Aug 09 2017 00:09
    theon commented #74
  • Aug 09 2017 00:08
    theon commented #74
  • Jul 26 2017 07:12
    evanbennett closed #115
  • Jul 26 2017 07:11
    evanbennett closed #116
  • May 11 2017 20:59
    chiselwright closed #127
  • May 11 2017 20:54
    Travis lemonlabsuk/scala-uri@2306ee1 (move-nap-to-lemonlabs) passed (5)
  • May 11 2017 20:54
    theon opened #127
  • May 11 2017 20:10
    Travis lemonlabsuk/scala-uri (master) passed (1)
  • May 11 2017 13:12
    briggsw commented #126
  • May 11 2017 07:16
    theon commented #126
  • May 10 2017 18:48
    briggsw opened #126
  • Apr 27 2017 12:45
    redarqas commented #74
  • Jan 26 2017 09:22
    theon commented #123
  • Jan 25 2017 22:46
    druhinsagargoel commented #123
  • Jan 23 2017 20:42
    herriojr commented #122
  • Jan 23 2017 14:58
    marius-carp commented #122
  • Jan 23 2017 08:38
    marius-carp commented #122
  • Jan 16 2017 11:01
    theon commented #113
Ian Forsey
@theon
Welcome to the scala-uri gitter chat room! :D
Anders Brujordet
@brujoand
@theon Perfect timing @theon :) #91
I was almost done moving us away from the horrid java.net.URI with all the extra hacks we needed. Using paramMap was the last thing on my todolist
Anders Brujordet
@brujoand
As far as I can tell it's impossible to prevent non-ascii letters to be percent encoded. such as "åøæ". Is this correct?
Anders Brujordet
@brujoand
scala> parse("http://theon.github,com/scala-uri?param1=1&param2=2").toURI
res20: java.net.URI = http://theon.github,com/scala-uri?param1=1&param2=2
shouldn't this fail?
@theon
Ian Forsey
@theon
Hi!
Sorry for not replying before
Hmmm
res3: Option[String] = Some(theon.github,com)
Uri.parse("http://theon.github,com/scala-uri?param1=1&param2=2").host
res3: Option[String] = Some(theon.github,com)
I imagine commas are illegal in hostnames?
not sure?
if so we should fix that
Anders Brujordet
@brujoand
From what I can tell the comma in a hostname is not allowed, and if that's true I think this should result in an exception. Or maybe the toURI would be better of returning an option/disjunction. I'm usually a fan of "fail early". But in this case one might not even be interested in the hostname, but maybe just the query. So it's not really a failure until a URI or host is requested.

ah, yeah. Wikipedia agrees at the least.

"The Internet standards (Requests for Comments) for protocols mandate that component hostname labels may contain only the ASCII letters 'a' through 'z' (in a case-insensitive manner), the digits '0' through '9', and the hyphen ('-'). The original specification of hostnames in RFC 952, mandated that labels could not start with a digit or with a hyphen, and must not end with a hyphen. However, a subsequent specification (RFC 1123) permitted hostname labels to start with digits. No other symbols, punctuation characters, or white space are permitted." http://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names