I was almost done moving us away from the horrid java.net.URI with all the extra hacks we needed. Using paramMap was the last thing on my todolist
shouldn't this fail?
@theon
Sorry for not replying before
Hmmm
res3: Option[String] = Some(theon.github,com)Uri.parse("http://theon.github,com/scala-uri?param1=1¶m2=2").host
res3: Option[String] = Some(theon.github,com)
I imagine commas are illegal in hostnames?
not sure?
if so we should fix that
From what I can tell the comma in a hostname is not allowed, and if that's true I think this should result in an exception. Or maybe the toURI would be better of returning an option/disjunction. I'm usually a fan of "fail early". But in this case one might not even be interested in the hostname, but maybe just the query. So it's not really a failure until a URI or host is requested.
ah, yeah. Wikipedia agrees at the least.
"The Internet standards (Requests for Comments) for protocols mandate that component hostname labels may contain only the ASCII letters 'a' through 'z' (in a case-insensitive manner), the digits '0' through '9', and the hyphen ('-'). The original specification of hostnames in RFC 952, mandated that labels could not start with a digit or with a hyphen, and must not end with a hyphen. However, a subsequent specification (RFC 1123) permitted hostname labels to start with digits. No other symbols, punctuation characters, or white space are permitted." http://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names