These are chat archives for Nethereum/Nethereum

2nd
Aug 2016
Dylan McKendry
@dylanmckendry
Aug 02 2016 00:29
@naddison36 https://github.com/Nethereum/Netherum.Maker we don't use it but needed it to build
Dylan McKendry
@dylanmckendry
Aug 02 2016 01:52
Thanks @juanfranblanco
Nick Addison
@naddison36
Aug 02 2016 05:15
Ah, its the Maker DAO. @juanfranblanco why is Nethereum.Maker a dependency of Nethereum? I would have thought it should be the other way around
slothbag
@slothbag
Aug 02 2016 05:23
I'm pretty sure I'm building nethereum without including the maker stuff
Nick Addison
@naddison36
Aug 02 2016 05:25
slothbag
@slothbag
Aug 02 2016 05:29
I use a custom csproj file where I have cherry picked the parts needed to compile nethereum. I pretty sure I did not include the maker stuff and it compiles fine.
Dylan McKendry
@dylanmckendry
Aug 02 2016 05:30
This is for the Portable version, we were building a remote server pulling directly from github
Juan Blanco
@juanfranblanco
Aug 02 2016 05:47
Yes don't pick it if not needed, I just included it originally as it was the basis for mobile wallet tests. Now that standard token is a separate project is not required.
Juan Blanco
@juanfranblanco
Aug 02 2016 06:02
@brendan87 @dylanmckendry this is the new method to verify transactions https://github.com/Nethereum/Nethereum/blob/master/src/Nethereum.Web3.Tests/TransactionSigningTests.cs#L23
Juan Blanco
@juanfranblanco
Aug 02 2016 07:14
ill remove mkr from the next release and make it standalone
I was thinking of deprecating portable as now all the packages are portable... thoughts?
Nick Addison
@naddison36
Aug 02 2016 07:42
Thanks @juanfranblanco for removing mkr
Dylan McKendry
@dylanmckendry
Aug 02 2016 09:40
@juanfranblanco we are just using it so we can reference the csproj as our project is using those. But we could easily have the csproj on our side (possible what @slothbag is doing). Later we will use the nugets just we liked have the Nethereum source :)
So deprecating is fine for us
Juan Blanco
@juanfranblanco
Aug 02 2016 09:42
oh I might keep the portable to have access to all the source.. tooling (vs studio) is still rather painful to work with in the new world. I was thinking in the nuget side
Dylan McKendry
@dylanmckendry
Aug 02 2016 09:43
Yep, that would be fine with us
Juan Blanco
@juanfranblanco
Aug 02 2016 09:44
cool