These are chat archives for Nethereum/Nethereum

1st
May 2017
specifically ShouldRecoverSimple is not returning the expected address
Matt.Tan
@mtbitcoin
May 01 2017 16:48
is the example working?
Juan Blanco
@juanfranblanco
May 01 2017 16:56
Tests have been passing, I'll have a look. This is returning the account formatted.
Matt.Tan
@mtbitcoin
May 01 2017 17:41
sorry, can you elaborate on "account formatted" ?
i am trying to see if i can verify the same signatures from here https://etherscan.io/verifiedSignatures which were verified with ethereumjs
they don't appear to match
Juan Blanco
@juanfranblanco
May 01 2017 17:42
Checksum
With the geth prefix?
Does ethereumjs implement the same prefix?
I know Aaron / Kumavis has just done something about it.
Matt.Tan
@mtbitcoin
May 01 2017 17:46
yes, its uses the latest version of ethereumjs-tx
which i think has additional stuff added in
i guess this means that they are both not compatible atm?
Juan Blanco
@juanfranblanco
May 01 2017 17:49
Mine was verified with geth, I had to create a custom geth to verify the interpretation of each "string" element. Then that might be used as a pointer for other implementations
Geth is the master, if it has not changed in the latest
Matt.Tan
@mtbitcoin
May 01 2017 17:54
did you test it with geth > 1.5?
Juan Blanco
@juanfranblanco
May 01 2017 17:55
Yeah, not 1.6
Matt.Tan
@mtbitcoin
May 01 2017 17:56
i've tested mine with both myetherwallet and etherchain signature verify.. and i know its compatible with those
Juan Blanco
@juanfranblanco
May 01 2017 17:57
But those do not add the prefix
Do they?
Matt.Tan
@mtbitcoin
May 01 2017 17:57
nope, i don't believe myetherwallets add the prefix
not sure on etherchain
Juan Blanco
@juanfranblanco
May 01 2017 18:03
I have 3 signers, RLP, Ethereum and Message
Message does not have a prefix
Ethereum has the prefix
RLP uses same format as transactions.
Matt.Tan
@mtbitcoin
May 01 2017 18:08
for verifying a raw message signature. I think we are only either using Ethereum or Message.
Juan Blanco
@juanfranblanco
May 01 2017 18:10
Yep, those are the only ones, i added RLP
Matt.Tan
@mtbitcoin
May 01 2017 18:27
thanks juan. i was able to get MessageSigner to work. its without the prefix
Juan Blanco
@juanfranblanco
May 01 2017 18:28
ah cool, was booting pc now to verify (windows 10 update :) )
Matt.Tan
@mtbitcoin
May 01 2017 18:32
which sort of makes sense, because Ethereumjs is used by all client side signers (metamask, myetherwallet)
i think that is what the majority is using.
so only geth > 1.5 includes the prefix right?
Juan Blanco
@juanfranblanco
May 01 2017 18:34
yeah
but it was done for security, to avoid users being tricked to sign something blank
Matt.Tan
@mtbitcoin
May 01 2017 18:36
what is the security issue for signing something blank?
Juan Blanco
@juanfranblanco
May 01 2017 18:38
let me find the discussion
Matt.Tan
@mtbitcoin
May 01 2017 18:42
i am not sure if i have said this before.. but Nethereum rocks!
:-)
Juan Blanco
@juanfranblanco
May 01 2017 18:42
lol thanks :D
Juan Blanco
@juanfranblanco
May 01 2017 18:48
ethereum/go-ethereum#2940
here is the thread ^^
Juan Blanco
@juanfranblanco
May 01 2017 18:55
@mtbitcoin if you do in geth
personal.ecRecover(web3.sha3("test"), "0x0976a177078198a261faf206287b8bb93ebb233347ab09a57c8691733f5772f67f398084b30fc6379ffee2cc72d510fd0f8a7ac2ee0162b95dc5d61146b40ffa1c"
you should get
"0x12890d2cce102216644c59dae5baed380d84830c"
which is the same as per
Juan Blanco
@juanfranblanco
May 01 2017 19:16
Actually I think it was you who pointed this out a long time ago !
Bennett-farley
@Bennett-farley
May 01 2017 20:26
What is the extra data field on an ethereum block? I tried googling, but I didn't find anything definitive.