can you reproduce it in Nethereum ? https://github.com/Nethereum/Nethereum.WSLogStreamingUniswapSample
will it be due to the client disconnecting the socket and need to reconnect?
need to do that
I'm using EthNewPendingTransactionObservableSubscription but I'd like to filter on a contract address (Uniswap V2 Router 2). I've tried the following, but it results in no events at all, not even the Uniswap ones:
await subscription.SubscribeAsync(Event<TransferEventDto>.GetEventABI().CreateFilterInput("0x7a250d5630b4cf539739df2c5dacb4c659f2488d"));Is it possible to do this? Or, even better, can I just subscribe to pending transactions on the Uniswap contract instead?
@juanfranblanco Hey sorry for taking so long to get back to you! I tested your repo (uniswap pubsub) on my laptop (macbook) and it didn't work.....
BUT, I uploaded code on a ubunu server that I have and it worked there! So I think I need to update my dotnet version on my macbook or something... Thanks for helping out!
BUT, I uploaded code on a ubunu server that I have and it worked there! So I think I need to update my dotnet version on my macbook or something... Thanks for helping out!
@cesarsld great (ish) let me know if you fix it in your mac
anyone here using Nethereum + Unity? I wrote an article about it. I’d love to get some feedback https://medium.com/coinmonks/part-1-using-nethereum-in-unity-54e62f7e65d5
@juanfranblanco Do you see any problems in the below code?
var ethSwapHandler = web3.Eth.GetContractTransactionHandler<SwapExactETHForTokensFunction>();
var ethSwapDTO = new SwapExactETHForTokensFunction
{
AmountToSend = Web3.Convert.ToWei(wethToTrade), // wethToTrade = 1
AmountOutMin = Web3.Convert.ToWei(amountOutMin), // amountOutMin = 7.25
Path = path,
To = myWallet,
Deadline = ((DateTimeOffset)DateTime.Now).ToUnixTimeSeconds() + 1200,
GasPrice = Web3.Convert.ToWei(gasPriceToUse, UnitConversion.EthUnit.Gwei), // gasPriceToUse = 300 (taken from Etherscan + 200)
Gas = Web3.Convert.ToWei(400000)
};
var transactionEthSwapReceipt = await ethSwapHandler.SendRequestAndWaitForReceiptAsync(uniswapContractAddress, ethSwapDTO);I wasn't converting the amountOutMin & Gas amounts to Wei before. Could that be the reason for getting the 'insufficient funds for gas * price' error?
we have discussed this many years ago, it it truly did not make any sense
there was an effort to so compile at the time to convert to IL to EVM opcodes, and others to transpile.. both truly don't make any sense as you will prefer Solidity anytime as it advances much faster and is closer to the chain. Also the reuse of smart contract logic, best practices etc it is best done in Solidity.
Now having a top layer that might protect you from common solidity mistakes might have been "good" but truly it wont give you much of an advantage
what requirements you had in mind?
@juanfranblanco Thanks. The swaps work on mainnet now. I have a question regarding Uniswap trades for you - When trading is paused / disabled for a token on Uniswap (by the token creators), one can see a 'UniswapV2: TRANSFER_FAILED. There is an error with one of the tokens you are trading' error message pop up on the UI as soon as you hit the 'SWAP' button. What check might this be making to figure out that the token trade is paused? I tried swaps for a token that had its trading paused by the token devs and ended up submitting a few transactions to the blockchain which all failed due to the same error, but they cost gas! The Uniswap frontend is able to figure this out without spending gas, is there any READ function on the router / factory that allows this kind of query? I will post this question to Uniswap as well, but I thought you might already know the solution. :)
@juanfranblanco Hello Juan, when I'm compiling to Android APK by Unity, Google Play requests IL2CPP backend with ARM64. However, when I test it on phone, all the Ethereum codes are just not working, strangely I don't see any error message. By the way I already disabled "Strip engine code" option, so do you probably know what happened?
If I change to Mono backend, everything is fine.
the same for webgl
Not sure if it's AOT
Can you distinguish?
the aot is linked to that specific version of json.net
@juanfranblanco Sure. This one (0xB244AC0F3ee2E9caE5dfdde5DaB8d49FA467E1A9) recently 'paused/didn't allow trading' for 20 minutes after they added liquidity to Uniswap. And so did this one (0x691ACE5e56507C008d836c8c58ed93546bDc81fF).
Uniswap shows this message as soon as you try to hit the SWAP button when trading is paused - 'The transaction cannot succeed due to error: UniswapV2: TRANSFER_FAILED. This is probably an issue with one of the tokens you are swapping.'
Uniswap shows this message as soon as you try to hit the SWAP button when trading is paused - 'The transaction cannot succeed due to error: UniswapV2: TRANSFER_FAILED. This is probably an issue with one of the tokens you are swapping.'
@notBehemoth_twitter only thing i can think of is this https://github.com/Uniswap/uniswap-v2-core/blob/1f563ce23b6dbe972d667c79058d0299e6f10ff6/contracts/UniswapV2Pair.sol#L44
what you can do is make a query beforehand (same parameters) and check for the error output this will be handled by Nethereum if an error occurs
@juanfranblanco Can you help me create the syntax for the query? This is the swap code that I use currently -
var wethSwapHandler = web3.Eth.GetContractTransactionHandler<SwapExactTokensForTokensFunction>();
var wethSwapDTO = new SwapExactTokensForTokensFunction
{
AmountIn = Web3.Convert.ToWei(wethToTrade),
AmountOutMin = amountOutMinInWei,
Path = path,
To = myWallet,
Deadline = ((DateTimeOffset)DateTime.Now).ToUnixTimeSeconds() + 1200,
GasPrice = Web3.Convert.ToWei(gasPriceToUse, UnitConversion.EthUnit.Gwei),
Gas = 400000
};
var transactionWethSwapReceipt = await wethSwapHandler.SendRequestAndWaitForReceiptAsync(uniswapContractAddress, wethSwapDTO);
if (transactionWethSwapReceipt.Status.Value == 1)
{
var wethSwapEventOutput = transactionWethSwapReceipt.DecodeAllEvents<TransferEventDTO>();
if (wethSwapEventOutput.Any() && wethSwapEventOutput.Last()?.Event?.Value != null)I think I need to use 'QueryDeserializingToObjectAsync' method but I dont know what output DTO to use for this. Also, how to check for the error output? Thanks for all the help :)
it returns an array of amounts so that will be a List<BigInteger>
if it errors (reverts) then it will attempt to deserialise the error and throw an exception
Or, does anyway can make a transaction send from specific Android app?
there is a wallet example too if you want