Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 22 18:59

    brollb on 2888-project-owner-msgs

    (compare)

  • Oct 22 18:59
    brollb closed #2888
  • Oct 22 18:59

    brollb on master

    Route <project>@<owner> message… (compare)

  • Oct 22 18:59
    brollb closed #2889
  • Oct 22 18:48
    brollb labeled #2889
  • Oct 22 18:48
    brollb opened #2889
  • Oct 22 18:48

    brollb on 2888-project-owner-msgs

    Route <project>@<owner> message… (compare)

  • Oct 22 18:47
    brollb opened #2888
  • Oct 17 16:05

    brollb on 2886-proj-id-in-action-reqs

    (compare)

  • Oct 17 16:05
    brollb closed #2886
  • Oct 17 16:05

    brollb on master

    Send project, role ID in action… (compare)

  • Oct 17 16:05
    brollb closed #2887
  • Oct 17 16:02
    brollb opened #2887
  • Oct 17 16:01

    brollb on 2886-proj-id-in-action-reqs

    Update the browser to pass proj… (compare)

  • Oct 17 15:58

    brollb on 2886-proj-id-in-action-reqs

    Pass project, role ID in action… (compare)

  • Oct 17 15:09
    brollb opened #2886
  • Oct 16 20:45

    brollb on 2836-improved-dockerfile

    (compare)

  • Oct 16 20:45
    brollb closed #2851
  • Oct 16 20:45
    brollb commented #2851
  • Oct 13 19:20
    brollb closed #2885
Brian Broll
@brollb
np
I see what you mean
yeah, the static map code won't help you at all for that
Hamid Zare
@hamidzr
thanks i'll check it out
Brian Broll
@brollb
NetsBlox/NetsBlox#990
if you update the struct lib, it should be good to go
Hamid Zare
@hamidzr
I updated that but it only made the examle more complex
Brian Broll
@brollb
you can still use the block for lists of structs - just make sure they are named appropriately and stuff
it shouldn't make it more complex
Hamid Zare
@hamidzr
i used map instead
Brian Broll
@brollb
ok, cool
I think either is fine
well, you could do it 3 ways:
  • map over the primitive
  • loop over primitive
  • create custom block taking a list and mapping over it (like your earlier one)
any are good for the example
I just meant that the prim block (used in either a loop, map block or custom block) should be the one from the library
Hamid Zare
@hamidzr
yup all works
its more consistent now : )
Brian Broll
@brollb
cool, looks good
however, what does it return if it doesn't find anything?
it should return an empty list but it seems like it doesn't
it seems to return a message but this causes it to break when the surrounding code expects a list
Hamid Zare
@hamidzr
that's right in the first version I was returning a string so it would have been alright but not now. changed it to return list unless there is sth wrong with the apli
Api
Brian Broll
@brollb
@hamidzr have you checked out the code climate plugin for chrome? I would recommend checking it out
Hamid Zare
@hamidzr
yup I have it it comes in handy
thanks
Brian Broll
@brollb
@hamidzr I have v0.14.3 ready to be deployed but I am still waiting on some server down time. If worst comes to worst, I can email the users who are logged in about an update and updated it at night
just giving you a heads up about why the fix hasn't been updated on the prod server yet
Hamid Zare
@hamidzr
Yep it is getting crowded in there,
Brian Broll
@brollb
@hamidzr I just back ported the examples back to the dev branch
(just as a heads up)
Hamid Zare
@hamidzr
is that the dev-examples branch ?
*demo-examples
Brian Broll
@brollb
fyi - NetsBlox/NetsBlox#1050
that was what was causing the tests to break
basically the examples endpoint was taking too long to parse the xml
Hamid Zare
@hamidzr
#1050 should come with some performance improvements too, nice
Brian Broll
@brollb
@hamidzr just a heads up - I merged the PR for netsblox.org and updated the deployment
Brian Broll
@brollb
I ran into a number of small bugs that needed fixing so I am going to put the update off until tomorrow so I can make sure there aren't any more surprises
Brian Broll
@brollb
docker image is now available for netsblox and the installation instructions are in the readme
Brian Broll
@brollb
@hamidzr I added a new label "blocking"
if there is a PR that is more important for me to check out, add that label and I will try to check it out right away
Brian Broll
@brollb
here is the line for updating the fully qualified name for the srcId: https://github.com/NetsBlox/NetsBlox/blob/master/src/server/rooms/netsblox-socket.js#L346
in messages
well, that is the fn anyway; that specific line is adding support for sending to a list of roles
I would recommend adding a method like getFullyQualifiedRoleId
or something