Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 24 2019 08:01
    fergarrui commented #9
  • Jun 10 2019 22:39

    AusIV on 0xv2

    Increase order buffer size We'… Merge pull request #165 from No… (compare)

  • Jun 10 2019 22:39
    AusIV closed #165
  • Jun 10 2019 22:35
    AusIV opened #165
  • Jun 10 2019 22:33

    AusIV on bump-ingest-buffer

    Increase order buffer size We'… (compare)

  • Jun 07 2019 03:17

    AusIV on 0xv2

    Kovan block monitor fixes Switching to python block monit… Better error handling in blockm… and 3 more (compare)

  • Jun 07 2019 03:17
    AusIV closed #164
  • Jun 07 2019 03:17
    AusIV opened #164
  • Jun 06 2019 22:33

    AusIV on kovan-blockmonitor

    Publish relay messages in gorou… (compare)

  • Jun 06 2019 20:37

    AusIV on kovan-blockmonitor

    Kovan block monitor: Add rate l… (compare)

  • May 31 2019 19:43

    AusIV on kovan-blockmonitor

    Better error handling in blockm… (compare)

  • May 31 2019 19:15

    AusIV on kovan-blockmonitor

    Switching to python block monit… (compare)

  • May 31 2019 16:27

    AusIV on kovan-blockmonitor

    Kovan block monitor fixes (compare)

  • May 24 2019 13:59

    AusIV on 0xv2

    Docker Compose Cleanup This cl… Merge pull request #163 from No… (compare)

  • May 24 2019 13:59
    AusIV closed #163
  • May 24 2019 13:54
    AusIV opened #163
  • May 24 2019 13:54

    AusIV on docker-compose-cleanup

    Docker Compose Cleanup This cl… (compare)

  • May 13 2019 18:47
    AusIV closed #127
  • Apr 26 2019 15:52

    AusIV on 0xv2

    Add logging information to fill… Merge pull request #162 from No… (compare)

  • Apr 26 2019 15:52
    AusIV closed #162
AusIV
@AusIV
@alejoloaiza - I'm sort of working on this now, but the master branch is going to go away. Moving forward we're going to have a support/0xv1 branch, a support/0xv2 branch, and feature / bugfix branches for other things we're working on. As a 0xv3 or 0xv2.1 starts to make sense, we may spin up corresponding branches, but since we have two branches we actively support in production, the conventional "master" concept is kind of hard to apply.
We will be making support/0xv2 the default branch
@shikar123 - The AWS compose file is horribly outdated, and it will be going away soon. In the early days of OpenRelay, we deployed in AWS using Docker Swarm, which used the compose file. We had some stability issues with Swarm, and ultimately decided that ECS was a better fit. We manage that with CloudFormation stacks, which we haven't open sourced mainly because they're a mess. Once we stop supporting 0xv1, it will be a lot easier to clean up our CloudFormation stacks, and we'll probably publish those too.
In the meantime, I'd be happy to share them on an individual basis if you'd like a look, I just don't really want to publish them.
AusIV
@AusIV
As far as enabling / disabling security tokens based on geolocation - Possibly, but geolocation is pretty easy to circumvent, and the blockchain itself has no way to enforce geolocation. We could refuse securities orders from people in the US, and decline to serve securities orders to people in the US, but as soon as someone outside the US partially fills an order, the order is on the blockchain for all to see, and anyone else could come fill it the rest of the way. Any support for securities tokens will probably have to involve some kind of KYC process and a filtering contract. We probably won't be the ones to drive that, but we're in conversations with some potential partners who are interested in doing KYC while using OpenRelay as a backend.
Alejo L
@alejoloaiza
Hi @AusIV , one question regarding asset_pairs endpoint, I think you have the wrong names for AssetA and B, according to the spec is assetDataA and assetDataB but in the file pairs.go I see assetA and assetB, just check when you have time, thanks.
AusIV
@AusIV
That's possible. The spec moved under me a few times while we were developing. I've got another update I need to push today, so that can go with it.
AusIV
@AusIV
actually, no, we're good on this
if you lok at db/pairs.go, you'll see the MarshalJSON function, which determines how it is presented through the API
Eh, wait
We're good for how we present it to the user, but not the filtering parameter
Alejo L
@alejoloaiza
yeah, I ment the parameters
AusIV
@AusIV
This should be fixed
Alejo L
@alejoloaiza
cool thanks
AusIV
@AusIV
thanks for bringing it to our attention
Alejo L
@alejoloaiza
make sense to me
Alejo L
@alejoloaiza
@AusIV just a quick question, what's the use of assetamount when the asset is a erc721 token, that value should be validated or just ignored? should be validated to 1 or what?
AusIV
@AusIV
We validate that it is 1, but kind of in a round about way. The ERC721 balance checker returns 1 if the user has the specified asset, 0 if they don't
So we make sure that they have the necessary quantity to fill the order, and the only amount they could have is 1.
Alejo L
@alejoloaiza
Hi @AusIV just one doubt, how are you handling signatures with V as 38 or 37 in openrelay?
AusIV
@AusIV
When would it be 37 or 38?
Alejo L
@alejoloaiza
yeah, it's already there, run this code once, it's just some block from today: https://gist.github.com/alejoloaiza/5eec95b8e3dcac1cff448e39134dfc60
AusIV
@AusIV
Transactions can be signed with 38 or 37, but the 0x protocol specification prescribes that orders must be signed with 27 or 28 (see: https://github.com/0xProject/0x-protocol-specification/blob/master/v2/v2-specification.md#eip712). When we handle signing in our widgets toolkit, we check for v < 27 and set v+=27 in that case. I haven't encountered any web3 clients that would set v=37 or 38 for an eth_sign call.
AusIV
@AusIV
FYI, in one week OpenRelay.xyz will start requiring makers agree to our terms of use before we will accepted orders. See: https://blog.openrelay.xyz/terms-of-use/
IK
@devmanio
Hi OpenRelay team, awesome project! Faced with some problems when deploying the relay - tell me if there are developers here, who can help?
AusIV
@AusIV
Hey @devmanio - I was offline when you came by last night, but I'm happy to lend a hand now
Fodé Diop
@diopfode_twitter
Hello all! My name if Fodé and I'm new here. Our team is building on top of OpenRelay.
Fodé Diop
@diopfode_twitter
Good morning @AusIV Do you have any available guides for deploying an OpenRelay node to production?
AusIV
@AusIV
Hey @diopfode_twitter - We don't have much in the way of documentation for deploying OpenRelay to production. If you're interested, I can provide you with the cloudformation templates we use as a reference, but they're a bit messy, which is why we haven't published them.
Depending on your needs, you may be able to just use api.openrelay.xyz rather than hosting your own. We have our affiliates program, and if that doesn't suit your needs we'd be happy to talk with you about a custom pool.
Fodé Diop
@diopfode_twitter
@AusIV Ok got it. Makes total sense to use the affiliate program as well. Thank you for the feedback. Will take it into consideration.
Dr. Michael Commini
@DrSee_twitter
Hi all. I've literally just discovered OpenRelay a few minutes ago. This could be exactly what my students and I are looking for to learn more about relay systems. How do I install an instance of OpenRelay on our own server? I apologize in advance if this has been answered elsewhere. I've been searching but have not found it. Any help you can provide is appreciated.
AusIV
@AusIV

Hi @DrSee_twitter - I saw your message on linked in, but I'd rather have this conversation here for public consumption. OpenRelay is designed to be deployed with Docker across a small cluster of servers (it's small enough to run on a single server - I run it on my laptop quite regularly - but we recommend a cluster for resilience). For development, we provide a docker-compose.yml in the root of our repository. If you have Docker and Docker Compose, you can run docker-compose up and it will build all of the components and launch a local environment using ganache as an Ethereum client. If you set the ETHEREUM_NODE environment variable to point to a Mainnet / Testnet client, all the microservices will point to the client in the environment variable instead of the ganache client that docker-compose creates, so you could point it at a real network.

You could potentially use that in conjunction with Docker Swarm to run a production environment (probably scaling up the number of instances of each service for redundancy), but we had some problems with Docker Swarm in our early days, and opted to run in Amazon's Elastic Container Service instead. We have CloudFormation templates that haven't been polished enough for public consumption, but I'm not opposed to sharing them privately if you're open to potentially working through some issues.

Lastly, depending on your use case, you may be able to use api.openrelay.xyz instead of needing to host your own. We have an affiliates program, and if that doesn't suit your needs we'd be happy to talk with you about a custom pool - which is essentially a customizable orderbook on our shared-tenancy infrastructure.

L. Preston Sego III
@NullVoxPopuli
hi. I just found open relay, looks neat.
are there any open source UIs using this?
AusIV
@AusIV
There are a handful of liquidity aggregators that pull liquidity from our API, but not traditional exchange frontends that I'm aware of.
L. Preston Sego III
@NullVoxPopuli
why is that? I'd expect there to be opensource 0x relays :-\
AusIV
@AusIV
We haven't built it ourselves for a handful of reasons (largely stemming from lack of UI talent in-house). There are a bunch of subcomponents out there (some of which we've built) but I'm not aware of any full open source dex frontends
L. Preston Sego III
@NullVoxPopuli
I can do UIs
:)
AusIV
@AusIV
If you're interested in building something we'd be happy to help with your efforts as we can
L. Preston Sego III
@NullVoxPopuli
is there an open source backend hosted somewhere?
My current side project is https://emberclear.io :)
Would be happy to collab with people on a dex UI
I can even start the project if there is an existing backend I can integrate with
AusIV
@AusIV
api.openrelay.xyz is a publicly hosted version of OpenRelay. It supports mainnet and Kovan
L. Preston Sego III
@NullVoxPopuli
cool
AusIV
@AusIV
I'll need to do some digging, but there are a bunch of components that might be of interest to you
L. Preston Sego III
@NullVoxPopuli
fwiw, I'd want to use Ember, (I do know React really well, as I've been using it professionally for the past 3 years), but ember feels super productive, and super clean. conventions!
AusIV
@AusIV
I quite like ember myself