by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Jody Garnett
    @jodygarnett
    ah sorry, let me check
    you have addressed my feedback
    Torben Barsballe
    @tbarsballe
    :+1: Great, there were a few amgiguous points in there. I’ll merge then
    Jody Garnett
    @jodygarnett
    blog thoughts:
    • do we plan to make a “milestone” or “update our release schedule” ? We do not have a solid answer as to “when” the public can get a copy they can run on Java 11.
    • starting from the two emails, adding section to thank sponsors and osgeo
    • I guess they can download a nightly build?
    Torben Barsballe
    @tbarsballe
    Nightly build is probably the best place to point people for now.
    As for a milestone, so far there is no strong commitment to actually doing one (most people agree we should do one, no one’s actually stepped up an said they’ll do it)
    I would like to get some confirmation on someone willing to do the release before we announce we are doing one
    Jody Garnett
    @jodygarnett
    I am willing to do so, I have some weeks of holiday off
    but would prefer to move the release up early
    ie we have delayed releases before (for java 8)
    in this case it would be good to move forward
    (admitted some of that motivation evaporated with Java 8 collecting different options for “support”)
    Torben Barsballe
    @tbarsballe
    I think a milestone would probably be the better option, last time we changed the actual release schedule it took quite a while to go back to normal
    Jody Garnett
    @jodygarnett
    @tbarsballe updating the spreadsheet to reflect moved classes
    do we still hope to make a SED script or publish this thing?
    for the work done post-sprit I do not see the moves being recorded?
    Torben Barsballe
    @tbarsballe
    Good question. Did we ever determine if a sed script would actually be feasible? (i.e. has anyone tested a minimal case yet). A sed script would be nice, but given the size of the changes is likely going to be a lot of work to do.
    As for the moves, yeah, you’re right. I’ll update everything I’ve moved
    Jody Garnett
    @jodygarnett
    @jnh5y indicated he had experience
    as long as we are matching the full classnames a sed script should be both possible, and get client code 95% of the way there (reflection for example may fail).
    the good news is the most recent changes to gt-complex did not have any affect on the geoserver codebase
    Torben Barsballe
    @tbarsballe
    A couple of the changes I made had minor effects
    Torben Barsballe
    @tbarsballe
    Just had a thought - at current, the nightlies won’t work for Java 11, because the only ones we publish are built on Java 8.
    Jody Garnett
    @jodygarnett
    I thought if we build on Java 8 … it can work on Java 11
    Torben Barsballe
    @tbarsballe
    Maybe, thought there was a reason it couldn’t; I’m verifying now
    Jody Garnett
    @jodygarnett
    It was only the reverse that was not true (ie build on Java 11 the result cannot run on Java 8 because of type narrowing API changes)
    Torben Barsballe
    @tbarsballe
    Yeah, you’re right - just confirmed that the current 2.15.x nightly works fine on Java 11
    I’d got my directions the wrong way around
    Jody Garnett
    @jodygarnett
    so for the spreadsheet - sqlite?
    Torben Barsballe
    @tbarsballe
    Do you know what gt uses spatiallite for
    I don’t, and don’t really know what might break if we drop it
    (I’m currently working on the GS Running Java 11 docs)
    Jody Garnett
    @jodygarnett
    I added a line for the geotools docs and am working on that
    Jody Garnett
    @jodygarnett
    I am having trouble testing locally since I hava GDAL / OGR 1.x on the path which ends up failing geoserver tests
    Torben Barsballe
    @tbarsballe
    Hmm. That shouldn’t fail the tests
    I’ve got GDAL 1.11.1 locally and my GeoServer tests all pass
    Jody Garnett
    @jodygarnett
    I will need to look at it later
    okay geotools docs are added to our branch, for your review?
    back in a couple hours
    Torben Barsballe
    @tbarsballe
    I’ll take a look
    Torben Barsballe
    @tbarsballe
    Reviewed.
    I’ve pushed up some GeoServer Java 11 docs to the GeoServer branch, if you want to take a look
    They feel a little sparse, but there’s not a whole lot to say for GeoServer...
    Jody Garnett
    @jodygarnett
    thanks, answering your feedback now, please advise.
    James Hughes
    @jnh5y
    @tbarsballe @jodygarnett most of my knowledge is captured by things like what's in the JTS sed commands: https://github.com/locationtech/jts/blob/master/MIGRATION.md
    that said, I do believe it is possible to build up a sed script with a list of transformations (e.g. one sed script with 500 changes rather than 500 scripts each with one change)
    Jody Garnett
    @jodygarnett
    Want to give it a go? We have our sheet with somewhat less then 500 changes :)
    James Hughes
    @jnh5y
    Ah... this week is rather bad for me to jump into something like this...