Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

OSSIA/libossia

feel free to ask us here about libossia

People

Repo info

Activity

May 16 19:13

jcelerier on total_variant_refactor

Tentative to move back to prope… (compare)
May 16 13:49

avilleret on master

[ossia-max] use shortest comman… (compare)
May 16 12:43

avilleret on master

[ossia-max] CI test : remove an… (compare)
May 15 14:57

jcelerier on variant_refactor

[variant] Add some type safety … (compare)
May 15 13:58

jcelerier on variant_refactor

[variant] Add some type safety … (compare)
May 15 11:42

jcelerier on variant_refactor

[deps] Cleanup dependencies a l… (compare)
May 15 10:49

jcelerier on variant_refactor

[deps] Cleanup dependencies a l… (compare)
May 15 09:59

jcelerier on variant_refactor

[core] Refactor everything to u… [deps] Cleanup dependencies a l… (compare)
May 14 12:21

jcelerier on master

add mpark/variant as a git subm… (compare)
May 14 12:21

jcelerier closed #789
May 14 12:21

jcelerier commented #789
May 14 12:20

jcelerier commented #789
May 14 11:42

smoothdeveloper opened #789
May 14 08:43

jcelerier on master

[curve] Move behavior::apply ou… (compare)
May 12 21:09

jcelerier on master

[compilers] Fixes for GCC 12 [exec] Copy inlet content if th… (compare)
May 12 13:13

robtherich commented #786
May 12 12:43

jcelerier commented #786
May 12 12:43

jcelerier commented #786
May 12 12:42

jcelerier commented #786
May 12 12:04

avilleret closed #693

Jean-Michaël Celerier

@jcelerier

thanks for the extensive test, reviewing it

Alex Norman

@x37v

fantastic @jcelerier ! thanks, I was thinking optionals would be nice, though, the container is called bidir or something so i wasn't quite sure :)
will test out this approach in the example in the next few hours

Alex Norman

@x37v

I updated my PR, rebased against the async_protocols branch and fixed up the test, still failing on that SET getting sent out though

but as is, this should be usable for my purposes, it'll just have extra messages out that i consider noise.. but not that big of a deal

Alex Norman

@x37v

okay, another thing. considering the new complexity of osc protocol configurations, seems like it would be nice to have a visitor based to get ip/port so, for instance, i can find and remove OSC senders from the muliplex protocols.. maybe something already exists?

i think I can figure out the exact type i'm using and do a dynamic cast like i used to do, but i imagine its something that would be generally useful in the lib

Alex Norman

@x37v

okay, the SET output isn't just noise now, it is causing crashes because websockets can handle a lot bigger OSC encoded messages on the input than UDP osc can send out (I believe)

when i add a UDP OSC output to my multiplex protocol that also has a OSCQuery protocol, i get crashes when I send these large WS messages.
it might make sense for me to chunk these smaller either way

Jean-Michaël Celerier

@jcelerier

okay, the SET output isn't just noise now, it is causing crashes because websockets can handle a lot bigger OSC encoded messages on the input than UDP osc can send out (I believe)

agh indeed, I'll add a filter + log

hmm

although a crash shouldn't happen

do you have a repro ? I have some tests that send large messages, and if it's > the max UDP size, it just gives an error during send

well I can easily do a check on my end given what you said, trying that

okay, another thing. considering the new complexity of osc protocol configurations, seems like it would be nice to have a visitor based to get ip/port so, for instance, i can find and remove OSC senders from the muliplex protocols.. maybe something already exists?

It does not exist, what would your dream API for that look like ?

Alex Norman

@x37v

do you have a repro ? I have some tests that send large messages, and if it's > the max UDP size, it just gives an error during send

I'll try to create a test case for it.

Alex Norman

@x37v

okay, another thing. considering the new complexity of osc protocol configurations, seems like it would be nice to have a visitor based to get ip/port so, for instance, i can find and remove OSC senders from the muliplex protocols.. maybe something already exists?

It does not exist, what would your dream API for that look like ?

Hmm. I'm not sure, I kinda liked just being able to dynamic cast to the osc protocol before and get the port and ip.. so something simple ideally without having to make my own visitor.. in the mean time I have a std::set of pairs of ip/port that i keep and to remove a specific OSC outbound I clear everything from the multiplex protocols except an oscquery protocol, then i remove the ip/port from the std::set and add the OSC outbounds back.
not ideal, but works.. but really only because the oscquery protocol is pretty simple to get the type of

Alex Norman

@x37v

@jcelerier this test illustrates the problem: https://github.com/Cycling74/libossia/blob/92b0e2b2623a8be86c85f5f09c4eade4018eea97/tests/Network/MultiplexTest.cpp#L107-L140

Jean-Michaël Celerier

@jcelerier

thanks @x37v, checked, fixed that large size thing and commented on the PR

btw @/all I'm not sure this is entirely 100% strictly necessary but maybe we should have at some point a small chat session on improving the contribution process ? so far it seems to work well but I'm sure we can find some small quality-of-life improvements, also maybe do a pass on whatever automated tool we can use, e.g. was thinking of commit hooks for various sanitizations

Alex Norman

@x37v

@jcelerier updates (re OSC out crash issue) are working well, thanks!

Alex Norman

@x37v

ahh cool, the async-protocols stuff is in master now! great

Thibaud Keller

@thibaudk

Hi @jcelerier , sorry, I am looking for the script to regenerate dataspace enums

is it a .sh file ?

Jean-Michaël Celerier

@jcelerier

It's genvariant

But it needs fixing

Alex Norman

@x37v

been a while..
I'm using multiplex_protocol to enable the addition/deletion of UDP OSC listeners.. generally it works but I'm occasionally getting an exception Bad Connection when I'm updating a value from another thread.. so, it seems like adding/removing protocols isn't thread safe

though, I should upgrade my libossia build as it has been a while

Alex Norman

@x37v

I'm using the context approach, with one thread polling the context.. there are 2 or 3 other threads that might push values, but only one polls the context.. the exception happens outside the poll, so maybe the context isn't actually fully encapsulating all network i/o?

Alex Norman

@x37v

interestingly, the exception is coming from the websocket library via the oscquery protocol, which is the one protocol that i don't remove

Jean-Michaël Celerier

@jcelerier

hi @x37v :)

hmmm, do you make the add_protocol call happening in the io_context thread ?

(with e.g. some post(...)) method

I'm doing some contract work rn, looking at it this weekend

Alex Norman

@x37v

@jcelerier I don't add the protocol in the same thread but I have a mutex around the io_context polling and adding/removing the protocol, so they're mutually exclusive. the exception comes when i push_valueto a parameter that uses the mutiplex protocol

the push_value that triggers the exception in this case happens in the same thread as the io_context poll, but no longer with the mutex lock so add/remove protocol could be happening in parallel

Pia Baltazar

@bltzr

Hey there!
There is no 1.2.5 build for ossia-max, which notably prevents users from using a version with some bugs fixed (in this case ossia/libossia#710)

Would anyone be able to make one?

fxw-fxw

@fxw-fxw

Hi all,

fxw-fxw

@fxw-fxw

I'm waiting for libossia 1.2.5 build for max... need it cause i'm using [poly~], as Pia said before... thx in advance.

Antoine Villeret

@avilleret

try https://github.com/ossia/libossia/releases/download/latest-ci-build/ossia-max.zip

not 1.2.5 but more recent

fxw-fxw

@fxw-fxw

Thanks Antoine !

Jean-Michaël Celerier

@jcelerier

hi folks ! i've been busy with a project for the last couple weeks, will get back on track here soon.
for anyone interested: automatic media object generation (max/pd external, audio plug-ins, python bindings, etc...) just from a C++ class: https://github.com/celtera/avendish

Antoine Villeret

@avilleret

:+1:

Antoine Villeret

@avilleret

AWESOME

Pia Baltazar

@bltzr

"declarative polyamorous...", lol

Vincent Goudard

@vincentgoudard

whooo... super awesome ! :)

Travis West

@DocSunset

Very super awesome.

Alex Norman

@x37v

very cool @jcelerier

Vincent Goudard

@vincentgoudard

hey! I remember there was a discussion on SET/GET modes for ossia.parameters, but I forgot what the status was and can't find anything in the docs... does anyone know ? (@avilleret?, at random :) )

Namely, is there a way to have parameters which are not stored in a preset?

Chat via Matrix