Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Wictor Wilén
@wictorwilen
As long as it works... :-)
Wictor Wilén
@wictorwilen
Just pushed a brand new preview (last one before we go live with this version) - 2.9.0-preview3. It contains a whole lotta new features. The build system specifically has been improved with faster incremental builds (just rebuilding the code that has changed)
Here's a list of all changes and additions in 2.9.0, please check it out and let's get this published before the end of the week

Added

  • Added support for manifest version 1.5, new default
  • Added suppot for optionally adding Microsoft Partner Id. More info at https://aka.ms/partner
  • Added files support option for bots (schema version 1.4+)
  • Now persists settings for using unit testing, application insights and the library name
  • Added default logging of "msteams" in the .env file
  • Added support for SCSS in the build pipeline
  • Added a default styling to the start page
  • Added an option for Tabs to specify scope; groupcaht or team
  • Added a build option called linting to be able to opt-out of Typescript linting. Use gulp serve --no-linting for faster builds.

Changed

  • Updated the @microsoft/teams-js package to version 1.4.2
  • Added strict handling of inquirer answers in the main generator
  • Refactored the gulp build system into gulpfile.js and gulpfile.config.js
  • Refactored gulp tasks and added new gulp tasks to support independent builds of client side and server side code
  • The watch gulp tasks now only rebuilds the parts that has changed (server side code, client side code, styles or static files) which improves incremental build times
  • Updated gulpfile.js to use the $schema defined in the manifest file for validation and the SCHEMAS object only as backup
  • Clarified some questions that the users is adding Message Extension commands, rather than new message extensions

Fixes

  • Fixed an issue when you add a messaging extension to an existing project and has renamed the bot file or folder name
  • Fixed an issue when you add additional pages/scripts to a project and the library name is camel cased. Now correctly cased library name is retrieved from existing webpack.config.js file, and then the persisted config if exists, before defaulting to the library name
  • Fixed an issue where Microsoft Partner Id is incorrectly persisted in the Yeoman configuration file
Wictor Wilén
@wictorwilen
Ralf Brennscheidt
@RalfBrennscheidt
image.png
Wictor Wilén
@wictorwilen
Thanks @RalfBrennscheidt - an installation (npm postinstall) bug was found in 2.9.0 and it is now fixed in 2.9.1 - please try the @latest
Ralf Brennscheidt
@RalfBrennscheidt
image.png
Sorry ->
happens on a "gulp build"
no code changes at all. Wizard only selected MessageExtension
Wictor Wilén
@wictorwilen
Try to run npm install again
Ralf Brennscheidt
@RalfBrennscheidt
nope, same error :(
Wictor Wilén
@wictorwilen
What happens if you do install file-loder?
File-loader
Ralf Brennscheidt
@RalfBrennscheidt
can you see this? -> https://www.paste.org/99119
Strangely it says that the dependency of webpack ^4.... is missing even though i have installed it globally.
Wictor Wilén
@wictorwilen
Have u tried removing node_modules and package-lock.json and npm install?
Ralf Brennscheidt
@RalfBrennscheidt
executed now, still fails with same error.
Ralf Brennscheidt
@RalfBrennscheidt
okay, tried now on my private computer and it worked. Therefore not an issue with the generator. Sorry to bother!
Wictor Wilén
@wictorwilen
npm acts a bit like that once in a while, it misses a package or two during the install
Ralf Brennscheidt
@RalfBrennscheidt
Thank you for your help, Sir!
Wictor Wilén
@wictorwilen
Preview mode again...2.10.0-preview now supports choosing between a configurable and static tab, and also adding more tabs running the generator again
Wictor Wilén
@wictorwilen
10k npm downloads!! Thanks all for your support!
Wictor Wilén
@wictorwilen
And, version 2.10.0 is out
Ralf Brennscheidt
@RalfBrennscheidt
Hi! Is there any news related to SSO ? So there is no need for the whole MS-Graph ping pong-/user-interaction to authenticate ?
Wictor Wilén
@wictorwilen

Hi! Is there any news related to SSO ? So there is no need for the whole MS-Graph ping pong-/user-interaction to authenticate ?

Nothing official AFAIK

Wictor Wilén
@wictorwilen
I just published 2.11.0-preview. It contains support for localization of your apps. You can either start a new project using the 2.11.0 version or you can update a project from 2.9.0+. The latter one I need help with testing on your existing projects, as it will do an update to gulp.config.js - which is a new feature in the generator that allows us to update the core build files going forward, when new features are introduced. Test it on your existing projects - but ensure to have them under source control for any issues in this preview.
Amit
@amitvig22
This is great, and i was able to build a quick teams app and test locally. can someone point me to the documentation to deploy this react app to Azure via visual studio code ? thanks much appreciated.
Wictor Wilén
@wictorwilen
Great to hear @amitvig22. If you take a look at the generated README.md file then you will find instructions for how to deploy it to Azure
Amit
@amitvig22
@wictorwilen aah gotcha, i kept looking at the readme.md for the teams generator and got puzzled. Saw the readme in the project yo teams created and found the instructions.
Andrew Connell
@andrewconnell
Is there a reason why all dependencies, even those not needed in production, are in dependencies section of package.json? IOW, any reason why devDependencies is avoided?
Wictor Wilén
@wictorwilen

Is there a reason why all dependencies, even those not needed in production, are in dependencies section of package.json? IOW, any reason why devDependencies is avoided?

Very valid, that actually has an answer. The reason we did move everything to dependencies is the fact that when you do a git push to Azure and want to avoid having the compiled dist included in Git, meaning Azure should do the build after the push. When Azure does the npm install it did not pick up the devDependencies so the build failed. I have not gone back and tested this for a long time and it was a know issue back then (if I recall with Kudu).

Wictor Wilén
@wictorwilen
So @andrewconnell I have not bothered with this for years, just leaved it that way, since it worked...
But, I just looked into deploy.cmd now and it uses npm install --production (which causes only dependencies to be installed). If I remember I fiddled with that but did not get it to work, might be worth going back and test again #goodfirstissue :-)
Andrew Connell
@andrewconnell
When you run npm install, it looks for an envvar that indicates if you are in PRODUCTION or not (which you can override by including the --production flag too. If not (like your laptop), npm install picks up everything in dependencies & devDependencies. But in An Azure WebApp has the envvar set to PRODUCTION so npm install only grabs what's in dependencies.
In general, you never ship dev stuff (@types/*, gulp, webpack, compilers, test runners, etc)... should only ship what's needed in prod.
First time i'm looking at the teams generator (because i'm building training materials on it) and was a bit surprised, hence why i asked :)
But if you're trying to avoid /dist or an equiv, what you currently have is your only option.
Azure web app's ability to support GIT based deployments are the "easy" button way. Thanks for explaining the thought process behind this.
Andrew Connell
@andrewconnell

You say #goodfirstissue... would you be open to a PR that did two things: (1) moved what's needed => devDependencies & (2) modified the deploy.cmd & docs to explain how to do a deployment that includes both if you use Azure web app capability of git deployment?

This would allow others who want a more enterprisey style deploy to use CI/CD to do the build NOT in production, but only deploy production assets (ie: /dist) which would also keep /dist out of the repo.

That ^^ way you get best of both worlds: you retain the easy deployment option but you don't impose it on people who want to keep dev dep's out of production deployments.
Wictor Wilén
@wictorwilen
Fo sho, I'd love that. And also it's good for you to learn something :-)
Andrew Connell
@andrewconnell
Cool... i'll look into it. Bit swamped writing the training materials now on deadline but something I'll try to get to...
Andrew Connell
@andrewconnell
Is it a known issue that the generator hangs after asking for the default tab name if there are spaces in the tab name?
I don't see it on the issue list, I can bug it if not...
Wictor Wilén
@wictorwilen
Not seen that before, I typically always have a space in there...have u checked OfficeDev/generator-teams#80
Andrew Connell
@andrewconnell
I did... I didn't think it was the same one, but I'll post it as an issue if it keeps up...
Wictor Wilén
@wictorwilen
what node version do you have, I've seen issues with Yeoman/Inquirer related to how async/await is implemented in node 10+
Andrew Connell
@andrewconnell
Node v10, MacOS & only happens on that one question when there's a space in the name.
Wictor Wilén
@wictorwilen
interesting, don't have a mac so can't try. It would be interesting to try without the validation
Andrew Connell
@andrewconnell
I’ll do a proper issue... repro & the like