by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Cagdas Davulcu
@cagdasdavulcu
I can do it. Should it also work for devPreview?
The "single sign-on" API is currently supported in Developer Preview only.
https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/authentication/auth-aad-sso
Wictor Wilén
@wictorwilen
Yes, I've already fixed that issue in my local branch.
So, expect it to work in next preview release
"Developer Preview" does mean a lot of things in Teams. In this case it means developer preview in the client, not the devPreview schema
Cagdas Davulcu
@cagdasdavulcu

So, expect it to work in next preview release

Thank you!

"Developer Preview" does mean a lot of things in Teams. In this case it means developer preview in the client, not the devPreview schema

Really interesting!

In this example, they are also using the v1.5 schema:
https://github.com/ydogandjiev/taskmeow/blob/master/manifest/sso/manifest.json
Wictor Wilén
@wictorwilen
It's all confusing - same as the SDK versions are not correlated to the manifest versions. Even though they did follow eachother in the beginning

@cagdasdavulcu

In this example, they are also using the v1.5 schema:
https://github.com/ydogandjiev/taskmeow/blob/master/manifest/sso/manifest.json

Exactly.

Cagdas Davulcu
@cagdasdavulcu
@wictorwilen i wish you nice session tomorrow with @VesaJuvonen:
https://www.linkedin.com/feed/update/urn:li:activity:6645713977672286208/
Wictor Wilén
@wictorwilen
Thanks, will be a short demo
Wictor Wilén
@wictorwilen
Are you folks getting 429's when sideloading apps?
Cagdas Davulcu
@cagdasdavulcu

Are you folks getting 429's when sideloading apps?

Do you still have the 429 problem?

Wictor Wilén
@wictorwilen
Yea, it's all over now. Can't even save a standard website tab due to throttling
Let's see if this demo at the PnP call works...
Cagdas Davulcu
@cagdasdavulcu

Yea, it's all over now. Can't even save a standard website tab due to throttling

:( How was your session? i also wanted to join but i had a meeting

Wictor Wilén
@wictorwilen
All good methinks!
Cagdas Davulcu
@cagdasdavulcu
✌🏻✌🏻✌🏻
Andrew Connell
@andrewconnell
Sorry for the delay in contributing to the issues assigned to me. It was "all hands" at the end of the quarter to get my non-community work complete. I finished early and planned to put a lot of time on my open issues for the bulk of March, but then the pandemic wrecked my biz. That's got my focus now... so I'm going to be more delayed on contributing. Sorry folks.
Wictor Wilén
@wictorwilen
@andrewconnell - no worries mate, we all do have quite a lot on our tables right now. You have the right priorities!!
Wictor Wilén
@wictorwilen
@/all Got some great news. Got upset enough when building out an app on the build times - now I'm down to subseconds when rebuilding the app :-)
Ralf Brennscheidt
@RalfBrennscheidt
O,O
Wictor Wilén
@wictorwilen
I know, I know, way overdue...
Ralf Brennscheidt
@RalfBrennscheidt
I have to apologize too very much. I was so motivated and enthusiastic to contribute and help....and then this C-thing hit the world and i barely have any time at all anymore.
Wictor Wilén
@wictorwilen
Thanks @RalfBrennscheidt for the contributions to this new 2.15 version
Thanks @cagdasdavulcu for the test contributions to this new version - found a few things while running the integration tests that now is fixed. Running full integration testing now takes 1-3 hours :-)
Ralf Brennscheidt
@RalfBrennscheidt
Thank you @wictorwilen for giving me the honor of being added to the Contributor list :)
Wictor Wilén
@wictorwilen

Thank you @wictorwilen for giving me the honor of being added to the Contributor list :)

Worth it!

Sometimes in June we will pass 20K downloads and we've had 4.000 Teams apps being scaffolded since mid-march. I think that is pretty good. On to the next chapter!! I wanted to get this 2.15 out, and mayhaps a 2.16, before we close done the v2 branch for new features and focuses on v3.
Ralf Brennscheidt
@RalfBrennscheidt
Awesome, can't wait for v3...i predict some significant changes.
In regard to #87, which mainly affect the tests. Perhaps we should change the componentwillmount already to "UNSAFE_componentWillMount()" to be on the safe side for the future v17 of react ?
Wictor Wilén
@wictorwilen
I think we can leave it as is for now. I do want to go to React Hooks for v3.
Ralf Brennscheidt
@RalfBrennscheidt
Even better, yes.
Cagdas Davulcu
@cagdasdavulcu

Thanks @cagdasdavulcu for the test contributions to this new version - found a few things while running the integration tests that now is fixed. Running full integration testing now takes 1-3 hours :-)

Hello @wictorwilen , thank you too! I would suggest to integrate the integration tests into build pipeline, there by we don't have to run it and wait for it for 3h. Are you planing to setup a new call for discussing next steps?

Wictor Wilén
@wictorwilen
Considering that as well. Currently I only do the non-integration tests using Travis
Ralf Brennscheidt
@RalfBrennscheidt
Yes a call would be nice. There's questions :) - Are you working already on 3.x ? Are there any concluded new structures for the generator ? Where could we have a peek of the new changes so far for 3.x ? and and and
Wictor Wilén
@wictorwilen
I'll set it up, I'll share an invite during this week. Re current status of v3 - it's to experimental to share now, but let me start cleaning it up!
Cagdas Davulcu
@cagdasdavulcu
Wictor rocks! 💪🏼💪🏼💪🏼😂
Ralf Brennscheidt
@RalfBrennscheidt
high-five :)
Wictor Wilén
@wictorwilen
😊
PS. With 2.15.0 I added Github Workflows for builds - will slowly transition to that over Travis...Will setup a specific workflow for release management as well
Wictor Wilén
@wictorwilen
image.png
@/all Does next Tuesday work for folks?
Paul Schaeflein
@pschaeflein
👍
Ralf Brennscheidt
@RalfBrennscheidt
@wictorwilen : Works for me :thumbsup:
Cagdas Davulcu
@cagdasdavulcu
👍🏼
Cagdas Davulcu
@cagdasdavulcu
Do we have the meeting today? :)
Wictor Wilén
@wictorwilen
Sorry no. I've been swamped with work and not have had time to prepare 🙁
Cagdas Davulcu
@cagdasdavulcu
Alright! Thank you for your feedback!