Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 17:07
    jld3103 commented #11360
  • 17:05
    agilob commented #11360
  • 17:04
    hrstoyanov edited #8015
  • 16:51
    zitnik opened #11399
  • 16:51
    zitnik labeled #11399
  • 16:36
    jld3103 commented #11360
  • 16:07
    WtfJoke commented #8255
  • 16:04
    WtfJoke commented #8255
  • 15:53
    Abrhm7786 synchronize #11345
  • 15:09
    kevinkirkup commented #9603
  • 14:42
    kevinkirkup commented #9603
  • 14:38

    wing328 on gh-pages

    Deploy website version based on… (compare)

  • 14:20
    jafin edited #11398
  • 14:19
    jafin opened #11398
  • 13:54
    wing328 milestoned #10270
  • 13:54
    wing328 labeled #10270
  • 13:54
    wing328 labeled #10270
  • 13:41
    RamanShyrski opened #11397
  • 13:35
    lfvjimisola labeled #11396
  • 13:35
    lfvjimisola opened #11396
Jérémie Bresson
@jmini
we do this already if you define a parameter in "path".
Then you have them in each of the operation defined under this path.
Michal Foksa
@MichalFoksa
Right - there is only operation, I remember now. I think I can circumvent the issue now. Put the extensions into operation and render them on path level - maybe.

@jimschubert

I think we should copy all the path from a vendor specific extension from path to each operation

Do you think it makes sense in the grand scheme of OpenAPI generator?

Michal Foksa
@MichalFoksa
@wing328 @jmini Thank you - I have workaround-ed the issue by moving the extensions on operation level
William Cheng
@wing328
:+1:
parrotcar00
@parrotcar00
@wing328 @jimschubert Is there a good-practice workflow when using openapi generation with javascript? For example, when using it in Java spring, the open api generator maven plugin makes it very easy. One just has to run maven compile and all of your generated files are updated according to your openapi.yaml file. Is there anything like that for javascript or will one have to run the update process manually each time for openapi.yaml file update?
Jim Schubert
@jimschubert
@parrotcar00 if you're using node, you can use the npm module: https://github.com/OpenAPITools/openapi-generator-cli. This is just a wrapper around the Java artifact, but you can create automation in your project pretty easily
parrotcar00
@parrotcar00
Do you keep your generated code outside git repo for javascript?
William Cheng
@wing328
@parrotcar00 you may also publish the auto-generated JS SDK Github repo, e.g. https://github.com/wing328/petstore-js.
Slavek Kabrda
@bkabrda
@cbornet hey, if you have some time to spare, could you please take a look again at OpenAPITools/openapi-generator#3474 ? a simple thumbsup/thumbsdown to let me know if I should start doing the modifications on the other library templates and regenerating samples
Christophe Bornet
@cbornet
Yes. I'll have a look. Could you show a sample of generated code ?
Slavek Kabrda
@bkabrda
sure, I'll share it in the PR
Richard Whitehouse
@richardwhiuk
I'm looking at adding callback support to the Rust Server generator. Does anyone know if any of the other generators have good support for callbacks?
Fjolnir-Dvorak
@Fjolnir-Dvorak
hmm, I am wondering. The project has a checkstyle file. Is that file to be used? At the moment it is broken (LeftCurly has no child property " <property name="maxLineLength" value="100"/>". After I repaired that locally I ran checkstyle and the result was horrific...
The file DefaultCodegen.java has 352 style violations on its own...
makes me wondering. Should the eclipse formatter config file be used or is that one historic, too?
Fjolnir-Dvorak
@Fjolnir-Dvorak
And another question. Did anyone tried to delete the samples folder and to regenerate it? After fixing the typescript-fetch scripts which are copying files without creating the directories and ignoring meta-codegen.sh (something there is broken, too, if I am trying to regenerate all sample after executing "rm -rf samples") I got about 9920 deleted files which are no longer generated anymore...
It could also be that I understand the whole project totally wrong though. But how else shall I regenerate the golden files if I made a change which would result in a file rename which I will do with the fix of case sensitive reserved word escaping
Jim Schubert
@jimschubert
Things under samples include unit tests and pom.xml files which allow us to compile and execute some supported outputs as part of our CI. You can't just delete and recreate the directory. ~10k files sounds like a node_modules directory, maybe? I'd suggest deleting only the files you expect to no longer be generated within the generator you're modifying.
Fjolnir-Dvorak
@Fjolnir-Dvorak
I saw one zero too much. I just needed to repair typescript and copy the file which were missing in meta-codegen to CI/samples and the script ensure worked again. That were only 1800 files, so it is not nearly as bad
I did not check yet if the file ensure-up-to-date.sh does what it should do
all other languages did copy their test pom.xml files from CI/samples into samples, so that worked just fine
Is it correct that OCaml is not tested by ensure-up-to-date.sh?
Fjolnir-Dvorak
@Fjolnir-Dvorak
well, that is not so easy since I modified every generator since I patched a DefaultCodegen "bug"
If what I did was wrong it is easy to fix for me since I separated those changes in different branches / commits. I assume a rebase is possible on a pull request
Fjolnir-Dvorak
@Fjolnir-Dvorak
Would it be possible to distinguish generated from manual supplied but still needed files? At the moment the files are generated in the same folder where files are lying which were added manually. That does make a well tested change nearly impossible since there is no way to distinguish those files
Jim Schubert
@jimschubert
We could add manually modified files to each ignore file, but that doesn't solve the delete/recreate unless all generators have the extra files copied from the staging directory.
Slavek Kabrda
@bkabrda
@cbornet hey, so I added the example to https://github.com/OpenAPITools/openapi-generator/pull/3474#issuecomment-516772779 - feel free to take a look and comment
Dennis Kliban
@dkliban
@wing328 Thanks for merging the faraday PR. I actually have another commit that I put together last night for handling all the TLS related options.
@wing328
I will wait to make that PR until your new PR is merged
Dennis Kliban
@dkliban
@wing328 or should I go ahead and make my PR now?
William Cheng
@wing328
please go ahead
Dennis Kliban
@dkliban
@wing328 OpenAPITools/openapi-generator#3335 ... this is not python specific ... i ams eeing the same thing in Ruby. so even though you merged teh Faraday PR, i still can't switch to using the master branch
William Cheng
@wing328
is it due to the use of -D (system property)?
can you try switching to --additional-properties instead?
Dennis Kliban
@dkliban
@wing328 that seems to fix it
@wing328 when did this change?
William Cheng
@wing328
i think it's part of the refactoring work that we've been doing
the change (PR) should have been marked as breaking
with fallback
Dennis Kliban
@dkliban
@wing328 here is the PR that adds support for the TLS options of faraday https://github.com/OpenAPITools/openapi-generator/pull/3527/files
i had to add a new configuration template with the options that correspond to faraday
William Cheng
@wing328
OK, I'll try to merge them into one
Dennis Kliban
@dkliban
@jimschubert I am ready to talk about adding a 'toDisciminator' method to the CodegenConfig interface
oops
wrong link
Dennis Kliban
@dkliban
and i looked at the CodegenConfig interface. I see it has toVarName and toParamName methods