Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:57
    4brunu commented #11013
  • 09:19
    Abrhm7786 labeled #11018
  • 09:19
    Abrhm7786 opened #11018
  • 08:47
    JoeCqupt commented #11005
  • 08:38
    40rn05lyv opened #11017
  • 08:21
    40rn05lyv commented #6882
  • 07:12
    amakhrov synchronize #11016
  • 06:55
    amakhrov opened #11016
  • 05:58
    spacether synchronize #8325
  • 04:24
    matthewjchou commented #10913
  • 04:23
    matthewjchou commented #10913
  • 04:22
    matthewjchou commented #10913
  • 04:20
    S2021Git commented #6882
  • 03:05
    S2021Git commented #6882
  • 02:10
    wing328 synchronize #10995
  • 02:10

    wing328 on okhttp-gson-next-gen-better-error

    add option, update api doc with… (compare)

  • Dec 01 23:54
    jarrodparkes synchronize #11013
  • Dec 01 23:24
    maciex commented #10498
  • Dec 01 23:24
    maciex closed #10498
  • Dec 01 23:00
    carmenquan synchronize #11003
William Cheng
@wing328
@parrotcar00 you may also publish the auto-generated JS SDK Github repo, e.g. https://github.com/wing328/petstore-js.
Slavek Kabrda
@bkabrda
@cbornet hey, if you have some time to spare, could you please take a look again at OpenAPITools/openapi-generator#3474 ? a simple thumbsup/thumbsdown to let me know if I should start doing the modifications on the other library templates and regenerating samples
Christophe Bornet
@cbornet
Yes. I'll have a look. Could you show a sample of generated code ?
Slavek Kabrda
@bkabrda
sure, I'll share it in the PR
Richard Whitehouse
@richardwhiuk
I'm looking at adding callback support to the Rust Server generator. Does anyone know if any of the other generators have good support for callbacks?
Fjolnir-Dvorak
@Fjolnir-Dvorak
hmm, I am wondering. The project has a checkstyle file. Is that file to be used? At the moment it is broken (LeftCurly has no child property " <property name="maxLineLength" value="100"/>". After I repaired that locally I ran checkstyle and the result was horrific...
The file DefaultCodegen.java has 352 style violations on its own...
makes me wondering. Should the eclipse formatter config file be used or is that one historic, too?
Fjolnir-Dvorak
@Fjolnir-Dvorak
And another question. Did anyone tried to delete the samples folder and to regenerate it? After fixing the typescript-fetch scripts which are copying files without creating the directories and ignoring meta-codegen.sh (something there is broken, too, if I am trying to regenerate all sample after executing "rm -rf samples") I got about 9920 deleted files which are no longer generated anymore...
It could also be that I understand the whole project totally wrong though. But how else shall I regenerate the golden files if I made a change which would result in a file rename which I will do with the fix of case sensitive reserved word escaping
Jim Schubert
@jimschubert
Things under samples include unit tests and pom.xml files which allow us to compile and execute some supported outputs as part of our CI. You can't just delete and recreate the directory. ~10k files sounds like a node_modules directory, maybe? I'd suggest deleting only the files you expect to no longer be generated within the generator you're modifying.
Fjolnir-Dvorak
@Fjolnir-Dvorak
I saw one zero too much. I just needed to repair typescript and copy the file which were missing in meta-codegen to CI/samples and the script ensure worked again. That were only 1800 files, so it is not nearly as bad
I did not check yet if the file ensure-up-to-date.sh does what it should do
all other languages did copy their test pom.xml files from CI/samples into samples, so that worked just fine
Is it correct that OCaml is not tested by ensure-up-to-date.sh?
Fjolnir-Dvorak
@Fjolnir-Dvorak
well, that is not so easy since I modified every generator since I patched a DefaultCodegen "bug"
If what I did was wrong it is easy to fix for me since I separated those changes in different branches / commits. I assume a rebase is possible on a pull request
Fjolnir-Dvorak
@Fjolnir-Dvorak
Would it be possible to distinguish generated from manual supplied but still needed files? At the moment the files are generated in the same folder where files are lying which were added manually. That does make a well tested change nearly impossible since there is no way to distinguish those files
Jim Schubert
@jimschubert
We could add manually modified files to each ignore file, but that doesn't solve the delete/recreate unless all generators have the extra files copied from the staging directory.
Slavek Kabrda
@bkabrda
@cbornet hey, so I added the example to https://github.com/OpenAPITools/openapi-generator/pull/3474#issuecomment-516772779 - feel free to take a look and comment
Dennis Kliban
@dkliban
@wing328 Thanks for merging the faraday PR. I actually have another commit that I put together last night for handling all the TLS related options.
@wing328
I will wait to make that PR until your new PR is merged
Dennis Kliban
@dkliban
@wing328 or should I go ahead and make my PR now?
William Cheng
@wing328
please go ahead
Dennis Kliban
@dkliban
@wing328 OpenAPITools/openapi-generator#3335 ... this is not python specific ... i ams eeing the same thing in Ruby. so even though you merged teh Faraday PR, i still can't switch to using the master branch
William Cheng
@wing328
is it due to the use of -D (system property)?
can you try switching to --additional-properties instead?
Dennis Kliban
@dkliban
@wing328 that seems to fix it
@wing328 when did this change?
William Cheng
@wing328
i think it's part of the refactoring work that we've been doing
the change (PR) should have been marked as breaking
with fallback
Dennis Kliban
@dkliban
@wing328 here is the PR that adds support for the TLS options of faraday https://github.com/OpenAPITools/openapi-generator/pull/3527/files
i had to add a new configuration template with the options that correspond to faraday
William Cheng
@wing328
OK, I'll try to merge them into one
Dennis Kliban
@dkliban
@jimschubert I am ready to talk about adding a 'toDisciminator' method to the CodegenConfig interface
oops
wrong link
Dennis Kliban
@dkliban
and i looked at the CodegenConfig interface. I see it has toVarName and toParamName methods
and i see where those are called later ... but i am not quite sure where you were thinking toDiscriminator would be called ... and would i need to implement a custom discriminator?
William Cheng
@wing328
Hi all, we've collected some feedback from the community and would like to announce we're switching the chatroom from Gitter.im to Slack. Please join our Slack channel via https://join.slack.com/t/openapi-generator/shared_invite/enQtNzAyNDMyOTU0OTE1LTY5ZDBiNDI5NzI5ZjQ1Y2E5OWVjMjZkYzY1ZGM2MWQ4YWFjMzcyNDY5MGI4NjQxNDBiMTlmZTc5NjY2ZTQ5MGM and we'll only answer questions in the Slack channels moving forward. We'll keep this Gitter chatroom for a few months and remove it when there's no activity. Thank you.
Fjolnir-Dvorak
@Fjolnir-Dvorak
My suggestion would be on that that we keep this gitter here as support chat. Slack seems very inappropriate for that (no one is using it and it requires authentication without GitHub). GitHub is widely used and accepted. I do have to agree with that that perhaps slack could be better for development?
The problem I have with moving to slack: I do not report any bugs if I have to login into any platform. If they want me to login into their system, they are not interested in getting bug reports so why should I bother helping them?
And sometimes I am reporting bugs via gitter. Writing bugreports is a science for itself sometimes. It's way to complicated for just reporting that something is wrong if I am not interested in fixing the issue myself
Jim Schubert
@jimschubert
The problem with Gitter is that notifications often don’t work. On both desktop and mobile, I frequently have to close the client in order to see new messages. This makes having a “conversation” pretty difficult. There’s also no support for threaded comments, and editing comments on mobile is not exactly functional. Gitter isn’t a main product focus of GitLab, and as such it’s been years and these bugs are still not fixed. Makes one wonder if unanswered messages are just dropped.
Colton Kopsa
@coljamkop
Is there a way to do selective generation from the CLI?
Fjolnir-Dvorak
@Fjolnir-Dvorak
There is a tool written in JavaScript, sadly. It's called openapi-extract. The generator itself is not selective in any way...
Colton Kopsa
@coljamkop
In general what is the best way to update generated clients? It looks like the maven plugin has some ability to be selective.