Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 07:13
    abandoned-prototype review_requested #901
  • 07:12
    abandoned-prototype synchronize #901
  • 07:12

    abandoned-prototype on format-codebase

    Remove stand-alone scripts. Th… Automatic changes from running … Remove executable from non-exec… and 3 more (compare)

  • 06:54

    abandoned-prototype on fix-main

    (compare)

  • 06:44

    abandoned-prototype on develop

    Swap the fields that are shown … Add custom JPEG identification … Image submission: Remove Secure… and 18 more (compare)

  • 06:44

    abandoned-prototype on pre-format

    (compare)

  • 06:44
    abandoned-prototype closed #900
  • 06:36
    abandoned-prototype synchronize #900
  • 06:36

    abandoned-prototype on pre-format

    Swap the fields that are shown … Add custom JPEG identification … Image submission: Remove Secure… and 17 more (compare)

  • 06:16

    abandoned-prototype on main

    Fix CircleCI automated tasks U… Merge pull request #885 from lu… Add confirmation check-box to u… and 7 more (compare)

  • 06:16
    abandoned-prototype closed #905
  • 06:08
    abandoned-prototype opened #905
  • 06:06

    abandoned-prototype on main

    Revert "Fix CircleCI automated … (compare)

  • 05:32

    abandoned-prototype on fix-main

    Merge branch 'develop' into fix… (compare)

  • 05:13

    abandoned-prototype on v0.6.7

    (compare)

  • Feb 06 05:27

    abandoned-prototype on circleci-fix

    (compare)

  • Feb 06 05:27

    abandoned-prototype on develop

    Fix circleci deployment. (#904)… (compare)

  • Feb 06 05:27
    abandoned-prototype closed #904
  • Feb 05 05:38
    abandoned-prototype review_requested #904
  • Feb 03 07:40

    abandoned-prototype on circleci-test

    (compare)

pierwill
@pierwill
  1. the routes are different depending on whether dept_pref == None is true. so i was gonna have it try both None and 1..?
  2. ah ok
None is allowed: ie, a registered user with no preference
Freddy Martinez
@b-meson
@tmc the latest branch exifstrip might be a first pass at stripping jpg ?
Travis Cline
@tmc
nice
redshiftzero
@redshiftzero
note that pngs do not have exif data @b-meson
and the only extensions we allow are jpg, jpeg, gif, png for reference
Freddy Martinez
@b-meson
hmm, another thing we can do is use PIL to see if the upload is an image, if not, throw it away. for example someone could append .jpgto a PDF. (if they read our source and still upload to our bucket)
these logos are so cute lucyparsons/OpenOversight#253
pierwill
@pierwill
i gotta quit y'all. getting late here. thanks for your help everyone!
redshiftzero
@redshiftzero
night @pierwill :-)
Holden Grissett
@HoldenGs
Hey guys, novice question. I made one small change to an html file. Should make a new branch, commit, and do a PR, or should I just commit it to an existing branch?
This is for issue #378 for reference
Travis Cline
@tmc
generally separate concerns should go into separate branches and prs
Holden Grissett
@HoldenGs
Okay
Travis Cline
@tmc
useful git alias:
r = for-each-ref --count=15 --sort=-committerdate refs/heads/ --format='%(refname:short)'
edit-branch / edit-branch-develop are how I do squashing
redshiftzero
@redshiftzero
those are lit aliases
Freddy Martinez
@b-meson
hmm my exif strip is failing, I will continue to poke at it in a VM
Travis Cline
@tmc
@redshiftzero git branch --merged |grep -v '^*' |xargs -L1 git branch -d
redshiftzero
@redshiftzero
that is super handy ^
ok im signing off to clean up the (physical) room and such. thanks everyone for helping out today! if you're interested in making future PRs, we'll keep this room around and we always love contributions :-)
Stuart Kuredjian
@dbconfession78
worked on 387 otw home. going to sleep. wlil submit pr tom
camille
@ssempervirens
thanks @dbconfession78 !
Mason D.
@r4v5
Howdy hey, another hackathon starts in ~4 hours. Physical location is Chicago at South Side Hackerspace, 1048 W 37th St, Chicago, IL but you're of course also welcome to attend remotely.
Just a warning that it's gonna get chatty again for the first time in... ten months
int10h
@brianmwaters
Hello! I am here! I am mostly going to be working w/ the OJB team on officer photos
McEileen
@McEileen
Delightful! I am also here.
int10h
@brianmwaters
it looks like the baltimore folks are doing presentations and other stuff until 4:30 EST so maybe i'll do some PR's until them
McEileen
@McEileen
cool, I'm working on this lucyparsons/OpenOversight#506
redshiftzero
@redshiftzero
so the tricky part with the officer profile upload in #506 is that once we upload the photo, we then want the user to go to a page similar to the officer identification page to select the bounding box containing the face of the officer in question, then we use that bounding box to make a cropped version of the photo (crop_data is the variable in the diff that should contain the bounding box). the goal here is to only display cutouts/cropped photos containing just the face of an officer on their profile
[resolving merge conflicts and testing it as is still a good place to start, as you test you'll see what i mean above ^]
McEileen
@McEileen
Hey @redshiftzero, is there anywhere we're storing photos to test the upload feature with? I can obviously find photos to use somewhere, but for some reason I thought you had mentioned images stored in a S3 bucket.... thanks!
redshiftzero
@redshiftzero
we are using S3 in prod, but to test with the current code one would need to make an aws account and a test S3 bucket (i do this for testing rn) following this: https://github.com/lucyparsons/OpenOversight/blob/develop/DEPLOY.md#s3-image-hosting
McEileen
@McEileen
on it, thanks
Mason D.
@r4v5
Any idea why the selenium test_functional.py:test_lastname_capitalization seems to be failing? McEileen said some things that implied it wasn't just me seeing it
redshiftzero
@redshiftzero
is it failing locally reproducibly for yall?
CI is passing
want to open up an issue? (even if its a flake) worth tracking and squashing
Mason D.
@r4v5
it has been, but this in a branch of someone's in which i'm trying to clean up a merge conflict. retrying on develop
redshiftzero
@redshiftzero
ahhhhh
gotcha
Mason D.
@r4v5
yeah, i'll throw up an issue
redshiftzero
@redshiftzero
hrm debug is off in dev, woops
Mason D.
@r4v5
yeah I don't know where to begin debugging that since the output is entirely from pyselenium :)
redshiftzero
@redshiftzero
running tests locally to see if i can repro
ok yep i see it too
Mason D.
@r4v5
btw @redshiftzero can you re-review lucyparsons/OpenOversight#531 ? i just fixed its merge conflict
redshiftzero
@redshiftzero
will doo
Mason D.
@r4v5
want me to versionbump to geckodriver 23?