Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 15 14:38

    dismantl on baltimore

    (compare)

  • Oct 15 14:36

    dismantl on baltimore

    Only show complaint form for BPD typo Add table of court cases to off… and 7 more (compare)

  • Oct 10 02:45
    dependabot[bot] labeled #878
  • Oct 10 02:45
    dependabot[bot] labeled #878
  • Oct 10 02:45
    dependabot[bot] opened #878
  • Oct 10 02:45

    dependabot[bot] on pip

    Bump pillow from 7.2.0 to 8.3.2… (compare)

  • Oct 10 02:44

    abandoned-prototype on add-markdown-incident-description

    (compare)

  • Oct 10 02:44

    abandoned-prototype on develop

    867/add markdown incident descr… (compare)

  • Oct 10 02:44
    abandoned-prototype closed #877
  • Oct 10 02:44
    abandoned-prototype closed #867
  • Oct 06 04:54
    abandoned-prototype synchronize #851
  • Oct 06 04:54

    abandoned-prototype on s3-local

    Update Pillow (#850) A couple … normalizing dates, setting defa… fix link from image sorting to … and 16 more (compare)

  • Oct 06 04:51

    dependabot[bot] on pip

    (compare)

  • Oct 06 04:51
    dependabot[bot] commented #862
  • Oct 06 04:51
    abandoned-prototype closed #862
  • Oct 06 04:51
    abandoned-prototype commented #862
  • Oct 06 04:44
    abandoned-prototype synchronize #862
  • Oct 06 04:44

    abandoned-prototype on pip

    Adhoc/security patch (#873) * … fix image upload fix csrf on admin tags and 4 more (compare)

  • Oct 05 06:46
    abandoned-prototype review_requested #877
  • Oct 05 06:46
    abandoned-prototype synchronize #877
Fritz Davenport
@fritzdavenport
danks :D
Fritz Davenport
@fritzdavenport
@here does flake8 currently work on master?
and by master I mean dev?
Jack Laxson
@jrabbit
it doesn't like install it locally for you no
redshiftzero
@redshiftzero
if you install the requirements in dev-requirements.txt, running flake8 should return 0
Fritz Davenport
@fritzdavenport
$ pwd 
/home/<me>/OpenOversight/OpenOversight
 $ flake8
./manage.py:30:46: E999 SyntaxError: invalid syntax
./db_backup.py:6:26: E999 SyntaxError: invalid syntax
./app/auth/utils.py:20:17: W504 line break after binary operator
./app/main/forms.py:34:6: W605 invalid escape sequence '\w'
./app/main/forms.py:38:6: W605 invalid escape sequence '\w'
./app/main/forms.py:63:6: W605 invalid escape sequence '\w'
./app/main/forms.py:68:6: W605 invalid escape sequence '\w'
./app/main/forms.py:85:6: W605 invalid escape sequence '\w'
./app/main/forms.py:95:6: W605 invalid escape sequence '\w'
./app/main/forms.py:99:6: W605 invalid escape sequence '\w'
./app/main/forms.py:152:6: W605 invalid escape sequence '\w'
./app/main/forms.py:154:6: W605 invalid escape sequence '\w'
./app/main/forms.py:156:6: W605 invalid escape sequence '\w'
./app/main/forms.py:164:6: W605 invalid escape sequence '\w'
./app/main/forms.py:166:6: W605 invalid escape sequence '\w'
./app/main/forms.py:199:6: W605 invalid escape sequence '\w'
./app/main/forms.py:202:6: W605 invalid escape sequence '\w'
./app/main/forms.py:205:6: W605 invalid escape sequence '\w'
./app/main/forms.py:216:6: W605 invalid escape sequence '\w'
./app/main/forms.py:232:6: W605 invalid escape sequence '\w'
./app/main/forms.py:285:7: W605 invalid escape sequence '\d'
./app/main/views.py:166:39: W504 line break after binary operator
./app/main/views.py:167:40: W504 line break after binary operator
sorry if I didn't rtfm
YO I DID MY FIRST OPEN SOURCE PR THO
I'M A REAL PERSON NOWWWWW
redshiftzero
@redshiftzero
lol
hmm can you run flake8 --version
Fritz Davenport
@fritzdavenport
$  flake8 --version
3.6.0 (mccabe: 0.6.1, pycodestyle: 2.4.0, pyflakes: 2.0.0) CPython 3.7.1 on Linux
redshiftzero
@redshiftzero
ah, the deviation is due to your local development environment using version 3.6.0 whereas dev-requirements.txt has version 3.5.0 pinned
are you using a virtualenv?
Fritz Davenport
@fritzdavenport
gotcha. poops. I didn't venv or anything
redshiftzero
@redshiftzero
gotcha yea
Jack Laxson
@jrabbit
pipenv wouldn't solve this but i'd like to push it anyways :^)
b/c i don't think you can get JUST the dev packages
redshiftzero
@redshiftzero
yeah pipenv wouldn't solve this
thoughts welcome on lucyparsons/OpenOversight#565
tl;dr python dependency management is a nightmare
i do love pipenv check tho
Fritz Davenport
@fritzdavenport
++ for pushing pipenv
Jack Laxson
@jrabbit
I mean it works pretty well and you can drop to requirements files easily if you need them
I use it in production even
only had minor issues
mostly due to package devs fucking up
redshiftzero
@redshiftzero
what would the advantage be?
Jack Laxson
@jrabbit
pipenv bakes in hashes
in the lockfiles and requirements (generated by pipenv lock -r)
redshiftzero
@redshiftzero
we can do that now with pip --require-hashes
we just don't ;)
Jack Laxson
@jrabbit
it makes it plausible
instead of "not something we do"
it's ok if it's too much at once but I can work it into the dockerfile shuffle i wanted to do
redshiftzero
@redshiftzero
using pip --require-hashes is actually better than generating requirements.txt from Pipfile/Pipfile.lock for prod as it doesn't keep the hashes
Jack Laxson
@jrabbit
it does keep the hashes iirc
redshiftzero
@redshiftzero
hmm
redshiftzero @redshiftzero tests
Jack Laxson
@jrabbit
oh weird
it doesn't by default at least...
int10h
@brianmwaters
been some talk tonight about getting OO started here in burlington, VT :heart:
Jack Laxson
@jrabbit
well whats stopping us from just using it in the deploy?
it takes care of the venv for you too which is nice
redshiftzero
@redshiftzero
yeah i would be surprised if they added that: we wrote our own tool for SecureDrop to generate the requirements.txt hashes from Pipfile.lock
Fritz Davenport
@fritzdavenport
(we should have a prod docker)
oh - what architecture are yall usin in prod anyway? EC2?
Jack Laxson
@jrabbit
pipenv does do dev separation tho