These are chat archives for OrchardCMS/AdminTheme

12th
Aug 2016
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 09:35
Ok, so which version will we use for the light theme? My preference would be white. The contrast with the dark ones seems too stark to me.
Jasmin Savard
@Skrypt
Aug 12 2016 13:20
I could try with a light dark panel first
Jasmin Savard
@Skrypt
Aug 12 2016 13:39
FireShot Capture 17 - Orchard - Module_ - http___localhost_30321_OrchardLocal_Admin_Modules_Features.png
could be also using primary color
would just need some adjustments on controls colors
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 14:31
I think that's too much / too busy. White seems best to me, given the current "light" theme.
Jasmin Savard
@Skrypt
Aug 12 2016 14:36
alright, white it is :)
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 14:36
Excellent choice
Jasmin Savard
@Skrypt
Aug 12 2016 14:36
I'm going to wait before pushing because I have lots of changes locally
some of them are not done completely
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 14:38
No problem for me
Jasmin Savard
@Skrypt
Aug 12 2016 14:55
While you are here. Do you agree on the implementation of the left side menu ?
OrchardCMS/Orchard#7019
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 14:59
Well, I am not sure I understand why "open on hover" would not work on mobile devices. Isn't it so that on mobile devices, a "hover" event is triggered upon a tap?
Wait, I remember something Sebastien proposed: to do it the same way as the current admin theme, where the user needs to click on an arrow to expand the sub menu.
Jasmin Savard
@Skrypt
Aug 12 2016 15:00
It got changed by Antoine because Sebastien requested that it looks like the current menu.
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:01
That way, we don't need to handle with hovering, and users can either click the main menu item, or the arrow to expand.
Ok, I haven't seen his latest work.
Jasmin Savard
@Skrypt
Aug 12 2016 15:01
Then you pointed to the fact that since now it's an accordion menu we can't open a root section without adding it to the sub-menu list
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:01
Yes, I know. Then Sebastien suggested what I just typed in.
Jasmin Savard
@Skrypt
Aug 12 2016 15:01
So I added to opening of the default sub-section by clicking on the icon
because that small arrow icons is tiny
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:02
Icon, instead of arrow?
Aha
Is this common?
Jasmin Savard
@Skrypt
Aug 12 2016 15:02
well right now the behavior is
when you click on the menu item section it will open up the sub-menu list
but if you click on the root section icon it will open up the default sub-menu item
open up the action of that item
like it did before
So I just reverted the behavior
It's just for being easier on mobile devices
I can't argue if it is common or not. Just seems to me like the best alternative.
most people from start will click on the menu section
it will open up the sub-menu
I'm thinking about a user that will use a iPad mostly
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:07
Ok. Do you know how other themes solve this? I believe AdminLTE always opens the sub menu upon clicking the main menu item, right?
Jasmin Savard
@Skrypt
Aug 12 2016 15:07
right
so in that case we need to add a sub-menu item for the default action that was on that root menu item
I think that's why Antoine changed it back to what it was
mainly
I mean if we look at what I did. Logically, people will expect that clicking on that root menu item : it will open up the sub-menu
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:10
Maybe we should go with what you said: clicking the root menu item icon will open the sub menu. Clicking the text of the menu item will take the user to the default action of the menu item. Clicking the arrow will open the menu item. The arrow, I presume, is only visible on wider screens - not on smaller viewports.
Logically, how do you figure that?
Jasmin Savard
@Skrypt
Aug 12 2016 15:11
Because it's an accordion
before we could open every sub-sections
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:11
That's a good point. It's no longer a flyout menu.
Jasmin Savard
@Skrypt
Aug 12 2016 15:12
I'm not sure but I think Antoine said that the sub-menus we're not working on mobile devices
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:12
Then I think that answers it. An unfortunate side effect of the accordion is that we always require a sub menu item.
Jasmin Savard
@Skrypt
Aug 12 2016 15:12
I would need to revert back to test it.
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:13
It would surprise me that the original Amaretti would not work properly on a mobile device, but I have not tested it.
Jasmin Savard
@Skrypt
Aug 12 2016 15:13
will try
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:13
You won't have to revert it - there is an online demo of Amaretti.
Jasmin Savard
@Skrypt
Aug 12 2016 15:13
on the Amaretti theme directly
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:13
Exactly
Jasmin Savard
@Skrypt
Aug 12 2016 15:14
my laptop has a touch screen
does not work
tried single, double, triple tap
swipe either
I don't mind putting back the flyout menu
if we fix the mobile behavior
Well, the idea was to have the flyout menu when I click on the small icon I added in the bottom of the menu
so that we can switch from the accordion menu
to the flyout menu
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:17
That would be cool I think
Jasmin Savard
@Skrypt
Aug 12 2016 15:17
then we get both
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:18
Yes
Let the people choose.
Jasmin Savard
@Skrypt
Aug 12 2016 15:18
So the last thing we need to agree on is how we open up the default action on the accordion menu
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:19
When would this default action be triggered?
I mean, if you click the root menu item, the accordion opens up.
It would need at least one sub menu item. Perhaps, if there are no sub menu items, then it simply goes to whatever URL was configured on the root menu item
Jasmin Savard
@Skrypt
Aug 12 2016 15:21
Let me check but I'm pretty sure there was direct link to creating a blog post on that root menu blog item
or to create a blog
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:22
There was. In the new admin theme, this could no longer work (for the accordion) - we would require a sub menu item.
Jasmin Savard
@Skrypt
Aug 12 2016 15:23
Can I demo you what I did ? Would be easier
Sipke Schoorstra
@sfmskywalker
Aug 12 2016 15:23
What we could do is this: when rendering the accordion, check if there is a default action - if there is, automatically add a sub menu item that is the same as the root menu item.
Yes
I'm on Skype