These are chat archives for OrchardCMS/AdminTheme

24th
Jul 2017
Sotiris Roussos
@urbanit
Jul 24 2017 09:38
Hi, back on track with this after short vacation. About point 1, it is really strange and I do not know how it should look like...
Should it be like that?
FireShot Capture 8 - Amaretti - Responsive Admin Templ_ - http___wrapbootstrap.com_preview_WB0696K5S.png
Or like that?
440d29d6-3fcd-11e6-9228-3532c13c9f88.png
Xceno
@Xceno
Jul 24 2017 09:51
I think like the second one
I'm just a bit concerned what happens if we expand that list
i have a view custom modules who do this
will test them later
Sotiris Roussos
@urbanit
Jul 24 2017 09:52
The buttons group you mean?
Xceno
@Xceno
Jul 24 2017 09:52
I think it'll look pretty ugly / verbose when that thing has 2 or more row
yeah
Sotiris Roussos
@urbanit
Jul 24 2017 09:54
Maybe we should add icons to all buttons (standard and extra) as well and if many(?) to hide text, css wise
Xceno
@Xceno
Jul 24 2017 10:03
probably yes, I've also read in the issue mentioned above that "every" button in the admin theme should have an icon (I think for the reason you mentioned)
Do we have a set of standard icons laying around already?
If I do not forget something else.
Xceno
@Xceno
Jul 24 2017 10:10
ah nice
now i get why every fa was changed to s7 ;) didn't bother looking it up
Sotiris Roussos
@urbanit
Jul 24 2017 10:11
Looking around, https://darkskyapp.github.io/skycons/ is not likely to use... :-p
This change made just to keep in sync with the original theme...
Xceno
@Xceno
Jul 24 2017 11:14
true, but they come in handy for me for another project haha
Jasmin Savard
@Skrypt
Jul 24 2017 11:27
that button list used to collide when the window was too small
now I'm guessing that the problem is that the javascript component that was applying changes on that item is not working anymore on that view
try to look on other views that are similar to find if there's not some place like on the blogs module that could work.
Sotiris Roussos
@urbanit
Jul 24 2017 11:29
Ok, I see... I think it is the same on blog... And we have duplicate actions, that's the weird thing
Jasmin Savard
@Skrypt
Jul 24 2017 11:29
try also to look into the javascript console for any error that might give you a hint on what's missing
yeah, that's because that list is supposed to be a contextual menu that opens up only when the window width is small
but it's always displaying like if it missed a display: none
but also it's not anchored at the right place
Sotiris Roussos
@urbanit
Jul 24 2017 11:30
ok, inderstood... Let me check for js errors
Sotiris Roussos
@urbanit
Jul 24 2017 11:39
2017-07-24.png
Xceno
@Xceno
Jul 24 2017 11:40
so no errors coming from the buttons
i think it's just a css issue
and of course some buttons are rendered twice, which is an error in itself
Sotiris Roussos
@urbanit
Jul 24 2017 11:42
Edit & Delete are duplicates, all others are not
Xceno
@Xceno
Jul 24 2017 11:42
(btw: I can only do hands on work on that theme at night. So for now I just drop wild guesses/comments ;) )
Sotiris Roussos
@urbanit
Jul 24 2017 19:24
Orchard.Web\Themes\TheAdmin\Assets\Js\orchard-admin.js --> function renderContentItemActions() creates the problem... I will get a look at it later though or tomorrow. @Skrypt if this reminds you what it does, it would be helpful