Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 22 15:46
    dependabot[bot] labeled #90
  • Jun 22 15:46
    dependabot[bot] opened #90
  • Jun 22 15:46

    dependabot[bot] on nuget

    Bump Newtonsoft.Json from 7.0.1… (compare)

  • Jun 22 15:45
    dependabot[bot] labeled #89
  • Jun 22 15:45
    dependabot[bot] opened #89
  • Jun 22 15:45

    dependabot[bot] on nuget

    Bump Newtonsoft.Json from 7.0.1… (compare)

  • Nov 27 2021 19:50
    Krutonium closed #88
  • Nov 24 2021 17:42
    Krutonium commented #88
  • Nov 24 2021 17:42
    Krutonium commented #88
  • Nov 24 2021 11:08
    jamesixgun commented #88
  • Nov 24 2021 07:30
    Krutonium commented #88
  • Nov 22 2021 23:31
    jamesixgun commented #88
  • Nov 22 2021 23:15
    jamesixgun opened #88
  • Nov 26 2018 18:37
    Policegking closed #87
  • Nov 26 2018 18:31
    Policegking opened #87
  • Oct 09 2018 04:19
    thorsummoner closed #73
  • Sep 26 2018 20:30
    francoism90 closed #72
  • Sep 05 2017 12:50
    runelaenen commented #86
  • Sep 03 2017 04:42
    jamtraks closed #86
  • Sep 03 2017 04:42
    jamtraks commented #86
LRFLEW
@LRFLEW
I trust you on it as the translator. It just seemed like it could be a problem to me.
Hielke Morsink
@Broxzier
It's right next to other OpenRCT2 settings, so I'd assume the player is smart enough to see it's about the game's window, not their screen
LRFLEW
@LRFLEW
I mean, I guess, but that's not the confusion I'm worried about. When they see "Schermresolutie" in-game, it means "resolution the game pretends the screen is at when the game is in fullscreen". So having it in the launcher to mean "the size of the window that the game is in when the game is played in a window" seems like it could cause confusion. I understand that there's an issue with there not being a good direct translation to convey that, but if I start getting error reports that the option isn't changing the fullscreen resolution because of the translation issue, I'm going to be a little annoyed.
Hielke Morsink
@Broxzier
Oh right, it's just about the size of the window, and fullscreen is not affected by it. In that case "Venster grootte" would be more clear
LRFLEW
@LRFLEW
That looks good to me (and Google Translate :P ). :+1:
Hielke Morsink
@Broxzier
I see it was also missing the :
Shouldn't there be one behind "Language" too?
"Server Name" is also missing one
All other labels with a field behind them seem to be correct
LRFLEW
@LRFLEW
Yeah. I saw that, and would correct that myself if you hadn't.
Hielke Morsink
@Broxzier
I fixed them in the Dutch translation now too
LRFLEW
@LRFLEW
The Linguist tool can show a warning for those.
Hielke Morsink
@Broxzier
Yeah, that's nifty
LRFLEW
@LRFLEW
Unfortunately, it doesn't warn about the space :/
Hielke Morsink
@Broxzier
I haven't changed the English translation by the way, only the Dutch. I was talking about them missing in the English one.
Whoops, it sets the one I changed to unfinished, fixing it now
Hielke Morsink
@Broxzier
Fixed
LRFLEW
@LRFLEW
Yeah, the english one (which I'm calling the "POSIX" one based on how Qt uses it, and that there are english translation files) needs some work. I planned on fixing it once your PR was merged so that I could go through and fix all the translated languages at the same time.
LRFLEW
@LRFLEW
@Broxzier I checked everything, and it looks good... except the translation for "bin dir not created" is too long :P
It's worded so strangely in the english translation because it needs to be very short, and it's more of a technical error anyways.
Hielke Morsink
@Broxzier
Would "Fout bij maken van bin map." (Error creating bin folder) fit?
Otherwise maybe "Bin map niet gemaakt", but that's not very clear
Michael Steenbeek
@Gymnasiast
That's incorrect Dutch.
Both of them.
LRFLEW
@LRFLEW
Well, "bin dir not created" isn't correct English either :P
It's an uncommon error, pretty much only possible by having the OpenRCT2 save location set to read only, or for there to be a file called "bin"
Krutonium
@Krutonium
How about "Failed to create 'bin' directory"
LRFLEW
@LRFLEW
That's kind of long for the area it has
"bin folder not created" is probably what it should be :P
I may consider making it, and the related errors, untranslatable, so that the error reports for it would be language independent :P
Krutonium
@Krutonium
0x0001010
LRFLEW
@LRFLEW
Lol :P
Krutonium
@Krutonium
AKA How to make your users hate you 101
LRFLEW
@LRFLEW
I mean, if anybody sees the "Error extracting archive" error, then something has gone terribly, terribly wrong.
Hielke Morsink
@Broxzier
@Gymnasiast: I know, but I can't think of anything similar that's valid and would fit...
Michael Steenbeek
@Gymnasiast
Fout bij maken van 'bin'-map.
LRFLEW
@LRFLEW
It fits, but tight enough that there may be platform-dependent size issues.
Again, I might just make (some of) those strings untranslatable, and leave it at that.
LRFLEW
@LRFLEW
Welp, got my first issue report unrelated to the launcher :P
Krutonium
@Krutonium
Eventually you just start ignoring them
Michael Steenbeek
@Gymnasiast
I just helped that guy. :)
Matte A
@Nubbie
8v98tn.jpg
Krutonium
@Krutonium
:cookie:
LRFLEW
@LRFLEW
:cookie: Thank you for that. I wasn't sure the best way to respond to help him understand it. Is there something I should add to my readme and/or release notes to make that more clear?
Krutonium
@Krutonium
Honestly most of the time I would help them as best as I could and direct them to the right github page.
King Oliver
@Kingoliver11_twitter
@PFCKrutonium Assertion failed! program: C:\Program Files (x86)\OpenRCT2\openrct2.dll File: src\network\NetworkKey.cpp Line: 95 Expression: file != nullptr For information on how your program can cause an assertion failure, see the Visual C++ documentation on asserts (Press Retry to debug the application - JIT must be enabled) can u help?
Hielke Morsink
@Broxzier
@Kingoliver11_twitter: That looks like an error with OpenRCT2, not with the launcher. Please go to https://gitter.im/OpenRCT2/OpenRCT2 for help.
LRFLEW
@LRFLEW
Can someone explain what is being asked of me with LRFLEW/OpenRCT2Launcher#22 ? I feel like I'm missing something here
Matte A
@Nubbie
Automatic updates of the game - settings to check for new updates and how frequently (being able to update OpenRct2 via launcher)
If you already have it implanted- feedback :)