the other one (return) is being made here FriendsOfPHP/PHP-CS-Fixer#4435 I think, so if you've time please review and test that one : )
Hello @SpacePossum , Thank you for answer. Btw, I fixed this behaviour in "./src/Fixer/Basic/BracesFixer.php" and "src/Fixer/FunctionNotation/MethodArgumentSpaceFixer.php"
I completely dont know how to write custom fixers (I found some examples, and they are too complecated). I can give you my diffs, if you write some code to do this as some "preferences" it will be great. I know about PSR-2 and other "bigger standarts", but other formatters and linters based on just PSR have not many options. Like strictly use spaces instead of tabs, or "\n" ending instead of "\r\n", which I use for indenting, or the option "binary_operator_spaces" where I can set "no_space" for any operator I like. I like "php-cs-fixer" for its flexibility. Its not much code to add new indenting features "out of the box".
The code to remove spaces between method arguments was in:
"src/Fixer/FunctionNotation/MethodArgumentSpaceFixer.php"
+ 455:3: $nextToken->override(array('', ''));
+ 456:3: return;
- 475:3: $tokens->insertAt($index + 1, new Token([T_WHITESPACE, ' ']));
+ 475:3: //$tokens->insertAt($index + 1, new Token([T_WHITESPACE, ' ']));Some my fixes for Spaces around Braces and Parentheses. in
"src/Fixer/Basic/BracesFixer.php"
There are actually 3 different features in this diff:
1) add the new line before T_ELSE, T_ELSEIF, I knew many people asked for it, its actually easy to separate getControlContinuationTokens, for those who asked
2) remove space around parentheses in control structures like "function () {", or "if (...) {"
3) fix indentation bug which i found in auto-added braces where
"else some();" transformed to
"else {
some();}" - there should be line ending and $indent before closing brace;
+ 336:4: if (' ' === $tokens[$parenthesisEndIndex + 1]->getContent()) {
+ 337:4: $tokens[$parenthesisEndIndex + 1]->override(['', '']);
+ 338:4: }
+ 596:4: // fix for space after function parenthesis
+ 597:4: $tokens->removeTrailingWhitespace($closingParenthesisIndex);
- 638:4: $tokens->insertAt($statementEndIndex + 1, [new Token([T_WHITESPACE, ' ']), new Token('}')]);
+ 638:4: // Fix for wrong Indentation after autoinserted braces
+ 639:4: $indent = $this->detectIndent($tokens, $index);
+ 640:4: $tokens->insertAt($statementEndIndex + 1, [new Token($this->whitespacesConfig->getLineEnding().$indent), new Token('}')]);
+ 666:4: if (' ' === $tokens[$nextNonWhitespaceIndex - 1]->getContent()) {
+ 667:4: $tokens[$nextNonWhitespaceIndex - 1]->override(['', '']);
+ 668:4: }
+ 669:4: /*
+ 677:4: */
- 838:4: T_ELSE,
+ 838:4: //T_ELSE,
- 839:4: T_ELSEIF,
+ 839:4: //T_ELSEIF,
- 850:4: T_ELSE,
+ 850:4: //T_ELSE,
- 851:4: T_ELSEIF,
+ 851:4: //T_ELSEIF,
+ 891:4: $tokens->removeLeadingWhitespace($startParenthesisIndex);
+ 896:4: $tokens->removeTrailingWhitespace($endParenthesisIndex);I never contibuted code to opensource, so if you can add this as a optional feature, I will be very grateful.
I updated: FriendsOfPHP/PHP-CS-Fixer#4362, FriendsOfPHP/PHP-CS-Fixer#4310 and FriendsOfPHP/PHP-CS-Fixer#4275
Is there anyone to help me get one config file or create a good config file that does not have conflict with WordPress coding standard?
I'm totally new to PHP-CS-Fixer, but I already enjoy it a lot.
I use it in Sublime, and I get a lot of errors on my comments from my linter like:
phpcs: error
error - Tag value for @since tag indented incorrectly; expected 2 spaces but found 4I tried to use the docs of CS-Fixer, and tried out a lot of setting, but could not made it fix it automatically.
My
.phpcsfixer file looks like this at the moment:<?php
return PhpCsFixer\Config::create()
->setRules([
'@PSR2' => true,
'array_syntax' => ['syntax' => 'short'],
'align_multiline_comment' => ['comment_type' => 'phpdocs_like'] ,
'doctrine_annotation_indentation' => [ 'indent_mixed_lines' => true ]
]);<?php
return PhpCsFixer\Config::create()
->setRules([
'@PSR2' => true,
'array_syntax' => ['syntax' => 'short'],
'align_multiline_comment' => ['comment_type' => 'all_multiline'] ,
'heredoc_indentation' => true,
'doctrine_annotation_indentation' => true,
'doctrine_annotation_spaces' => [
'after_argument_assignments' => true,
'after_array_assignments_colon' => true,
'after_array_assignments_equals' => true,
'around_parentheses' => true,
'before_argument_assignments' => true,
'before_array_assignments_colon' => true,
'before_array_assignments_equals' => true,
]
'phpdoc_align' => true,
'phpdoc_indent' => true,
'phpdoc_order' => true,
'phpdoc_separation' => true,
'phpdoc_single_line_var_spacing' => true,
'phpdoc_var_annotation_correct_order' => true,
'psr4' => true,
'psr0' => true,
'no_unused_imports' => true,
]);@SpacePossum
/**
* The ID of this plugin.
*
* @since 1.0.0
* @access private
* @var string $_plugin_name The ID of this plugin.
*/
private $_plugin_name;And the error, what my linter says:
phpcs: error
error - Tag value for @since tag indented incorrectly; expected 2 spaces but found 4
error - Tag value for @access tag indented incorrectly; expected 1 spaces but found 3
error - Tag value for @var tag indented incorrectly; expected 4 spaces but found 6
true. Then, each project can use it with configuration it wants. In PHP CS Fixer project, we follow Symfony's ruleset configuration, that configures b_mode=false