Hi there,
I have a question about \DI\get() and the documentation saying that it's a "alias" to any existing definition. The result I get is a bit misleading when dealing with non-singleton objects. Here's my example:
class UniqId {
public $id;
public function __construct() {
$this->id = uniqid();
}
}
class OtherClass {
public $id;
public function __construct(UniqId $u) {
$this->id = $u->id;
}
}
$containerBuilder = new DI\ContainerBuilder();
$containerBuilder->addDefinitions([
UniqId::class => \DI\create(),
'UniqId_alias' => \DI\get(UniqId::class),
OtherClass::class => \DI\autowire(),
'OtherClass_alias' => \DI\get(OtherClass::class),
'OtherClass_alias2' => \DI\autowire(OtherClass::class)
->constructorParameter('u', \DI\get('UniqId_alias'))
]);
$container = $containerBuilder->build();
var_dump([
'UniqId ' => $container->make(UniqId::class)->id,
'UniqId (again) ' => $container->make(UniqId::class)->id,
'UniqId_alias ' => $container->make('UniqId_alias')->id,
'OtherClass ' => $container->make(OtherClass::class)->id,
'OtherClass_alias ' => $container->make('OtherClass_alias')->id,
'OtherClass_alias2 ' => $container->make('OtherClass_alias2')->id,
]);The result is as follows:
array (size=6)
'UniqId ' => string '5d0e6194728ec' (length=13)
'UniqId (again) ' => string '5d0e619472911' (length=13)
'UniqId_alias ' => string '5d0e61947294e' (length=13)
'OtherClass ' => string '5d0e61947294e' (length=13)
'OtherClass_alias ' => string '5d0e61947294e' (length=13)
'OtherClass_alias2 ' => string '5d0e61947294e' (length=13)My idea was that as UniqId is defined as a non-singleton because of \DI\create(), so were its references when used as dependencies of other classes (here OtherClass ot its aliases). But actually it's not. The only solution I've found is to "force" it when defining the dependent class:
...
'OtherClass_alias3' => \DI\autowire(OtherClass::class)
->constructorParameter('u', \DI\create(UniqId::class))
...
but this way, we loose the power of creating a particular definition only once.
To be more precise about what results I'm confused about, it's:
'OtherClass ' => string '5d0e6316dbd5a' (length=13)
'OtherClass_alias ' => string '5d0e6316dbd5a' (length=13)
'OtherClass_alias2 ' => string '5d0e6316dbd5a' (length=13)where clearly the instance of UniqId which is injected in OtherClass is a singleton, when I would like to have a new instance each time a new OtherClass is created.
Uncaught DI\NotFoundException: No entry or class found
Where I could go to resolve this ?
Some problem in there ?
@mnapoli Any suggestions on how to resolve circular dependency issues? I have a request handler that needs a command bus to handle a command, that command triggers an event that’s emitted on an event bus, which has an event listener that also requires the commandbus. I thought this wouldn’t be an issue, but apparently it is.
@Brammm What you might want to try is to inject one of the dependencies via setter and not via constructor. This way you should be able to construct an (still incomplete) object, and then add the missing dependency, without falling into a CD issue. See http://php-di.org/doc/php-definitions.html#objects
Hey, @nanawel, thanks for the reply. What I tried to do was to register a factory class in the container which is responsible for creating new instances for me. Then I inject that factory class into my controllers via the constructor. However, even in this case it seems like when I use the factory within the constructor to generate a new instance I'm still just getting the same instance. Does that line up with your understanding too?
first time user of Slim4 framework and first time even trying to use a DI. Slim4 uses PHP-DI and i'm having a hell of a time figuring out how to use it. It seems to only inject SOME of the dependencies while ignoring others. How do i debug this or troubleshoot it? I've run "composer dump-autoload" to no avail, it has the classes mapped correctly. Everything is typehinted, and explicit "use blah/blah" exist as well. any help would be appreciated
== index.php
declare(strict_types=1);
(require __DIR__ . '/app/config/bootstrap.php')->run();
== bootstrap.php
declare(strict_types=1);
use DI\ContainerBuilder;
use Slim\App;
require_once __DIR__ . '/../../../vendor/autoload.php';
$containerBuilder = new ContainerBuilder();
$containerBuilder->addDefinitions(__DIR__ . '/container.php');
$container = $containerBuilder->build();
$app = $container->get(App::class);
(require __DIR__ . '/routes.php')($app);
(require __DIR__ . '/middleware.php')($app);
return $app;
== container.php
declare(strict_types=1);
use Psr\Container\ContainerInterface;
use Selective\Config\Configuration;
use Slim\App;
use Slim\Factory\AppFactory;
return [
Configuration::class => function () {
return new Configuration(require __DIR__ . '/settings.php');
},
App::class => function (ContainerInterface $container) {
AppFactory::setContainer($container);
$app = AppFactory::create();
//$app->setBasePath('/app');
return $app;
},
PDO::class => function (ContainerInterface $container) {
$config = $container->get(Configuration::class);
...
return new PDO($dsn, $username, $password, $flags);
},
];
== settings.php
$settings = [];
$settings['root'] = dirname(__DIR__);
$settings['temp'] = $settings['root'] . '/tmp';
$settings['public'] = $settings['root'] . '/public';
$settings['error_handler_middleware'] = [
'display_error_details' => true,
'log_errors' => true,
'log_error_details' => true,
];
$settings['db'] = [
'driver' => 'mysql',
'host' => 'localhost',
...
'charset' => 'utf8mb4',
'collation' => 'utf8mb4_unicode_ci',
'flags' => [
...
],
];
return $settings;== routes.php
declare(strict_types=1);
use Slim\Http\Response;
use Slim\Http\ServerRequest;
use Slim\App;
//require \App\Action\HomeAction;
//require __DIR__ . '/../action/HomeAction.php';
//require __DIR__ . '/../action/AccountReadAction.php';
return function (App $app) {
$app->get('/', \App\Action\HomeAction::class);
$app->get( '/api/v1/accounts', \App\Action\AccountReadAllAction::class);
$app->post( '/api/v1/account/new', \App\Action\AccountCreateAction::class);
$app->get( '/api/v1/account/{id}', \App\Action\AccountReadAction::class);
$app->patch( '/api/v1/account/{id}', \App\Action\AccountUpdateAction::class);
$app->delete( '/api/v1/account/{id}', \App\Action\AccountDeleteAction::class);
};
== Error Message
Slim Application Error
The application could not run because of the following error:
Details
Type: RuntimeException
Code: 0
Message: Callable App\Action\AccountReadAction does not exist
File: /home/PROJECTNAME/vendor/slim/slim/Slim/CallableResolver.php
Line: 137
Trace
#0 /home/PROJECTNAME/vendor/slim/slim/Slim/CallableResolver.php(91): Slim\CallableResolver->resolveSlimNotation('App\\Action\\Acco...')
#1 /home/PROJECTNAME/vendor/slim/slim/Slim/CallableResolver.php(61): Slim\CallableResolver->resolveByPredicate('App\\Action\\Acco...', Array, 'handle')
#2 /home/PROJECTNAME/vendor/slim/slim/Slim/Routing/Route.php(358): Slim\CallableResolver->resolveRoute('App\\Action\\Acco...')
#3 /home/PROJECTNAME/vendor/slim/slim/Slim/MiddlewareDispatcher.php(73): Slim\Routing\Route->handle(Object(Slim\Http\ServerRequest))
#4 /home/PROJECTNAME/vendor/slim/slim/Slim/MiddlewareDispatcher.php(73): Slim\MiddlewareDispatcher->handle(Object(Slim\Http\ServerRequest))
#5 /home/PROJECTNAME/vendor/slim/slim/Slim/Routing/Route.php(333): Slim\MiddlewareDispatcher->handle(Object(Slim\Http\ServerRequest))
#6 /home/PROJECTNAME/vendor/slim/slim/Slim/Routing/RouteRunner.php(80): Slim\Routing\Route->run(Object(Slim\Http\ServerRequest))
#7 /home/PROJECTNAME/vendor/slim/slim/Slim/Middleware/BodyParsingMiddleware.php(50): Slim\Routing\RouteRunner->handle(Object(Slim\Http\ServerRequest))
#8 /home/PROJECTNAME/vendor/slim/slim/Slim/MiddlewareDispatcher.php(132): Slim\Middleware\BodyParsingMiddleware->process(Object(Slim\Http\ServerRequest), Object(Slim\Routing\RouteRunner))
#9 /home/PROJECTNAME/vendor/slim/slim/Slim/Middleware/RoutingMiddleware.php(58): class@anonymous->handle(Object(Slim\Http\ServerRequest))
#10 /home/PROJECTNAME/vendor/slim/slim/Slim/MiddlewareDispatcher.php(132): Slim\Middleware\RoutingMiddleware->process(Object(Slim\Http\ServerRequest), Object(class@anonymous))
#11 /home/PROJECTNAME/vendor/slim/slim/Slim/Middleware/ErrorMiddleware.php(89): class@anonymous->handle(Object(Slim\Http\ServerRequest))
#12 /home/PROJECTNAME/vendor/slim/slim/Slim/MiddlewareDispatcher.php(132): Slim\Middleware\ErrorMiddleware->process(Object(Slim\Http\ServerRequest), Object(class@anonymous))
#13 /home/PROJECTNAME/vendor/slim/slim/Slim/Middleware/ErrorMiddleware.php(89): class@anonymous->handle(Object(Slim\Http\ServerRequest))
#14 /home/PROJECTNAME/vendor/slim/slim/Slim/MiddlewareDispatcher.php(132): Slim\Middleware\ErrorMiddleware->process(Object(Slim\Http\ServerRequest), Object(class@anonymous))
#15 /home/PROJECTNAME/vendor/slim/slim/Slim/MiddlewareDispatcher.php(73): class@anonymous->handle(Object(Slim\Http\ServerRequest))
#16 /home/PROJECTNAME/vendor/slim/slim/Slim/App.php(208): Slim\MiddlewareDispatcher->handle(Object(Slim\Http\ServerRequest))
#17 /home/PROJECTNAME/vendor/slim/slim/Slim/App.php(192): Slim\App->handle(Object(Slim\Http\ServerRequest))
#18 /home/PROJECTNAME/public_html/index.php(5): Slim\App->run()
#19 {main}
So i included the routes.php which is the next step that would run, which you saw in the bootstrap.php earlier. But unless i manually put those includes (which are commented out) it gives me the above error message. But you can see it's not throwing errors for Slim\App or anything else, but it does for \App\Action\AccountReadAction
I don't know Slim, but to me this looks more like an autoload issue than a DI issue. Are you sure you have an autoloader somewhere that's able to handle
\App classes? Otherwise if it follows PSR-4 convention (which it should) you can add it to your composer.json like so: https://getcomposer.org/doc/04-schema.md#psr-4
{
"require": {
"php": ">=7.1",
"ext-json": "*",
"monolog/monolog": "^2.0",
"php-di/php-di": "^6.0",
"selective/config": "^0.1.1",
"slim/http": "^0.8.0",
"slim/psr7": "^0.6.0",
"slim/slim": "4.*"
},
"require-dev": {
"phpunit/phpunit": "8"
},
"autoload": {
"psr-4": {
"App\\": "public/app/"
}
}
}
Sorry I won't be able to help you more for today (you know, Xmas and stuff) but I'll try to come back in a few days. In the meantime, try to use the debugger to trace how files are (auto)loaded and classes are resolved, you might figure out what's wrong more easily.
oh and yes, you are correct, that is the path of the file
The learning curve is just a bit steep
i have to say it's really tempting to just say screw it and just manually put the require lines in and be done with it
@gmariani It looks like an PSR-4 autoloader issue. Make sure that you defined the correct namespaces and paths in your composer.json file. Linux is case sensitive. For example if you have a namespace
App\Action, then your directory should be named like this: src/Action/ and not src/action/.
Hello :wave: when using the autowiring to load classes, if the class can not be instantiated because of an exception the container just returns null, is this behaviour intended (I don't know if I've changed something) and is there any way I can make these exceptions get thrown out of the container so I can handle them myself?
Hi. I have this problem, when I upload my project to a host this error activates me: Fatal error: Not captured DI \ NotFoundException: No entry or class was found for 'App \ Controllers \ AuthController' in /home/vrfctuqw/myhonsting.com/ vendor /php-di/php-di/src/Container.php:135 Stack tracking: # 0 /home/vrfctuqw/myhosting.com/vendor/php-di/php-di/src/CompiledContainer.php(64) : DI \ Container-> get ('App \ Controllers ...') # 1 /home/vrfctuqw/myhosting.com/public/index.php(474): DI \ CompiledContainer-> get ('App \ \ Controllers ... ') # 2 {main} included in /home/vrfctuqw/myhosting.com/vendor/php-di/php-di/src/Container.php on line 135
Locally it works correctly, but in hosting I present this. I would like you to help me please
Hi I have used "mnapoli/php-di": "~4.0", "container-interop/container-interop": "^1.1", for my application and now im moving to php 7 with "php-di/php-di": "6.0.11", "psr/container": "^1.0.0", I'm getting "Entry "Idfix\Contracts\RegistryInterface" cannot be resolved: the class is not instantiable Full definition: Object ( class = #NOT INSTANTIABLE# Idfix\Contracts\RegistryInterface lazy = false )" this issue please advice
Hello! So, after doing
composer update I get a notice that the package jeremeamia/superclosure is abandoned and php-di seems to require/depend on this package. Any solutions to this problem especially that the recommendation is using opis/closure and it's not advisable to edit composer.lock directly??
