These are chat archives for PHPOffice/PHPPresentation

22nd
May 2015
Progi1984
@Progi1984
May 22 2015 06:31
The pull request is this of @kenliau ;)
Kenny Liau
@kenliau
May 22 2015 12:57
Hey @Progi1984 sorry, didn't have time yesterday to update Changelog. Thanks for updating for me.
Also, I'm not sure why the unit tests failed.
Progi1984
@Progi1984
May 22 2015 12:57
@kenliau No problem
Units tests didn't fail, but PHPCS & PHPMD reports failed
Kenny Liau
@kenliau
May 22 2015 13:02
Ah I just saw your commit
It is expecting a line end of file. Right?
Progi1984
@Progi1984
May 22 2015 13:22
@kenliau Yeap :) and two variables unused (for PHPMD)
Kenny Liau
@kenliau
May 22 2015 13:36
Got it. New at this. Thanks!