These are chat archives for PHPOffice/PhpSpreadsheet

30th
Oct 2017
Frédéric Delaunay
@Dfred
Oct 30 2017 16:34
@PowerKiKi I believe the Calculation Engine could create better errors and could discuss that before submitting a PR.
Frédéric Delaunay
@Dfred
Oct 30 2017 16:43
In effect there are syntax errors, reference/names errors, and calculation errors (such as division by 0).
With the latter, errors from call_user_func_array() bypass raiseFormulaError().
Plus, error strings could be rewritten with gettext __() in mind.
Also, the calculation context in the Stack object is unused while it could help a lot.
Frédéric Delaunay
@Dfred
Oct 30 2017 16:48
I ended up passing a copy of the last stack element along and making sure raiseFormulaError is always called.
thoughts?