PegaSysEng/artemis

Jonny Rhea

@jrhea

🤘

Jonny Rhea

@jrhea

@kanthgithub sorry for the delayed reply. I could use some help with this: PegaSysEng/artemis#664

Jonny Rhea

@jrhea

@mankenavenkatesh in future PRs, do u mind submitting them from a seperate branch than your forked master? it makes it a little easier on our end. thanks

Jonny Rhea

@jrhea

oh and your PR was successfully merged!! thanks buddy

lakshmi kanth

@kanthgithub

@jrhea thanks , will start working on #664

Venkatesh Mankena

@mankenavenkatesh

@jrhea Sure. Will create a separate branch next time. Thanks Jonny :)

Jonny Rhea

@jrhea

@kanthgithub someone completed it yesterday. 😅

lakshmi kanth

@kanthgithub

@jrhea got it . Can take another open issue. Let me know the Next one in order

Antoine Toulme

@atoulme

hey I’m trying to run artemis in the eth2 test runner, and I get this exception at every epoch

May 23, 2019 9:50:19 PM com.google.common.eventbus.EventBus$LoggingHandler handleException
SEVERE: Exception thrown by subscriber method onNewHeadStateEvent(tech.pegasys.artemis.statetransition.HeadStateEvent) on subscriber tech.pegasys.artemis.validator.coordinator.ValidatorCoordinator@46d63dbb when dispatching event: tech.pegasys.artemis.statetransition.HeadStateEvent@551f7234
java.lang.IllegalArgumentException
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:127)
at tech.pegasys.artemis.datastructures.util.BeaconStateUtil.get_block_root(BeaconStateUtil.java:559)
at tech.pegasys.artemis.datastructures.util.AttestationUtil.createAttestations(AttestationUtil.java:613)
at tech.pegasys.artemis.validator.coordinator.ValidatorCoordinator.onNewHeadStateEvent(ValidatorCoordinator.java:102)
at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:87)
at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:144)
at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:72)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)

Antoine Toulme

@atoulme

I filed an issue, easier to discuss there: PegaSysEng/artemis#678

Steven Schroeder

@schroedingerscode

:+1:

Venkatesh Mankena

@mankenavenkatesh

Hi Everyone,
i am working on code changes for Dynamic Json fields of Events.
I have added following config to toml.

[output.fileds] TimeSeriesRecord = [date, index, slot, epoch] Eth2Genesis = [deposit_root, deposit_count, time]

Inside ArtemisConfiguration, i am thinking of creating a map which contains Key as EventName and Value as "Array of output fields".
This map can be used to fetch the output fields for specific event when event is generated and create Dynamic JSON.

is this right approach?
i don't find method to generate map inside SchemaBuilder class. Let me know the alternative.

Jonny Rhea

@jrhea

@atoulme since you wrote the SchemaBuilder in ApacheTuweni, can you answer @mankenavenkatesh's question?

Antoine Toulme

@atoulme

SchemaBuilder is for toml right? It can take a map IIRC.

ok here is the reasoning. If you mean to add individual key/value pairs, add them all to the schema one by one. If you have a whole section you’d like to add and it repeats, list of maps is the way.

Venkatesh Mankena

@mankenavenkatesh

@atoulme Hi Antoine,
Sorry if there is any confusion. Use case is -
i have group of key value pairs, and i need way to lookup the group by key.
So, is it possible to create a map with this group of key value pairs?
i think adding key value pairs individually or creating a list of maps will not help.

Antoine Toulme

@atoulme

well hang on, you want to add random keys to configuration?

you can just do that then. The schema is here to document and validate, not enforce only certain keys are present

Hans Enlin

@hansenlin

Hi everyone, I'm part of the cohort from truffleuniversity and am super interested about Artemis. I spoke with Felipe and he directed me here to find out more and see if there is a good first issue to tackle, something good for someone with high level knowledge about eth2 clients. looking forward to contributing!

Felipe Faraggi

@faraggi

Hi @hansenlin , welcome!

Hans Enlin

@hansenlin

Thanks @faraggi !

Jonny Rhea

@jrhea

Welcome @hansenlin!

Lemme see if I can dig up an issue for you

Antoine Toulme

@atoulme

I opened up some issues related to metrics and Prometheus: https://github.com/PegaSysEng/artemis/issues. HTH.

Jonny Rhea

@jrhea

Thanks @atoulme!! @hansenlin and @mankenavenkatesh take a look at those issues and see what you can do

Venkatesh Mankena

@mankenavenkatesh

Thanks @atoulme Sure @jrhea

Ajoy Das

@ajoydas

Can anyone confirm me that is MessageSender class of package org.apache.tuweni.plumtree is implemented or not?

Antoine Toulme

@atoulme

huh?

Antoine Toulme

@atoulme

Ajoy I can confirm. It’s implemented as a lambda function. Intellij or eclipse can help inspect

Diederik Loerakker

@protolambda

@jrhea Could you please take a look at ethereum/eth2.0-specs#1311 and send me a survey response? (or just a few suggestions, anything helps)

Felipe Faraggi

@faraggi

Would anyone here be interested in writing some community technical content about Artemis? If so, reply or PM me.

Marcel Koopman

@marcelkoopman

Hey guys, I was wondering why the jdk used was version 8, would it not be better to switch to jdk 11 to take advantage of type inference (var) and have less code?

Danno Ferrin

@shemnon

Venkatesh Mankena

@mankenavenkatesh

Hi Guys,
We won EthIndia 2.0 Hackathon. :) :)

Developed Selective-ZKP At EthIndia 2.0.
It is a Decentralized platform for Role based access view of Confidential Assets created using Zero Knowledge Proofs.
Github Link - https://github.com/mankenavenkatesh/Selective-ZKP
Please have a look and let me know your feedback. :)

Ben Edgington

@benjaminion

:tada: Congratulations - that's awesome! :tada:

Marcel Koopman

@marcelkoopman

@shemnon yeah well i was expecting an argument instead of a meme?

Danno Ferrin

@shemnon

It’s an attempt at humor to say we are not sure what to do about new Java 11 language features. Pantheon has transitioned to Java 11 and we have yet to use var. The meme represents the two extremes of people who are scared of change and people who are overly eager.

On a serious note, for Pantheon we are needing a more complete notion of when to use var and when not to. On one hand types add comprehension and readability to the code, but then there are also some extreme generics constructions that are incomprehensible and would benefit from a var decleration.

If it wouldn’t violate confidentiality I would ping my Google contacts to see what theire internal code styles and readability guidelines around var are, but I think there is a good chance they are still based on Java 8.

Semi-related, I agree that Artemis for it’s next release should go to Java 11 minimum.

Marcel Koopman

@marcelkoopman

@shemnon ok so maybe i can help there if you want to experiment later

Felipe Faraggi

@faraggi

Hello PegaSys/Artemis community! In the spirit of improving the way we communicate and the information you receive, we've put together a short survey to gather your feedback. All answers are optional, and we'd love to hear what you have to say!

The survey is centered on Pantheon but we'd appreciate all your responses as well.
https://forms.gle/4Jddy7bSPFa9a2zz6

Fabio Tudone

@circlespainter

Hi all, a tech question for Artemis developers (potentially Besu too): have you considered using other JVM languages besides (in addition to?) Java? Thinking mostly of Kotlin due to its non-revolutionary and very pragmatic approach.

Jonny Rhea

@jrhea

ya, there is definitely interest in Kotlin. Our team participates in the jvm-libp2p implementation written in Kotlin.

thor314

@thor314

Apologies in advance if this is not the best place to post about this; I’m trying to build the project repo and getting build issues

I tried both the curl and git clone methods, and in each case, I’m getting build failed, with the error msg
check-licenses.gradle’ line: 169
execution failed for task ‘:checkLicenses’
with a java exception calling out a directory trace with at one point, /5.2.1/build/.....
where I don’t have a build directory beneath my 5.2.1 directory. Is this something trivial to fix?

Fabio Tudone

@circlespainter

@jrhea Cool, so would a PR enabling Kotlin code (and including a proposal for reasonable coding conventions) be considered? As for Java coding conventions, I suggest to add that classes and methods too should be final unless explicitly designed for inheritance/override, what are your thoughts about that?

Fabio Tudone

@circlespainter

@thor314 Strange, I've just (re-)tried and it works for me; 5.2.1 is the gradle version configured for the Gradle wrapper, maybe a broken download? Maybe try to clear ~/.gradle/wrapper and retry from another dir . Also check that JAVA_HOME points to an OpenJDK 11 (even though the error should be different if that's not the case)

Adrian Sutton

@ajsutton

@circlespainter At this stage I would be against adding Kotlin into Artemis itself. We've found a lot of benefit with Besu in using plain java and thus being familiar to the huge community of Java developers. While Kotlin is a nice language, it has a much smaller community of developers around it and adds a barrier to entry for developers. It's extremely rare that the productivity benefits of a language actually outweigh the cost of that barrier. There are also extra costs of having a mix of languages in the code base (Kotlin has good interaction with java but still needs to be designed the right way and there are a number of places it can be confusing).

Where communities thrive

People

Repo info

Activity