These are chat archives for PerfDotNet/BenchmarkDotNet

1st
May 2016
Andrey Akinshin
@AndreyAkinshin
May 01 2016 09:22
@adamsitnik, how it's going with my last comments?
Adam Sitnik
@adamsitnik
May 01 2016 10:53
@AndreyAkinshin Sorry for my lack of response! I did not get any gitter notification this time
Andrey Akinshin
@AndreyAkinshin
May 01 2016 10:54
Please, review my last messages.
Adam Sitnik
@adamsitnik
May 01 2016 10:54
  1. It is ok that ProcessorArchitectureTest fails. It is because dotnet cli does not support x86 compilation yet
  1. dotnet5.4 is more for frameworks, and dnxcore50 is for applications
Andrey Akinshin
@AndreyAkinshin
May 01 2016 10:55
  1. Can we mark this test with Skip?
Adam Sitnik
@adamsitnik
May 01 2016 10:56
so our tests/samples stay as dnxcore50, when VS switches from dnx to dotnetcli we will move to netstandard/netcoreapp monikers
sure, I will add it with the commit I have right now
I will also check Algo_Md5VsSha256
Andrey Akinshin
@AndreyAkinshin
May 01 2016 10:58
Cool, thanks.
Adam Sitnik
@adamsitnik
May 01 2016 10:59
btw I have also implemented fix for #148, I hope you dont mind if I take some minor bugs and fix them even if you are assigned
Andrey Akinshin
@AndreyAkinshin
May 01 2016 10:59
Of course, no problem.
Adam Sitnik
@adamsitnik
May 01 2016 11:00
cool
Andrey Akinshin
@AndreyAkinshin
May 01 2016 11:00
Thanks for your help.
Adam Sitnik
@adamsitnik
May 01 2016 11:00
have you tried switching from msbuild to roslyn package?
Andrey Akinshin
@AndreyAkinshin
May 01 2016 11:00
No.
I think, we should publish v0.9.5 first.
Adam Sitnik
@adamsitnik
May 01 2016 11:00
you are right
the only thing that I would check first
is whether the roslyn supports generation of the assembly redirects
I fixed some msbuild bug recently with F# by just changing simple property
Adam Sitnik
@adamsitnik
May 01 2016 14:51
ok @AndreyAkinshin sorry for introducing the problem with dnxcore50 -> dotnet5.4 change, samples and tests should be buildable with dotnet cli again
I have just pushed the fixes
please let me know if you have any other problems
Andrey Akinshin
@AndreyAkinshin
May 01 2016 14:51
Cool, thanks. I will check it tonight.
Adam Sitnik
@adamsitnik
May 01 2016 14:51
great!