Where communities thrive
Join over
1.5M+ people
Join over
100K+ communities
Free
without limits
Create
your own community
Explore more communities
PerfectlySoft/PerfectDocs
Reference and documentation for Perfect.
People
Repo info
Activity
Jonathan Guthrie
@iamjono
Done
Kyle Jessup
@kjessup
BTW
@taplin
I massaged and brought in your syslog related log work. I don't think I mentioned it
https://github.com/PerfectlySoft/Perfect/blob/master/Sources/PerfectLib/Log.swift
Tim Taplin
@taplin
cool, hopefully you didnt have to do too much massaging ?
Kyle Jessup
@kjessup
not really. you're stuff was a good way there
Kyle Jessup
@kjessup
ug, your. too late to edit it :P
Jonathan Guthrie
@iamjono
Guys, youy gotta keep up!
https://github.com/PerfectlySoft/PerfectDocs
Kyle Jessup
@kjessup
dang
Jonathan Guthrie
@iamjono
@rymcol
have you had the chance to work on the MySQL or SQLite docs?
Ryan Collins
@rymcol
@iamjono
yes - I’m about halfway through the basics of SQLite
Jonathan Guthrie
@iamjono
awesome!!!
Ryan Collins
@rymcol
@iamjono
PerfectlySoft/PerfectDocs#2
Also you have no CLA assistant/Contributor Agreement on PerfectDocs
And might want to consider that
Jonathan Guthrie
@iamjono
Good call, thx
reviewing the PR now :)
Jonathan Guthrie
@iamjono
Nicely done
@rymcol
only thing i added was some swift syntax highlighting to a few blocks
Ryan Collins
@rymcol
I didn't realize that was a thing. Thanks @
@iamjono
Jonathan Guthrie
@iamjono
np
Jonathan Guthrie
@iamjono
BTW
@rymcol
I’ve added the CLA on PerfectDocs :)
thanks for pointing it out
Ryan Collins
@rymcol
No problem
_
Kyle Jessup
@kjessup
Building With SPM - feedback welcome
https://github.com/PerfectlySoft/PerfectDocs/blob/master/guide/buildingWithSPM.md
Jonathan Guthrie
@iamjono
looking now...
Kyle, this is awesome
Tim Taplin
@taplin
+1
Kyle Jessup
@kjessup
Added a few more doc sectons to the TOC. Sorry :)
Jonathan Guthrie
@iamjono
no need to apologize! I have a few more to add as well
can’t see them?
nm, i see them now
Ryan Collins
@rymcol
but have you finished writing the new sections you’ve added yet?????
:D
Kyle Jessup
@kjessup
filters and networking
Jonathan Guthrie
@iamjono
PostgreSQL docs up, if anyone would like to vet them…
https://github.com/PerfectlySoft/PerfectDocs/blob/master/guide/PostgreSQL.md
Tim Taplin
@taplin
Jono, I’ve added a quickstart example for the Mysql readme. Please review.
I’m thinking about potentially changing the error response.
Ryan Collins
@rymcol
@taplin
if you do, please let me know so I can change it in the Docs guide
Tim Taplin
@taplin
@rymcol
I’m referring to changing how I handle it in my quickstart code, not planning on changing the MySQL functionality.
Ryan Collins
@rymcol
k
Tim Taplin
@taplin
I’m just returning empty along with a logged error message, and I’m thinking that I should likely do a throw error
Ryan Collins
@rymcol
Gotcha
Tim Taplin
@taplin
I would appreciate your input as well, ryan
Ryan Collins
@rymcol
I’ll take a look
Tim Taplin
@taplin
by the time I come up with several more quoickstarts, I might have a format that I actually like… its a work in progress
Ryan Collins
@rymcol
Lol, I know the feeling
Jonathan Guthrie
@iamjono
docs for me are the same
Ryan Collins
@rymcol
@taplin
that’s really in depth and looks good