PetaVision is a C++ library for designing and deploying large-scale neurally-inspired computational models.
@garkenyon hopefully this message gets pushed to your email
@riskybacon
The goal was to get something that we could start using and add that functionality moving forward, as opposed to trying to add that functionality to std::cout, fprintf and std::cerr
error() doesn't exit the program does it?
or does it
Debug() is compiled out of Release versions. Debug() output can be added to Release versions by setting PV_DEBUG_OUTPUT to On
And... this should be a wiki entry :)
I keep putting Debug() << getName(). Would it make sense to add this to all Error() output?
hard part is for the error obj to actually get the name of the class and a reference to the object
maybe have error take "this"?
Error(this) << "Oh no, error!"
at least for layers
we have getKeyword() and getName()
as for the wiki entries
I think we should separate user wikis (e.g. how do I write this params file) and developer wikis (e.g. how do I print an error in my custom layer)
although I guess writing custom layers is part of being a user
If you're inside a BaseObject the getName and getKeyword methods exist; otherwise they generally don't. Could we give BaseObject methods called Info, Error, and Debug, and also have there be Info, Error, and Debug functions defined in the PV namespace but outside of any class? I believe that in that case, inside a BaseObject class you'd get the method but outside you'd get the PV:: function, which seems like what Sheng is asking for. That does mean that they wouldn't be defined as macros, though.
like PVAssert and PVAlloc
what do they do differently?
[ 94%] Building CXX object /home/sheng/workspace/Projects/mlearning/CMakeFiles/mlearning.dir/src/columns/MLPRegisterKeywords.cpp.o
In file included from /usr/include/c++/4.8/type_traits:35:0,
from /home/sheng/workspace/OpenPV/pv-core/src/utils/PVLog.hpp:6,
from /home/sheng/workspace/Projects/mlearning/src/columns/../layers/BackwardsBatchNorm.hpp:13,
from /home/sheng/workspace/Projects/mlearning/src/columns/MLPRegisterKeywords.cpp:7:
/usr/include/c++/4.8/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support is currently experimental, and must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
#error This file requires compiler and library support for the \
^
make[2]: *** [/home/sheng/workspace/Projects/mlearning/CMakeFiles/mlearning.dir/src/columns/MLPRegisterKeywords.cpp.o] Error 1
make[1]: *** [/home/sheng/workspace/Projects/mlearning/CMakeFiles/mlearning.dir/all] Error 2
make: *** [all] Error 2
In file included from /usr/include/c++/4.8/type_traits:35:0,
from /home/sheng/workspace/OpenPV/pv-core/src/utils/PVLog.hpp:6,
from /home/sheng/workspace/Projects/mlearning/src/columns/../layers/BackwardsBatchNorm.hpp:13,
from /home/sheng/workspace/Projects/mlearning/src/columns/MLPRegisterKeywords.cpp:7:
/usr/include/c++/4.8/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support is currently experimental, and must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
#error This file requires compiler and library support for the \
^
make[2]: *** [/home/sheng/workspace/Projects/mlearning/CMakeFiles/mlearning.dir/src/columns/MLPRegisterKeywords.cpp.o] Error 1
make[1]: *** [/home/sheng/workspace/Projects/mlearning/CMakeFiles/mlearning.dir/all] Error 2
make: *** [all] Error 2
Is there a cmakelists template for various projects?
The pv_config_project macro defined in cmake/PVConfigProject.cmake sets the c++11 flag. Right now the idea is that pv_config_project is called at the beginning of the OpenPV/CMakeLists.txt project, but that's changing. Perhaps someone has written a new project CMakeLists.txt but I don't think that's happened yet.
So another question. There exists system tests that used to be in the old auxlib directory that makes extensive use of GradientCheckConn, which used to be a custom class under the mlearning auxlib
I know @garkenyon has told me to add BatchNorm and BackwardsBatchNorm layers into pv-core (in the devel branch), but I want system tests that check the gradients of BackwardsBatchNorm
So now that we no longer have an auxlib directory, where do you think a custom connection GradientCheckConn belongs?
Currently, there was one system test in mlearning/tests, which tests various models (such as mlp, mlp with softmax, convolutions, relu, etc) for correctness in gradients. Currently, I have a system test for BatchNorm that tests the feedforward pass, and am planning on writing a test for testing the correctness of the gradient in the backwards pass. I had hoped to keep these 2 tests together, but under your suggestion, we would either have to break the feedforward test and the backward test of BatchNorm up into 2 seperate tests (with the backward test grouped with the rest of the gradient checks), or we would have to copy GradientCheckConn into 2 separate places
There actually is a lot of repeated code in many of the tests, such as probes that check for zeros in a specific layer
Perhaps the solution is to make shared custom layers and connections for system tests
(and probes)