But really with the file moves/renaming not being detected correctly I might have no choice
executors.pyonly, so you can test if git can check it or not.
install_requires=[ 'requests', 'beautifulsoup4', 'scandir', 'rarfile', 'watchdog', 'robobrowser', 'Send2Trash', 'pillow', 'python-dateutil', 'QtAwesome', 'appdirs', ] if is_not_linux_32_bit(): install_requires.append('pyqt5') setup( # ... install_requires=install_requires, # ... )
How have you been able to run Happypanda at all so far? Or is it just that the installer trips up when it can't find the package and ends the install entirely?
after commenting pyqt5 on
setup.py i can install in with
pip install -e . on root project in virtual env.
maybe don't use
platform.architecture. the comment on that stackoverflow mention that it is not reliable.
Sorry, as noted in the current Python documentation for the platform command, the platform.architecture test is not reliable at execution time on all platforms, in particular, on OS X universal builds with both 32-bit and 64-bit archs as asked by the OP.
other than that, i believe it is correct
As for the css not being found it seems I didn't take into account the different slashes between windows and unix paths
pkg_resources.resource_filename http://setuptools.readthedocs.io/en/latest/pkg_resources.html#resource-extraction ?
__init__.pyremoved from tests and all tests now in top level of directory (No more
git-mvthis time before doing any actual changes to the files contents so the diff is much easier to read.
python setup.py sdist bdist_wheel egg_info, create a page for it on PyPI, upload the PKG-INFO file in .egg-info (this will create the "release" and add the README) then add the .whl in /dist as a wheel file of type any for that release.
hi, i have made list to change on pr, but i haven't check the rst file yet, and maybe @Pewpews can do it.
Nice work on pr, it is now easier to see the change right now. thanks
i reinstall it with
pip install -e . and it is working (
style.css, icon, taskbar icon).
is there anything else i should check?
not pass, but i don't think it is necessary right now. if this pr all test will be invalid anyway. after that just send new pr to check all test. (or maybe don't change any tests file yet and leave it for another pr?)
in current state right now happypanda dont do automation test, so yeah.
opinion @Pewpews ?
use conventional metadata http://stackoverflow.com/a/1523456 ?
Can't really, sure author and version metadata exist but no appname, and
__name__ would be the name of the file which would be incorrect. Currently the metadata is all over the place and mostly hardcoded. I will however look into making that better in the cleanup PR
__init__.pylike it should be really.