Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Anthony Forsberg
@Evolution0
As altering the requirements list wouldn't help, pyqt5 5.7.1 is the only one available on pypi
Unless you mean that the install fails because it can't get that exact module but you have a previous version installed via another method?
Anthony Forsberg
@Evolution0
How have you been able to run Happypanda at all so far? Or is it just that the installer trips up when it can't find the package and ends the install entirely?
rachmadani haryono
@rachmadaniHaryono
for pyqt5
install_requires=[
    'requests',
    'beautifulsoup4',
    'scandir',
    'rarfile',
    'watchdog',
    'robobrowser',
    'Send2Trash',
    'pillow',
    'python-dateutil',
    'QtAwesome',
    'appdirs',
]
if is_not_linux_32_bit():
    install_requires.append('pyqt5')

setup(
    # ...
    install_requires=install_requires,
    # ...
)
for function this may help http://stackoverflow.com/a/6107982

How have you been able to run Happypanda at all so far? Or is it just that the installer trips up when it can't find the package and ends the install entirely?

after commenting pyqt5 on setup.py i can install in with pip install -e . on root project in virtual env.

Anthony Forsberg
@Evolution0
Alright this should work then:
if name == "posix" and architecture()[0] == "32bit":
    install_requires.append('pyqt5')
I'll restructure the setup.py with that in mind
well, inverse :P
As for the css not being found it seems I didn't take into account the different slashes between windows and unix paths
rachmadani haryono
@rachmadaniHaryono

maybe don't use platform.architecture. the comment on that stackoverflow mention that it is not reliable.

the comment:

Sorry, as noted in the current Python documentation for the platform command, the platform.architecture test is not reliable at execution time on all platforms, in particular, on OS X universal builds with both 32-bit and 64-bit archs as asked by the OP.

other than that, i believe it is correct

As for the css not being found it seems I didn't take into account the different slashes between windows and unix paths

use pkg_resources.resource_filename http://setuptools.readthedocs.io/en/latest/pkg_resources.html#resource-extraction ?

Anthony Forsberg
@Evolution0
Well i'll start round two of this PR tommorow, i'm getting mixed messages when it comes to getting system architecture, a few seem to have issues (32 bit python running on 64 bit os, os.name only showing posix and not distinguishing between linux and unix, etc)
Anthony Forsberg
@Evolution0
As clean as possible this time: Pewpews/happypanda#182
I didn't change the order or formatting of the imports other than making sure all the module level imports were explicit.
Setup has been adjusted to skip attempting to install pyqt5 in linux 32bit.
Now using gui_scripts rather than console_scripts for launching Happypanda.
__init__.py removed from tests and all tests now in top level of directory (No more tests/database/etc)
I also used a more reliable method of getting the architecture so the setup should work fine.
Benefit of using gui_scripts is it starts its own process and doesn't stay attached to the console
Don't mind the massive line count, this is primarily due to converting Markdown to ReStructuredText, I properly used git-mv this time before doing any actual changes to the files contents so the diff is much easier to read.
Anthony Forsberg
@Evolution0
@Pewpews If after the PR you want to make Happypanda installable via pip and whl do: python setup.py sdist bdist_wheel egg_info, create a page for it on PyPI, upload the PKG-INFO file in .egg-info (this will create the "release" and add the README) then add the .whl in /dist as a wheel file of type any for that release.
Or create it and add me as a maintainer, I have experience with doing releases: https://pypi.python.org/pypi/bandcamp-downloader / https://github.com/iheanyi/bandcamp-dl
Anthony Forsberg
@Evolution0
Also binary installers are possible:
happypanda_inst.PNG
Not pretty yet though but can be built for linux, osx, and windows.
If you have a bigger Happypanda logo that would be great
rachmadani haryono
@rachmadaniHaryono

hi, i have made list to change on pr, but i haven't check the rst file yet, and maybe @Pewpews can do it.

Nice work on pr, it is now easier to see the change right now. thanks

i reinstall it with pip install -e . and it is working (style.css, icon, taskbar icon).

is there anything else i should check?

Anthony Forsberg
@Evolution0
Does the db test pass? It was acting strangely for me even though I haven't modified any code that should cause it to do so
rachmadani haryono
@rachmadaniHaryono

not pass, but i don't think it is necessary right now. if this pr all test will be invalid anyway. after that just send new pr to check all test. (or maybe don't change any tests file yet and leave it for another pr?)

in current state right now happypanda dont do automation test, so yeah.

opinion @Pewpews ?

Anthony Forsberg
@Evolution0

use conventional metadata http://stackoverflow.com/a/1523456 ?

Can't really, sure author and version metadata exist but no appname, and __name__ would be the name of the file which would be incorrect. Currently the metadata is all over the place and mostly hardcoded. I will however look into making that better in the cleanup PR

Id like all the info to be in the primary __init__.py like it should be really.
rachmadani haryono
@rachmadaniHaryono
maybe just keep it hardcoded. my suggestion to keep those metadata on one file seems quite hard and result in circular import. and yeah i want to put it on __init__.py , but with current structure, it may break other modules.
Anthony Forsberg
@Evolution0
Yeah between app_constants, db_constants, and settings there is a few values that should be in one file. Lot of imports going on atm
Anthony Forsberg
@Evolution0
I also noticed the icon was kinda blurry when looking for a bigger one so I remade it:
Wait a sec.. old one in the bg
happypanda.png
There.
256x256 should be good, can be scaled down (much better than scaling up)
Making larger higher quality images from small simple source images is one of my specialties: https://github.com/F32Organization/Faithful32-1.7.10/graphs/contributors lol
rachmadani haryono
@rachmadaniHaryono
is it svg?
Anthony Forsberg
@Evolution0
I can convert it or just redo it in inkscape or something.
Wouldn't be much trouble and I can see the benefit of having a vector
First I'll check if vectormagic can handle the conversion, if not I'll redo it
Ew I have to subscribe, the result looked nice to. Rather do it myself then.
Anthony Forsberg
@Evolution0
happypanda.png
There, SVG
Had to draw it, not used to Inkscape
Anthony Forsberg
@Evolution0
Yeah the option to adjust the resolution without losing quality is nice
happypanda.png
^ 1024x1024
rachmadani haryono
@rachmadaniHaryono
well that is better :smile:
Anthony Forsberg
@Evolution0
Fixed the under indents, moved ctype to top, and version is set to the variable now.
rachmadani haryono
@rachmadaniHaryono
@Evolution0 i approve your pr. now wait for @Pewpews .