Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Anthony Forsberg
@Evolution0
Id like all the info to be in the primary __init__.py like it should be really.
rachmadani haryono
@rachmadaniHaryono
maybe just keep it hardcoded. my suggestion to keep those metadata on one file seems quite hard and result in circular import. and yeah i want to put it on __init__.py , but with current structure, it may break other modules.
Anthony Forsberg
@Evolution0
Yeah between app_constants, db_constants, and settings there is a few values that should be in one file. Lot of imports going on atm
Anthony Forsberg
@Evolution0
I also noticed the icon was kinda blurry when looking for a bigger one so I remade it:
Wait a sec.. old one in the bg
happypanda.png
There.
256x256 should be good, can be scaled down (much better than scaling up)
Making larger higher quality images from small simple source images is one of my specialties: https://github.com/F32Organization/Faithful32-1.7.10/graphs/contributors lol
rachmadani haryono
@rachmadaniHaryono
is it svg?
Anthony Forsberg
@Evolution0
I can convert it or just redo it in inkscape or something.
Wouldn't be much trouble and I can see the benefit of having a vector
First I'll check if vectormagic can handle the conversion, if not I'll redo it
Ew I have to subscribe, the result looked nice to. Rather do it myself then.
Anthony Forsberg
@Evolution0
happypanda.png
There, SVG
Had to draw it, not used to Inkscape
Anthony Forsberg
@Evolution0
Yeah the option to adjust the resolution without losing quality is nice
happypanda.png
^ 1024x1024
rachmadani haryono
@rachmadaniHaryono
well that is better :smile:
Anthony Forsberg
@Evolution0
Fixed the under indents, moved ctype to top, and version is set to the variable now.
rachmadani haryono
@rachmadaniHaryono
@Evolution0 i approve your pr. now wait for @Pewpews .
Twiddly
@twiddli

@rachmadaniHaryono @Evolution0
Hi, sorry guys, I've been super busy with homework & school.

not pass, but i don't think it is necessary right now. if this pr all test will be invalid anyway. after that just send new pr to check all test. (or maybe don't change any tests file yet and leave it for another pr?)
in current state right now happypanda dont do automation test, so yeah.

Yes, no automated tests, there's no reason to add them since we're abandoning HP for HPX anyways.

I'll follow up and review the PR later today.

@Evolution0 thank you very much for your work :)
Anthony Forsberg
@Evolution0
Holo_Happy.png
AYY LMAO
@Ayy69lmao_twitter
I pretty sure I'm autistic and did something wrong but when I try to follow the install.md instructions for MacOs I get an error when trying to run it 'no module Named scandir.'
rachmadani haryono
@rachmadaniHaryono
@Ayy69lmao_twitter pip3 install scandir
Also add - - user flag
To avoid using sudo
Anthony Forsberg
@Evolution0
@rachmadaniHaryono @Pewpews Development is essentially Python 3.5 and up now right? Then scandir isn't really a requirement anymore, its stdlib now.
scandir => os.scandir()
rachmadani haryono
@rachmadaniHaryono
@Evolution0 it is correct, but the dependencies is still there (and we all seems forget to refactor it on ). so now @Ayy69lmao_twitter can do is just install it.
Anthony Forsberg
@Evolution0
Kivy is driving me nuts
Its great but learning an entire GUI framework is hell
Twiddly
@twiddli
@Ayy69lmao_twitter you wouldn't have been getting that error if you correctly ran this command: pip3 install -r requirements.txt
Anthony Forsberg
@Evolution0
And not at all if installed via pip, the requirements are automatically fetched and installed.
CyanLeader
@CyanLeader
Oh I didnt see this here.
Anyway should I post the log?
Twiddly
@twiddli
@CyanLeader that'd be great
CyanLeader
@CyanLeader

14-11 22:00 INFO main DB Version: 0.26
14-11 22:00 CRITICAL app File "<frozen importlib._bootstrap>", line 969, in _find_and_load
File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 634, in _load_backward_compatible
File "C:\Python\35\lib\site-packages\cx_Freeze\initscripts__startup.py", line 12, in <module>
File "<frozen importlib._bootstrap>", line 969, in _find_and_load
File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 664, in _load_unlocked
File "<frozen importlib._bootstrap>", line 634, in _load_backward_compatible
File "C:\Python\35\lib\site-packages\cx_Freeze\initscripts\Console.py", line 24, in <module>
File "version\main.py", line 258, in <module>
File "version\main.py", line 251, in start
File "version\main.py", line 187, in start_main_window
File "D:\Code\Github\Happypanda\version\app.py", line 90, in
init__
File "D:\Code\Github\Happypanda\version\app.py", line 229, in initUI
File "D:\Code\Github\Happypanda\version\app.py", line 636, in init_toolbar
File "D:\Code\Github\Happypanda\version\misc.py", line 264, in set_toolbutton_text

14-11 22:00 CRITICAL app <class 'AttributeError'>: 'NoneType' object has no attribute 'text'

Twiddly
@twiddli
Your settings.ini file is most likely the culprit. Try renaming it to something else and then launch HP.
CyanLeader
@CyanLeader
That did the trick, I guess it had to do with the font stuff that I was changing. Thanks a lot!
By the way, how usable is HPX at the moment?
I'm just an end user, not a dev or anything.
Twiddly
@twiddli
I haven't pushed the stuff I've been working on yet, but after this push I'd say pretty usable for reading on multiple devices.
CyanLeader
@CyanLeader
I see, is it able to organize folders by itself now?
Twiddly
@twiddli
No, not yet. I say usable, but it really isn't much. You're able to convert your HP db to a HPX db and then start reading the galleries on different clients.
CyanLeader
@CyanLeader
Hum.. another feature I was thinking it could be really handy is to be able to take things from tags and modify the fields. Say, you sync a gallery to ex and it fetches the artist name (the author:x tag). But that name mismatches yours, there could be an option to take it from there and force it on your file.