by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 03 22:08
    MichaelRandall closed #545
  • Jun 20 11:42
    iRon7 edited #546
  • Jun 20 11:19
    gaelcolas commented #546
  • Jun 20 10:00
    iRon7 opened #546
  • Jun 12 14:23
    MichaelRandall commented #545
  • Jun 10 15:38
    MichaelRandall edited #545
  • Jun 10 15:37
    MichaelRandall edited #545
  • Jun 09 05:20
    microsoft-cla[bot] commented #545
  • Jun 09 05:19
    microsoft-cla[bot] commented #545
  • Jun 09 05:19
    MichaelRandall opened #545
  • May 25 16:54
    gaelcolas closed #544
  • May 25 16:54
    gaelcolas commented #544
  • May 25 16:51
    gaelcolas closed #500
  • May 25 16:51
    gaelcolas commented #500
  • May 25 16:49
    gaelcolas closed #520
  • May 25 16:49
    gaelcolas commented #520
  • May 25 16:49

    gaelcolas on master

    Update Maintainers.md (compare)

  • May 25 16:49
    gaelcolas closed #542
  • May 20 21:02
    gaelcolas added as member
  • May 19 13:37
    steskalja opened #544
Gael
@gaelcolas
I was thinking of doing something similar, but that's actually simpler.
Johan Ljunggren
@johlju
In regards to breaking changes I agree with @PlagueHO that any configuration that seize to work is a breaking change. But also if the functionality changes there are a definition of breaking changes here https://github.com/PowerShell/DscResources/blob/master/Maintainers.md#breaking-changes
Gael
@gaelcolas
yeah, that case is slightly different. API does not change, functionality don't really change, it's fixed...
I've put the draft here: PowerShell/DscResource.Template#16
Adding in-line comments to help understanding and commenting the changes
Gael
@gaelcolas
comments added. Hope they help explain
Gael
@gaelcolas
@johlju I think we should encourage the changelog practices from here: https://keepachangelog.com/en/1.0.0/
got a few questions about that change.
Johan Ljunggren
@johlju
What are we not already doing in that changelog practice?
Can you comment your thoughts in that PR? Though, the PR could be obsolete with the template work you are doing. If so, we can close it.
Gael
@gaelcolas
I just saw that we're not really doing the Type of changes... it's not 'organised'
not a big deal, but I found keepachangelog quite clear.
The other benefit is that we can point people to that page for documentation, it's clear and well explained, with examples...
My changes are longer term, before that goes through (and if it does) we should not stop improving the current templates
I wanted to ask if your changes I commented on was fixing some tests. Is the DscResource.Template pass the tests? or is it failing because of MSFT_ResourceName
Johan Ljunggren
@johlju
Ah you mean “Added”, “Changed” etc.? It could be complicated for contributor to know how to write this. It easier to say add an entry to the change log. Instead of add an entry to the change log under, and add a header ”Added” and ”Changed”. Personally I rather want to avoid having to alter the change log after a merge or before a release.
Gael
@gaelcolas
meh, ok. No biggie. :)
Johan Ljunggren
@johlju
Let me look double-check the PR later tonight and see if line 39 is meant to be that way.
Gael
@gaelcolas
nah it looks ok, I was just wondering if you managed to get green tests on the template (which would be nice).
Johan Ljunggren
@johlju
You mean the status badges? If you can connect ApoVeyor and give the API “key” for the badges.
Gael
@gaelcolas
running locally
Johan Ljunggren
@johlju
The tests should work, they do in my fork
Gael
@gaelcolas
lemme try again
Johan Ljunggren
@johlju
Integration tests and unit tests should work. 🤔
I run only unit tests locally. Do they fail?
Gael
@gaelcolas
ah ok, that kinda explain my issue there I think.
Integration tests run fine in AppVeyor. I never run integration tests locally.
Well, for more complex stuff in SqlServerDsc I do :D
Gael
@gaelcolas
yeah, on AppVeyor I'm not surprised...
Johan Ljunggren
@johlju
But not using the integration tests locally, in SqlServerDsc I test so the resources does what they should when there are need for multiple nodes.
Like clusters
Sometime maybe there is time to write actual manual integration tests.
But tsince it has taken 2,5 years to be where we are at now, I don't think we are gonna see that in the short time :P
Gael
@gaelcolas
lol, have some hope! :p
Johan Ljunggren
@johlju
haha :D
Always! :P
Gael
@gaelcolas
alright Unit works locally no issue. So I'll just not run integration tests locally for now until I template and document Test-Kitchen ;)
Johan Ljunggren
@johlju
Sounds good! :D
Gael
@gaelcolas
I'll approve and merge your changes today/tomorrow.
Johan Ljunggren
@johlju
The integration tests should work locally though, but it is probably dependencies that are not in place. Like need to have $env:APPVEYOR environment variable.
or specifik AppVeyor environment variables.
Gael
@gaelcolas
yeah, I assumed as much. That's one of the reason I use BuildHelpers to 'normalize' the variable whatever the build system
Johan Ljunggren
@johlju
That will need to be resolved with Test-Kitchen. So it can run both locally and in AppVeyor.
Gael
@gaelcolas
Please have a quick look at my PR tonight and let me know what you think. It's not ready yet, I need to fix the tests and invoke them in workflow, and then maybe showcase test-kitchen
Johan Ljunggren
@johlju
Might not have time tonight... :/ But tomorrow night
Gael
@gaelcolas
Sure I mean next time you have some. No rush! I've got plenty of meetings tomorrow, and more things to do anyway...
Alright, I call it a day, Good night!
Johan Ljunggren
@johlju
I will look at it! Good night :)