Ah you mean “Added”, “Changed” etc.? It could be complicated for contributor to know how to write this. It easier to say add an entry to the change log. Instead of add an entry to the change log under, and add a header ”Added” and ”Changed”. Personally I rather want to avoid having to alter the change log after a merge or before a release.
meh, ok. No biggie. :)
Let me look double-check the PR later tonight and see if line 39 is meant to be that way.
nah it looks ok, I was just wondering if you managed to get green tests on the template (which would be nice).
You mean the status badges? If you can connect ApoVeyor and give the API “key” for the badges.
@johlju I rebased the branch for the xADDomainController to upstream/dev, and after fixing a lot of merge conflicts, I was able to push the commit. Should I just go ahead and abandon the PR and create a new one with my changes?
I think the file changes you were seeing were from the merge from dev into my branch.
Yes I figured as much. I thought maybe a rebase again would fix it. 🤔 If a rebase doesn’t work I’m okay with you creating a new PR.
I think the Pr looks good now
Let me check closer
thanks for the quick turn around!
Thanks for adding those stubs! Now we can use them for the other unit tests! :)
They should. I asked Joel for those 2 I know of who didn't get an email and he'll check
Hi Slack invitation page is broken, I'm not able to sign up
I'm working on this issue PowerShell/xWebAdministration#241 It's gone on for too long and I would like to finally finish it. Unfortunately it looks like I'm not able to deal with it by myself. I need a consultation but github issues has a long response time. I'm looking for someone who could help me with that