by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 20 11:42
    iRon7 edited #546
  • Jun 20 11:19
    gaelcolas commented #546
  • Jun 20 10:00
    iRon7 opened #546
  • Jun 12 14:23
    MichaelRandall commented #545
  • Jun 10 15:38
    MichaelRandall edited #545
  • Jun 10 15:37
    MichaelRandall edited #545
  • Jun 09 05:20
    microsoft-cla[bot] commented #545
  • Jun 09 05:19
    microsoft-cla[bot] commented #545
  • Jun 09 05:19
    MichaelRandall opened #545
  • May 25 16:54
    gaelcolas closed #544
  • May 25 16:54
    gaelcolas commented #544
  • May 25 16:51
    gaelcolas closed #500
  • May 25 16:51
    gaelcolas commented #500
  • May 25 16:49
    gaelcolas closed #520
  • May 25 16:49
    gaelcolas commented #520
  • May 25 16:49

    gaelcolas on master

    Update Maintainers.md (compare)

  • May 25 16:49
    gaelcolas closed #542
  • May 20 21:02
    gaelcolas added as member
  • May 19 13:37
    steskalja opened #544
  • May 07 15:41
    Rob-S opened #543
Gael
@gaelcolas
meh, ok. No biggie. :)
Johan Ljunggren
@johlju
Let me look double-check the PR later tonight and see if line 39 is meant to be that way.
Gael
@gaelcolas
nah it looks ok, I was just wondering if you managed to get green tests on the template (which would be nice).
Johan Ljunggren
@johlju
You mean the status badges? If you can connect ApoVeyor and give the API “key” for the badges.
Gael
@gaelcolas
running locally
Johan Ljunggren
@johlju
The tests should work, they do in my fork
Gael
@gaelcolas
lemme try again
Johan Ljunggren
@johlju
Integration tests and unit tests should work. 🤔
I run only unit tests locally. Do they fail?
Gael
@gaelcolas
ah ok, that kinda explain my issue there I think.
Integration tests run fine in AppVeyor. I never run integration tests locally.
Well, for more complex stuff in SqlServerDsc I do :D
Gael
@gaelcolas
yeah, on AppVeyor I'm not surprised...
Johan Ljunggren
@johlju
But not using the integration tests locally, in SqlServerDsc I test so the resources does what they should when there are need for multiple nodes.
Like clusters
Sometime maybe there is time to write actual manual integration tests.
But tsince it has taken 2,5 years to be where we are at now, I don't think we are gonna see that in the short time :P
Gael
@gaelcolas
lol, have some hope! :p
Johan Ljunggren
@johlju
haha :D
Always! :P
Gael
@gaelcolas
alright Unit works locally no issue. So I'll just not run integration tests locally for now until I template and document Test-Kitchen ;)
Johan Ljunggren
@johlju
Sounds good! :D
Gael
@gaelcolas
I'll approve and merge your changes today/tomorrow.
Johan Ljunggren
@johlju
The integration tests should work locally though, but it is probably dependencies that are not in place. Like need to have $env:APPVEYOR environment variable.
or specifik AppVeyor environment variables.
Gael
@gaelcolas
yeah, I assumed as much. That's one of the reason I use BuildHelpers to 'normalize' the variable whatever the build system
Johan Ljunggren
@johlju
That will need to be resolved with Test-Kitchen. So it can run both locally and in AppVeyor.
Gael
@gaelcolas
Please have a quick look at my PR tonight and let me know what you think. It's not ready yet, I need to fix the tests and invoke them in workflow, and then maybe showcase test-kitchen
Johan Ljunggren
@johlju
Might not have time tonight... :/ But tomorrow night
Gael
@gaelcolas
Sure I mean next time you have some. No rush! I've got plenty of meetings tomorrow, and more things to do anyway...
Alright, I call it a day, Good night!
Johan Ljunggren
@johlju
I will look at it! Good night :)
Gael
@gaelcolas
The link for Wednesday's Community call has been updated:
https://twitter.com/katiedsc/status/1110262316438716416
Jason Ryberg
@devopsjesus
@johlju I rebased the branch for the xADDomainController to upstream/dev, and after fixing a lot of merge conflicts, I was able to push the commit. Should I just go ahead and abandon the PR and create a new one with my changes?
I think the file changes you were seeing were from the merge from dev into my branch.
Johan Ljunggren
@johlju
Yes I figured as much. I thought maybe a rebase again would fix it. 🤔 If a rebase doesn’t work I’m okay with you creating a new PR.
I think the Pr looks good now
Let me check closer
Jason Ryberg
@devopsjesus
thanks for the quick turn around!
Johan Ljunggren
@johlju
Thanks for adding those stubs! Now we can use them for the other unit tests! :)
Johan Ljunggren
@johlju
We are also available on the DSC channel PowerShell.slack.com http://poshcode.org
There are also http://slack.poshcode.org
@gaelcolas will both work? Do you know?
Gael
@gaelcolas
They should. I asked Joel for those 2 I know of who didn't get an email and he'll check
Cezary Piątek
@cezarypiatek
Hi
Slack invitation page is broken, I'm not able to sign up
image.png
I'm working on this issue PowerShell/xWebAdministration#241 It's gone on for too long and I would like to finally finish it. Unfortunately it looks like I'm not able to deal with it by myself. I need a consultation but github issues has a long response time. I'm looking for someone who could help me with that
Johan Ljunggren
@johlju
Have you tried both links? Please ping @gaelcolas to see if he can help you get on Slack.