@johlju I rebased the branch for the xADDomainController to upstream/dev, and after fixing a lot of merge conflicts, I was able to push the commit. Should I just go ahead and abandon the PR and create a new one with my changes?
I think the file changes you were seeing were from the merge from dev into my branch.
Yes I figured as much. I thought maybe a rebase again would fix it. 🤔 If a rebase doesn’t work I’m okay with you creating a new PR.
I think the Pr looks good now
Let me check closer
thanks for the quick turn around!
Thanks for adding those stubs! Now we can use them for the other unit tests! :)
They should. I asked Joel for those 2 I know of who didn't get an email and he'll check
Hi Slack invitation page is broken, I'm not able to sign up
I'm working on this issue PowerShell/xWebAdministration#241 It's gone on for too long and I would like to finally finish it. Unfortunately it looks like I'm not able to deal with it by myself. I need a consultation but github issues has a long response time. I'm looking for someone who could help me with that
Have you tried both links? Please ping @gaelcolas to see if he can help you get on Slack.
If you just start Slack and try to register for PowerShell.slack.com through Slack, does that work?
Let me look at #241 and see what I can assist with. It’s gonna take a day or so, but I will get back to you.