Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Sergei Vorobev
    @vors
    :shipit:
    Nick James
    @omniomi
    @vors @gravejester @tylerl0706, I closed a bunch of issues, renamed and commented on some others, and cleared all the assignees.
    Sergei Vorobev
    @vors
    Awesome
    Tyler James Leonhardt
    @TylerLeonhardt
    Nice!
    I was wondering why my Github notifications blew up :p
    Tyler James Leonhardt
    @TylerLeonhardt
    @omniomi went through all the updates and helped out where I could
    Nick James
    @omniomi
    FYI, VSCode has a test file for PowerShell https://github.com/Microsoft/vscode/blob/master/extensions/powershell/test/colorize-results/test_ps1.json that we'll need to update when we push syntax changes to vscode.
    Øyvind Kallstad
    @gravejester
    Yeah, that is something that I discussed with David when he was working on this. My take on this is that we should get rid of the color tests. What purpose do they have? Different themes colorizes tokens differently.. we should only make sure that the tokens get the correct scope name and that's that. David agreed me with on this when he was working in Microsoft. Don't know if @tylerl0706 does though :)
    But if we are to remove this, we need to work together with the maintainers of the vscode repo so that we don't break their tests.
    The best thing would be if we could convince them that we are testing our own stuff good enough, so they can remove the powershell tests from their repo
    Tyler James Leonhardt
    @TylerLeonhardt
    @omniomi did you have to update their tests in the VSCode PR?
    @gravejester I think everything you said is reasonable :) I agree 👍
    @vors now that @omniomi's PR is done, can we get Sublime using EditorSyntax, please :)
    Nick James
    @omniomi
    @tylerl0706 Matt Bierner updated them. I apologized for not knowing about them ;D
    Sergei Vorobev
    @vors
    Yes, let me try it out
    Tyler James Leonhardt
    @TylerLeonhardt
    No worries, @omniomi! How could you have known :)
    @vors awesome!
    Sergei Vorobev
    @vors
    Awesome work! I switched ST to it :tada:
    Solves SO MANY issues in the ST repo :D
    Nick James
    @omniomi
    @vors awesome!

    @vors I reopened #23 about variable sigils.

    I am inclined to keep the sigil scoped but make its parent the same as the variable name so if a theme doesn't include the sigil's scope it will fall back to being the same colour as the variable name.

    Sergei Vorobev
    @vors
    @omniomi yes, I like this
    Sergei Vorobev
    @vors
    @omniomi are existing tests compatible with.sublime-syntax grammar?
    Nick James
    @omniomi
    @vors they should be.
    atom-grammar-test uses the sublime test format
    Nick James
    @omniomi
    @vors playing with variable definitions... If I give the variable an end-to-end scope it deals with the sigil colouring on themes that don't define it (yay) but it does not fix the double-click to select behaviour (not yay.)
    Sergei Vorobev
    @vors
    hmm, interesting. This is with the overlapping scopes, I assume? Does removing overlapping scopes fixes double-click?
    I wonder is this a correct understanding:
    VS Code use the syntax tokens to determine what text to select when the user double-clicks in the current file.
    cc @daviwil
    maybe it changed in VS Code and now double-click doesn’t use the regions
    Sergei Vorobev
    @vors
    off top: trying to figure out does syblime-syntax provide a way to implement this highlighting idea: https://github.com/rust-lang/rust-enhanced/issues/285#issuecomment-392402236
    Nick James
    @omniomi
    @vors just dealing with an application issue (actual work) will take a look once done.
    Sergei Vorobev
    @vors
    I’m watching tree-sitter intro video, looks so much better then regexes
    Nick James
    @omniomi
    Tree-sitter is very cool... It actually understands the language. (sort of)
    As per that issue... If I am reading it right it could be done in tmLanguage with 3-4 repository items, would be easier in sublime-syntax.
    Sergei Vorobev
    @vors
    3-4 repository items
    you mean special case for the small number of args?
    I’m actually strugling to express even a simpler heuristic - just find a comma after the string and if there is a comma, consider it a format string
    in tmLanguage that would be a look-ahead
    but the way rust grammar is written, it’s not obvious to me how to match a look-ahead , and handle things like print!(“\”,”, foo) correctly
    Nick James
    @omniomi
    I don't know much about rust. How many constructs are formatted word(...)
    I was thinking one item would begin capture word( with an end capture for ) with includes for separate items covering the string and arguments.
    Not sure if that would clobber anything else.
    word!( rather
    missed the !
    Tyler James Leonhardt
    @TylerLeonhardt
    @omniomi I can't remember the issue I wanted to show you
    I think it was a problem with strings
    Lol
    Specifically escaping in them
    Nick James
    @omniomi
    @tylerl0706 if it comes to you hit me up here or Slack whenever :)