Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tod Roman
    @ShepherdV8
    I have commits rejected beacause I changed the theme.css directly, also when pushing commits can I just push the .scss or do I need the theme.css as well
    Tod Roman
    @ShepherdV8
    Anyone here to answer a npm run watch question, I finally have this working
    Tod Roman
    @ShepherdV8
    After running npm run watch and editing files I notice that other files have also been changes themes.map.js, themes.js and theme.css.map is there a reason to include these in the commit
    Tod Roman
    @ShepherdV8
    New to using NPM
    Tod Roman
    @ShepherdV8
    crickets
    Tod Roman
    @ShepherdV8
    I love talking to myself
    Maxime Biloé
    @maximebiloe
    Sorry but we’re in French time zone, but at 4:00 AM we were spleeping :wink:
    It could be normal that .js files were modified too, especially you just run npm install so you get the latest versions of libraries
    Tod Roman
    @ShepherdV8
    Hello would I include them with commit or just the .scss and the theme.css
    Maxime Biloé
    @maximebiloe
    Yes, you can commit them
    Tod Roman
    @ShepherdV8
    Ok thanks
    Tod Roman
    @ShepherdV8
    Anyone here
    Hey I just made a pull request using NPM for the first time after pushing the commit I noticed that for some reason the Social SVG files URL were changed and not by me is this normal
    That is after using NPM for the first time to compile, just learning to use it
    Tod Roman
    @ShepherdV8
    Ok thanks I used my inspector on my test site and changed the file to the same as waht is showing now in the commit and the image was the same
    No I was using npm run watch and it compiled auto
    No from the directions I was given npm run watch
    in the _dev folder
    I just checked my css folder and for example the afc39d2b4ef6d2fdcbab2f0748fcfd57.svg that the Facebook was changed to does exist
    Tod Roman
    @ShepherdV8
    I have not looked at the Prestashop repo yet
    The file exist in the Prestashop repo as well very odd
    Tod Roman
    @ShepherdV8
    Is it possible that the .scss points to this file but has not been compiled yet on the Prestashop Dev branch
    Tod Roman
    @ShepherdV8
    OK Looking at things myself
    Tod Roman
    @ShepherdV8
    Can you tell me a little more on what you mean by script
    OK so your running npm run watch on your PC
    I received no errors at all when I ran it
    Are you on Windows Ununtu or Cent
    Tod Roman
    @ShepherdV8
    Im on Windows
    Try rinning npm install -g npm and then try again
    Tod Roman
    @ShepherdV8
    from the classic_dev folder
    I am new to using NPM and node.js so I am learning as I go as you probably know I had several request denied due to changeing the theme.css directly. So now I figured out how to use NPM and change the .scss and this happens I am sure the commit will be rejected again
    Tod Roman
    @ShepherdV8
    3.8.6 here
    Tod Roman
    @ShepherdV8
    OK so how about this I have added a HR to the cart-summary-totals to divide the totals from the grand total as there was no divide in the checkout steps I was told to not add HR but to use CSS the issue is that HR was used to divide the cart summary page totals so why not use it in the cart steps as well. It was actually there from the other commit and I did not remove it.
    The other commit was fejected for editing the theme.css and adding the HR
    rejected
    #5428 But after looking at how the other divides were added I do not understand
    Tod Roman
    @ShepherdV8
    Example cart.tpl and cart-summary.tpl
    I also noticed that 1 check has failed on the request
    Tod Roman
    @ShepherdV8
    In case any comes here for Alpha 4 install fail I have submitted a pull request addressing the issue.
    Tod Roman
    @ShepherdV8
    I thought this would be a lot more busy then this or maybe I live on the wrong side of the world
    Julien Bourdeau
    @julienbourdeau
    This channel was especially created for people who don’t know if their PR should be on this branch or that one. Little help to rebase or something like that.
    dks295
    @dks295
    Hello, How can I fork the Prestashop "develop" branch on git
    Tod Roman
    @ShepherdV8
    Sorry to break in here anyone have NPM installed on Windows 10 I need help
    Tod Roman
    @ShepherdV8
    When I run npm install nothing happens it does not add the node_modules to the _dev folder so npm run watch does not work
    Tod Roman
    @ShepherdV8
    Well I seem to have found the issue the package.json file seems to not work in Windows 10 , it was changed since my last sync so I still had the older one and compared the 2, I changed the new to the same as my older repo and the install worked. I also created a new repo on the XP machine with the changed package.json file and on there it worked not sure what the diff is but at least for now I have a work around for my Win 10 PC
    Tod Roman
    @ShepherdV8
    Well not sure why but today I updated Node.js, NPM, TortoiseGit and the NPM started installing with the new package.json so no more issues, Hmmm
    loertel
    @loertel
    hi to all - could some explain how csv import works in detail ... i tried to figure out why it´s so slow - and got strange sql queries reorganizing nested sets of category table all the time while importing articles
    tried with 1.7.0.6 and 1.7.1 beta
    Mateusz Rosiak
    @mateuszrosiak__twitter
    I have a problem with combinations on PrestaShop 1.7.4.2, when I try to select a specific combinaition on product page it automatically de-select and returns to the default value, anyone know the solution / willing to help?
    Fabrizio Spanu
    @freeman78ita
    hi mateus i had a similar issue on a site i was working on, have you upgraded your theme lately?