Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Feb 27 00:02
    Build #127 passed
  • Feb 23 08:22
    Build #113 passed
  • Feb 22 09:25
    Build #109 passed
  • Feb 21 22:35
    Build #106 passed
  • Feb 21 22:32
    Build #105 passed
  • Feb 21 22:27
    Build #104 passed
Oleksandr Poliakov
@sanych-sun
Generally I'm OK with reorganization, but some extensions
Metrics extensions - I think it's better to put them in some "commonly used" namespace, so they would be available and visible "by default"
Sergey Kuznetsov
@phnx47
Yes, I think - good
Oleksandr Poliakov
@sanych-sun
@phnx47 , there is one more extensions to move into root
And as a side note - there is something wrong with InternalsVisible attribute (it applied twice and quite "hidden")
Sergey Kuznetsov
@phnx47
Yes, I see, I will find information about this, then fix
Oleksandr Poliakov
@sanych-sun
perfect!
Sergey Kuznetsov
@phnx47
@sanych-sun Hi!
I checked previos behavior, and put expected result to txt file
Oleksandr Poliakov
@sanych-sun
HI @phnx47 ! I see the problem. Will fix it tonight. Sorry for broken tests
Sergey Kuznetsov
@phnx47
Ok!
I'm testing in my real project :) It is good tests before release
Oleksandr Poliakov
@sanych-sun
Actually fix is quite simple, allow transition from MetricStarted, TypeWriten and HelpWritten to EndMetric
@phnx47 If you need the fix ASAP I can guide you how to fix it (I do not have access to Visual Studio now)
Sergey Kuznetsov
@phnx47
No, 12:54AM now :) I'm using only my dev server before publish to testing and production server
Oleksandr Poliakov
@sanych-sun
Ok, it will be fixed tonight
Sergey Kuznetsov
@phnx47
I think, we ready for release 3.0.0.
@sanych-sun You can add your name to Authors
Oleksandr Poliakov
@sanych-sun
Hi Sergey! Sounds good!
Do you mean in csproj file? or where?
Sergey Kuznetsov
@phnx47
Yes, csproj
Oleksandr Poliakov
@sanych-sun
Can you add me as "Oleksandr Poliakov"?
Sergey Kuznetsov
@phnx47
Ok!
Oleksandr Poliakov
@sanych-sun
Thanks
Oleksandr Poliakov
@sanych-sun
@phnx47 the examples on readme also needs to be updated
I can do that tonight, also I'll review release draft to ensure that we include all the changes.
Sergey Kuznetsov
@phnx47
Yes, the documentation needs to be improved.
But the documentation isn't block to the release.
Oleksandr Poliakov
@sanych-sun
let me check if everything is listed in release notes
Sergey Kuznetsov
@phnx47
Ok!
Oleksandr Poliakov
@sanych-sun
@phnx47 Seems everything is listed.
Sergey Kuznetsov
@phnx47
@sanych-sun Hi! Everything working in Prometheus.Client.Owin? We are ready for release?
Oleksandr Poliakov
@sanych-sun
@phnx47 , it looks good, but I do not have any test frame for it... let's release it as is :-)
Oleksandr Poliakov
@sanych-sun
@phnx47 Hi! Can we make a release package of the Prometheus.Client.MetricServer? It's still rc for the moment.
Sergey Kuznetsov
@phnx47
@sanych-sun Hi! Yes, I will do it this week.
Sergey Kuznetsov
@phnx47
@sanych-sun I Published! Can you write Release Notes?
Sergey Kuznetsov
@phnx47
@sanych-sun
Or just fix?
Oleksandr Poliakov
@sanych-sun
Hi @/all ! I've just started new milestone for Prometheus.Client
We have 1 user request "NaN metric is not reported" #65 also I have an idea how to improve scrape processing performance #70
If you have any useful ideas how to improve the library - welcome to share it, it's a nice moment to do that ;-)
Oleksandr Poliakov
@sanych-sun
Hi @tomkerkhove ! Welcome to our chat room. I've add you because we are planning next release and you might share some changes/improvement on our side that could be useful for Promitor.
Sergey Kuznetsov
@phnx47
@sanych-sun Good news! Thank you
Oleksandr Poliakov
@sanych-sun
Hi @/all
We have to cut the hot-fix release with some urgent changes, before 3.1 release...
As there is 1 bug and 1 pending feature which prevents @tomkerkhove to make a release
I've created new milestone and move that issues so we can cut the release